[COMMITTERS] pgsql: Fix whitespace

2016-04-11 Thread Peter Eisentraut
Fix whitespace Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/70715e6a600f1652a04b4e698dad3c7d6bff6bdb Modified Files -- src/backend/utils/time/snapmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (p

[COMMITTERS] pgsql: Fix _SPI_execute_plan() for CREATE TABLE IF NOT EXISTS foo AS ..

2016-04-11 Thread Tom Lane
Fix _SPI_execute_plan() for CREATE TABLE IF NOT EXISTS foo AS ... When IF NOT EXISTS was added to CREATE TABLE AS, this logic didn't get the memo, possibly resulting in an Assert failure. It looks like there would have been no ill effects in a non-Assert build, though. Back-patch to 9.5 where th

[COMMITTERS] pgsql: Fix _SPI_execute_plan() for CREATE TABLE IF NOT EXISTS foo AS ..

2016-04-11 Thread Tom Lane
Fix _SPI_execute_plan() for CREATE TABLE IF NOT EXISTS foo AS ... When IF NOT EXISTS was added to CREATE TABLE AS, this logic didn't get the memo, possibly resulting in an Assert failure. It looks like there would have been no ill effects in a non-Assert build, though. Back-patch to 9.5 where th

[COMMITTERS] pgsql: Fix two places that thought Windows64 is indicated by WIN64 macr

2016-04-11 Thread Tom Lane
Fix two places that thought Windows64 is indicated by WIN64 macro. Everyplace else thinks it's _WIN64, so make these places fall in line. The pg_regress.c usage is not going to result in any change in behavior, only suppressing (or not) a compiler warning about downcasting HANDLEs. So there seems

[COMMITTERS] pgsql: Fix freshly-introduced PL/Python portability bug.

2016-04-11 Thread Tom Lane
Fix freshly-introduced PL/Python portability bug. It turns out that those PyErr_Clear() calls I removed from plpy_elog.c in 7e3bb080387f4143 et al were not quite as random as they appeared: they mask a Python 2.3.x bug. (Specifically, it turns out that PyType_Ready() can fail if the error indicat

[COMMITTERS] pgsql: Fix freshly-introduced PL/Python portability bug.

2016-04-11 Thread Tom Lane
Fix freshly-introduced PL/Python portability bug. It turns out that those PyErr_Clear() calls I removed from plpy_elog.c in 7e3bb080387f4143 et al were not quite as random as they appeared: they mask a Python 2.3.x bug. (Specifically, it turns out that PyType_Ready() can fail if the error indicat

[COMMITTERS] pgsql: Fix freshly-introduced PL/Python portability bug.

2016-04-11 Thread Tom Lane
Fix freshly-introduced PL/Python portability bug. It turns out that those PyErr_Clear() calls I removed from plpy_elog.c in 7e3bb080387f4143 et al were not quite as random as they appeared: they mask a Python 2.3.x bug. (Specifically, it turns out that PyType_Ready() can fail if the error indicat

[COMMITTERS] pgsql: Fix freshly-introduced PL/Python portability bug.

2016-04-11 Thread Tom Lane
Fix freshly-introduced PL/Python portability bug. It turns out that those PyErr_Clear() calls I removed from plpy_elog.c in 7e3bb080387f4143 et al were not quite as random as they appeared: they mask a Python 2.3.x bug. (Specifically, it turns out that PyType_Ready() can fail if the error indicat

[COMMITTERS] pgsql: Fix freshly-introduced PL/Python portability bug.

2016-04-11 Thread Tom Lane
Fix freshly-introduced PL/Python portability bug. It turns out that those PyErr_Clear() calls I removed from plpy_elog.c in 7e3bb080387f4143 et al were not quite as random as they appeared: they mask a Python 2.3.x bug. (Specifically, it turns out that PyType_Ready() can fail if the error indicat

[COMMITTERS] pgsql: Use static inline function for BufferGetPage()

2016-04-11 Thread Kevin Grittner
Use static inline function for BufferGetPage() I was initially concerned that the some of the hundreds of references to BufferGetPage() where the literal BGP_NO_SNAPSHOT_TEST were passed might not optimize as well as a macro, leading to some hard-to-find performance regressions in corner cases. I

[COMMITTERS] pgsql: Make oldSnapshotControl a pointer to a volatile structure

2016-04-11 Thread Kevin Grittner
Make oldSnapshotControl a pointer to a volatile structure It was incorrectly declared as a volatile pointer to a non-volatile structure. Eliminate the OldSnapshotControl struct definition; it is really not needed. Pointed out by Tom Lane. While at it, add OldSnapshotControlData to pgindent's li

[COMMITTERS] pgsql: Fix whitespace

2016-04-11 Thread Peter Eisentraut
Fix whitespace Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d8ed83cd7fd1082f60a5b9897b62216f6b3e2587 Modified Files -- src/backend/foreign/foreign.c | 2 +- src/backend/nodes/extensible.c | 2 +- src/backend/utils/adt/tsquery_op.

[COMMITTERS] pgsql: Prefix RLS regression test roles with 'regress_'

2016-04-11 Thread Stephen Frost
Prefix RLS regression test roles with 'regress_' To avoid any possible overlap with existing roles on a system when doing a 'make installcheck', use role names which start with 'regress_'. Pointed out by Tom. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6c7b0388c

[COMMITTERS] pgsql: Add directory created during build to gitignore

2016-04-11 Thread Peter Eisentraut
Add directory created during build to gitignore Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/29ca231b83a142ea1633e7c496619accb7dd9e4f Modified Files -- src/test/modules/snapshot_too_old/.gitignore | 1 + 1 file changed, 1 insertion(+) -- Sent via pgs

Re: [COMMITTERS] pgsql: Add the "snapshot too old" feature

2016-04-11 Thread Kevin Grittner
On Mon, Apr 11, 2016 at 8:20 AM, Alexander Korotkov wrote: > 1) We uglify buffer manager interface a lot. This patch adds 3 more > arguments to BufferGetPage(). It looks weird. Should we try to find less > invasive way for doing this? As already pointed out, I originally touched about 450 few

[COMMITTERS] pgsql: Fix missing "volatile" in PLy_output().

2016-04-11 Thread Tom Lane
Fix missing "volatile" in PLy_output(). Commit 5c3c3cd0a3046339 plastered "volatile" on a bunch of variables in PLy_output(), but removed the one that actually mattered, ie the one on "oldcontext". This allows some versions of clang to generate code in which "oldcontext" has been trashed when con

[COMMITTERS] pgsql: cpluspluscheck: Update include path

2016-04-11 Thread Peter Eisentraut
cpluspluscheck: Update include path Some things in src/include/fe_utils require libpq headers, so add libpq's include path to the command line used here. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ee5dbc8173d8f434a467380bfd218ef6f91a8e31 Modified Files

Re: [COMMITTERS] pgsql: Add the "snapshot too old" feature

2016-04-11 Thread Alexander Korotkov
Kevin, This commit makes me very uneasy. I didn't much care about this patch mainly because I didn't imagine its consequences. Now, I see following: 1) We uglify buffer manager interface a lot. This patch adds 3 more arguments to BufferGetPage(). It looks weird. Should we try to find less inv

[COMMITTERS] pgsql: Fix documented return type of pg_logical_emit_message() in func.

2016-04-11 Thread Fujii Masao
Fix documented return type of pg_logical_emit_message() in func.sgml. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cfe96ae24c97ff376157c48ccd5ca6d3938632be Modified Files -- doc/src/sgml/func.sgml | 8 1 file changed, 4 insertions(+), 4 deletio