[COMMITTERS] pgsql: In recordExtensionInitPriv(), keep the scan til we're done with

2016-04-15 Thread Stephen Frost
In recordExtensionInitPriv(), keep the scan til we're done with it For reasons of sheer brain fade, we (I) was calling systable_endscan() immediately after systable_getnext() and expecting the tuple returned by systable_getnext() to still be valid. That's clearly wrong. Move the systable_endscan

[COMMITTERS] pgsql: doc: Add missing parentheses

2016-04-15 Thread Peter Eisentraut
doc: Add missing parentheses From: Alexander Law Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/56aa0f142d8e450bc0f94bb39b50f16aff3296df Modified Files -- doc/src/sgml/ecpg.sgml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- Se

[COMMITTERS] pgsql: doc: Add missing parentheses

2016-04-15 Thread Peter Eisentraut
doc: Add missing parentheses From: Alexander Law Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d2de44c2ce5c697a2de8089fb377816b2387107a Modified Files -- doc/src/sgml/ecpg.sgml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- Sent via

[COMMITTERS] pgsql: doc: Add missing parentheses

2016-04-15 Thread Peter Eisentraut
doc: Add missing parentheses From: Alexander Law Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/9b2dc0884d723bad744bc55190da2ad96d920a6d Modified Files -- doc/src/sgml/ecpg.sgml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- Se

[COMMITTERS] pgsql: doc: Add missing parentheses

2016-04-15 Thread Peter Eisentraut
doc: Add missing parentheses From: Alexander Law Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/e2c183ef808466ed20c2d7877b9c10e13c897e16 Modified Files -- doc/src/sgml/ecpg.sgml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- Se

[COMMITTERS] pgsql: doc: Add missing parentheses

2016-04-15 Thread Peter Eisentraut
doc: Add missing parentheses From: Alexander Law Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/f6a849b282267c4ee139577de6a32aa8f337a364 Modified Files -- doc/src/sgml/ecpg.sgml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- Se

[COMMITTERS] pgsql: doc: Add missing parentheses

2016-04-15 Thread Peter Eisentraut
doc: Add missing parentheses From: Alexander Law Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/f719cd9bfbcf98ce9423b5c01184cf3bc627bbd7 Modified Files -- doc/src/sgml/ecpg.sgml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- Se

[COMMITTERS] pgsql: psql: Add new gettext trigger

2016-04-15 Thread Peter Eisentraut
psql: Add new gettext trigger Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c3136876734b31ce50018f39c87b00145a8c7c33 Modified Files -- src/bin/psql/nls.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing l

[COMMITTERS] pgsql: Sync 9.2 and 9.3 versions of barrier.h with 9.4's version.

2016-04-15 Thread Tom Lane
Sync 9.2 and 9.3 versions of barrier.h with 9.4's version. We weren't particularly maintaining barrier.h before 9.4, because nothing was using it in those branches. Well, nothing until commit 37de8de9e got back-patched. That broke 9.2 and 9.3 for some non-mainstream platforms that we haven't bee

[COMMITTERS] pgsql: Sync 9.2 and 9.3 versions of barrier.h with 9.4's version.

2016-04-15 Thread Tom Lane
Sync 9.2 and 9.3 versions of barrier.h with 9.4's version. We weren't particularly maintaining barrier.h before 9.4, because nothing was using it in those branches. Well, nothing until commit 37de8de9e got back-patched. That broke 9.2 and 9.3 for some non-mainstream platforms that we haven't bee

[COMMITTERS] pgsql: Use less-generic names in matview.sql.

2016-04-15 Thread Tom Lane
Use less-generic names in matview.sql. The original coding of this test used table and view names like "t", "tv", "foo", etc. This tended to interfere with doing simple manual tests in the regression database; not to mention that it posed a considerable risk of conflict with other regression test

[COMMITTERS] pgsql: Fix possible crash in ALTER TABLE ... REPLICA IDENTITY USING IND

2016-04-15 Thread Tom Lane
Fix possible crash in ALTER TABLE ... REPLICA IDENTITY USING INDEX. Careless coding added by commit 07cacba983ef79be could result in a crash or a bizarre error message if someone tried to select an index on the OID column as the replica identity index for a table. Back-patch to 9.4 where the feat

[COMMITTERS] pgsql: Fix possible crash in ALTER TABLE ... REPLICA IDENTITY USING IND

2016-04-15 Thread Tom Lane
Fix possible crash in ALTER TABLE ... REPLICA IDENTITY USING INDEX. Careless coding added by commit 07cacba983ef79be could result in a crash or a bizarre error message if someone tried to select an index on the OID column as the replica identity index for a table. Back-patch to 9.4 where the feat

[COMMITTERS] pgsql: Fix possible crash in ALTER TABLE ... REPLICA IDENTITY USING IND

2016-04-15 Thread Tom Lane
Fix possible crash in ALTER TABLE ... REPLICA IDENTITY USING INDEX. Careless coding added by commit 07cacba983ef79be could result in a crash or a bizarre error message if someone tried to select an index on the OID column as the replica identity index for a table. Back-patch to 9.4 where the feat

[COMMITTERS] pgsql: postgres_fdw: Clean up handling of system columns.

2016-04-15 Thread Robert Haas
postgres_fdw: Clean up handling of system columns. Previously, querying the xmin column of a single postgres_fdw foreign table fetched the tuple length, xmax the typmod, and cmin or cmax the composite type OID of the tuple. However, when you queried several such tables and the join got shipped to

[COMMITTERS] pgsql: Tweak EXPLAIN for parallel query to show workers launched.

2016-04-15 Thread Robert Haas
Tweak EXPLAIN for parallel query to show workers launched. The previous display was sort of confusing, because it didn't distinguish between the number of workers that we planned to launch and the number that actually got launched. This has already confused several people, so display both numbers

[COMMITTERS] pgsql: Fix portability problem induced by commit a6f6b7819.

2016-04-15 Thread Tom Lane
Fix portability problem induced by commit a6f6b7819. pg_xlogdump includes bufmgr.h. With a compiler that emits code for static inline functions even when they're unreferenced, that leads to unresolved external references in the new static-inline version of BufferGetPage(). So hide it with #ifnde

[COMMITTERS] pgsql: Fix typo in comment

2016-04-15 Thread Magnus Hagander
Fix typo in comment Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ba8fe38f58e2f3d86c5361373598af80d5ce4443 Modified Files -- src/backend/optimizer/plan/planner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailin

[COMMITTERS] pgsql: Update helptext for vcregress.pl

2016-04-15 Thread Magnus Hagander
Update helptext for vcregress.pl This has clearly not been tracking the code changse for quite some time. Michael Paquier, problem spotted by Kyotaro HORIGUCHI Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cf086b1c2fa1e11c14a9fe5fea05553974a480ef Modified Files -