[COMMITTERS] pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co

2016-04-22 Thread Tom Lane
Convert contrib/seg's bool-returning SQL functions to V1 call convention. It appears that we can no longer get away with using V0 call convention for bool-returning functions in newer versions of MSVC. The compiler seems to generate code that doesn't clear the higher-order bits of the result regi

[COMMITTERS] pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co

2016-04-22 Thread Tom Lane
Convert contrib/seg's bool-returning SQL functions to V1 call convention. It appears that we can no longer get away with using V0 call convention for bool-returning functions in newer versions of MSVC. The compiler seems to generate code that doesn't clear the higher-order bits of the result regi

Re: [HACKERS] Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold

2016-04-22 Thread Amit Kapila
On Thu, Apr 21, 2016 at 6:38 AM, Ants Aasma wrote: > > On Tue, Apr 19, 2016 at 6:11 PM, Kevin Grittner wrote: > > On Tue, Apr 19, 2016 at 9:57 AM, Amit Kapila wrote: > >> On Sun, Apr 17, 2016 at 2:26 AM, Andres Freund wrote: > >>> > >>> FWIW, I could be kinda convinced that it's temporarily ok,

Re: [HACKERS] Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold

2016-04-22 Thread Amit Kapila
On Wed, Apr 20, 2016 at 7:39 PM, Andres Freund wrote: > > On 2016-04-19 20:27:31 +0530, Amit Kapila wrote: > > On Sun, Apr 17, 2016 at 2:26 AM, Andres Freund wrote: > > > > > > On 2016-04-16 16:44:52 -0400, Noah Misch wrote: > > > > That is more controversial than the potential ~2% regression for

[COMMITTERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-04-22 Thread Magnus Hagander
Add putenv support for msvcrt from Visual Studio 2013 This was missed when VS 2013 support was added. Michael Paquier Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9f633b404cb3be6139f8dfdea00538489ffef9ab Modified Files -- src/port/win32env.c | 3 +++

[COMMITTERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-04-22 Thread Magnus Hagander
Add putenv support for msvcrt from Visual Studio 2013 This was missed when VS 2013 support was added. Michael Paquier Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/c238a41014db7f818982641a8b95fae15515c88e Modified Files -- src/port/win32env.c |

[COMMITTERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-04-22 Thread Magnus Hagander
Add putenv support for msvcrt from Visual Studio 2013 This was missed when VS 2013 support was added. Michael Paquier Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/409c49c64a0549c39044ed6ea845ba0fb6c6190d Modified Files -- src/port/win32env.c |

[COMMITTERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-04-22 Thread Magnus Hagander
Add putenv support for msvcrt from Visual Studio 2013 This was missed when VS 2013 support was added. Michael Paquier Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/ab5c6d01f6dbe036469fd77b488a21ca8d7d26f1 Modified Files -- src/port/win32env.c |