[COMMITTERS] pgsql: Remember asking for feedback during walsender shutdown.

2016-04-28 Thread Andres Freund
Remember asking for feedback during walsender shutdown. Since 5a991ef8 we're explicitly asking for feedback from the receiving side when shutting down walsender, if there's not yet replicated data. Unfortunately we didn't remember (i.e. set waiting_for_ping_response to true) having asked for feed

[COMMITTERS] pgsql: Remember asking for feedback during walsender shutdown.

2016-04-28 Thread Andres Freund
Remember asking for feedback during walsender shutdown. Since 5a991ef8 we're explicitly asking for feedback from the receiving side when shutting down walsender, if there's not yet replicated data. Unfortunately we didn't remember (i.e. set waiting_for_ping_response to true) having asked for feed

[COMMITTERS] pgsql: Remember asking for feedback during walsender shutdown.

2016-04-28 Thread Andres Freund
Remember asking for feedback during walsender shutdown. Since 5a991ef8 we're explicitly asking for feedback from the receiving side when shutting down walsender, if there's not yet replicated data. Unfortunately we didn't remember (i.e. set waiting_for_ping_response to true) having asked for feed

Re: [COMMITTERS] pgsql: Fix support of digits in email/hostnames.

2016-04-28 Thread Bruce Momjian
On Tue, Mar 29, 2016 at 03:29:20PM +, Teodor Sigaev wrote: > Fix support of digits in email/hostnames. > > When tsearch was implemented I did several mistakes in hostname/email > definition rules: > 1) allow underscore in hostname what prohibited by RFC > 2) forget to allow leading digits sepa

[COMMITTERS] pgsql: Adjust DatumGetBool macro, this time for sure.

2016-04-28 Thread Tom Lane
Adjust DatumGetBool macro, this time for sure. Commit 23a41573c attempted to fix the DatumGetBool macro to ignore bits in a Datum that are to the left of the actual bool value. But it did that by casting the Datum to bool; and on compilers that use C99 semantics for bool, that ends up being a who

[COMMITTERS] pgsql: Adjust DatumGetBool macro, this time for sure.

2016-04-28 Thread Tom Lane
Adjust DatumGetBool macro, this time for sure. Commit 23a41573c attempted to fix the DatumGetBool macro to ignore bits in a Datum that are to the left of the actual bool value. But it did that by casting the Datum to bool; and on compilers that use C99 semantics for bool, that ends up being a who

[COMMITTERS] pgsql: Adjust DatumGetBool macro, this time for sure.

2016-04-28 Thread Tom Lane
Adjust DatumGetBool macro, this time for sure. Commit 23a41573c attempted to fix the DatumGetBool macro to ignore bits in a Datum that are to the left of the actual bool value. But it did that by casting the Datum to bool; and on compilers that use C99 semantics for bool, that ends up being a who

[COMMITTERS] pgsql: Adjust DatumGetBool macro, this time for sure.

2016-04-28 Thread Tom Lane
Adjust DatumGetBool macro, this time for sure. Commit 23a41573c attempted to fix the DatumGetBool macro to ignore bits in a Datum that are to the left of the actual bool value. But it did that by casting the Datum to bool; and on compilers that use C99 semantics for bool, that ends up being a who

[COMMITTERS] pgsql: Adjust DatumGetBool macro, this time for sure.

2016-04-28 Thread Tom Lane
Adjust DatumGetBool macro, this time for sure. Commit 23a41573c attempted to fix the DatumGetBool macro to ignore bits in a Datum that are to the left of the actual bool value. But it did that by casting the Datum to bool; and on compilers that use C99 semantics for bool, that ends up being a who

[COMMITTERS] pgsql: Adjust DatumGetBool macro, this time for sure.

2016-04-28 Thread Tom Lane
Adjust DatumGetBool macro, this time for sure. Commit 23a41573c attempted to fix the DatumGetBool macro to ignore bits in a Datum that are to the left of the actual bool value. But it did that by casting the Datum to bool; and on compilers that use C99 semantics for bool, that ends up being a who

[COMMITTERS] pgsql: Revert "Convert contrib/seg's bool-returning SQL functions to V1

2016-04-28 Thread Tom Lane
Revert "Convert contrib/seg's bool-returning SQL functions to V1 call convention." This reverts commit b1dd2f86ce7d43f23f6aae307bb22de826849e7d. That turns out to have been based on a faulty diagnosis of why the VS2015 build was misbehaving. Instead, we need to fix DatumGetBool(). Branch --

[COMMITTERS] pgsql: Revert "Convert contrib/seg's bool-returning SQL functions to V1

2016-04-28 Thread Tom Lane
Revert "Convert contrib/seg's bool-returning SQL functions to V1 call convention." This reverts commit c8e81afc60093b199a128ccdfbb692ced8e0c9cd. That turns out to have been based on a faulty diagnosis of why the VS2015 build was misbehaving. Instead, we need to fix DatumGetBool(). Branch --

[COMMITTERS] pgsql: Prevent to use magic constants

2016-04-28 Thread Teodor Sigaev
Prevent to use magic constants Use macroses for definition amstrategies/amsupport fields instead of hardcoded values. Author: Nikolay Shaplov with addition for contrib/bloom Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f8467f7da8685dbc47187864e5afe130d9c63fff Mo

[COMMITTERS] pgsql: Prevent multiple cleanup process for pending list in GIN.

2016-04-28 Thread Teodor Sigaev
Prevent multiple cleanup process for pending list in GIN. Previously, ginInsertCleanup could exit early if it detects that someone else is cleaning up the pending list, without waiting for that someone else to finish the job. But in this case vacuum could miss tuples to be deleted. Cleanup proces

Re: [COMMITTERS] pgsql: pg_upgrade: preserve database and relation minmxid values

2016-04-28 Thread Bruce Momjian
On Sun, Mar 27, 2016 at 05:44:51PM +0200, Andres Freund wrote: > Hi, > > On 2014-07-02 19:29:43 +, Bruce Momjian wrote: > > pg_upgrade: preserve database and relation minmxid values > > > > Also set these values for pre-9.3 old clusters that don't have values to > > preserve. > > > > Analysis

[COMMITTERS] pgsql: pg_upgrade: Fix indentation of if() block

2016-04-28 Thread Bruce Momjian
pg_upgrade: Fix indentation of if() block Incorrect indentation introduced in commit 3d2e1851096752c3ca4dee5c16b552332de09946. Reported-by: Andres Freund Backpatch-through: 9.3 and 9.4 only Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/3be77da179a187dc7ea

[COMMITTERS] pgsql: pg_upgrade: Fix indentation of if() block

2016-04-28 Thread Bruce Momjian
pg_upgrade: Fix indentation of if() block Incorrect indentation introduced in commit 3d2e1851096752c3ca4dee5c16b552332de09946. Reported-by: Andres Freund Backpatch-through: 9.3 and 9.4 only Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/4f29edbb1603c552ead