[COMMITTERS] pgsql: Update back-branch release notes for the last few commits.

Update back-branch release notes for the last few commits. OpenSSL error queue fix no longer needs to be documented under 9.6. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7dc1d359699345a2b2af6af6d21bd6f7bd6cfb27 Modified Files --

Re: [COMMITTERS] pgsql: Add TAP tests for pg_dump

Peter Eisentraut writes: > Again, I applaud this, but this is clearly a new major chunk of mostly > not-peer-reviewed code with potential for portability problems and the > possibility to break downstream packaging routines. There is no harm in > leaving this

[COMMITTERS] pgsql: Distrust external OpenSSL clients; clear err queue

Distrust external OpenSSL clients; clear err queue OpenSSL has an unfortunate tendency to mix per-session state error handling with per-thread error handling. This can cause problems when programs that link to libpq with OpenSSL enabled have some other use of OpenSSL; without care, one caller of

[COMMITTERS] pgsql: Distrust external OpenSSL clients; clear err queue

Distrust external OpenSSL clients; clear err queue OpenSSL has an unfortunate tendency to mix per-session state error handling with per-thread error handling. This can cause problems when programs that link to libpq with OpenSSL enabled have some other use of OpenSSL; without care, one caller of

[COMMITTERS] pgsql: Distrust external OpenSSL clients; clear err queue

Distrust external OpenSSL clients; clear err queue OpenSSL has an unfortunate tendency to mix per-session state error handling with per-thread error handling. This can cause problems when programs that link to libpq with OpenSSL enabled have some other use of OpenSSL; without care, one caller of

[COMMITTERS] pgsql: Distrust external OpenSSL clients; clear err queue

Distrust external OpenSSL clients; clear err queue OpenSSL has an unfortunate tendency to mix per-session state error handling with per-thread error handling. This can cause problems when programs that link to libpq with OpenSSL enabled have some other use of OpenSSL; without care, one caller of

[COMMITTERS] pgsql: Distrust external OpenSSL clients; clear err queue

Distrust external OpenSSL clients; clear err queue OpenSSL has an unfortunate tendency to mix per-session state error handling with per-thread error handling. This can cause problems when programs that link to libpq with OpenSSL enabled have some other use of OpenSSL; without care, one caller of

[COMMITTERS] pgsql: Fix SSL tests

Fix SSL tests These were accidentally broken by the great backpatching of 331828b754378733cb5c2e49227603e7354e4e39. Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/ab32a4057229dc59ee83614b1fcc7fe242213a78 Modified Files --

Re: [COMMITTERS] pgsql: Add TAP tests for pg_dump

On 5/6/16 3:11 PM, Stephen Frost wrote: These are just new tests..? This is a matter of degree, but I think there is a difference between new test cases and a whole new test suite. I assumed that would be welcome during post feature-freeze, and certainly no one raised any concerns about

Re: [COMMITTERS] pgsql: Add TAP tests for pg_dump

On 5/6/16 4:07 PM, Stephen Frost wrote: Are you suggesting commiting to still-9.6-HEAD post-beta1? I took Peter's comment as suggesting that adding the tests would have to wait til after we branched 9.6, as we do for features. I'd really like to have these tests included as that will make them

[COMMITTERS] pgsql: Clean up after pg_dump test runs.

Clean up after pg_dump test runs. The tmp_check directory needs to be removed by "make clean", and also ignored by .gitignore. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/74a73b17225385e54dbf9fc2f77aaa59191ac04b Modified Files --

[COMMITTERS] pgsql: Fix pg_upgrade to not fail when new-cluster TOAST rules differ f

Fix pg_upgrade to not fail when new-cluster TOAST rules differ from old. This patch essentially reverts commit 4c6780fd17aa43ed, in favor of a much simpler solution for the case where the new cluster would choose to create a TOAST table but the old cluster doesn't have one: just don't create a

[COMMITTERS] pgsql: Fix pg_upgrade to not fail when new-cluster TOAST rules differ f

Fix pg_upgrade to not fail when new-cluster TOAST rules differ from old. This patch essentially reverts commit 4c6780fd17aa43ed, in favor of a much simpler solution for the case where the new cluster would choose to create a TOAST table but the old cluster doesn't have one: just don't create a

[COMMITTERS] pgsql: Fix pg_upgrade to not fail when new-cluster TOAST rules differ f

Fix pg_upgrade to not fail when new-cluster TOAST rules differ from old. This patch essentially reverts commit 4c6780fd17aa43ed, in favor of a much simpler solution for the case where the new cluster would choose to create a TOAST table but the old cluster doesn't have one: just don't create a

[COMMITTERS] pgsql: Fix pg_upgrade to not fail when new-cluster TOAST rules differ f

Fix pg_upgrade to not fail when new-cluster TOAST rules differ from old. This patch essentially reverts commit 4c6780fd17aa43ed, in favor of a much simpler solution for the case where the new cluster would choose to create a TOAST table but the old cluster doesn't have one: just don't create a

Re: [HACKERS] Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold

On Fri, May 6, 2016 at 7:48 PM, Andres Freund wrote: > On 2016-05-06 19:43:24 -0500, Kevin Grittner wrote: >> It's disappointing that I am not getting more consistent numbers, >> but NUMA can be hard to manage that way. > > FWIW, in my experience, unless you disable autovacuum

[COMMITTERS] pgsql: Disable BLOB test in pg_dump TAP tests

Disable BLOB test in pg_dump TAP tests Buildfarm member jacana appears to have an issue with running this test. It's not entirely clear to me why, but rather than try to fight with it, just disable it for now. None of the other tests try to write out from psql directly as this test does, so it

[COMMITTERS] pgsql: Mitigate "snapshot too old" performance regression on NUMA

Mitigate "snapshot too old" performance regression on NUMA Limit maintenance of time to xid mapping to once per minute. At least in the tested case this brings performance within 5% of when the feature is off, compared to several times slower without this patch. While there, fix comments and

Re: [HACKERS] Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold

On 2016-05-06 19:43:24 -0500, Kevin Grittner wrote: > It's disappointing that I am not getting more consistent numbers, > but NUMA can be hard to manage that way. FWIW, in my experience, unless you disable autovacuum (or rather auto-analyze), the effects from non-predicable analyze runs with

Re: [HACKERS] Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold

On Fri, May 6, 2016 at 5:07 PM, Andres Freund wrote: > On 2016-05-06 14:18:22 -0500, Kevin Grittner wrote: >> I rebased the patch Ants posted (attached), and am running >> benchmarks on a cthulhu (a big NUMA machine with 8 memory nodes). >> Normally I wouldn't post results

[COMMITTERS] pgsql: First-draft release notes for 9.5.3.

First-draft release notes for 9.5.3. As usual, the release notes for other branches will be made by cutting these down, but put them up for community review first. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/eb7de00ac2d282263541ece849ec71e2809e9467 Modified

Re: [HACKERS] Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold

Hi, On 2016-05-06 14:18:22 -0500, Kevin Grittner wrote: > I rebased the patch Ants posted (attached), and am running > benchmarks on a cthulhu (a big NUMA machine with 8 memory nodes). > Normally I wouldn't post results without a lot more data points > with multiple samples at each, but the

Re: [COMMITTERS] pgsql: Rename pgbench min/max to least/greatest, and fix handling of do

> The very minor patch attached re-establishes the alphabetical order when > listing functions names in pgbench documentation. Pushed, thanks. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your

[COMMITTERS] pgsql: Docs: fix alphabetization of table entries.

Docs: fix alphabetization of table entries. Fabien Coelho Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bbbae5ead3952bee9184da4864e2f4078940cac7 Modified Files -- doc/src/sgml/ref/pgbench.sgml | 14 +++--- 1 file changed, 7 insertions(+), 7

[COMMITTERS] pgsql: Docs: minor copy-editing for GSSAPI/SSPI authentication docs.

Docs: minor copy-editing for GSSAPI/SSPI authentication docs. Describe compat_realm = 0 as "disabled" not "enabled", per discussion with Christian Ullrich. I failed to resist the temptation to do some other minor copy-editing in the same area. Branch -- master Details ---

Re: [COMMITTERS] pgsql: Rename pgbench min/max to least/greatest, and fix handling of do

Rename pgbench min/max to least/greatest, and fix handling of double args. Ok. The very minor patch attached re-establishes the alphabetical order when listing functions names in pgbench documentation. -- Fabien.diff --git a/doc/src/sgml/ref/pgbench.sgml b/doc/src/sgml/ref/pgbench.sgml

[COMMITTERS] pgsql: Add test_pg_dump to @contrib_excludes

Add test_pg_dump to @contrib_excludes The test_pg_dump extension doesn't have a C component, so we need to exclude it from the MSVC build system trying to figure out how to build it. Also add a "MODULES" line to the Makefile, as test_extensions has. Might not be necessary, but seems good to keep

Re: [COMMITTERS] pgsql: Add TAP tests for pg_dump

Tom Lane wrote: > Alvaro Herrera writes: > > Stephen Frost wrote: > >> I'm guessing the right answer here is to just add test_pg_dump to that > >> list. > > > I don't like this solution, because it means pg_dump will get little > > testing on Windows. > > No, that's

Re: [COMMITTERS] pgsql: Add TAP tests for pg_dump

Alvaro Herrera writes: > Stephen Frost wrote: >> I'm guessing the right answer here is to just add test_pg_dump to that >> list. > I don't like this solution, because it means pg_dump will get little > testing on Windows. No, that's incorrect: @contrib_excludes stops

[COMMITTERS] pgsql: More small 9.6 release note improvements.

More small 9.6 release note improvements. Corrections per Jeff Janes, Christian Ullrich, and Daniel Vérité. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/76ef266a86fdc3c4bdbd12b9ea9cacd523e00779 Modified Files -- doc/src/sgml/release-9.5.sgml | 2 +-

Re: [COMMITTERS] pgsql: Add TAP tests for pg_dump

* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > Stephen Frost wrote: > > * Stephen Frost (sfr...@snowman.net) wrote: > > > > The intagg contrib modules doesn't have a .c file either, nor a > > > MODULES_big line, and I don't see any errors with it. I'm not terribly > > > familiar with how

Re: [COMMITTERS] pgsql: Add TAP tests for pg_dump

Stephen Frost wrote: > * Stephen Frost (sfr...@snowman.net) wrote: > > The intagg contrib modules doesn't have a .c file either, nor a > > MODULES_big line, and I don't see any errors with it. I'm not terribly > > familiar with how the Windows builds are run though. > > It looks like there's an

[COMMITTERS] pgsql: Correct query in pg_dumpall:dumpRoles

Correct query in pg_dumpall:dumpRoles We need to use a new branch due to the 9.5 addition of bypassrls when adding in the clause to exclude pg_* roles from being dumped by pg_dumpall. Pointed out by Noah, patch by me. Branch -- master Details ---

Re: [COMMITTERS] pgsql: Add TAP tests for pg_dump

* Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Stephen Frost (sfr...@snowman.net) wrote: > >> Looks like the test_pg_dump extension made the Windows builds upset. > >> I'm guessing that's because I set 'MODULES_big' even though there isn't > >> a .c

Re: [COMMITTERS] pgsql: Add TAP tests for pg_dump

Stephen Frost writes: > * Stephen Frost (sfr...@snowman.net) wrote: >> Looks like the test_pg_dump extension made the Windows builds upset. >> I'm guessing that's because I set 'MODULES_big' even though there isn't >> a .c component. >> >> Doing a local build with that

Re: [COMMITTERS] pgsql: Add TAP tests for pg_dump

* Stephen Frost (sfr...@snowman.net) wrote: > Alright, apparently that made other Windows buildfarm members unhappy... > > I guess the next approach will be to add back MODULES_big and add in a > .c file for the Windows systems to be happy about. I'm certainly open > to other suggestions. > >

Re: [COMMITTERS] pgsql: Add TAP tests for pg_dump

* Stephen Frost (sfr...@snowman.net) wrote: > * Stephen Frost (sfr...@snowman.net) wrote: > > src/test/modules/test_pg_dump/Makefile | 25 + > > src/test/modules/test_pg_dump/README |2 + > > .../modules/test_pg_dump/expected/test_pg_dump.out |6 + > >

[COMMITTERS] pgsql: Remove MODULES_big from test_pg_dump

Remove MODULES_big from test_pg_dump The Makefile for test_pg_dump shouldn't have a MODULES_big line because there's no actual compiled bit for that extension. Hopefully this will fix the Windows buildfarm members which were complaining. In passing, also add the 'prove_installcheck' bit to the

Re: [HACKERS] Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold

On Wed, Apr 20, 2016 at 8:08 PM, Ants Aasma wrote: > I had an idea I wanted to test out. The gist of it is to effectively > have the last slot of timestamp to xid map stored in the latest_xmin > field and only update the mapping when slot boundaries are crossed. > See

Re: [COMMITTERS] pgsql: Add TAP tests for pg_dump

On 2016-05-06 15:11:53 -0400, Stephen Frost wrote: > * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > > On 5/6/16 2:06 PM, Stephen Frost wrote: > > >Add TAP tests for pg_dump > > > > I'd be the first to welcome this, but what happened to feature freeze? > > These are just new

Re: [COMMITTERS] pgsql: Add TAP tests for pg_dump

* Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > On 5/6/16 2:06 PM, Stephen Frost wrote: > >Add TAP tests for pg_dump > > I'd be the first to welcome this, but what happened to feature freeze? These are just new tests..? I assumed that would be welcome during post feature-freeze,

Re: [COMMITTERS] pgsql: Add TAP tests for pg_dump

On 5/6/16 2:06 PM, Stephen Frost wrote: Add TAP tests for pg_dump I'd be the first to welcome this, but what happened to feature freeze? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via

[COMMITTERS] pgsql: Minimal fix for crash bug in quals_match_foreign_key.

Minimal fix for crash bug in quals_match_foreign_key. Discussion is still underway as to whether to revert the entire patch that added this function, but that discussion may not conclude before beta1. So, in the meantime, let's do at least this much. David Rowley Branch -- master Details

[COMMITTERS] pgsql: Limit maximum parallel degree to 1024.

Limit maximum parallel degree to 1024. This new limit affects both the max_parallel_degree GUC and the parallel_degree reloption. There may some day be a use case for using more than 1024 CPUs for a single query, but that's surely not the case right now. Not only do not very many people have

Re: [COMMITTERS] pgsql: Add TAP tests for pg_dump

* Stephen Frost (sfr...@snowman.net) wrote: > src/test/modules/test_pg_dump/Makefile | 25 + > src/test/modules/test_pg_dump/README |2 + > .../modules/test_pg_dump/expected/test_pg_dump.out |6 + > src/test/modules/test_pg_dump/sql/test_pg_dump.sql |1 + >

[COMMITTERS] pgsql: Improve pg_upgrade's report about failure to match up old and ne

Improve pg_upgrade's report about failure to match up old and new tables. Ordinarily, pg_upgrade shouldn't have any difficulty in matching up all the relations it sees in the old and new databases. If it does, however, it just goes belly-up with a pretty unhelpful error message. That seemed

[COMMITTERS] pgsql: Use mul_size when multiplying by the number of parallel workers.

Use mul_size when multiplying by the number of parallel workers. That way, if the result overflows size_t, you'll get an error instead of undefined behavior, which seems like a plus. This also has the effect of casting the number of workers from int to Size, which is better because it's harder

[COMMITTERS] pgsql: Correct pg_dump WHERE clause for functions/aggregates

Correct pg_dump WHERE clause for functions/aggregates The query to grab the function/aggregate information is now joining to pg_init_privs, so we can simplify (and correct) the WHERE clause used to determine if a given function's ACL has changed from the initial ACL on the function. Bug found by

[COMMITTERS] pgsql: Add TAP tests for pg_dump

Add TAP tests for pg_dump This TAP test suite will create a new cluster, populate it based on the 'create_sql' values in the '%tests' hash, run all of the runs defined in the '%pgdump_runs' hash, and then for each test in the '%tests' hash, compare each run's output the the regular expression

[COMMITTERS] pgsql: pg_dump performance and other fixes

pg_dump performance and other fixes Do not try to dump objects which do not have ACLs when only ACLs are being requested. This results in a significant performance improvement as we can avoid querying for further information on these objects when we don't need to. When limiting the components

[COMMITTERS] pgsql: Only issue LOCK TABLE commands when necessary

Only issue LOCK TABLE commands when necessary Reviewing the cases where we need to LOCK a given table during a dump, it was pointed out by Tom that we really don't need to LOCK a table if we are only looking to dump the ACL for it, or certain other components. After reviewing the queries run for

[COMMITTERS] pgsql: Remove various special checks around default roles

Remove various special checks around default roles Default roles really should be like regular roles, for the most part. This removes a number of checks that were trying to make default roles extra special by not allowing them to be used as regular roles. We still prevent users from creating

[COMMITTERS] pgsql: Update config.guess and config.sub

Update config.guess and config.sub Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e324f8ad610bdc83a1392e54da5d9613e710b02f Modified Files -- config/config.guess | 114 ++-- config/config.sub | 22

[COMMITTERS] pgsql: Fix possible read past end of string in to_timestamp().

Fix possible read past end of string in to_timestamp(). to_timestamp() handles the TH/th format codes by advancing over two input characters, whatever those are. It failed to notice whether there were two characters available to be skipped, making it possible to advance the pointer past the end

[COMMITTERS] pgsql: Fix possible read past end of string in to_timestamp().

Fix possible read past end of string in to_timestamp(). to_timestamp() handles the TH/th format codes by advancing over two input characters, whatever those are. It failed to notice whether there were two characters available to be skipped, making it possible to advance the pointer past the end

[COMMITTERS] pgsql: Fix possible read past end of string in to_timestamp().

Fix possible read past end of string in to_timestamp(). to_timestamp() handles the TH/th format codes by advancing over two input characters, whatever those are. It failed to notice whether there were two characters available to be skipped, making it possible to advance the pointer past the end

[COMMITTERS] pgsql: Fix possible read past end of string in to_timestamp().

Fix possible read past end of string in to_timestamp(). to_timestamp() handles the TH/th format codes by advancing over two input characters, whatever those are. It failed to notice whether there were two characters available to be skipped, making it possible to advance the pointer past the end

[COMMITTERS] pgsql: Fix possible read past end of string in to_timestamp().

Fix possible read past end of string in to_timestamp(). to_timestamp() handles the TH/th format codes by advancing over two input characters, whatever those are. It failed to notice whether there were two characters available to be skipped, making it possible to advance the pointer past the end

[COMMITTERS] pgsql: Fix possible read past end of string in to_timestamp().

Fix possible read past end of string in to_timestamp(). to_timestamp() handles the TH/th format codes by advancing over two input characters, whatever those are. It failed to notice whether there were two characters available to be skipped, making it possible to advance the pointer past the end

[COMMITTERS] pgsql: Fix pgbench's parsing of double values to notice trailing garbag

Fix pgbench's parsing of double values to notice trailing garbage. Noted by Fabien Coelho, though this isn't exactly his proposed patch. (The technique used here is borrowed from the zic sources.) Branch -- master Details ---

[COMMITTERS] pgsql: Improve handling of numeric-valued variables in pgbench.

Improve handling of numeric-valued variables in pgbench. The previous coding always stored variable values as strings, doing conversion on-the-fly when a numeric value was needed or a number was to be assigned. This was a bit inefficient and risked loss of precision for floating-point values.

[COMMITTERS] pgsql: Docs: fix \crosstabview example.

Docs: fix \crosstabview example. This example missed being updated when we redefined \crosstabview's argument processing. Daniel Vérité Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/daa9856fcea775caeb4c92580b9693858509b43b Modified Files --

[COMMITTERS] pgsql: Fix hash index vs "snapshot too old" problemms

Fix hash index vs "snapshot too old" problemms Hash indexes are not WAL-logged, and so do not maintain the LSN of index pages. Since the "snapshot too old" feature counts on detecting error conditions using the LSN of a table and all indexes on it, this makes it impossible to safely do early

[COMMITTERS] pgsql: Move and rename fmtReloptionsArray().

Move and rename fmtReloptionsArray(). Move fmtReloptionsArray() from pg_dump.c to string_utils.c so that it is available to other frontend code. In particular psql's \ev and \sv commands need it to handle view reloptions. Also rename the function to appendReloptionsArray(), which is a more

[COMMITTERS] pgsql: Fix psql's \ev and \sv commands so that they handle view relopti

Fix psql's \ev and \sv commands so that they handle view reloptions. Commit 8eb6407aaeb6cbd972839e356b436bb698f51cff added support for editing and showing view definitions, but neglected to account for view options such as security_barrier and WITH CHECK OPTION which are not returned by