[COMMITTERS] pgsql: Add a HINT for client-vs-server COPY failure cases.

2016-09-06 Thread Tom Lane
Add a HINT for client-vs-server COPY failure cases. Users often get confused between COPY and \copy and try to use client-side paths with COPY. The server then cannot find the file (if remote), or sees a permissions problem (if local), or some variant of that. Emit a hint about this in the most

[COMMITTERS] pgsql: Add location field to DefElem

2016-09-06 Thread Peter Eisentraut
Add location field to DefElem Add a location field to the DefElem struct, used to parse many utility commands. Update various error messages to supply error position information. To propogate the error position information in a more systematic way, create a ParseState in standard_ProcessUtility(

[COMMITTERS] pgsql: Doc: small improvements for documentation about VACUUM freezing.

2016-09-06 Thread Tom Lane
Doc: small improvements for documentation about VACUUM freezing. Mostly, explain how row xmin's used to be replaced by FrozenTransactionId and no longer are. Do a little copy-editing on the side. Per discussion with Egor Rogov. Back-patch to 9.4 where the behavioral change occurred. Discussion

[COMMITTERS] pgsql: Doc: small improvements for documentation about VACUUM freezing.

2016-09-06 Thread Tom Lane
Doc: small improvements for documentation about VACUUM freezing. Mostly, explain how row xmin's used to be replaced by FrozenTransactionId and no longer are. Do a little copy-editing on the side. Per discussion with Egor Rogov. Back-patch to 9.4 where the behavioral change occurred. Discussion

[COMMITTERS] pgsql: Doc: small improvements for documentation about VACUUM freezing.

2016-09-06 Thread Tom Lane
Doc: small improvements for documentation about VACUUM freezing. Mostly, explain how row xmin's used to be replaced by FrozenTransactionId and no longer are. Do a little copy-editing on the side. Per discussion with Egor Rogov. Back-patch to 9.4 where the behavioral change occurred. Discussion

[COMMITTERS] pgsql: Doc: small improvements for documentation about VACUUM freezing.

2016-09-06 Thread Tom Lane
Doc: small improvements for documentation about VACUUM freezing. Mostly, explain how row xmin's used to be replaced by FrozenTransactionId and no longer are. Do a little copy-editing on the side. Per discussion with Egor Rogov. Back-patch to 9.4 where the behavioral change occurred. Discussion

[COMMITTERS] pgsql: Guard against possible memory allocation botch in batchmemtuples

2016-09-06 Thread Tom Lane
Guard against possible memory allocation botch in batchmemtuples(). Negative availMemLessRefund would be problematic. It's not entirely clear whether the case can be hit in the code as it stands, but this seems like good future-proofing in any case. While we're at it, insist that the value be no

[COMMITTERS] pgsql: Guard against possible memory allocation botch in batchmemtuples

2016-09-06 Thread Tom Lane
Guard against possible memory allocation botch in batchmemtuples(). Negative availMemLessRefund would be problematic. It's not entirely clear whether the case can be hit in the code as it stands, but this seems like good future-proofing in any case. While we're at it, insist that the value be no

[COMMITTERS] pgsql: Teach appendShellString() to not quote strings containing "-".

2016-09-06 Thread Tom Lane
Teach appendShellString() to not quote strings containing "-". Brain fade in commit a00c58314: I was thinking that a string starting with "-" could be taken as a switch depending on command line syntax. That's true, but having appendShellString() quote it will not help, so we may as well not do s

[COMMITTERS] pgsql: Repair whitespace in initdb message.

2016-09-06 Thread Tom Lane
Repair whitespace in initdb message. What used to be four spaces somehow turned into a tab and a couple of spaces in commit a00c58314, no doubt from overhelpful emacs autoindent. Noted by Peter Eisentraut. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a2ee579b6def8

[COMMITTERS] pgsql: Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL

2016-09-06 Thread Simon Riggs
Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL lazy_truncate_heap() was waiting for VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL, but in microseconds not milliseconds as originally intended. Found by code inspection. Simon Riggs Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/dcb12c

Re: [COMMITTERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-09-06 Thread Christian Ullrich
* Michael Paquier wrote: On Tue, Sep 6, 2016 at 5:36 PM, Christian Ullrich wrote: * Michael Paquier wrote: In order to avoid any problems with the load and unload windows, my bet goes for 0001, 0002 and 0003, with the last two patches merged together, 0001 being only a set of independent fi

Re: [COMMITTERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-09-06 Thread Michael Paquier
On Tue, Sep 6, 2016 at 5:36 PM, Christian Ullrich wrote: > * Michael Paquier wrote: >> In order to avoid any problems with the load and unload windows, my >> bet goes for 0001, 0002 and 0003, with the last two patches merged >> together, 0001 being only a set of independent fixes. That's ugly, but

Re: [COMMITTERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-09-06 Thread Craig Ringer
On 6 Sep. 2016 15:12, "Michael Paquier" wrote: > > On Thu, Sep 1, 2016 at 4:03 PM, Christian Ullrich wrote: > > > That said, introducing this requirement would be a very significant change. > > I'm not sure how many independently maintained compiled extensions there > > are, but this would mean t

Re: [COMMITTERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-09-06 Thread Christian Ullrich
* Michael Paquier wrote: On Thu, Sep 1, 2016 at 4:03 PM, Christian Ullrich wrote: My conclusion from April stands: The fact that master looks like it does means that there have not been many (or any) complaints about missing cross-module environment variables. If nobody ever needs to see a

Re: [COMMITTERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-09-06 Thread Michael Paquier
On Thu, Sep 1, 2016 at 4:03 PM, Christian Ullrich wrote: > * Michael Paquier wrote: > >> On Wed, Apr 27, 2016 at 2:39 AM, Christian Ullrich >> wrote: > >>> * Christian Ullrich wrote: > >> And actually, by looking at those patches, isn't it a dangerous >> practice to be able to load multiple versi