[COMMITTERS] pgsql: Remove user_relns() SRF from regression tests.

2016-09-12 Thread Andres Freund
Remove user_relns() SRF from regression tests. The output of the function changes whenever previous (or, as in this case, concurrent) tests leave a table in place. That causes unneeded churn. This should fix failures due to the tests added bfe16d1a5, like on lapwing, caused by the tsrf test runni

Re: [COMMITTERS] pgsql: Address portability issues in bfe16d1a5 test output.

2016-09-12 Thread Andres Freund
On 2016-09-12 21:49:47 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2016-09-12 21:33:03 -0400, Tom Lane wrote: > >> It looks like making your tables temp would work around it ... > > > Right. But the more general question about the value of that test > > remain. Not that the tables in t

Re: [COMMITTERS] pgsql: Address portability issues in bfe16d1a5 test output.

2016-09-12 Thread Tom Lane
Andres Freund writes: > On 2016-09-12 21:33:03 -0400, Tom Lane wrote: >> It looks like making your tables temp would work around it ... > Right. But the more general question about the value of that test > remain. Not that the tables in this test matter given how simple they > are, but in genera

Re: [COMMITTERS] pgsql: Address portability issues in bfe16d1a5 test output.

2016-09-12 Thread Andres Freund
On 2016-09-12 21:25:05 -0400, Tom Lane wrote: > Hm, lapwing says this can't run in parallel with "misc" either :-( Gah. That's probably why I had originally had it running in the rules group. But isn't that user_relns() test just a bad idea independent of this failure? I mean what's the benefit o

Re: [COMMITTERS] pgsql: Address portability issues in bfe16d1a5 test output.

2016-09-12 Thread Andres Freund
On 2016-09-12 21:33:03 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2016-09-12 21:25:05 -0400, Tom Lane wrote: > >> Hm, lapwing says this can't run in parallel with "misc" either :-( > > > Gah. That's probably why I had originally had it running in the rules > > group. But isn't that us

Re: [COMMITTERS] pgsql: Address portability issues in bfe16d1a5 test output.

2016-09-12 Thread Tom Lane
Andres Freund writes: > On 2016-09-12 21:25:05 -0400, Tom Lane wrote: >> Hm, lapwing says this can't run in parallel with "misc" either :-( > Gah. That's probably why I had originally had it running in the rules > group. But isn't that user_relns() test just a bad idea independent of > this fail

Re: [COMMITTERS] pgsql: Address portability issues in bfe16d1a5 test output.

2016-09-12 Thread Tom Lane
Hm, lapwing says this can't run in parallel with "misc" either :-( I'm not sure about the change you made to have generate_series output just one row --- isn't that losing some of the point of the test? regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-

[COMMITTERS] pgsql: Address portability issues in bfe16d1a5 test output.

2016-09-12 Thread Andres Freund
Address portability issues in bfe16d1a5 test output. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9f478b4f19d8e26300ae19e42c26343f5791e32a Modified Files -- src/test/regress/expected/tsrf.out | 37 +++-- src/test/regress/

[COMMITTERS] pgsql: Add more tests for targetlist SRFs.

2016-09-12 Thread Andres Freund
Add more tests for targetlist SRFs. We're considering changing the implementation of targetlist SRFs considerably, and a lot of the current behaviour isn't tested in our regression tests. Thus it seems useful to increase coverage to avoid accidental behaviour changes. It's quite possible that som

[COMMITTERS] pgsql: Docs: assorted minor cleanups.

2016-09-12 Thread Tom Lane
Docs: assorted minor cleanups. Standardize on "user_name" for a field name in related examples in ddl.sgml; before we had variously "user_name", "username", and "user". The last is flat wrong because it conflicts with a reserved word. Be consistent about entry capitalization in a table in func.sg

[COMMITTERS] pgsql: Docs: assorted minor cleanups.

2016-09-12 Thread Tom Lane
Docs: assorted minor cleanups. Standardize on "user_name" for a field name in related examples in ddl.sgml; before we had variously "user_name", "username", and "user". The last is flat wrong because it conflicts with a reserved word. Be consistent about entry capitalization in a table in func.sg

[COMMITTERS] pgsql: Docs: assorted minor cleanups.

2016-09-12 Thread Tom Lane
Docs: assorted minor cleanups. Standardize on "user_name" for a field name in related examples in ddl.sgml; before we had variously "user_name", "username", and "user". The last is flat wrong because it conflicts with a reserved word. Be consistent about entry capitalization in a table in func.sg

[COMMITTERS] pgsql: pg_basebackup: Clean created directories on failure

2016-09-12 Thread Peter Eisentraut
pg_basebackup: Clean created directories on failure Like initdb, clean up created data and xlog directories, unless the new -n/--noclean option is specified. Tablespace directories are not cleaned up, but a message is written about that. Reviewed-by: Masahiko Sawada Branch -- master Detai

[COMMITTERS] pgsql: Fix recent commit for tab-completion of database template.

2016-09-12 Thread Kevin Grittner
Fix recent commit for tab-completion of database template. The details of commit 52803098ab26051c0c9802f3c19edffc90de8843 were based on a misunderstanding of the role inheritance allowing use of a database for a template. While the CREATEDB privilege is not inherited, the database ownership is pr

[COMMITTERS] pgsql: Fix copy/pasto in file identification

2016-09-12 Thread Simon Riggs
Fix copy/pasto in file identification Daniel Gustafsson Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/9410b711deafeec01672f213ec6b8383c137e759 Modified Files -- src/backend/storage/ipc/dsm_impl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[COMMITTERS] pgsql: Fix copy/pasto in file identification

2016-09-12 Thread Simon Riggs
Fix copy/pasto in file identification Daniel Gustafsson Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/75684fc1f5bbcb097f8230cb9d897b689d44eb10 Modified Files -- src/backend/storage/ipc/dsm_impl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[COMMITTERS] pgsql: Fix copy/pasto in file identification

2016-09-12 Thread Simon Riggs
Fix copy/pasto in file identification Daniel Gustafsson Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/4b47cb35fa516c1bb380ab4edf3131fb6adfacfe Modified Files -- src/backend/storage/ipc/dsm_impl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[COMMITTERS] pgsql: Fix copy/pasto in file identification

2016-09-12 Thread Simon Riggs
Fix copy/pasto in file identification Daniel Gustafsson Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4068eb9918cbbeaba8042fa6fe0c1f5382f2f05f Modified Files -- src/backend/storage/ipc/dsm_impl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -

[COMMITTERS] pgsql: Identify walsenders in pg_stat_activity

2016-09-12 Thread Simon Riggs
Identify walsenders in pg_stat_activity Following 8299471c37fff0b walsender procs are now visible in pg_stat_activity. Set query to ‘walsender’ for walsender procs to allow them to be identified. Discussion:cab7npqs8c76kpsufk_hsdeyrbtg+zz7d0eekjem6txseucb...@mail.gmail.com Michael Paquier, issue