[COMMITTERS] pgsql: Fix latent costing error in create_merge_append_path.

2016-11-19 Thread Tom Lane
Fix latent costing error in create_merge_append_path. create_merge_append_path should use the path rowcount it just computed, not rel->tuples, for costing purposes. Those numbers should always be the same at present, but if we ever support parameterized MergeAppend paths (a case this function is

[COMMITTERS] pgsql: Code review for GUC serialization/deserialization code.

2016-11-19 Thread Tom Lane
Code review for GUC serialization/deserialization code. The serialization code dumped core for a string-valued GUC whose value is NULL, which is a legal state. The infrastructure isn't capable of transmitting that state exactly, but fortunately, transmitting an empty string instead should be clos

[COMMITTERS] pgsql: Code review for GUC serialization/deserialization code.

2016-11-19 Thread Tom Lane
Code review for GUC serialization/deserialization code. The serialization code dumped core for a string-valued GUC whose value is NULL, which is a legal state. The infrastructure isn't capable of transmitting that state exactly, but fortunately, transmitting an empty string instead should be clos

[COMMITTERS] pgsql: Code review for GUC serialization/deserialization code.

2016-11-19 Thread Tom Lane
Code review for GUC serialization/deserialization code. The serialization code dumped core for a string-valued GUC whose value is NULL, which is a legal state. The infrastructure isn't capable of transmitting that state exactly, but fortunately, transmitting an empty string instead should be clos