Re: [COMMITTERS] pgsql: Simplify tape block format.

2016-12-26 Thread Peter Geoghegan
On Thu, Dec 22, 2016 at 8:45 AM, Heikki Linnakangas wrote: > Simplify tape block format. > > No more indirect blocks. The blocks form a linked list instead. There is still one remaining reference to indirect blocks that you missed in comments above LogicalTapeRewindForWrite(). -- Peter Geogheg

[COMMITTERS] pgsql: Remove triggerable Assert in hashname().

2016-12-26 Thread Tom Lane
Remove triggerable Assert in hashname(). hashname() asserted that the key string it is given is shorter than NAMEDATALEN. That should surely always be true if the input is in fact a regular value of type "name". However, for reasons of coding convenience, we allow plain old C strings to be treat

[COMMITTERS] pgsql: Remove triggerable Assert in hashname().

2016-12-26 Thread Tom Lane
Remove triggerable Assert in hashname(). hashname() asserted that the key string it is given is shorter than NAMEDATALEN. That should surely always be true if the input is in fact a regular value of type "name". However, for reasons of coding convenience, we allow plain old C strings to be treat

[COMMITTERS] pgsql: Remove triggerable Assert in hashname().

2016-12-26 Thread Tom Lane
Remove triggerable Assert in hashname(). hashname() asserted that the key string it is given is shorter than NAMEDATALEN. That should surely always be true if the input is in fact a regular value of type "name". However, for reasons of coding convenience, we allow plain old C strings to be treat

[COMMITTERS] pgsql: Remove triggerable Assert in hashname().

2016-12-26 Thread Tom Lane
Remove triggerable Assert in hashname(). hashname() asserted that the key string it is given is shorter than NAMEDATALEN. That should surely always be true if the input is in fact a regular value of type "name". However, for reasons of coding convenience, we allow plain old C strings to be treat

[COMMITTERS] pgsql: Remove triggerable Assert in hashname().

2016-12-26 Thread Tom Lane
Remove triggerable Assert in hashname(). hashname() asserted that the key string it is given is shorter than NAMEDATALEN. That should surely always be true if the input is in fact a regular value of type "name". However, for reasons of coding convenience, we allow plain old C strings to be treat

[COMMITTERS] pgsql: Remove triggerable Assert in hashname().

2016-12-26 Thread Tom Lane
Remove triggerable Assert in hashname(). hashname() asserted that the key string it is given is shorter than NAMEDATALEN. That should surely always be true if the input is in fact a regular value of type "name". However, for reasons of coding convenience, we allow plain old C strings to be treat