[COMMITTERS] pgsql: Fix invalid-parallel-jobs error message

2017-01-09 Thread Stephen Frost
Fix invalid-parallel-jobs error message Including the program name twice is not helpful: -> pg_dump -j -1 pg_dump: pg_dump: invalid number of parallel jobs Correct by removing the progname from the exit_horribly() call used when validating the number of parallel jobs. Noticed while testing vari

[COMMITTERS] pgsql: Fix invalid-parallel-jobs error message

2017-01-09 Thread Stephen Frost
Fix invalid-parallel-jobs error message Including the program name twice is not helpful: -> pg_dump -j -1 pg_dump: pg_dump: invalid number of parallel jobs Correct by removing the progname from the exit_horribly() call used when validating the number of parallel jobs. Noticed while testing vari

[COMMITTERS] pgsql: Fix invalid-parallel-jobs error message

2017-01-09 Thread Stephen Frost
Fix invalid-parallel-jobs error message Including the program name twice is not helpful: -> pg_dump -j -1 pg_dump: pg_dump: invalid number of parallel jobs Correct by removing the progname from the exit_horribly() call used when validating the number of parallel jobs. Noticed while testing vari

[COMMITTERS] pgsql: Fix invalid-parallel-jobs error message

2017-01-09 Thread Stephen Frost
Fix invalid-parallel-jobs error message Including the program name twice is not helpful: -> pg_dump -j -1 pg_dump: pg_dump: invalid number of parallel jobs Correct by removing the progname from the exit_horribly() call used when validating the number of parallel jobs. Noticed while testing vari

[COMMITTERS] pgsql: Fix invalid-parallel-jobs error message

2017-01-09 Thread Stephen Frost
Fix invalid-parallel-jobs error message Including the program name twice is not helpful: -> pg_dump -j -1 pg_dump: pg_dump: invalid number of parallel jobs Correct by removing the progname from the exit_horribly() call used when validating the number of parallel jobs. Noticed while testing vari

[COMMITTERS] pgsql: Fix error handling in pltcl_returnnext.

2017-01-09 Thread Tom Lane
Fix error handling in pltcl_returnnext. We can't throw elog(ERROR) out of a Tcl command procedure; we have to catch the error and return TCL_ERROR to the Tcl interpreter. pltcl_returnnext failed to meet this requirement, so that errors detected by pltcl_build_tuple_result or other functions called

[COMMITTERS] pgsql: Fix ALTER TABLE / SET TYPE for irregular inheritance

2017-01-09 Thread Alvaro Herrera
Fix ALTER TABLE / SET TYPE for irregular inheritance If inherited tables don't have exactly the same schema, the USING clause in an ALTER TABLE / SET DATA TYPE misbehaves when applied to the children tables since commit 9550e8348b79. Starting with that commit, the attribute numbers in the USING e

[COMMITTERS] pgsql: Fix ALTER TABLE / SET TYPE for irregular inheritance

2017-01-09 Thread Alvaro Herrera
Fix ALTER TABLE / SET TYPE for irregular inheritance If inherited tables don't have exactly the same schema, the USING clause in an ALTER TABLE / SET DATA TYPE misbehaves when applied to the children tables since commit 9550e8348b79. Starting with that commit, the attribute numbers in the USING e

[COMMITTERS] pgsql: Fix ALTER TABLE / SET TYPE for irregular inheritance

2017-01-09 Thread Alvaro Herrera
Fix ALTER TABLE / SET TYPE for irregular inheritance If inherited tables don't have exactly the same schema, the USING clause in an ALTER TABLE / SET DATA TYPE misbehaves when applied to the children tables since commit 9550e8348b79. Starting with that commit, the attribute numbers in the USING e

[COMMITTERS] pgsql: BRIN revmap pages are not standard pages ...

2017-01-09 Thread Alvaro Herrera
BRIN revmap pages are not standard pages ... ... and therefore we ought not to tell XLogRegisterBuffer the opposite, when writing XLog for a brin update that moves the index tuple to a different page. Otherwise, xlog insertion would try to "compress the hole" when producing a full-page image for

[COMMITTERS] pgsql: BRIN revmap pages are not standard pages ...

2017-01-09 Thread Alvaro Herrera
BRIN revmap pages are not standard pages ... ... and therefore we ought not to tell XLogRegisterBuffer the opposite, when writing XLog for a brin update that moves the index tuple to a different page. Otherwise, xlog insertion would try to "compress the hole" when producing a full-page image for

[COMMITTERS] pgsql: BRIN revmap pages are not standard pages ...

2017-01-09 Thread Alvaro Herrera
BRIN revmap pages are not standard pages ... ... and therefore we ought not to tell XLogRegisterBuffer the opposite, when writing XLog for a brin update that moves the index tuple to a different page. Otherwise, xlog insertion would try to "compress the hole" when producing a full-page image for

[COMMITTERS] pgsql: Expand the regression tests for PL/Tcl.

2017-01-09 Thread Tom Lane
Expand the regression tests for PL/Tcl. This raises the test coverage (by line count) in pltcl.c from about 70% to 86%. Karl Lehenbauer and Jim Nasby Discussion: https://postgr.es/m/92a1670d-21b6-8f03-9c13-e4fb2207a...@bluetreble.com Branch -- master Details --- http://git.postgresql.

[COMMITTERS] pgsql: Use an enum instead of two bools to indicate wal inclusion in ba

2017-01-09 Thread Magnus Hagander
Use an enum instead of two bools to indicate wal inclusion in base backups This makes the code easier to read as it becomes more explicit what the different allowed combinations really are. Suggested by Michael Paquier Branch -- master Details --- http://git.postgresql.org/pg/commitdiff