Re: [COMMITTERS] pgsql: Generate fmgr prototypes automatically

2017-01-17 Thread Tom Lane
Peter Eisentraut writes: > On 1/17/17 2:35 PM, Tom Lane wrote: >> BTW, now that I've looked through this patch ... why does it add >> >> +#include "nodes/nodes.h" >> +#include "nodes/pg_list.h" >> >> to utils/builtins.h? > There are things in builtins.h that technically need those declarations.

[COMMITTERS] pgsql: Remove dead code in bootstrap

2017-01-17 Thread Alvaro Herrera
Remove dead code in bootstrap The bootstrap scanner/parser contains code to parse floating point values, but this is not exercised anywhere, so remove it. Reviewed-by: Jim Nasby Discussion: https://postgr.es/m/20170110051119.b5h7i3z5qagy35rb@alvherre.pgsql Branch -- master Details --- h

[COMMITTERS] pgsql: Fix typo

2017-01-17 Thread Alvaro Herrera
Fix typo Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/593c75d5c38a47096f11e318cdb3321a5780753f Modified Files -- src/backend/storage/lmgr/lwlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-

Re: [COMMITTERS] pgsql: Generate fmgr prototypes automatically

2017-01-17 Thread Peter Eisentraut
On 1/17/17 2:35 PM, Tom Lane wrote: > Peter Eisentraut writes: >> Generate fmgr prototypes automatically > > BTW, now that I've looked through this patch ... why does it add > > +#include "nodes/nodes.h" > +#include "nodes/pg_list.h" > > to utils/builtins.h? AFAICS that shouldn't be necessary,

Re: [COMMITTERS] pgsql: Generate fmgr prototypes automatically

2017-01-17 Thread Tom Lane
Peter Eisentraut writes: > Generate fmgr prototypes automatically BTW, now that I've looked through this patch ... why does it add +#include "nodes/nodes.h" +#include "nodes/pg_list.h" to utils/builtins.h? AFAICS that shouldn't be necessary, since there are no declarations in builtins.h that w

[COMMITTERS] pgsql: Fix typo

2017-01-17 Thread Alvaro Herrera
Fix typo Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/dda7c34555ca3696fd2a8b93d9aabad333c6cb4e Modified Files -- src/backend/storage/lmgr/lwlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-

Re: [COMMITTERS] pgsql: Generate fmgr prototypes automatically

2017-01-17 Thread Tom Lane
Peter Eisentraut writes: > Generate fmgr prototypes automatically Buildfarm's quite unhappy with this. Did you check parallel make? regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http

[COMMITTERS] pgsql: Correct include file path

2017-01-17 Thread Peter Eisentraut
Correct include file path Mistake in 352a24a1f9d6f7d4abb1175bfd22acc358f43140, not clear why it worked for some before. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/063ef8308b148e3581ddb626fdb397f7a5a48303 Modified Files -- src/include/utils/builtins.

[COMMITTERS] pgsql: Generate fmgr prototypes automatically

2017-01-17 Thread Peter Eisentraut
Generate fmgr prototypes automatically Gen_fmgrtab.pl creates a new file fmgrprotos.h, which contains prototypes for all functions registered in pg_proc.h. This avoids having to manually maintain these prototypes across a random variety of header files. It also automatically enforces a correct f

[COMMITTERS] pgsql: Remove unnecessary include

2017-01-17 Thread Peter Eisentraut
Remove unnecessary include Between 6eeb95f0f56bb5e8a0a9328aeec04c9e6de87272 and 7b1c2a0f2066672b24f6257ec9b8d78a1754f494, builtins.h contained additional prototypes that have now been moved elsewhere, so we don't need to include nodes/parsenodes.h anymore. Fix some files that were relying on buil

[COMMITTERS] pgsql: Rename C symbols for backend lo_ functions

2017-01-17 Thread Peter Eisentraut
Rename C symbols for backend lo_ functions Rename the C symbols for lo_* to be_lo_*, so they don't conflict with libpq prototypes. Reviewed-by: Pavel Stehule Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6fc547960dbe0b8bd6cefae5ab7ec3605a5c46fc Modified Files --

[COMMITTERS] pgsql: Add more tests for money type

2017-01-17 Thread Peter Eisentraut
Add more tests for money type Add tests for functions currently not covered at all. Reviewed-by: Pavel Stehule Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/09e35315ccafb83c52da2e0fd6a0a9be410ce6a4 Modified Files -- src/test/regress/expected/money.ou

[COMMITTERS] pgsql: Register missing money operators in system catalogs

2017-01-17 Thread Peter Eisentraut
Register missing money operators in system catalogs The operators money*int8, int8*money, and money/int8 were implemented in code but not registered in pg_operator or pg_proc. Reviewed-by: Pavel Stehule Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/323b96aa34239b

[COMMITTERS] pgsql: Remove unnecessary prototypes in loadable modules

2017-01-17 Thread Peter Eisentraut
Remove unnecessary prototypes in loadable modules Reviewed-by: Pavel Stehule Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5d7c9c906a0b888dcfd3b0a2f2170e1f5ca366c4 Modified Files -- contrib/intarray/_int_selfuncs.c | 8 contrib/sepgsql/sepgsql

Re: [COMMITTERS] pgsql: doc: Update URL for Microsoft download site

2017-01-17 Thread Tom Lane
Magnus Hagander writes: > I suggest backpatching this. +1. Also, is the reference to "version 7.1", just above, still current? Do we even want to try to track what the current version is? I'd be inclined to delete that parenthetical remark. regards, tom lane -- Sent v

Re: [COMMITTERS] pgsql: doc: Update URL for Microsoft download site

2017-01-17 Thread Magnus Hagander
I suggest backpatching this. It will take a long time for the correct link to reach "current" per the schedule we have now, and it will be years with an incorrect link.. //Magnus On Tue, Jan 17, 2017 at 4:05 PM, Peter Eisentraut wrote: > doc: Update URL for Microsoft download site > > Branch >

[COMMITTERS] pgsql: doc: Update URL for Microsoft download site

2017-01-17 Thread Peter Eisentraut
doc: Update URL for Microsoft download site Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6181c34da882544c4842e7442189a7ea1dd03032 Modified Files -- doc/src/sgml/install-windows.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pg

[COMMITTERS] pgsql: Add compression support to pg_receivexlog

2017-01-17 Thread Magnus Hagander
Add compression support to pg_receivexlog Author: Michael Paquier, review and small changes by me Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cada1af31d769a6b607018d68894f2c879ff275f Modified Files -- doc/src/sgml/ref/pg_receivexlog.sgml | 13

[COMMITTERS] pgsql: Fix an assertion failure related to an exclusive backup.

2017-01-17 Thread Fujii Masao
Fix an assertion failure related to an exclusive backup. Previously multiple sessions could execute pg_start_backup() and pg_stop_backup() to start and stop an exclusive backup at the same time. This could trigger the assertion failure of "FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)". This

[COMMITTERS] pgsql: Fix an assertion failure related to an exclusive backup.

2017-01-17 Thread Fujii Masao
Fix an assertion failure related to an exclusive backup. Previously multiple sessions could execute pg_start_backup() and pg_stop_backup() to start and stop an exclusive backup at the same time. This could trigger the assertion failure of "FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)". This

[COMMITTERS] pgsql: Fix an assertion failure related to an exclusive backup.

2017-01-17 Thread Fujii Masao
Fix an assertion failure related to an exclusive backup. Previously multiple sessions could execute pg_start_backup() and pg_stop_backup() to start and stop an exclusive backup at the same time. This could trigger the assertion failure of "FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)". This

[COMMITTERS] pgsql: Fix an assertion failure related to an exclusive backup.

2017-01-17 Thread Fujii Masao
Fix an assertion failure related to an exclusive backup. Previously multiple sessions could execute pg_start_backup() and pg_stop_backup() to start and stop an exclusive backup at the same time. This could trigger the assertion failure of "FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)". This

[COMMITTERS] pgsql: Fix an assertion failure related to an exclusive backup.

2017-01-17 Thread Fujii Masao
Fix an assertion failure related to an exclusive backup. Previously multiple sessions could execute pg_start_backup() and pg_stop_backup() to start and stop an exclusive backup at the same time. This could trigger the assertion failure of "FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)". This

[COMMITTERS] pgsql: Fix an assertion failure related to an exclusive backup.

2017-01-17 Thread Fujii Masao
Fix an assertion failure related to an exclusive backup. Previously multiple sessions could execute pg_start_backup() and pg_stop_backup() to start and stop an exclusive backup at the same time. This could trigger the assertion failure of "FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)". This