[COMMITTERS] pgsql: Silence compiler warning.

2017-02-02 Thread Heikki Linnakangas
Silence compiler warning. Not all compilers understand that the elog(ERROR) never returns. David Rowley Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cb695ae993a38a0600a907154cfcc71285a9b9ef Modified Files -- src/backend/libpq/crypt.c | 1 + 1 file cha

[COMMITTERS] pgsql: Add KOI8-U map files to Makefile.

2017-02-02 Thread Heikki Linnakangas
Add KOI8-U map files to Makefile. These were left out by mistake back when support for KOI8-U encoding was added. Extracted from Kyotaro Horiguchi's larger patch. Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/e5e75ea288299aafe6dba1d1c18f284593210596 Modifi

[COMMITTERS] pgsql: Add KOI8-U map files to Makefile.

2017-02-02 Thread Heikki Linnakangas
Add KOI8-U map files to Makefile. These were left out by mistake back when support for KOI8-U encoding was added. Extracted from Kyotaro Horiguchi's larger patch. Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/12b4bdcb43b749ecbcde8e129d2a42f797377a6a Modifi

[COMMITTERS] pgsql: Add KOI8-U map files to Makefile.

2017-02-02 Thread Heikki Linnakangas
Add KOI8-U map files to Makefile. These were left out by mistake back when support for KOI8-U encoding was added. Extracted from Kyotaro Horiguchi's larger patch. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/b87e1680b98465b002198ae49a4f4f2bce4d129e Modifi

[COMMITTERS] pgsql: Add KOI8-U map files to Makefile.

2017-02-02 Thread Heikki Linnakangas
Add KOI8-U map files to Makefile. These were left out by mistake back when support for KOI8-U encoding was added. Extracted from Kyotaro Horiguchi's larger patch. Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/3aab31bbc74b4898d62b83868be5f47215cd36f7 Modifi

[COMMITTERS] pgsql: Add KOI8-U map files to Makefile.

2017-02-02 Thread Heikki Linnakangas
Add KOI8-U map files to Makefile. These were left out by mistake back when support for KOI8-U encoding was added. Extracted from Kyotaro Horiguchi's larger patch. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/c5c755862348ec52007ae18e489be07395cbb023 Modifi

[COMMITTERS] pgsql: Add KOI8-U map files to Makefile.

2017-02-02 Thread Heikki Linnakangas
Add KOI8-U map files to Makefile. These were left out by mistake back when support for KOI8-U encoding was added. Extracted from Kyotaro Horiguchi's larger patch. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/53dd2da257fb5904b087b97dd9c2867390d309c1 Modified File

[COMMITTERS] pgsql: Code review for avoidance of direct cross-module links.

2017-02-02 Thread Noah Misch
Code review for avoidance of direct cross-module links. Remove $(pkglibdir) from $(rpathdir), since commits d51924be886c2a05e691fa05b16cb6b30ab8370f and eda04886c1e048d695728206504ab4198462168e removed direct linkage to objects stored there. Users are unlikely to notice the difference. Accompany

[COMMITTERS] pgsql: pageinspect: Support hash indexes.

2017-02-02 Thread Robert Haas
pageinspect: Support hash indexes. Patch by Jesper Pedersen and Ashutosh Sharma, with some error handling improvements by me. Tests from Peter Eisentraut. Reviewed by Álvaro Herrera, Michael Paquier, Jesper Pedersen, Jeff Janes, Peter Eisentraut, Amit Kapila, Mithun Cy, and me. Discussion: http

[COMMITTERS] pgsql: Increase upper bound for bgwriter_lru_maxpages.

2017-02-02 Thread Robert Haas
Increase upper bound for bgwriter_lru_maxpages. There is no particularly good reason to limit this value to 1000, so increase the limit to INT_MAX / 2, the same limit we use for shared_buffers. It's not clear how much practical effect larger settings will have, but there seems no harm in letting

[COMMITTERS] pgsql: doc: Document result set of CREATE_REPLICATION_SLOT

2017-02-02 Thread Peter Eisentraut
doc: Document result set of CREATE_REPLICATION_SLOT From: Marko Tiikkaja Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ecb814b5cef4971e50ee177eff320d416aa0b882 Modified Files -- doc/src/sgml/protocol.sgml | 49 +

[COMMITTERS] pgsql: Fix mishandling of tSRFs at different nesting levels.

2017-02-02 Thread Tom Lane
Fix mishandling of tSRFs at different nesting levels. Given a targetlist like "srf(x), f(srf(x))", split_pathtarget_at_srfs() decided that it needed two levels of ProjectSet nodes, failing to notice that the two SRF calls are textually equal(). Because of that, setrefs.c would convert the upper P

[COMMITTERS] pgsql: doc: Add missing include in example code

2017-02-02 Thread Peter Eisentraut
doc: Add missing include in example code It's not broken because the header file is included via other headers, but for better style we should be more explicit. Reported-by: mthrockmor...@hme.com Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/aa09b9dcd57cbf18516332

[COMMITTERS] pgsql: Fix placement of initPlans when forcibly materializing a subplan

2017-02-02 Thread Tom Lane
Fix placement of initPlans when forcibly materializing a subplan. If we forcibly place a Material node atop a finished subplan, we need to move any initPlans attached to the subplan up to the Material node, in order to keep SS_finalize_plan() happy. I'd figured this out in commit 7b67a0a49 for th

[COMMITTERS] pgsql: Fix placement of initPlans when forcibly materializing a subplan

2017-02-02 Thread Tom Lane
Fix placement of initPlans when forcibly materializing a subplan. If we forcibly place a Material node atop a finished subplan, we need to move any initPlans attached to the subplan up to the Material node, in order to keep SS_finalize_plan() happy. I'd figured this out in commit 7b67a0a49 for th

[COMMITTERS] pgsql: Avoid improbable null pointer dereference in pgpassfileWarning()

2017-02-02 Thread Tom Lane
Avoid improbable null pointer dereference in pgpassfileWarning(). Coverity complained that we might pass a null pointer to strcmp() if PQresultErrorField were to return NULL. That shouldn't be possible, since the server is supposed to always provide some SQLSTATE or other in an error message. Bu

[COMMITTERS] pgsql: Clean up psql's behavior for a few more control variables.

2017-02-02 Thread Tom Lane
Clean up psql's behavior for a few more control variables. Modify FETCH_COUNT to always have a defined value, like other control variables, mainly so it will always appear in "\set" output. Add hooks to force HISTSIZE to be defined and require it to have an integer value. (I don't see any point

Re: [COMMITTERS] pgsql: pageinspect: Support hash indexes.

2017-02-02 Thread Tom Lane
Robert Haas writes: > pageinspect: Support hash indexes. A significant fraction of the buildfarm doesn't like this one bit. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.po

[COMMITTERS] pgsql: pageinspect: Try to fix some bugs in previous commit.

2017-02-02 Thread Robert Haas
pageinspect: Try to fix some bugs in previous commit. Commit 08bf6e529587e1e9075d013d859af2649c32a511 seems not to have used the correct *GetDatum and PG_GETARG_* macros for the SQL types in some cases, and some of the SQL types seem to have been poorly chosen, too. Try to fix it. I'm not sure i

Re: [COMMITTERS] pgsql: pageinspect: Try to fix some bugs in previous commit.

2017-02-02 Thread Tom Lane
Robert Haas writes: > pageinspect: Try to fix some bugs in previous commit. This is a first step, but there's more :-(. Poking at it now on dromedary. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your

Re: [COMMITTERS] pgsql: pageinspect: Try to fix some bugs in previous commit.

2017-02-02 Thread Robert Haas
On Thu, Feb 2, 2017 at 10:40 PM, Tom Lane wrote: > Robert Haas writes: >> pageinspect: Try to fix some bugs in previous commit. > > This is a first step, but there's more :-(. Poking at it now on > dromedary. Ugh, yes. Sorry, I should have checked this more carefully before commit. I mentione

Re: [COMMITTERS] pgsql: pageinspect: Try to fix some bugs in previous commit.

2017-02-02 Thread Tom Lane
Robert Haas writes: > Ugh, yes. Sorry, I should have checked this more carefully before > commit. I mentioned the problem in a previous review and failed to > notice that it hadn't been fixed. Are you taking care of it at this > point or should I keep at it? I'm about to push a fix that remove

Re: [COMMITTERS] pgsql: pageinspect: Try to fix some bugs in previous commit.

2017-02-02 Thread Robert Haas
On Thu, Feb 2, 2017 at 11:00 PM, Tom Lane wrote: > Robert Haas writes: >> Ugh, yes. Sorry, I should have checked this more carefully before >> commit. I mentioned the problem in a previous review and failed to >> notice that it hadn't been fixed. Are you taking care of it at this >> point or s

[COMMITTERS] pgsql: Fix a bunch more portability bugs in commit 08bf6e529.

2017-02-02 Thread Tom Lane
Fix a bunch more portability bugs in commit 08bf6e529. It seems like somebody used a dartboard while choosing integer widths for the various values taken and returned by these functions ... and then threw a fresh set of darts while writing the SQL declarations. This patch brings the C code into l

Re: [COMMITTERS] pgsql: pageinspect: Try to fix some bugs in previous commit.

2017-02-02 Thread Tom Lane
Robert Haas writes: > On Thu, Feb 2, 2017 at 11:00 PM, Tom Lane wrote: >> I'm about to push a fix that removes the crashes (or at least the ones >> I see on dromedary), > For comparison, a patch I wrote by inspection is attached. Hm, some of what you have here matches what I just pushed, but no