[COMMITTERS] pgsql: Pass the source text for a parallel query to the workers.

2017-02-21 Thread Robert Haas
Pass the source text for a parallel query to the workers. With this change, you can see the query that a parallel worker is executing in pg_stat_activity, and if the worker crashes you can see what query it was executing when it crashed. Rafia Sabih, reviewed by Kuntal Ghosh and Amit Kapila and s

[COMMITTERS] pgsql: Fix incorrect typecast.

2017-02-21 Thread Robert Haas
Fix incorrect typecast. Ashutosh Sharma, per a report from Mithun Cy. Discussion: http://postgr.es/m/CAD__OujgqNNnCujeFTmKpjNu+W4smS8Hbi=rcwahf1zus3h...@mail.gmail.com Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b4316928d57bec22e95875e6487a4d665bd03a52 Modifie

Re: [COMMITTERS] pgsql: Fix connection leak in DROP SUBSCRIPTION command.

2017-02-21 Thread Michael Paquier
On Wed, Feb 22, 2017 at 8:39 AM, Fujii Masao wrote: > On Wed, Feb 22, 2017 at 6:57 AM, Michael Paquier > wrote: >> On Wed, Feb 22, 2017 at 4:12 AM, Tom Lane wrote: >>> Fujii Masao writes: Fix connection leak in DROP SUBSCRIPTION command. Previously the command forgot to close the conn

[COMMITTERS] pgsql: Shut down Gather's children before shutting down Gather itself.

2017-02-21 Thread Robert Haas
Shut down Gather's children before shutting down Gather itself. It turns out that the original shutdown order here does not work well. Multiple people attempting to develop further parallel query patches have discovered that they need to do cleanup before the DSM goes away, and you can't do that i

[COMMITTERS] pgsql: doc: Add missing comma.

2017-02-21 Thread Robert Haas
doc: Add missing comma. Yugo Nagata Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d912dd062b64287adcabab4180abafefd07cea14 Modified Files -- doc/src/sgml/ddl.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mail

Re: [COMMITTERS] pgsql: Fix connection leak in DROP SUBSCRIPTION command.

2017-02-21 Thread Petr Jelinek
On 22/02/17 00:39, Fujii Masao wrote: > On Wed, Feb 22, 2017 at 6:57 AM, Michael Paquier > wrote: >> On Wed, Feb 22, 2017 at 4:12 AM, Tom Lane wrote: >>> Fujii Masao writes: Fix connection leak in DROP SUBSCRIPTION command. Previously the command forgot to close the connection to the p

Re: [COMMITTERS] pgsql: Fix connection leak in DROP SUBSCRIPTION command.

2017-02-21 Thread Fujii Masao
On Wed, Feb 22, 2017 at 6:57 AM, Michael Paquier wrote: > On Wed, Feb 22, 2017 at 4:12 AM, Tom Lane wrote: >> Fujii Masao writes: >>> Fix connection leak in DROP SUBSCRIPTION command. >>> Previously the command forgot to close the connection to the publisher >>> when it failed to drop the replic

Re: [COMMITTERS] pgsql: Make walsender always initialize the buffers.

2017-02-21 Thread Fujii Masao
On Wed, Feb 22, 2017 at 4:04 AM, Tom Lane wrote: > Fujii Masao writes: >> Make walsender always initialize the buffers. >> ... >> Back-patch to 9.4 where replication slot was introduced. > > Doesn't look like you actually pushed the back-patch? I only see > this in HEAD. Oh, sorry... I pushed t

[COMMITTERS] pgsql: Make walsender always initialize the buffers.

2017-02-21 Thread Fujii Masao
Make walsender always initialize the buffers. Walsender uses the local buffers for each outgoing and incoming message. Previously when creating replication slot, walsender forgot to initialize one of them and which can cause the segmentation fault error. To fix this issue, this commit changes wals

[COMMITTERS] pgsql: Make walsender always initialize the buffers.

2017-02-21 Thread Fujii Masao
Make walsender always initialize the buffers. Walsender uses the local buffers for each outgoing and incoming message. Previously when creating replication slot, walsender forgot to initialize one of them and which can cause the segmentation fault error. To fix this issue, this commit changes wals

[COMMITTERS] pgsql: Make walsender always initialize the buffers.

2017-02-21 Thread Fujii Masao
Make walsender always initialize the buffers. Walsender uses the local buffers for each outgoing and incoming message. Previously when creating replication slot, walsender forgot to initialize one of them and which can cause the segmentation fault error. To fix this issue, this commit changes wals

[COMMITTERS] pgsql: Suppress unused-variable warning.

2017-02-21 Thread Tom Lane
Suppress unused-variable warning. Rearrange so we don't have an unused variable in disable-cassert case. Discussion: https://postgr.es/m/CAMkU=1x63f2qyfteas83xjqd+hm1pbuok1lrzyzs-ongdzy...@mail.gmail.com Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c56ac2913a1f3

[COMMITTERS] pgsql: Fix sloppy handling of corner-case errors in fd.c.

2017-02-21 Thread Tom Lane
Fix sloppy handling of corner-case errors in fd.c. Several places in fd.c had badly-thought-through handling of error returns from lseek() and close(). The fact that those would seldom fail on valid FDs is probably the reason we've not noticed this up to now; but if they did fail, we'd get quite

[COMMITTERS] pgsql: Fix sloppy handling of corner-case errors in fd.c.

2017-02-21 Thread Tom Lane
Fix sloppy handling of corner-case errors in fd.c. Several places in fd.c had badly-thought-through handling of error returns from lseek() and close(). The fact that those would seldom fail on valid FDs is probably the reason we've not noticed this up to now; but if they did fail, we'd get quite

[COMMITTERS] pgsql: Fix sloppy handling of corner-case errors in fd.c.

2017-02-21 Thread Tom Lane
Fix sloppy handling of corner-case errors in fd.c. Several places in fd.c had badly-thought-through handling of error returns from lseek() and close(). The fact that those would seldom fail on valid FDs is probably the reason we've not noticed this up to now; but if they did fail, we'd get quite

[COMMITTERS] pgsql: Fix sloppy handling of corner-case errors in fd.c.

2017-02-21 Thread Tom Lane
Fix sloppy handling of corner-case errors in fd.c. Several places in fd.c had badly-thought-through handling of error returns from lseek() and close(). The fact that those would seldom fail on valid FDs is probably the reason we've not noticed this up to now; but if they did fail, we'd get quite

[COMMITTERS] pgsql: Fix sloppy handling of corner-case errors in fd.c.

2017-02-21 Thread Tom Lane
Fix sloppy handling of corner-case errors in fd.c. Several places in fd.c had badly-thought-through handling of error returns from lseek() and close(). The fact that those would seldom fail on valid FDs is probably the reason we've not noticed this up to now; but if they did fail, we'd get quite

[COMMITTERS] pgsql: Fix sloppy handling of corner-case errors in fd.c.

2017-02-21 Thread Tom Lane
Fix sloppy handling of corner-case errors in fd.c. Several places in fd.c had badly-thought-through handling of error returns from lseek() and close(). The fact that those would seldom fail on valid FDs is probably the reason we've not noticed this up to now; but if they did fail, we'd get quite

[COMMITTERS] pgsql: Add tests for two-phase commit

2017-02-21 Thread Alvaro Herrera
Add tests for two-phase commit There's some ongoing performance work on this area, so let's make sure we don't break things. Extracted from a larger patch originally by Stas Kelvich. Authors: Stas Kelvich, Nikhil Sontakke, Michael Paquier Discussion: https://postgr.es/m/CAMGcDxfsuLLOg=h5cTg3g77

Re: [COMMITTERS] pgsql: Fix connection leak in DROP SUBSCRIPTION command.

2017-02-21 Thread Michael Paquier
On Wed, Feb 22, 2017 at 4:12 AM, Tom Lane wrote: > Fujii Masao writes: >> Fix connection leak in DROP SUBSCRIPTION command. >> Previously the command forgot to close the connection to the publisher >> when it failed to drop the replication slot. > > If there's a bug here, this seems like an extre

[COMMITTERS] pgsql: Fix whitespace

2017-02-21 Thread Peter Eisentraut
Fix whitespace Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/74321d87fb1a27746c9dd0853b2da3287a0940d9 Modified Files -- src/backend/commands/subscriptioncmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing

Re: [COMMITTERS] pgsql: Fix connection leak in DROP SUBSCRIPTION command.

2017-02-21 Thread Tom Lane
Fujii Masao writes: > Fix connection leak in DROP SUBSCRIPTION command. > Previously the command forgot to close the connection to the publisher > when it failed to drop the replication slot. If there's a bug here, this seems like an extremely unreliable way of fixing it. What if an error gets t

Re: [COMMITTERS] pgsql: Make walsender always initialize the buffers.

2017-02-21 Thread Tom Lane
Fujii Masao writes: > Make walsender always initialize the buffers. > ... > Back-patch to 9.4 where replication slot was introduced. Doesn't look like you actually pushed the back-patch? I only see this in HEAD. regards, tom lane -- Sent via pgsql-committers mailing l

[COMMITTERS] pgsql: Fix typo in comment.

2017-02-21 Thread Fujii Masao
Fix typo in comment. neha khatri Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e14ec7d346f8686c9471c16a01579d6b1c3b4975 Modified Files -- src/backend/utils/adt/varlena.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committe

[COMMITTERS] pgsql: Fix connection leak in DROP SUBSCRIPTION command.

2017-02-21 Thread Fujii Masao
Fix connection leak in DROP SUBSCRIPTION command. Previously the command forgot to close the connection to the publisher when it failed to drop the replication slot. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/898a792eb8283e31efc0b6fcbc03bbcd5f7df667 Modified Fi

[COMMITTERS] pgsql: Make walsender always initialize the buffers.

2017-02-21 Thread Fujii Masao
Make walsender always initialize the buffers. Walsender uses the local buffers for each outgoing and incoming message. Previously when creating replication slot, walsender forgot to initialize one of them and which can cause the segmentation fault error. To fix this issue, this commit changes wals

[COMMITTERS] pgsql: Remove confusing comment about unsupported feature.

2017-02-21 Thread Fujii Masao
Remove confusing comment about unsupported feature. The initial table synchronization feature has not been supported yet, but there was the confusing header comment about it in logical/worker.c. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d36537008a8d53853d2fda49

[COMMITTERS] pgsql: doc: Update URL for plr

2017-02-21 Thread Peter Eisentraut
doc: Update URL for plr Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/efc286643f33ce2949e5210338cb5cca0426eb04 Modified Files -- doc/src/sgml/external-projects.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committ

[COMMITTERS] pgsql: doc: Update URL for plr

2017-02-21 Thread Peter Eisentraut
doc: Update URL for plr Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/b9f05be3855e8573d44e16af39682705cc33b9f5 Modified Files -- doc/src/sgml/external-projects.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committ

[COMMITTERS] pgsql: doc: Update URL for plr

2017-02-21 Thread Peter Eisentraut
doc: Update URL for plr Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/931182fe3a2c7725238d4351f42c5318b4143bee Modified Files -- doc/src/sgml/external-projects.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committ

[COMMITTERS] pgsql: doc: Update URL for plr

2017-02-21 Thread Peter Eisentraut
doc: Update URL for plr Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/6b75aee4b645ae48ba99ed383218d50e46c292ae Modified Files -- doc/src/sgml/external-projects.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committ

[COMMITTERS] pgsql: doc: Update URL for plr

2017-02-21 Thread Peter Eisentraut
doc: Update URL for plr Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/cabfec988191bcaf49c9aefc777ac8b0ba35e6ec Modified Files -- doc/src/sgml/external-projects.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committ

[COMMITTERS] pgsql: doc: Update URL for plr

2017-02-21 Thread Peter Eisentraut
doc: Update URL for plr Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7248099c169b40b8f70cdaf8e12d0deaab9b16e2 Modified Files -- doc/src/sgml/external-projects.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mai

[COMMITTERS] pgsql: Use less-generic table name in new regression test case.

2017-02-21 Thread Tom Lane
Use less-generic table name in new regression test case. Creating global objects named "foo" isn't an especially wise thing, but especially not in a test script that has already used that name for something else, and most especially not in a script that runs in parallel with other scripts that use

[COMMITTERS] pgsql: Make more use of castNode()

2017-02-21 Thread Peter Eisentraut
Make more use of castNode() Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/38d103763d14baddf3cbfe4b00b501059fc9447f Modified Files -- src/backend/commands/copy.c| 2 +- src/backend/nodes/nodeFuncs.c | 24 +

[COMMITTERS] pgsql: Reject too-old Python versions a bit sooner.

2017-02-21 Thread Tom Lane
Reject too-old Python versions a bit sooner. Commit 04aad4018 added this check after the search for a Python shared library, which seems to me to be a pretty unfriendly ordering. The search might fail for what are basically version-related reasons, and in such a case it'd be better to say "your P

[COMMITTERS] pgsql: Drop support for Python 2.3

2017-02-21 Thread Peter Eisentraut
Drop support for Python 2.3 There is no specific reason for this right now, but keeping support for old Python versions around indefinitely increases the maintenance burden. The oldest supported Python version is now Python 2.4, which is still shipped in RHEL/CentOS 5 by default. In configure, a

[COMMITTERS] pgsql: Small correction to BRIN docs

2017-02-21 Thread Simon Riggs
Small correction to BRIN docs Replace incorrect word "index" with "heap" Takayuki Tsunakawa Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0bf41dd1908a0c05833168b9972e1c52cb7547b7 Modified Files -- doc/src/sgml/brin.sgml | 2 +- 1 file changed, 1 insert