[COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation.

2017-03-10 Thread Tom Lane
Improve postmaster's logging of listen socket creation. When one of the kernel calls in the socket()/bind()/listen() sequence fails, include the specific address we're trying to bind to in the log message. This greatly eases debugging of network misconfigurations. Also, after successfully settin

Re: [COMMITTERS] pgsql: contrib/amcheck needs RecentGlobalXmin to be PGDLLIMPORT'ified.

2017-03-10 Thread Peter Geoghegan
On Fri, Mar 10, 2017 at 11:47 AM, Andres Freund wrote: >> Assert(TransactionIdIsValid(RecentGlobalXmin)); >> >> I agree: that is just about utterly useless. > > Well, it mirrors an existing Assert, that'd be hit when doing normal > index lookups. But I agree that a bug around this is exceed

[COMMITTERS] pgsql: pg_dump: Fix dumping of publications

2017-03-10 Thread Peter Eisentraut
pg_dump: Fix dumping of publications Dumping a publication with more than one table crashed pg_dump. patch by Amit Langote , test by me Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/de75281637b762b4ccfb776366c44251e6864d0a Modified Files -- src/bin/pg

[COMMITTERS] pgsql: Reduce log verbosity of startup/shutdown for launcher subprocess

2017-03-10 Thread Tom Lane
Reduce log verbosity of startup/shutdown for launcher subprocesses. There's no really good reason why the autovacuum launcher and logical replication launcher should announce themselves at startup and shutdown by default. Users don't care that those processes exist, and it's inconsistent that tho

[COMMITTERS] pgsql: Revert "Use group updates when setting transaction status in clo

2017-03-10 Thread Robert Haas
Revert "Use group updates when setting transaction status in clog." This reverts commit ccce90b398673d55b0387b3de66639b1b30d451b. This optimization is unsafe, at least, of rollbacks and rollbacks to savepoints, but I'm concerned there may be other problematic cases as well. Therefore, I've decid

Re: [COMMITTERS] pgsql: contrib/amcheck needs RecentGlobalXmin to be PGDLLIMPORT'ified.

2017-03-10 Thread Andres Freund
On 2017-03-09 23:50:27 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2017-03-10 03:55:50 +, Tom Lane wrote: > >> contrib/amcheck needs RecentGlobalXmin to be PGDLLIMPORT'ified. > > > Heh, I just wanted to push a patch removing the assertion because it > > doesn't add that much. There

[COMMITTERS] pgsql: Enable 64 bit atomics on ARM64.

2017-03-10 Thread Andres Freund
Enable 64 bit atomics on ARM64. Previously they were disabled due to performance concerns on 32bit arm, where 64bit atomics are often implemented via kernel traps. Author: Roman Shaposhnik Discussion: http://postgr.es/m/ca+ulb+uerkfuxuccxwhyvnv5knayjguzzrcpa-m0cgo+hm4...@mail.gmail.com Branch -

[COMMITTERS] pgsql: Sanitize newlines in object names in "pg_restore -l" output.

2017-03-10 Thread Tom Lane
Sanitize newlines in object names in "pg_restore -l" output. Commits 89e0bac86 et al replaced newlines with spaces in object names printed in SQL comments, but we neglected to consider that the same names are also printed by "pg_restore -l", and a newline would render the output unparseable by "pg

[COMMITTERS] pgsql: Sanitize newlines in object names in "pg_restore -l" output.

2017-03-10 Thread Tom Lane
Sanitize newlines in object names in "pg_restore -l" output. Commits 89e0bac86 et al replaced newlines with spaces in object names printed in SQL comments, but we neglected to consider that the same names are also printed by "pg_restore -l", and a newline would render the output unparseable by "pg

[COMMITTERS] pgsql: Sanitize newlines in object names in "pg_restore -l" output.

2017-03-10 Thread Tom Lane
Sanitize newlines in object names in "pg_restore -l" output. Commits 89e0bac86 et al replaced newlines with spaces in object names printed in SQL comments, but we neglected to consider that the same names are also printed by "pg_restore -l", and a newline would render the output unparseable by "pg

[COMMITTERS] pgsql: Sanitize newlines in object names in "pg_restore -l" output.

2017-03-10 Thread Tom Lane
Sanitize newlines in object names in "pg_restore -l" output. Commits 89e0bac86 et al replaced newlines with spaces in object names printed in SQL comments, but we neglected to consider that the same names are also printed by "pg_restore -l", and a newline would render the output unparseable by "pg

[COMMITTERS] pgsql: Sanitize newlines in object names in "pg_restore -l" output.

2017-03-10 Thread Tom Lane
Sanitize newlines in object names in "pg_restore -l" output. Commits 89e0bac86 et al replaced newlines with spaces in object names printed in SQL comments, but we neglected to consider that the same names are also printed by "pg_restore -l", and a newline would render the output unparseable by "pg

[COMMITTERS] pgsql: Sanitize newlines in object names in "pg_restore -l" output.

2017-03-10 Thread Tom Lane
Sanitize newlines in object names in "pg_restore -l" output. Commits 89e0bac86 et al replaced newlines with spaces in object names printed in SQL comments, but we neglected to consider that the same names are also printed by "pg_restore -l", and a newline would render the output unparseable by "pg

[COMMITTERS] pgsql: Change the relkind for partitioned tables from 'P' to 'p'.

2017-03-10 Thread Tom Lane
Change the relkind for partitioned tables from 'P' to 'p'. Seven of the eight other relkind codes are lower-case, so it wasn't consistent for this one to be upper-case. Fix it while we still can. Historical notes: the reason for the lone exception, i.e. sequences being 'S', is that 's' was once

[COMMITTERS] pgsql: Un-break things on IPv6-less platforms.

2017-03-10 Thread Tom Lane
Un-break things on IPv6-less platforms. Commit be37c2120 forgot to teach initdb about commenting out the IPv6 replication entry that it caused to exist in pg_hba.conf.sample. Per buildfarm. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a83e4b4f31c7afa5f7360086ebb19

[COMMITTERS] pgsql: Improve gitignore file

2017-03-10 Thread Peter Eisentraut
Improve gitignore file One file was listed under a wrong comment. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/07a61e16703b5f90650d509e29a724c68efd79ab Modified Files -- doc/src/sgml/.gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --

[COMMITTERS] pgsql: dblink: Change some StringInfo to StringInfoData

2017-03-10 Thread Peter Eisentraut
dblink: Change some StringInfo to StringInfoData For consistency with other code and to avoid wasting some small amount of memory. From: Tsunakawa, Takayuki Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/22ef6b041a554b7536edb3a79e0b9d5d8403f432 Modified Files ---

[COMMITTERS] pgsql: dblink: Replace some macros by static functions

2017-03-10 Thread Peter Eisentraut
dblink: Replace some macros by static functions Also remove some unused code and the no longer useful dblink.h file. Reviewed-by: Tsunakawa, Takayuki Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/acaf7ccb94a3916ea83712671a3563f0eb595558 Modified Files --

[COMMITTERS] pgsql: Fix a potential double-free in ecpg.

2017-03-10 Thread Michael Meskes
Fix a potential double-free in ecpg. Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/466ee7a5326b0071b91b46fd3b657c35b52fd8c6 Modified Files -- src/interfaces/ecpg/preproc/pgc.l | 1 + 1 file changed, 1 insertion(+) -- Sent via pgsql-committers m

[COMMITTERS] pgsql: Fix a potential double-free in ecpg.

2017-03-10 Thread Michael Meskes
Fix a potential double-free in ecpg. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d1ca82d0a226f22438a1cf4ba0ed3460e6db692b Modified Files -- src/interfaces/ecpg/preproc/pgc.l | 1 + 1 file changed, 1 insertion(+) -- Sent via pgsql-committers mailing

[COMMITTERS] pgsql: Fix a potential double-free in ecpg.

2017-03-10 Thread Michael Meskes
Fix a potential double-free in ecpg. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/731afc91f0988604535db7838731cc1c355b160e Modified Files -- src/interfaces/ecpg/preproc/pgc.l | 1 + 1 file changed, 1 insertion(+) -- Sent via pgsql-committers m

[COMMITTERS] pgsql: Fix a potential double-free in ecpg.

2017-03-10 Thread Michael Meskes
Fix a potential double-free in ecpg. Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/d0fef065446e900aaca1382b641d9449396c41f4 Modified Files -- src/interfaces/ecpg/preproc/pgc.l | 1 + 1 file changed, 1 insertion(+) -- Sent via pgsql-committers m

[COMMITTERS] pgsql: Fix a potential double-free in ecpg.

2017-03-10 Thread Michael Meskes
Fix a potential double-free in ecpg. Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/f6b9065993e0d5e64dec28aff3a090674934ae52 Modified Files -- src/interfaces/ecpg/preproc/pgc.l | 1 + 1 file changed, 1 insertion(+) -- Sent via pgsql-committers m

[COMMITTERS] pgsql: Fix a potential double-free in ecpg.

2017-03-10 Thread Michael Meskes
Fix a potential double-free in ecpg. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/af471919bc7e501ee75dd48be763fbdb9c7b530a Modified Files -- src/interfaces/ecpg/preproc/pgc.l | 1 + 1 file changed, 1 insertion(+) -- Sent via pgsql-committers m