Add missing break
Reported-by: Mark Kirkwood
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/4dd3abe99f5062dbb874fbc8f6bd306b08f702e8
Modified Files
--
src/backend/tcop/utility.c | 1 +
1 file changed, 1 insertion(+)
--
Sent via pgsql-committers maili
psql: Add missing schema qualification
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/19f7e1a7f7dfa841d9357be951f7478b3741009e
Modified Files
--
src/bin/psql/describe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
Sent via pgsql-committers
On 3/24/17 22:28, Tom Lane wrote:
> David Rowley writes:
>> I see this commit changed the definition of pg_locale_t
>> but forgot to update varstr_cmp() completely.
>
> It's pretty disturbing that we don't seem to have caught that
> in testing.
Or during compilation!?!
> Some work on code cover
On 3/24/17 20:32, David Rowley wrote:
> but forgot to update varstr_cmp() completely.
>
> result = wcscoll_l((LPWSTR) a1p, (LPWSTR) a2p, mylocale);
>
> should be:
>
> result = wcscoll_l((LPWSTR) a1p, (LPWSTR) a2p, mylocale->info.lt);
>
> Patch attached.
Fixed.
--
Peter Eisentraut
Fix locale pointer use in WIN32 code path
Author: David Rowley
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/066e3a68ae5210a1fb4ac1c19069202615ce4d89
Modified Files
--
src/backend/utils/adt/varlena.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
On 3/23/17 23:53, Tom Lane wrote:
> Ah, scratch that, I was overthinking it. The problem is pretty
> clear from the error message:
>
> + ERROR: collation "en-x-icu" for encoding "SQL_ASCII" does not exist
>
> I can reproduce this with vanilla configure options if I'm running
> with --with-icu a
Remove ICU tests from default run
These tests require the test database to be in UTF8 encoding. Until
there is a better solution, take them out of the default test set and
treat them like the existing collate.linux.utf8 test, meaning it has to
be selected manually.
Branch
--
master
Details
Fix recovery test hang
The test would hang if a sufficient ~/.psqlrc was present. Fix by using
psql -X.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/cd07f73d3225c092f4cd0e7bf1cab11ac9f8c1f0
Modified Files
--
src/test/recovery/t/011_crash_recovery.pl
Add COMMENT and SECURITY LABEL support for publications and subscriptions
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/87dee41f3ed6d6c2a93e7ff359776cfe24f145e0
Modified Files
--
doc/src/sgml/ref/comment.sgml | 2 ++
doc/src/sgml/re
Make header self-contained
Add necessary include files for things used in the header.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/7678fe1c6dd532f5f85a768c97b75dc40072c8e4
Modified Files
--
src/include/catalog/pg_subscription_rel.h | 2 ++
1 file chang
David Rowley writes:
> I see this commit changed the definition of pg_locale_t
> but forgot to update varstr_cmp() completely.
It's pretty disturbing that we don't seem to have caught that
in testing. Some work on code coverage seems indicated.
regards, tom lane
--
Se
Add more subscription DDL tests
Add more tests for various variants of subscription DDL commands, based
on code coverage report. Fix a small bug discovered by that.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/e3920ac823353f200cfecde74076d3d40f79e2b1
Modified Fi
On 24 March 2017 at 06:33, Peter Eisentraut wrote:
> http://git.postgresql.org/pg/commitdiff/eccfef81e1f73ee41f1d8bfe4fa4e80576945048
[...]
> src/include/utils/pg_locale.h| 32 +-
I see this commit changed the definition of pg_locale_t
+struct pg_locale_t
+{
+ charpr
Fix typo in comment
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/2e0c919bceae23a9fd52d6dc1c3bf0d74501c14f
Modified Files
--
src/backend/utils/mmgr/dsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
Sent via pgsql-committers mailing list (
Fix stats_ext test in 32 bit machines
Because tuple packing is different (because of the MAXALIGN difference),
the expected costs of a seqscan is different.
The commonly used trick of eliding costs in EXPLAIN output (COSTS OFF)
would make the tests completely pointless. Instead, add an alternati
Check that published table exists on subscriber
Author: Petr Jelinek
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/176cbc2a25a1c0db97ec8977545bb16fe3ea5809
Modified Files
--
src/backend/commands/subscriptioncmds.c | 2 +-
1 file changed, 1 insertion(+)
Improve access to parallel query from procedural languages.
In SQL, the ability to use parallel query was previous contingent on
fcache->readonly_func, which is only set for non-volatile functions;
but the volatility of a function has no bearing on whether queries
inside it can use parallelism. R
Fix use-after-free bug
Detected by buildfarm member prion
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/8082bea2b06eb6bcd6cce4cc7801094c17045b4f
Modified Files
--
src/backend/commands/statscmds.c | 11 ++-
1 file changed, 6 insertions(+), 5 dele
Reverting 42b4b0b2413b9b472aaf2112a3bbfd80a6ab4dc5
Buildfarm issues and other reported issues
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/3428ef79115927c92c6e2ab6f261f5de5dc4e914
Modified Files
--
src/backend/access/transam/xact.c | 6 +++---
src/bac
Make VACUUM VERBOSE report the number of skipped frozen pages.
Previously manual VACUUM did not report the number of skipped frozen
pages even when VERBOSE option is specified. But this information is
helpful to monitor the VACUUM activity, and also autovacuum reports that
number in the log file w
Implement multivariate n-distinct coefficients
Add support for explicitly declared statistic objects (CREATE
STATISTICS), allowing collection of statistics on more complex
combinations that individual table columns. Companion commands DROP
STATISTICS and ALTER STATISTICS ... OWNER TO / SET SCHEMA
plpgsql: Don't generate parallel plans for RETURN QUERY.
Commit 7aea8e4f2daa4b39ca9d1309a0c4aadb0f7ed81b allowed a parallel
plan to be generated when for a RETURN QUERY or RETURN QUERY EXECUTE
statement in a PL/pgsql block, but that's a bad idea because plplgsql
asks the executor for 50 rows at a
plpgsql: Don't generate parallel plans for RETURN QUERY.
Commit 7aea8e4f2daa4b39ca9d1309a0c4aadb0f7ed81b allowed a parallel
plan to be generated when for a RETURN QUERY or RETURN QUERY EXECUTE
statement in a PL/pgsql block, but that's a bad idea because plplgsql
asks the executor for 50 rows at a
Fix pgbench options -C and -R together
The bug is that prior to --rate doCustom was always disconnect/reconnect
without exiting, but with rate it returns if it has to wait. However threadRun
test whether there is a connection before recalling doCustom, so it was never
called.
Bug is not existed i
Add a txid_status function.
If your connection to the database server is lost while a COMMIT is
in progress, it may be difficult to figure out whether the COMMIT was
successful or not. This function will tell you, provided that you
don't wait too long to ask. It may be useful in other situations
On 03/24/2017 09:26 AM, Tom Lane wrote:
> Andrew Dunstan writes:
>> On 03/23/2017 11:53 PM, Tom Lane wrote:
>>> + ERROR: collation "en-x-icu" for encoding "SQL_ASCII" does not exist
>>>
>>> I can reproduce this with vanilla configure options if I'm running
>>> with --with-icu and LANG=C. In sh
Avoid SnapshotResetXmin() during AtEOXact_Snapshot()
For normal commits and aborts we already reset PgXact->xmin
Avoiding touching highly contented shmem improves concurrent
performance.
Simon Riggs
Discussion: canp8+jjdxe9b+b9f8cqt-luxxo0pbcb-szffmvadp+akqo4...@mail.gmail.com
Branch
--
mas
Andrew Dunstan writes:
> On 03/23/2017 11:53 PM, Tom Lane wrote:
>> + ERROR: collation "en-x-icu" for encoding "SQL_ASCII" does not exist
>>
>> I can reproduce this with vanilla configure options if I'm running
>> with --with-icu and LANG=C. In short, this regression test does not
>> work in C
Handle empty result set in libpqrcv_exec
Always return tupleslot and tupledesc from libpqrcv_exec. This avoids
requiring callers to handle that separately.
Author: Petr Jelinek
Reported-by: Michael Banck
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/8398c836892
Allow SCRAM authentication, when pg_hba.conf says 'md5'.
If a user has a SCRAM verifier in pg_authid.rolpassword, there's no reason
we cannot attempt to perform SCRAM authentication instead of MD5. The worst
that can happen is that the client doesn't support SCRAM, and the
authentication will fail
Fix backup canceling
Assert-enabled build crashes but without asserts it works by wrong way:
it may not reset forcing full page write and preventing from starting
exclusive backup with the same name as cancelled.
Patch replaces pair of booleans
nonexclusive_backup_running/exclusive_backup_running
Fix backup canceling
Assert-enabled build crashes but without asserts it works by wrong way:
it may not reset forcing full page write and preventing from starting
exclusive backup with the same name as cancelled.
Patch replaces pair of booleans
nonexclusive_backup_running/exclusive_backup_running
Revert Windows service check refactoring, and replace with a different fix.
This reverts commit 38bdba54a64bacec78e3266f0848b0b4a824132a, "Fix and
simplify check for whether we're running as Windows service". It turns out
that older versions of MinGW - like that on buildfarm member narwhal - do
no
Revert Windows service check refactoring, and replace with a different fix.
This reverts commit 38bdba54a64bacec78e3266f0848b0b4a824132a, "Fix and
simplify check for whether we're running as Windows service". It turns out
that older versions of MinGW - like that on buildfarm member narwhal - do
no
Revert Windows service check refactoring, and replace with a different fix.
This reverts commit 38bdba54a64bacec78e3266f0848b0b4a824132a, "Fix and
simplify check for whether we're running as Windows service". It turns out
that older versions of MinGW - like that on buildfarm member narwhal - do
no
Revert Windows service check refactoring, and replace with a different fix.
This reverts commit 38bdba54a64bacec78e3266f0848b0b4a824132a, "Fix and
simplify check for whether we're running as Windows service". It turns out
that older versions of MinGW - like that on buildfarm member narwhal - do
no
Revert Windows service check refactoring, and replace with a different fix.
This reverts commit 38bdba54a64bacec78e3266f0848b0b4a824132a, "Fix and
simplify check for whether we're running as Windows service". It turns out
that older versions of MinGW - like that on buildfarm member narwhal - do
no
On 03/23/2017 11:53 PM, Tom Lane wrote:
> I wrote:
>> The buildfarm's mostly happy, but "prion" still isn't, which
>> suggests there's someplace in the new code that references an
>> already-closed relcache entry.
> Ah, scratch that, I was overthinking it. The problem is pretty
> clear from the
38 matches
Mail list logo
