Re: [COMMITTERS] pgsql: Remove unreachable code in expression evaluation.

2017-03-25 Thread Andres Freund
On 2017-03-26 00:14:30 -0400, Tom Lane wrote: > Andres Freund writes: > > Remove unreachable code in expression evaluation. > > The previous code still contained expression evaluation time support > > for CaseExprs without a defresult. But transformCaseExpr() creates a > > default expression if n

Re: [COMMITTERS] pgsql: Remove unreachable code in expression evaluation.

2017-03-25 Thread Tom Lane
Andres Freund writes: > Remove unreachable code in expression evaluation. > The previous code still contained expression evaluation time support > for CaseExprs without a defresult. But transformCaseExpr() creates a > default expression if necessary. BTW, now that I think about it, I wonder if a

[COMMITTERS] pgsql: Blindly attempt to fix sepgsql tests #2.

2017-03-25 Thread Andres Freund
Blindly attempt to fix sepgsql tests #2. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d253b0f6e3ea829bbc898040477cac6775faab67 Modified Files -- contrib/sepgsql/expected/alter.out | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsq

[COMMITTERS] pgsql: Blindly attempt to fix sepgsql tests.

2017-03-25 Thread Andres Freund
Blindly attempt to fix sepgsql tests. Due to b8d7f053c5c some permission checks are now happening even on empty tables, and some of the checks move around. Discussion: https://postgr.es/m/95bdb608-093c-160f-c6be-983a36ccd...@joeconway.com Branch -- master Details --- http://git.postgre

Re: [COMMITTERS] pgsql: Faster expression evaluation and targetlist projection.

2017-03-25 Thread Michael Paquier
On Sun, Mar 26, 2017 at 7:58 AM, David Rowley wrote: > On 26 March 2017 at 09:55, Thomas Munro wrote: >> On Sun, Mar 26, 2017 at 11:11 AM, Andres Freund wrote: >>> Faster expression evaluation and targetlist projection. >>> >>> This replaces the old, recursive tree-walk based evaluation, with >>

[COMMITTERS] pgsql: Remove unreachable code in expression evaluation.

2017-03-25 Thread Andres Freund
Remove unreachable code in expression evaluation. The previous code still contained expression evaluation time support for CaseExprs without a defresult. But transformCaseExpr() creates a default expression if necessary. Author: Andres Freund Discussion: https://postgr.es/m/4834.1490480...@sss.p

Re: [COMMITTERS] pgsql: Faster expression evaluation and targetlist projection.

2017-03-25 Thread David Rowley
On 26 March 2017 at 09:55, Thomas Munro wrote: > On Sun, Mar 26, 2017 at 11:11 AM, Andres Freund wrote: >> Faster expression evaluation and targetlist projection. >> >> This replaces the old, recursive tree-walk based evaluation, with >> non-recursive, opcode dispatch based, expression evaluation

Re: [COMMITTERS] pgsql: Faster expression evaluation and targetlist projection.

2017-03-25 Thread Peter Geoghegan
On Sat, Mar 25, 2017 at 3:55 PM, Thomas Munro wrote: > This is a huge achievement. Congratulations! I also think it's excellent. Well done to all involved. -- Peter Geoghegan -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: ht

Re: [COMMITTERS] pgsql: Faster expression evaluation and targetlist projection.

2017-03-25 Thread Thomas Munro
On Sun, Mar 26, 2017 at 11:11 AM, Andres Freund wrote: > Faster expression evaluation and targetlist projection. > > This replaces the old, recursive tree-walk based evaluation, with > non-recursive, opcode dispatch based, expression evaluation. > Projection is now implemented as part of expressio

[COMMITTERS] pgsql: git rm execQual.c

2017-03-25 Thread Tom Lane
git rm execQual.c Should have been in commit b8d7f053c5c2bf2a7e8734fe3327f6a8bc711755, but passing the patch back and forth as a patch seems to have dropped that metadata. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8acf08c68dd8b9fa1793f6ccf9e216cdec63fb49 Modif

[COMMITTERS] pgsql: Faster expression evaluation and targetlist projection.

2017-03-25 Thread Andres Freund
Faster expression evaluation and targetlist projection. This replaces the old, recursive tree-walk based evaluation, with non-recursive, opcode dispatch based, expression evaluation. Projection is now implemented as part of expression evaluation. This both leads to significant performance improve

[COMMITTERS] pgsql: Remember to drop roles created by regression tests.

2017-03-25 Thread Tom Lane
Remember to drop roles created by regression tests. Commit e3920ac82 created "regress_subscription_user2" in subscription.sql, but forgot to drop it, causing the regression tests to fail if run twice without re-initdb'ing. Branch -- master Details --- http://git.postgresql.org/pg/commitd

[COMMITTERS] pgsql: Re-adhere to policy of no more than 20 tests per parallel group.

2017-03-25 Thread Tom Lane
Re-adhere to policy of no more than 20 tests per parallel group. As explained at the head of parallel_schedule, we place an arbitrary limit of 20 test cases per parallel group. Commit c7a9fa399 overlooked this. Least messy solution seems to be to move the "comments" test to the next group, since

Re: [COMMITTERS] pgsql: Allow vacuums to report oldestxmin

2017-03-25 Thread Masahiko Sawada
On Sun, Mar 26, 2017 at 1:37 AM, Fujii Masao wrote: > On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada wrote: >> On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs wrote: >>> Allow vacuums to report oldestxmin >>> >>> Allow VACUUM and Autovacuum to report the oldestxmin value they >>> used while cleani

Re: [COMMITTERS] pgsql: Allow vacuums to report oldestxmin

2017-03-25 Thread Fujii Masao
On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada wrote: > On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs wrote: >> Allow vacuums to report oldestxmin >> >> Allow VACUUM and Autovacuum to report the oldestxmin value they >> used while cleaning tables, helping to make better sense out of >> the other

Re: [COMMITTERS] pgsql: Add COMMENT and SECURITY LABEL support for publications and subs

2017-03-25 Thread Stephen Frost
Peter, * Peter Eisentraut (pete...@gmx.net) wrote: > Add COMMENT and SECURITY LABEL support for publications and subscriptions Isn't this missing psql tab completion, and pg_dump support? And regression tests for the latter? Thanks! Stephen signature.asc Description: Digital signature

[COMMITTERS] pgsql: Add cleanup to new test cases

2017-03-25 Thread Peter Eisentraut
Add cleanup to new test cases Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cf366e97ff2f74663754085ee2386bbee39b3edf Modified Files -- src/test/modules/dummy_seclabel/expected/dummy_seclabel.out | 2 ++ src/test/modules/dummy_seclabel/sql/dummy_seclabel.

[COMMITTERS] pgsql: Report catalog_xmin separately in hot_standby_feedback

2017-03-25 Thread Simon Riggs
Report catalog_xmin separately in hot_standby_feedback If the upstream walsender is using a physical replication slot, store the catalog_xmin in the slot's catalog_xmin field. If the upstream doesn't use a slot and has only a PGPROC entry behaviour doesn't change, as we store the combined xmin and