Re: [COMMITTERS] pgsql: Allow vacuums to report oldestxmin

2017-03-28 Thread Masahiko Sawada
On Wed, Mar 29, 2017 at 1:32 AM, Fujii Masao wrote: > On Tue, Mar 28, 2017 at 1:06 AM, Masahiko Sawada > wrote: >> On Sun, Mar 26, 2017 at 2:26 AM, Masahiko Sawada >> wrote: >>> On Sun, Mar 26, 2017 at 1:37 AM, Fujii Masao wrote: On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada wro

[COMMITTERS] pgsql: Fix configure check for typeof

2017-03-28 Thread Peter Eisentraut
Fix configure check for typeof Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ddce628971fb611f5ecd49d72e1612f983d99097 Modified Files -- config/c-compiler.m4 | 2 +- configure| 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) -- Sent

[COMMITTERS] pgsql: Cast result of copyObject() to correct type

2017-03-28 Thread Peter Eisentraut
Cast result of copyObject() to correct type copyObject() is declared to return void *, which allows easily assigning the result independent of the input, but it loses all type checking. If the compiler supports typeof or something similar, cast the result to the input type. This creates a greate

[COMMITTERS] pgsql: Improve Node vs Expr use a bit

2017-03-28 Thread Peter Eisentraut
Improve Node vs Expr use a bit Author: Mark Dilger Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e0eb5e0aeac7643c10b550e8067182cd08fc59a3 Modified Files -- src/backend/catalog/partition.c | 32 1 file changed, 16 insert

[COMMITTERS] pgsql: doc: Mention --enable-tap-tests in regression test chapter

2017-03-28 Thread Peter Eisentraut
doc: Mention --enable-tap-tests in regression test chapter Reported-by: Jeff Janes Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/66b764341ba12206f01e2600713bdc3abdb070b3 Modified Files -- doc/src/sgml/regress.sgml | 6 ++ 1 file changed, 6 insertio

[COMMITTERS] pgsql: Change 'diag' to 'note' in TAP tests

2017-03-28 Thread Peter Eisentraut
Change 'diag' to 'note' in TAP tests Reduce noise from TAP tests by changing 'diag' to 'note', so output only goes to the test's log file not stdout, unless in verbose mode. This also removes the junk on screen when running the TAP tests in parallel. Author: Craig Ringer Branch -- master

[COMMITTERS] pgsql: Allow DSM segments to be created as pinned

2017-03-28 Thread Alvaro Herrera
Allow DSM segments to be created as pinned dsm_create and dsm_attach assumed that a current resource owner was always in place. Exploration with the API show that this is inconvenient: sometimes one must create a dummy resowner, create/attach the DSM, only to pin the mapping later, which is waste

[COMMITTERS] pgsql: Remove direct uses of ItemPointer.{ip_blkid,ip_posid}

2017-03-28 Thread Alvaro Herrera
Remove direct uses of ItemPointer.{ip_blkid,ip_posid} There are no functional changes here; this simply encapsulates knowledge of the ItemPointerData struct so that a future patch can change things without more breakage. All direct users of ip_blkid and ip_posid are changed to use existing macros

[COMMITTERS] pgsql: Make new expression eval code reject references to dropped colum

2017-03-28 Thread Tom Lane
Make new expression eval code reject references to dropped columns. Formerly, a Var referencing an already-dropped column was allowed and would always produce a NULL value. However, that behavior was implemented in slot_getattr which the new expression code doesn't use; thus there is now a risk o

[COMMITTERS] pgsql: Correct grammar in error message

2017-03-28 Thread Simon Riggs
Correct grammar in error message "could not generate" rather than "could not generation" from commit 818fd4a67d610991757b610755e3065fb99d80a5 Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a99f77021f0c8c1c221af4e36b64ca43abd04389 Modified Files -- src/b

[COMMITTERS] pgsql: Fix ssl tests

2017-03-28 Thread Peter Eisentraut
Fix ssl tests facde2a98f0b5f7689b4e30a9e7376e926e733b8 introduced a typo during rebasing. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/967a4b01e3637813365502b46499360b18b86725 Modified Files -- src/test/ssl/ServerSetup.pm | 2 +- 1 file changed, 1 inse

[COMMITTERS] pgsql: Suppress implicit-conversion warnings seen with newer clang vers

2017-03-28 Thread Tom Lane
Suppress implicit-conversion warnings seen with newer clang versions. We were assigning values near 255 through "char *" pointers. On machines where char is signed, that's not entirely kosher, and it's reasonable for compilers to warn about it. A better solution would be to change the pointer ty

[COMMITTERS] pgsql: Suppress implicit-conversion warnings seen with newer clang vers

2017-03-28 Thread Tom Lane
Suppress implicit-conversion warnings seen with newer clang versions. We were assigning values near 255 through "char *" pointers. On machines where char is signed, that's not entirely kosher, and it's reasonable for compilers to warn about it. A better solution would be to change the pointer ty

[COMMITTERS] pgsql: Suppress implicit-conversion warnings seen with newer clang vers

2017-03-28 Thread Tom Lane
Suppress implicit-conversion warnings seen with newer clang versions. We were assigning values near 255 through "char *" pointers. On machines where char is signed, that's not entirely kosher, and it's reasonable for compilers to warn about it. A better solution would be to change the pointer ty

Re: [COMMITTERS] pgsql: Allow vacuums to report oldestxmin

2017-03-28 Thread Fujii Masao
On Tue, Mar 28, 2017 at 1:06 AM, Masahiko Sawada wrote: > On Sun, Mar 26, 2017 at 2:26 AM, Masahiko Sawada > wrote: >> On Sun, Mar 26, 2017 at 1:37 AM, Fujii Masao wrote: >>> On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada >>> wrote: On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs wrote: >

[COMMITTERS] pgsql: Altering default privileges on schemas

2017-03-28 Thread Teodor Sigaev
Altering default privileges on schemas Extend ALTER DEFAULT PRIVILEGES command to schemas. Author: Matheus Oliveira Reviewed-by: Petr Jelínek, Ashutosh Sharma https://commitfest.postgresql.org/13/887/ Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ab89e465cb203201

[COMMITTERS] pgsql: dblink: Fix error reporting

2017-03-28 Thread Peter Eisentraut
dblink: Fix error reporting The conname variable was not initialized in some code paths, resulting in error reports referring to the "unnamed" connection rather than the correct connection name. Author: Rushabh Lathia Branch -- master Details --- http://git.postgresql.org/pg/commitdiff

[COMMITTERS] pgsql: Cleanup slots during drop database

2017-03-28 Thread Simon Riggs
Cleanup slots during drop database Automatically drop all logical replication slots associated with a database when the database is dropped. Previously we threw an ERROR if a slot existed. Now we throw ERROR only if a slot is active in the database being dropped. Craig Ringer Branch -- maste

[COMMITTERS] pgsql: Fix Perl code which had broken the Windows build

2017-03-28 Thread Peter Eisentraut
Fix Perl code which had broken the Windows build The previous change wanted to avoid modifying $_ in grep, but the code just made the change in a local variable and then lost it. Rewrite the code using a separate map and grep, which is clearer anyway. Author: Dagfinn Ilmari Mannsåker Branch --