Re: [COMMITTERS] pgsql: Add infrastructure to support EphemeralNamedRelation references.

2017-03-31 Thread Kevin Grittner
On Sat, Apr 1, 2017 at 12:21 AM, Kevin Grittner wrote: > On Sat, Apr 1, 2017 at 12:01 AM, Tom Lane wrote: > >> rhinoceros says you missed contrib/sepgsql. > > Yeah, I saw that and have pushed an attempt to fix. That blind fix seemed to work. >> (And while I'm bitching, you definitely failed to

Re: [COMMITTERS] pgsql: Add infrastructure to support EphemeralNamedRelation references.

2017-03-31 Thread Kevin Grittner
On Sat, Apr 1, 2017 at 12:01 AM, Tom Lane wrote: > rhinoceros says you missed contrib/sepgsql. Yeah, I saw that and have pushed an attempt to fix. > More generally, if you hack the API of some globally-referenced function, > you ought to grep for references to it rather than just assume your >

[COMMITTERS] pgsql: Try to fix breakage of sepgsql hooks by ENR patch.

2017-03-31 Thread Kevin Grittner
Try to fix breakage of sepgsql hooks by ENR patch. Turned up by buildfarm animal rhinoceros. Fixing blind. Will have to wait for next run by rhinoceros to know whether it worked. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/01fd6f8f2d15a9369768921d6fc95ac4817794

Re: [COMMITTERS] pgsql: Add infrastructure to support EphemeralNamedRelation references.

2017-03-31 Thread Tom Lane
rhinoceros says you missed contrib/sepgsql. More generally, if you hack the API of some globally-referenced function, you ought to grep for references to it rather than just assume your compiler will find them all for you. For one thing, that approach is a great way to fail to update relevant com

[COMMITTERS] pgsql: Add transition table support to plpgsql.

2017-03-31 Thread Kevin Grittner
Add transition table support to plpgsql. Kevin Grittner and Thomas Munro Reviewed by Heikki Linnakangas, David Fetter, and Thomas Munro with valuable comments and suggestions from many others Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/59702716324ab9c07b02fb005dc

[COMMITTERS] pgsql: Add infrastructure to support EphemeralNamedRelation references.

2017-03-31 Thread Kevin Grittner
Add infrastructure to support EphemeralNamedRelation references. A QueryEnvironment concept is added, which allows new types of objects to be passed into queries from parsing on through execution. At this point, the only thing implemented is a collection of EphemeralNamedRelation objects -- relat

[COMMITTERS] pgsql: Avoid GatherMerge crash when there are no workers.

2017-03-31 Thread Robert Haas
Avoid GatherMerge crash when there are no workers. It's unnecessary to return an actual slot when we have no tuple. We can just return NULL, which avoids the risk of indexing into an array that might not contain any elements. Rushabh Lathia, per a report from Tomas Vondra Discussion: http://pos

[COMMITTERS] pgsql: Fix parallel query so it doesn't spoil row estimates above Gathe

2017-03-31 Thread Robert Haas
Fix parallel query so it doesn't spoil row estimates above Gather. Commit 45be99f8cd5d606086e0a458c9c72910ba8a613d removed GatherPath's num_workers field, but this is entirely bogus. Normally, a path's parallel_workers flag is supposed to indicate the number of workers that it wants, and should b

[COMMITTERS] pgsql: Fix parallel query so it doesn't spoil row estimates above Gathe

2017-03-31 Thread Robert Haas
Fix parallel query so it doesn't spoil row estimates above Gather. Commit 45be99f8cd5d606086e0a458c9c72910ba8a613d removed GatherPath's num_workers field, but this is entirely bogus. Normally, a path's parallel_workers flag is supposed to indicate the number of workers that it wants, and should b

[COMMITTERS] pgsql: Don't use bgw_main even to specify in-core bgworker entrypoints.

2017-03-31 Thread Robert Haas
Don't use bgw_main even to specify in-core bgworker entrypoints. On EXEC_BACKEND builds, this can fail if ASLR is in use. Backpatch to 9.5. On master, completely remove the bgw_main field completely, since there is no situation in which it is safe for an EXEC_BACKEND build. On 9.6 and 9.5, leav

[COMMITTERS] pgsql: Don't use bgw_main even to specify in-core bgworker entrypoints.

2017-03-31 Thread Robert Haas
Don't use bgw_main even to specify in-core bgworker entrypoints. On EXEC_BACKEND builds, this can fail if ASLR is in use. Backpatch to 9.5. On master, completely remove the bgw_main field completely, since there is no situation in which it is safe for an EXEC_BACKEND build. On 9.6 and 9.5, leav

[COMMITTERS] pgsql: Don't use bgw_main even to specify in-core bgworker entrypoints.

2017-03-31 Thread Robert Haas
Don't use bgw_main even to specify in-core bgworker entrypoints. On EXEC_BACKEND builds, this can fail if ASLR is in use. Backpatch to 9.5. On master, completely remove the bgw_main field completely, since there is no situation in which it is safe for an EXEC_BACKEND build. On 9.6 and 9.5, leav

[COMMITTERS] pgsql: Fix unstable regression test result.

2017-03-31 Thread Tom Lane
Fix unstable regression test result. Whoops, missed that same test was made for json as well as jsonb. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c281cd5fe178c946dc23eae4d4642be5ddbe3eb4 Modified Files -- src/test/regress/expected/json.out | 2 +- sr

[COMMITTERS] pgsql: Fix unstable regression test result.

2017-03-31 Thread Tom Lane
Fix unstable regression test result. Commit e306df7f9 added a test case that depends on "the" being a stop word, which it is not in non-English locales. Since the point of the test is to check stopword behavior, fix by forcibly selecting the 'english' configuration. Per buildfarm. Branch --

[COMMITTERS] pgsql: Fix typos.

2017-03-31 Thread Robert Haas
Fix typos. Brandur Leach Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9a12ad042d26ba085f8ef72d030699b6f3d43b01 Modified Files -- src/backend/utils/adt/mac.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mail

[COMMITTERS] pgsql: For foreign keys, check REFERENCES privilege only on the referen

2017-03-31 Thread Tom Lane
For foreign keys, check REFERENCES privilege only on the referenced table. We were requiring that the user have REFERENCES permission on both the referenced and referencing tables --- but this doesn't seem to have any support in the SQL standard, which says only that you need REFERENCES permission

[COMMITTERS] pgsql: Improve documentation for table partitioning.

2017-03-31 Thread Robert Haas
Improve documentation for table partitioning. Emphasize the new declarative partitioning more, and compare and contrast it more clearly with inheritance-based partitioning. Amit Langote, reviewed and somewhat revised by me Discussion: http://postgr.es/m/a6f99cdb-21e7-1d65-1381-91f2cfa15...@lab.

[COMMITTERS] pgsql: Revert "Allow ON CONFLICT .. DO NOTHING on a partitioned table."

2017-03-31 Thread Robert Haas
Revert "Allow ON CONFLICT .. DO NOTHING on a partitioned table." This reverts commit 8355a011a0124bdf7ccbada206a967d427039553, which turns out to have been a misguided effort. We can't really support this in a partitioning hierarchy after all for exactly the reasons stated in the documentation re

[COMMITTERS] pgsql: Don't allocate storage for partitioned tables.

2017-03-31 Thread Robert Haas
Don't allocate storage for partitioned tables. Also, don't allow setting reloptions on them, since that would have no effect given the lack of storage. The patch does this by introducing a new reloption kind for which there are currently no reloptions -- we might have some in the future -- so it

[COMMITTERS] pgsql: postgres_fdw: Teach IMPORT FOREIGN SCHEMA about partitioning.

2017-03-31 Thread Robert Haas
postgres_fdw: Teach IMPORT FOREIGN SCHEMA about partitioning. Don't import partitions. Do import partitioned tables which are not themselves partitions. Report by Stephen Frost. Design and patch by Michael Paquier, reviewed by Amit Langote. Documentation revised by me. Discussion: http://post

Re: [COMMITTERS] pgsql: Full Text Search support for json and jsonb

2017-03-31 Thread Tom Lane
Andrew Dunstan writes: > Full Text Search support for json and jsonb > The new functions are ts_headline() and to_tsvector. Should this not have included a catversion bump? regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To

[COMMITTERS] pgsql: Transform or iterate over json(b) string values

2017-03-31 Thread Andrew Dunstan
Transform or iterate over json(b) string values Dmitry Dolgov, reviewed and lightly edited by me. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c80b9920fcbcbf75e3d7e8fe092bf6e15d9d40b8 Modified Files -- src/backend/utils/adt/jsonfuncs.c | 236 +

[COMMITTERS] pgsql: Full Text Search support for json and jsonb

2017-03-31 Thread Andrew Dunstan
Full Text Search support for json and jsonb The new functions are ts_headline() and to_tsvector. Dmitry Dolgov, edited and documented by me. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e306df7f9cd6b4433273e006df11bdc966b7079e Modified Files -- doc/s

[COMMITTERS] pgsql: Fix typo in comment

2017-03-31 Thread Magnus Hagander
Fix typo in comment Daniel Gustafsson Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/156d3882f89d2a224029e4c81adacd279eb1cdfc Modified Files -- src/interfaces/libpq/fe-connect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-c