Re: [COMMITTERS] pgsql: Remove bogus redefinition of _MSC_VER.

Thanks! The sad thing is that I did that file manually first, the right way. Then I realized I was going down the wrong track and made the change mechanical instead. And forgot to change that one back.. Oops. //Magnus On Tue, Apr 11, 2017 at 9:32 PM, Tom Lane wrote: > Remove bogus redefiniti

[COMMITTERS] pgsql: Remove bogus redefinition of _MSC_VER.

Remove bogus redefinition of _MSC_VER. Commit a4777f355 was a shade too mechanical: we don't want to override MSVC's own definition of _MSC_VER, as that breaks tests on its numerical value. Per buildfarm. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/587d62d8562d6

[COMMITTERS] pgsql: Simplify handling of remote-qual pass-forward in postgres_fdw.

Simplify handling of remote-qual pass-forward in postgres_fdw. Commit 0bf3ae88a encountered a need to pass the finally chosen remote qual conditions forward from postgresGetForeignPlan to postgresPlanDirectModify. It solved that by sticking them into the plan node's fdw_private list, which in hind

[COMMITTERS] pgsql: Allow a rule on partitioned table to be renamed.

Allow a rule on partitioned table to be renamed. Commit f0e44751d7175fa3394da2c8f85e3ceb3cdbfe63 should have updated this code, but did not. Amit Langote Discussion: http://postgr.es/m/52d9c443-ec78-5c8a-7a77-0f34aad12...@lab.ntt.co.jp Branch -- master Details --- http://git.postgresq

[COMMITTERS] pgsql: Add an Assert() to max_parallel_workers enforcement.

Add an Assert() to max_parallel_workers enforcement. To prevent future bugs along the lines of the one corrected by commit 8ff518699f19dd0a5076f5090bac8400b8233f7f, or find any that remain in the current code, add an Assert() that the difference between parallel_register_count and parallel_termina

Re: [COMMITTERS] pgsql: Fix confusion of max_parallel_workers mechanism following crash.

On Tue, Apr 11, 2017 at 12:52 PM, Robert Haas wrote: > Report by Thomas Vondra. Patch by me, reviewed by Kuntal Ghosh. Ah, nuts. Sorry for misspelling your name, Tomas. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-committers m

[COMMITTERS] pgsql: Fix confusion of max_parallel_workers mechanism following crash.

Fix confusion of max_parallel_workers mechanism following crash. Commit b460f5d6693103076dc554aa7cbb96e1e53074f9 failed to contemplate the possibilit that a parallel worker registered before a crash would be unregistered only after the crash; if that happened, we'd end up with parallel_terminate_c

[COMMITTERS] pgsql: doc: clearify pg_upgrade default copy behavior

doc: clearify pg_upgrade default copy behavior Reported-by: Marek Discussion: 20170328110253.2695.62...@wrigleys.postgresql.org Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1e298b8dbb3220a0d5e073e0ad6a8afd35042c2a Modified Files -- doc/src/sgml/ref/

[COMMITTERS] pgsql: Fix failure when a shared tidbitmap has only one page.

Fix failure when a shared tidbitmap has only one page. Commit 98e6e89040a0534ca26914c66cae9dd49ef62ad9 made inadequate provision for the case of a single-page shared tidbitmap. It allocate space for a shared PagetableEntry, but failed to initialize it. Report by Thomas Munro. Patch by Dilip Kum

[COMMITTERS] pgsql: Handle restriction clause lists more uniformly in postgres_fdw.

Handle restriction clause lists more uniformly in postgres_fdw. Clauses in the lists retained by postgres_fdw during planning were sometimes bare boolean clauses, sometimes RestrictInfos, and sometimes a mixture of the two in the same list. The comment about that situation didn't come close to te

[COMMITTERS] pgsql: Add max_sync_workers_per_subscription to postgresql.conf.sample.

Add max_sync_workers_per_subscription to postgresql.conf.sample. This commit also does - add REPLICATION_SUBSCRIBERS into config_group - mark max_logical_replication_workers and max_sync_workers_per_subscription as REPLICATION_SUBSCRIBERS parameters - move those parameters into "Subscribers" se

[COMMITTERS] pgsql: docs: Improve window function docs

docs: Improve window function docs Specifically, the behavior of general-purpose and statistical aggregates as window functions was not clearly documented, and terms were inconsistently used. Also add docs about the difference between cume_dist and percent_rank, rather than just the formulas. D

[COMMITTERS] pgsql: Remove symbol WIN32_ONLY_COMPILER

Remove symbol WIN32_ONLY_COMPILER This used to mean "Visual C++ except in those parts where Borland C++ was supported where it meant one of those". Now that we don't support Borland C++ anymore, simplify by using _MSC_VER which is the normal way to detect Visual C++. Branch -- master Details

[COMMITTERS] pgsql: Remove support for bcc and msvc standalone libpq builds

Remove support for bcc and msvc standalone libpq builds This removes the support for building just libpq using Borland C++ or Visual C++. This has not worked properly for years, and given the number of complaints it's clearly not worth the maintenance burden. Building libpq using the standard MSV

[COMMITTERS] pgsql: Fix possibile deadlock when dropping partitions.

Fix possibile deadlock when dropping partitions. heap_drop_with_catalog and RangeVarCallbackForDropRelation should lock the parent before locking the target relation. Amit Langote Discussion: http://postgr.es/m/29588799-a8ce-b0a2-3dae-f39ff6d35...@lab.ntt.co.jp Branch -- master Details --

[COMMITTERS] pgsql: Fix pgbench's --progress-timestamp option to print Unix-epoch ti

Fix pgbench's --progress-timestamp option to print Unix-epoch timestamps. As a consequence of commit 1d63f7d2d, on platforms with CLOCK_MONOTONIC, you got some random timescale or other instead of standard Unix timestamps as expected. I'd attempted to fix pgbench for that change in commits 74baa1

[COMMITTERS] pgsql: Document that bytea is best represented as char * in C for ecpg.

Document that bytea is best represented as char * in C for ecpg. Patch by Kato, Sho Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a6940bdcb9ef87a54459deac5699a61cfdbc696c Modified Files -- doc/src/sgml/ecpg.sgml | 5 + 1 file changed, 5 insertions(