[COMMITTERS] pgsql: First-draft release notes for 9.6.3.

2017-05-05 Thread Tom Lane
First-draft release notes for 9.6.3. As usual, the release notes for other branches will be made by cutting these down, but put them up for community review first. Note there are some entries that really only apply to pre-9.6 branches. Branch -- master Details --- https://git.postgresql

[COMMITTERS] pgsql: Suppress compiler warning about unportable pointer value.

2017-05-05 Thread Tom Lane
Suppress compiler warning about unportable pointer value. Setting a pointer value to "0xdeadbeef" draws a warning from some compilers, and for good reason. Be less cute and just set it to NULL. In passing make some other cosmetic adjustments nearby. Discussion: https://postgr.es/m/cajrrpgdw3ek

[COMMITTERS] pgsql: Allow MSVC to build with Tcl 8.6.

2017-05-05 Thread Alvaro Herrera
Allow MSVC to build with Tcl 8.6. Commit eaba54c20c5 added support for Tcl 8.6 for configure-supported platforms after verifying that pltcl works without further changes, but the MSVC tooling wasn't updated accordingly. Update MSVC to match, restructuring the code to avoid duplicating the logic f

[COMMITTERS] pgsql: Allow MSVC to build with Tcl 8.6.

2017-05-05 Thread Alvaro Herrera
Allow MSVC to build with Tcl 8.6. Commit eaba54c20c5 added support for Tcl 8.6 for configure-supported platforms after verifying that pltcl works without further changes, but the MSVC tooling wasn't updated accordingly. Update MSVC to match, restructuring the code to avoid duplicating the logic f

[COMMITTERS] pgsql: Allow MSVC to build with Tcl 8.6.

2017-05-05 Thread Alvaro Herrera
Allow MSVC to build with Tcl 8.6. Commit eaba54c20c5 added support for Tcl 8.6 for configure-supported platforms after verifying that pltcl works without further changes, but the MSVC tooling wasn't updated accordingly. Update MSVC to match, restructuring the code to avoid duplicating the logic f

[COMMITTERS] pgsql: Allow MSVC to build with Tcl 8.6.

2017-05-05 Thread Alvaro Herrera
Allow MSVC to build with Tcl 8.6. Commit eaba54c20c5 added support for Tcl 8.6 for configure-supported platforms after verifying that pltcl works without further changes, but the MSVC tooling wasn't updated accordingly. Update MSVC to match, restructuring the code to avoid duplicating the logic f

[COMMITTERS] pgsql: Allow MSVC to build with Tcl 8.6.

2017-05-05 Thread Alvaro Herrera
Allow MSVC to build with Tcl 8.6. Commit eaba54c20c5 added support for Tcl 8.6 for configure-supported platforms after verifying that pltcl works without further changes, but the MSVC tooling wasn't updated accordingly. Update MSVC to match, restructuring the code to avoid duplicating the logic f

[COMMITTERS] pgsql: Allow MSVC to build with Tcl 8.6.

2017-05-05 Thread Alvaro Herrera
Allow MSVC to build with Tcl 8.6. Commit eaba54c20c5 added support for Tcl 8.6 for configure-supported platforms after verifying that pltcl works without further changes, but the MSVC tooling wasn't updated accordingly. Update MSVC to match, restructuring the code to avoid duplicating the logic f

[COMMITTERS] pgsql: Prevent panic during shutdown checkpoint

2017-05-05 Thread Peter Eisentraut
Prevent panic during shutdown checkpoint When the checkpointer writes the shutdown checkpoint, it checks afterwards whether any WAL has been written since it started and throws a PANIC if so. At that point, only walsenders are still active, so one might think this could not happen, but walsenders

[COMMITTERS] pgsql: Fix wording in pg_upgrade docs

2017-05-05 Thread Magnus Hagander
Fix wording in pg_upgrade docs Author: Daniel Gustafsson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/499ae5f5db99c84035e9951fd30e428adf0f40d2 Modified Files -- src/bin/pg_upgrade/IMPLEMENTATION | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-

[COMMITTERS] pgsql: Build pgoutput.dll in MSVC build

2017-05-05 Thread Magnus Hagander
Build pgoutput.dll in MSVC build Without this, logical replication obviously does not work on Windows MauMau, with clean.bet additions from me per note from Michael Paquier Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/28d1c8ccc87128f9b0b937eae277473027c36b7e Mo

[COMMITTERS] pgsql: Give nicer error message when connecting to a v10 server requiri

2017-05-05 Thread Heikki Linnakangas
Give nicer error message when connecting to a v10 server requiring SCRAM. This is just to give the user a hint that they need to upgrade, if they try to connect to a v10 server that uses SCRAM authentication, with an older client. Commit to all stable branches, but not master. Discussion: https

[COMMITTERS] pgsql: Give nicer error message when connecting to a v10 server requiri

2017-05-05 Thread Heikki Linnakangas
Give nicer error message when connecting to a v10 server requiring SCRAM. This is just to give the user a hint that they need to upgrade, if they try to connect to a v10 server that uses SCRAM authentication, with an older client. Commit to all stable branches, but not master. Discussion: https

[COMMITTERS] pgsql: Give nicer error message when connecting to a v10 server requiri

2017-05-05 Thread Heikki Linnakangas
Give nicer error message when connecting to a v10 server requiring SCRAM. This is just to give the user a hint that they need to upgrade, if they try to connect to a v10 server that uses SCRAM authentication, with an older client. Commit to all stable branches, but not master. Discussion: https

[COMMITTERS] pgsql: Give nicer error message when connecting to a v10 server requiri

2017-05-05 Thread Heikki Linnakangas
Give nicer error message when connecting to a v10 server requiring SCRAM. This is just to give the user a hint that they need to upgrade, if they try to connect to a v10 server that uses SCRAM authentication, with an older client. Commit to all stable branches, but not master. Discussion: https

[COMMITTERS] pgsql: Give nicer error message when connecting to a v10 server requiri

2017-05-05 Thread Heikki Linnakangas
Give nicer error message when connecting to a v10 server requiring SCRAM. This is just to give the user a hint that they need to upgrade, if they try to connect to a v10 server that uses SCRAM authentication, with an older client. Commit to all stable branches, but not master. Discussion: https

[COMMITTERS] pgsql: Misc cleanup of SCRAM code.

2017-05-05 Thread Heikki Linnakangas
Misc cleanup of SCRAM code. * Remove is_scram_verifier() function. It was unused. * Fix sanitize_char() function, used in error messages on protocol violations, to print bytes >= 0x7F correctly. * Change spelling of scram_MockSalt() function to be more consistent with the surroundings. * Chang

[COMMITTERS] pgsql: Don't use SCRAM-specific "e=invalid-proof" on invalid password.

2017-05-05 Thread Heikki Linnakangas
Don't use SCRAM-specific "e=invalid-proof" on invalid password. Instead, send the same FATAL message as with other password-based authentication mechanisms. This gives a more user-friendly message: psql: FATAL: password authentication failed for user "test" instead of: psql: error received fro

[COMMITTERS] pgsql: Make SCRAM salts and nonces longer.

2017-05-05 Thread Heikki Linnakangas
Make SCRAM salts and nonces longer. The salt is stored base64-encoded. With the old 10 bytes raw length, it was always padded to 16 bytes after encoding. We might as well use 12 raw bytes for the salt, and it's still encoded into 16 bytes. Similarly for the random nonces, use a raw length that's