[COMMITTERS] pgsql: Use a better way of skipping all subscription tests on Windows

2017-05-12 Thread Andrew Dunstan
Use a better way of skipping all subscription tests on Windows This way we only need to specify the number of tests in one place, and the output is also less verbose. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8d9f06097714ce1f4243329172f73c2d20b896a6 Modified

[COMMITTERS] pgsql: Complete tab completion for DROP STATISTICS

2017-05-12 Thread Alvaro Herrera
Complete tab completion for DROP STATISTICS Tab-completing DROP STATISTICS would only work if you started writing the schema name containing the statistics object, because the visibility clause was missing. To add it, we need to add SQL-callable support for testing visibility of a statistics obje

[COMMITTERS] pgsql: Avoid searching for callback functions in CallSyscacheCallbacks(

2017-05-12 Thread Tom Lane
Avoid searching for callback functions in CallSyscacheCallbacks(). We have now grown enough registerable syscache-invalidation callback functions that the original assumption that there would be few of them is causing performance problems. In particular, let's fix things so that CallSyscacheCallb

[COMMITTERS] pgsql: Avoid searching for callback functions in CallSyscacheCallbacks(

2017-05-12 Thread Tom Lane
Avoid searching for callback functions in CallSyscacheCallbacks(). We have now grown enough registerable syscache-invalidation callback functions that the original assumption that there would be few of them is causing performance problems. In particular, let's fix things so that CallSyscacheCallb

[COMMITTERS] pgsql: Avoid searching for callback functions in CallSyscacheCallbacks(

2017-05-12 Thread Tom Lane
Avoid searching for callback functions in CallSyscacheCallbacks(). We have now grown enough registerable syscache-invalidation callback functions that the original assumption that there would be few of them is causing performance problems. In particular, let's fix things so that CallSyscacheCallb

[COMMITTERS] pgsql: Avoid searching for callback functions in CallSyscacheCallbacks(

2017-05-12 Thread Tom Lane
Avoid searching for callback functions in CallSyscacheCallbacks(). We have now grown enough registerable syscache-invalidation callback functions that the original assumption that there would be few of them is causing performance problems. In particular, let's fix things so that CallSyscacheCallb

[COMMITTERS] pgsql: doc: update markup for release note "release date" block

2017-05-12 Thread Bruce Momjian
doc: update markup for release note "release date" block This has to be backpatched to all supported releases so release markup added to HEAD and copied to back branches matches the existing markup. Reported-by: Peter Eisentraut Discussion: 2b8a2552-fffa-f7c8-97c5-14db47a87...@2ndquadrant.com

[COMMITTERS] pgsql: doc: update markup for release note "release date" block

2017-05-12 Thread Bruce Momjian
doc: update markup for release note "release date" block This has to be backpatched to all supported releases so release markup added to HEAD and copied to back branches matches the existing markup. Reported-by: Peter Eisentraut Discussion: 2b8a2552-fffa-f7c8-97c5-14db47a87...@2ndquadrant.com

[COMMITTERS] pgsql: doc: update markup for release note "release date" block

2017-05-12 Thread Bruce Momjian
doc: update markup for release note "release date" block This has to be backpatched to all supported releases so release markup added to HEAD and copied to back branches matches the existing markup. Reported-by: Peter Eisentraut Discussion: 2b8a2552-fffa-f7c8-97c5-14db47a87...@2ndquadrant.com

[COMMITTERS] pgsql: doc: update markup for release note "release date" block

2017-05-12 Thread Bruce Momjian
doc: update markup for release note "release date" block This has to be backpatched to all supported releases so release markup added to HEAD and copied to back branches matches the existing markup. Reported-by: Peter Eisentraut Discussion: 2b8a2552-fffa-f7c8-97c5-14db47a87...@2ndquadrant.com

[COMMITTERS] pgsql: doc: update markup for release note "release date" block

2017-05-12 Thread Bruce Momjian
doc: update markup for release note "release date" block This has to be backpatched to all supported releases so release markup added to HEAD and copied to back branches matches the existing markup. Reported-by: Peter Eisentraut Discussion: 2b8a2552-fffa-f7c8-97c5-14db47a87...@2ndquadrant.com

[COMMITTERS] pgsql: doc: update markup for release note "release date" block

2017-05-12 Thread Bruce Momjian
doc: update markup for release note "release date" block This has to be backpatched to all supported releases so release markup added to HEAD and copied to back branches matches the existing markup. Reported-by: Peter Eisentraut Discussion: 2b8a2552-fffa-f7c8-97c5-14db47a87...@2ndquadrant.com

[COMMITTERS] pgsql: Reduce initial size of RelfilenodeMapHash.

2017-05-12 Thread Tom Lane
Reduce initial size of RelfilenodeMapHash. A test case provided by Mathieu Fenniak shows that hash_seq_search'ing this hashtable can consume a very significant amount of overhead during logical decoding, which triggers frequent cache invalidation. Testing suggests that the actual population of th

[COMMITTERS] pgsql: Reduce initial size of RelfilenodeMapHash.

2017-05-12 Thread Tom Lane
Reduce initial size of RelfilenodeMapHash. A test case provided by Mathieu Fenniak shows that hash_seq_search'ing this hashtable can consume a very significant amount of overhead during logical decoding, which triggers frequent cache invalidation. Testing suggests that the actual population of th

[COMMITTERS] pgsql: Reduce initial size of RelfilenodeMapHash.

2017-05-12 Thread Tom Lane
Reduce initial size of RelfilenodeMapHash. A test case provided by Mathieu Fenniak shows that hash_seq_search'ing this hashtable can consume a very significant amount of overhead during logical decoding, which triggers frequent cache invalidation. Testing suggests that the actual population of th

[COMMITTERS] pgsql: Reduce initial size of RelfilenodeMapHash.

2017-05-12 Thread Tom Lane
Reduce initial size of RelfilenodeMapHash. A test case provided by Mathieu Fenniak shows that hash_seq_search'ing this hashtable can consume a very significant amount of overhead during logical decoding, which triggers frequent cache invalidation. Testing suggests that the actual population of th

[COMMITTERS] pgsql: getObjectDescription: support extended statistics

2017-05-12 Thread Alvaro Herrera
getObjectDescription: support extended statistics This was missed in 7b504eb282ca. Remove the "default:" clause in the switch, to avoid this problem in the future. Other switches involving the same enum should probably be changed in the same way, but are not touched by this patch. Discussion: h

[COMMITTERS] pgsql: Avoid searching for the target catcache in CatalogCacheIdInvalid

2017-05-12 Thread Tom Lane
Avoid searching for the target catcache in CatalogCacheIdInvalidate. A test case provided by Mathieu Fenniak shows that the initial search for the target catcache in CatalogCacheIdInvalidate consumes a very significant amount of overhead in cases where cache invalidation is triggered but has littl

[COMMITTERS] pgsql: Avoid searching for the target catcache in CatalogCacheIdInvalid

2017-05-12 Thread Tom Lane
Avoid searching for the target catcache in CatalogCacheIdInvalidate. A test case provided by Mathieu Fenniak shows that the initial search for the target catcache in CatalogCacheIdInvalidate consumes a very significant amount of overhead in cases where cache invalidation is triggered but has littl

[COMMITTERS] pgsql: Avoid searching for the target catcache in CatalogCacheIdInvalid

2017-05-12 Thread Tom Lane
Avoid searching for the target catcache in CatalogCacheIdInvalidate. A test case provided by Mathieu Fenniak shows that the initial search for the target catcache in CatalogCacheIdInvalidate consumes a very significant amount of overhead in cases where cache invalidation is triggered but has littl

[COMMITTERS] pgsql: Avoid searching for the target catcache in CatalogCacheIdInvalid

2017-05-12 Thread Tom Lane
Avoid searching for the target catcache in CatalogCacheIdInvalidate. A test case provided by Mathieu Fenniak shows that the initial search for the target catcache in CatalogCacheIdInvalidate consumes a very significant amount of overhead in cases where cache invalidation is triggered but has littl

[COMMITTERS] pgsql: Fix dependencies for extended statistics objects.

2017-05-12 Thread Tom Lane
Fix dependencies for extended statistics objects. A stats object ought to have a dependency on each individual column it reads, not the entire table. Doing this honestly lets us get rid of the hard-wired logic in RemoveStatisticsExt, which seems to have been misguidedly modeled on RemoveStatistic

[COMMITTERS] pgsql: Change CREATE STATISTICS syntax

2017-05-12 Thread Alvaro Herrera
Change CREATE STATISTICS syntax Previously, we had the WITH clause in the middle of the command, where you'd specify both generic options as well as statistic types. Few people liked this, so this commit changes it to remove the WITH keyword from that clause and makes it accept statistic types on

[COMMITTERS] pgsql: Replace another "transaction log" with "write-ahead log"

2017-05-12 Thread Peter Eisentraut
Replace another "transaction log" with "write-ahead log" Reported-by: Dagfinn Ilmari Mannsåker Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/46052d9ef314deafa8c94ac7fda4a2811db0679e Modified Files -- doc/src/sgml/func.sgml | 2 +- 1 file changed, 1 in

[COMMITTERS] pgsql: Standardize "WAL location" terminology

2017-05-12 Thread Peter Eisentraut
Standardize "WAL location" terminology Other previously used terms were "WAL position" or "log position". Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d496a65790734f808789f39e4f63b2790821c2be Modified Files -- doc/src/sgml/config.sgml

[COMMITTERS] pgsql: Replace "transaction log" with "write-ahead log"

2017-05-12 Thread Peter Eisentraut
Replace "transaction log" with "write-ahead log" This makes documentation and error messages match the renaming of "xlog" to "wal" in APIs and file naming. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c1a7f64b4a720a662ecec809bc9e289f35e887ad Modified Files -

[COMMITTERS] pgsql: Honor PROVE_FLAGS environment setting

2017-05-12 Thread Andrew Dunstan
Honor PROVE_FLAGS environment setting On MSVC builds and on back branches that means removing the hardcoded --verbose setting. On master for Unix that means removing the empty setting in the global Makefile so that the value can be acquired from the environment as well as from the make arguments.

[COMMITTERS] pgsql: Honor PROVE_FLAGS environment setting

2017-05-12 Thread Andrew Dunstan
Honor PROVE_FLAGS environment setting On MSVC builds and on back branches that means removing the hardcoded --verbose setting. On master for Unix that means removing the empty setting in the global Makefile so that the value can be acquired from the environment as well as from the make arguments.

[COMMITTERS] pgsql: Honor PROVE_FLAGS environment setting

2017-05-12 Thread Andrew Dunstan
Honor PROVE_FLAGS environment setting On MSVC builds and on back branches that means removing the hardcoded --verbose setting. On master for Unix that means removing the empty setting in the global Makefile so that the value can be acquired from the environment as well as from the make arguments.

[COMMITTERS] pgsql: Honor PROVE_FLAGS environment setting

2017-05-12 Thread Andrew Dunstan
Honor PROVE_FLAGS environment setting On MSVC builds and on back branches that means removing the hardcoded --verbose setting. On master for Unix that means removing the empty setting in the global Makefile so that the value can be acquired from the environment as well as from the make arguments.

[COMMITTERS] pgsql: Add libxml2 include path for MSVC builds

2017-05-12 Thread Andrew Dunstan
Add libxml2 include path for MSVC builds On Unix this path is detected via the use of xml2-config, but that's not available on Windows. This means that users building with libxml2 will no longer need to move things around from the standard libxml2 installation for MSVC builds. Backpatch to all li

[COMMITTERS] pgsql: Add libxml2 include path for MSVC builds

2017-05-12 Thread Andrew Dunstan
Add libxml2 include path for MSVC builds On Unix this path is detected via the use of xml2-config, but that's not available on Windows. This means that users building with libxml2 will no longer need to move things around from the standard libxml2 installation for MSVC builds. Backpatch to all li

[COMMITTERS] pgsql: Add libxml2 include path for MSVC builds

2017-05-12 Thread Andrew Dunstan
Add libxml2 include path for MSVC builds On Unix this path is detected via the use of xml2-config, but that's not available on Windows. This means that users building with libxml2 will no longer need to move things around from the standard libxml2 installation for MSVC builds. Backpatch to all li

[COMMITTERS] pgsql: Add libxml2 include path for MSVC builds

2017-05-12 Thread Andrew Dunstan
Add libxml2 include path for MSVC builds On Unix this path is detected via the use of xml2-config, but that's not available on Windows. This means that users building with libxml2 will no longer need to move things around from the standard libxml2 installation for MSVC builds. Backpatch to all li

[COMMITTERS] pgsql: Add libxml2 include path for MSVC builds

2017-05-12 Thread Andrew Dunstan
Add libxml2 include path for MSVC builds On Unix this path is detected via the use of xml2-config, but that's not available on Windows. This means that users building with libxml2 will no longer need to move things around from the standard libxml2 installation for MSVC builds. Backpatch to all li

[COMMITTERS] pgsql: Add libxml2 include path for MSVC builds

2017-05-12 Thread Andrew Dunstan
Add libxml2 include path for MSVC builds On Unix this path is detected via the use of xml2-config, but that's not available on Windows. This means that users building with libxml2 will no longer need to move things around from the standard libxml2 installation for MSVC builds. Backpatch to all li

[COMMITTERS] pgsql: pg_dump: Add --no-publications option

2017-05-12 Thread Peter Eisentraut
pg_dump: Add --no-publications option Author: Michael Paquier Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/96e1cb4c0fb45dfca2d8b0a58693b94cbdaabe11 Modified Files -- doc/src/sgml/ref/pg_dump.sgml| 9 + doc/src/sgml/ref/pg_dumpall.sgm

[COMMITTERS] pgsql: Rework the options syntax for logical replication commands

2017-05-12 Thread Peter Eisentraut
Rework the options syntax for logical replication commands For CREATE/ALTER PUBLICATION/SUBSCRIPTION, use similar option style as other statements that use a WITH clause for options. Author: Petr Jelinek Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b807f59828fb

[COMMITTERS] pgsql: Avoid tests which crash the calling process on Windows

2017-05-12 Thread Andrew Dunstan
Avoid tests which crash the calling process on Windows Certain recovery tests use the Perl IPC::Run module's start/kill_kill method of processing. On at least some versions of perl this causes the whole process and its caller to crash. If we ever find a better way of doing these tests they can be

[COMMITTERS] pgsql: Lag tracking for logical replication

2017-05-12 Thread Simon Riggs
Lag tracking for logical replication Lag tracking is called for each commit, but we introduce a pacing delay to ensure we don't swamp the lag tracker. Author: Petr Jelinek, with minor pacing delay code from me Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/024711b