[COMMITTERS] pgsql: Suppress indentation from Data::Dumper in regression tests

2017-05-13 Thread Andrew Dunstan
Suppress indentation from Data::Dumper in regression tests Ultra-modern versions of the perl Data::Dumper module have apparently changed how they indent output. Instead of trying to keep up we choose to tell it to supporess all indentation in the hstore_plperl regression tests. Backpatch to 9.5 w

[COMMITTERS] pgsql: Suppress indentation from Data::Dumper in regression tests

2017-05-13 Thread Andrew Dunstan
Suppress indentation from Data::Dumper in regression tests Ultra-modern versions of the perl Data::Dumper module have apparently changed how they indent output. Instead of trying to keep up we choose to tell it to supporess all indentation in the hstore_plperl regression tests. Backpatch to 9.5 w

[COMMITTERS] pgsql: Suppress indentation from Data::Dumper in regression tests

2017-05-13 Thread Andrew Dunstan
Suppress indentation from Data::Dumper in regression tests Ultra-modern versions of the perl Data::Dumper module have apparently changed how they indent output. Instead of trying to keep up we choose to tell it to supporess all indentation in the hstore_plperl regression tests. Backpatch to 9.5 w

[COMMITTERS] pgsql: Specify --outputdir for isolation install check, not just plain

2017-05-13 Thread Andres Freund
Specify --outputdir for isolation install check, not just plain check. This should probably have been part of 60f826c5e62. Reported-By: Andrew Gierth Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/29c7d5e483acaa74a0d06dd6c70b320bb315 Modified Files --

[COMMITTERS] pgsql: Avoid superfluous work for commits during logical slot creation.

2017-05-13 Thread Andres Freund
Avoid superfluous work for commits during logical slot creation. Before 955a684e0401 logical decoding snapshot maintenance needed to cope with transactions it might not have seen in their entirety. For such transactions we'd to assume they modified the catalog (could have happened before we were w

[COMMITTERS] pgsql: Avoid superfluous work for commits during logical slot creation.

2017-05-13 Thread Andres Freund
Avoid superfluous work for commits during logical slot creation. Before 955a684e0401 logical decoding snapshot maintenance needed to cope with transactions it might not have seen in their entirety. For such transactions we'd to assume they modified the catalog (could have happened before we were w

[COMMITTERS] pgsql: Avoid superfluous work for commits during logical slot creation.

2017-05-13 Thread Andres Freund
Avoid superfluous work for commits during logical slot creation. Before 955a684e0401 logical decoding snapshot maintenance needed to cope with transactions it might not have seen in their entirety. For such transactions we'd to assume they modified the catalog (could have happened before we were w

[COMMITTERS] pgsql: Avoid superfluous work for commits during logical slot creation.

2017-05-13 Thread Andres Freund
Avoid superfluous work for commits during logical slot creation. Before 955a684e0401 logical decoding snapshot maintenance needed to cope with transactions it might not have seen in their entirety. For such transactions we'd to assume they modified the catalog (could have happened before we were w

[COMMITTERS] pgsql: Fix race condition leading to hanging logical slot creation.

2017-05-13 Thread Andres Freund
Fix race condition leading to hanging logical slot creation. The snapshot assembly during the creation of logical slots relied waiting for transactions in xl_running_xacts to end, by checking for their commit/abort records. Unfortunately, despite locking, it is possible to see an xl_running_xact

[COMMITTERS] pgsql: Fix race condition leading to hanging logical slot creation.

2017-05-13 Thread Andres Freund
Fix race condition leading to hanging logical slot creation. The snapshot assembly during the creation of logical slots relied waiting for transactions in xl_running_xacts to end, by checking for their commit/abort records. Unfortunately, despite locking, it is possible to see an xl_running_xact

[COMMITTERS] pgsql: Fix race condition leading to hanging logical slot creation.

2017-05-13 Thread Andres Freund
Fix race condition leading to hanging logical slot creation. The snapshot assembly during the creation of logical slots relied waiting for transactions in xl_running_xacts to end, by checking for their commit/abort records. Unfortunately, despite locking, it is possible to see an xl_running_xact

[COMMITTERS] pgsql: Fix race condition leading to hanging logical slot creation.

2017-05-13 Thread Andres Freund
Fix race condition leading to hanging logical slot creation. The snapshot assembly during the creation of logical slots relied waiting for transactions in xl_running_xacts to end, by checking for their commit/abort records. Unfortunately, despite locking, it is possible to see an xl_running_xact

Re: [COMMITTERS] pgsql: Fix multi-column range partitioning constraints.

2017-05-13 Thread Tom Lane
Robert Haas writes: > Fix multi-column range partitioning constraints. Newer gcc versions are not very happy with this: partition.c: In function 'get_qual_from_partbound': partition.c:1642:18: warning: 'partexprs_item_saved' may be used uninitialized in this function [-Wmaybe-uninitialized]

[COMMITTERS] pgsql: Redesign get_attstatsslot()/free_attstatsslot() for more safety

2017-05-13 Thread Tom Lane
Redesign get_attstatsslot()/free_attstatsslot() for more safety and speed. The mess cleaned up in commit da0759600 is clear evidence that it's a bug hazard to expect the caller of get_attstatsslot()/free_attstatsslot() to provide the correct type OID for the array elements in the slot. Moreover, w

Re: [COMMITTERS] pgsql: Use a better way of skipping all subscription tests on Windows

2017-05-13 Thread Andrew Dunstan
On 05/13/2017 02:50 AM, Andrew Dunstan wrote: > Use a better way of skipping all subscription tests on Windows Of course, this should read "authentication", not "subscription". cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support,

[COMMITTERS] pgsql: Teach \d+ to show partitioning constraints.

2017-05-13 Thread Robert Haas
Teach \d+ to show partitioning constraints. The fact that we didn't have this in the first place is likely why the problem fixed by f8bffe9e6d700fd34759a92e47930ce9ba7dcbd5 escaped detection. Patch by Amit Langote, reviewed and slightly adjusted by me. Discussion: http://postgr.es/m/ca+tgmoywnv

[COMMITTERS] pgsql: Fix multi-column range partitioning constraints.

2017-05-13 Thread Robert Haas
Fix multi-column range partitioning constraints. The old logic was just plain wrong. Report by Olaf Gawenda. Patch by Amit Langote, reviewed by Beena Emerson and by me. Minor adjustments by me also. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f8bffe9e6d700fd3

[COMMITTERS] pgsql: Avoid hard-wired sleep delays in stats regression test.

2017-05-13 Thread Tom Lane
Avoid hard-wired sleep delays in stats regression test. On faster machines, the overall runtime for running the core regression tests is under twenty seconds these days, of which the hard-wired delays in the stats test are a significant fraction. But on closer inspection, it seems like we shouldn