[COMMITTERS] pgsql: pg_dump: Fix dumping of slot_name = NONE

2017-05-17 Thread Peter Eisentraut
pg_dump: Fix dumping of slot_name = NONE It previously wrote out slot_name = '', which was incorrect. Reported-by: Masahiko Sawada Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/157239d2cdad8fdc19afc13269c852dbddbe290b Modified Files -- src/bin/pg_du

[COMMITTERS] pgsql: Improve CREATE SUBSCRIPTION option parsing

2017-05-17 Thread Peter Eisentraut
Improve CREATE SUBSCRIPTION option parsing When creating a subscription with slot_name = NONE, we failed to check that also create_slot = false and enabled = false were set. This created an invalid subscription and could later lead to a crash if a NULL slot name was accessed. Add more checks aro

[COMMITTERS] pgsql: Post-PG 10 beta1 pgperltidy run

2017-05-17 Thread Bruce Momjian
Post-PG 10 beta1 pgperltidy run Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ce554810329b9b8e862eade08b598148931eb456 Modified Files -- contrib/intarray/bench/bench.pl| 3 +- src/backend/catalog/Catalog.pm | 1

[COMMITTERS] pgsql: Post-PG 10 beta1 pgindent run

2017-05-17 Thread Bruce Momjian
Post-PG 10 beta1 pgindent run perltidy run not included. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a6fd7b7a5f7bf3a8aa3f3d076cf09d922c1c6dd2 Modified Files -- contrib/bloom/blinsert.c | 10 +- contrib/bloom/blutils.c

[COMMITTERS] pgsql: Update typedefs list in prep. for post-PG10 beta1 pgindent run

2017-05-17 Thread Bruce Momjian
Update typedefs list in prep. for post-PG10 beta1 pgindent run Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8a943324780259757c77c56cfc597347d1150cdb Modified Files -- src/tools/pgindent/typedefs.list | 284 +-- 1 fil

[COMMITTERS] pgsql: Add download URL for perltidy version v20090616

2017-05-17 Thread Bruce Momjian
Add download URL for perltidy version v20090616 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/df238b43d76fb8e08469f418f570690651baaa7a Modified Files -- src/tools/pgindent/README | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- Sent via pgs

[COMMITTERS] pgsql: Code review for make_partition_op_expr.

2017-05-17 Thread Robert Haas
Code review for make_partition_op_expr. It's better to use the actual keynum here rather than 0, because someday someone might try to make list partitioning work with multiple partitioning columns. Jeevan Ladhe Discussion: http://postgr.es/m/caogct0m6-mx+dsx47jgjujp1ckr4xssbfvmknett0ozywpf...@m

[COMMITTERS] pgsql: Revert changes to pg_basebackup and pg_waldump usage() code.

2017-05-17 Thread Tom Lane
Revert changes to pg_basebackup and pg_waldump usage() code. Partially revert commit c079673dcb7f210617c9fc1470e6bf166d8a2971. There were complaints that splitting switch descriptions would complicate translation efforts. There are probably ways to resolve the formatting problem without doing tha

[COMMITTERS] pgsql: Remove redundant has_null member from PartitionBoundInfoData.

2017-05-17 Thread Robert Haas
Remove redundant has_null member from PartitionBoundInfoData. Jeevan Ladhe, with some changes by me. Discussion: http://postgr.es/m/caogct0nz_30-pjbpw2ognev1ammarhkzdz8b_kfc3q+_xb2...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/236d6d462d2c8e4ae

[COMMITTERS] pgsql: Add more tests for CREATE SUBSCRIPTION

2017-05-17 Thread Peter Eisentraut
Add more tests for CREATE SUBSCRIPTION Add some tests for parsing different option combinations. Fix some of the resulting error messages for recent changes in option naming. Author: Masahiko Sawada Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3db22794b76eb054

[COMMITTERS] pgsql: Make psql handle EOF during COPY FROM STDIN properly on all plat

2017-05-17 Thread Tom Lane
Make psql handle EOF during COPY FROM STDIN properly on all platforms. When stdin is a terminal, it's possible to end a COPY FROM STDIN with a keyboard EOF signal (typically control-D), and then keep on issuing SQL commands. One would expect another COPY FROM STDIN to work as well, but on some pl

[COMMITTERS] pgsql: Make psql handle EOF during COPY FROM STDIN properly on all plat

2017-05-17 Thread Tom Lane
Make psql handle EOF during COPY FROM STDIN properly on all platforms. When stdin is a terminal, it's possible to end a COPY FROM STDIN with a keyboard EOF signal (typically control-D), and then keep on issuing SQL commands. One would expect another COPY FROM STDIN to work as well, but on some pl

Re: [COMMITTERS] pgsql: Tag refs/tags/REL_10_BETA1 was created

2017-05-17 Thread Robert Haas
On Wed, May 17, 2017 at 8:04 AM, Andrew Dunstan wrote: >> When we get to v100, we'll need some other hack to make it work ... >> but I plan to be safely dead by then. > > Me too. Since posterity will be deprived of both of us let's note that > the same hack will work, we'll just need two underscor

[COMMITTERS] pgsql: Make psql handle EOF during COPY FROM STDIN properly on all plat

2017-05-17 Thread Tom Lane
Make psql handle EOF during COPY FROM STDIN properly on all platforms. When stdin is a terminal, it's possible to end a COPY FROM STDIN with a keyboard EOF signal (typically control-D), and then keep on issuing SQL commands. One would expect another COPY FROM STDIN to work as well, but on some pl

[COMMITTERS] pgsql: Make psql handle EOF during COPY FROM STDIN properly on all plat

2017-05-17 Thread Tom Lane
Make psql handle EOF during COPY FROM STDIN properly on all platforms. When stdin is a terminal, it's possible to end a COPY FROM STDIN with a keyboard EOF signal (typically control-D), and then keep on issuing SQL commands. One would expect another COPY FROM STDIN to work as well, but on some pl

[COMMITTERS] pgsql: Make psql handle EOF during COPY FROM STDIN properly on all plat

2017-05-17 Thread Tom Lane
Make psql handle EOF during COPY FROM STDIN properly on all platforms. When stdin is a terminal, it's possible to end a COPY FROM STDIN with a keyboard EOF signal (typically control-D), and then keep on issuing SQL commands. One would expect another COPY FROM STDIN to work as well, but on some pl

[COMMITTERS] pgsql: Make psql handle EOF during COPY FROM STDIN properly on all plat

2017-05-17 Thread Tom Lane
Make psql handle EOF during COPY FROM STDIN properly on all platforms. When stdin is a terminal, it's possible to end a COPY FROM STDIN with a keyboard EOF signal (typically control-D), and then keep on issuing SQL commands. One would expect another COPY FROM STDIN to work as well, but on some pl

Re: [HACKERS] [COMMITTERS] pgsql: Tag refs/tags/REL_10_BETA1 was created

2017-05-17 Thread Magnus Hagander
On Wed, May 17, 2017 at 2:41 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 5/16/17 22:37, Tom Lane wrote: > > BTW, I now remember having wondered[2] if we should make any other > changes > > in version-number formatting while we're at it, like maybe "10beta1" > > should be "

Re: [COMMITTERS] pgsql: Tag refs/tags/REL_10_BETA1 was created

2017-05-17 Thread Peter Eisentraut
On 5/16/17 22:37, Tom Lane wrote: > BTW, I now remember having wondered[2] if we should make any other changes > in version-number formatting while we're at it, like maybe "10beta1" > should be "10.beta1". That's not a naming format I've ever seen. I think the current format is fine. -- Peter E

Re: [COMMITTERS] pgsql: Tag refs/tags/REL_10_BETA1 was created

2017-05-17 Thread Andrew Dunstan
On 05/16/2017 10:37 PM, Tom Lane wrote: > Peter Eisentraut writes: >> On 5/16/17 18:14, pg...@postgresql.org wrote: >>> Tag refs/tags/REL_10_BETA1 was created. >> Was this change in naming pattern intentional? > Yes, it was. Andrew Dunstan suggested[1] during the > two-part-version-number discu