[COMMITTERS] pgsql: Fix typo in pg_dump's support for dumping collations from pre-v1

2017-05-26 Thread Tom Lane
Fix typo in pg_dump's support for dumping collations from pre-v10 servers. Dunno what 'p' was supposed to mean, but since neither the code below here nor pg_collation.h think it's valid, it must be a mistake. Per report from Thomas Kellerer. Discussion: https://postgr.es/m/og9q8f%24oes%241%40bla

[COMMITTERS] pgsql: Move autogenerated array types out of the way during ALTER ... R

2017-05-26 Thread Tom Lane
Move autogenerated array types out of the way during ALTER ... RENAME. Commit 9aa3c782c added code to allow CREATE TABLE/CREATE TYPE to not fail when the desired type name conflicts with an autogenerated array type, by dint of renaming the array type out of the way. But I (tgl) overlooked that th

[COMMITTERS] pgsql: Move autogenerated array types out of the way during ALTER ... R

2017-05-26 Thread Tom Lane
Move autogenerated array types out of the way during ALTER ... RENAME. Commit 9aa3c782c added code to allow CREATE TABLE/CREATE TYPE to not fail when the desired type name conflicts with an autogenerated array type, by dint of renaming the array type out of the way. But I (tgl) overlooked that th

[COMMITTERS] pgsql: Move autogenerated array types out of the way during ALTER ... R

2017-05-26 Thread Tom Lane
Move autogenerated array types out of the way during ALTER ... RENAME. Commit 9aa3c782c added code to allow CREATE TABLE/CREATE TYPE to not fail when the desired type name conflicts with an autogenerated array type, by dint of renaming the array type out of the way. But I (tgl) overlooked that th

[COMMITTERS] pgsql: Move autogenerated array types out of the way during ALTER ... R

2017-05-26 Thread Tom Lane
Move autogenerated array types out of the way during ALTER ... RENAME. Commit 9aa3c782c added code to allow CREATE TABLE/CREATE TYPE to not fail when the desired type name conflicts with an autogenerated array type, by dint of renaming the array type out of the way. But I (tgl) overlooked that th

[COMMITTERS] pgsql: Move autogenerated array types out of the way during ALTER ... R

2017-05-26 Thread Tom Lane
Move autogenerated array types out of the way during ALTER ... RENAME. Commit 9aa3c782c added code to allow CREATE TABLE/CREATE TYPE to not fail when the desired type name conflicts with an autogenerated array type, by dint of renaming the array type out of the way. But I (tgl) overlooked that th

[COMMITTERS] pgsql: Move autogenerated array types out of the way during ALTER ... R

2017-05-26 Thread Tom Lane
Move autogenerated array types out of the way during ALTER ... RENAME. Commit 9aa3c782c added code to allow CREATE TABLE/CREATE TYPE to not fail when the desired type name conflicts with an autogenerated array type, by dint of renaming the array type out of the way. But I (tgl) overlooked that th

[COMMITTERS] pgsql: Fix pg_dump to not emit invalid SQL for an empty operator class.

2017-05-26 Thread Tom Lane
Fix pg_dump to not emit invalid SQL for an empty operator class. If an operator class has no operators or functions, and doesn't need a STORAGE clause, we emitted "CREATE OPERATOR CLASS ... AS ;" which is syntactically invalid. Fix by forcing a STORAGE clause to be emitted anyway in this case. (

[COMMITTERS] pgsql: Fix pg_dump to not emit invalid SQL for an empty operator class.

2017-05-26 Thread Tom Lane
Fix pg_dump to not emit invalid SQL for an empty operator class. If an operator class has no operators or functions, and doesn't need a STORAGE clause, we emitted "CREATE OPERATOR CLASS ... AS ;" which is syntactically invalid. Fix by forcing a STORAGE clause to be emitted anyway in this case. (

[COMMITTERS] pgsql: Fix pg_dump to not emit invalid SQL for an empty operator class.

2017-05-26 Thread Tom Lane
Fix pg_dump to not emit invalid SQL for an empty operator class. If an operator class has no operators or functions, and doesn't need a STORAGE clause, we emitted "CREATE OPERATOR CLASS ... AS ;" which is syntactically invalid. Fix by forcing a STORAGE clause to be emitted anyway in this case. (

[COMMITTERS] pgsql: Fix pg_dump to not emit invalid SQL for an empty operator class.

2017-05-26 Thread Tom Lane
Fix pg_dump to not emit invalid SQL for an empty operator class. If an operator class has no operators or functions, and doesn't need a STORAGE clause, we emitted "CREATE OPERATOR CLASS ... AS ;" which is syntactically invalid. Fix by forcing a STORAGE clause to be emitted anyway in this case. (

[COMMITTERS] pgsql: Fix pg_dump to not emit invalid SQL for an empty operator class.

2017-05-26 Thread Tom Lane
Fix pg_dump to not emit invalid SQL for an empty operator class. If an operator class has no operators or functions, and doesn't need a STORAGE clause, we emitted "CREATE OPERATOR CLASS ... AS ;" which is syntactically invalid. Fix by forcing a STORAGE clause to be emitted anyway in this case. (

[COMMITTERS] pgsql: Fix pg_dump to not emit invalid SQL for an empty operator class.

2017-05-26 Thread Tom Lane
Fix pg_dump to not emit invalid SQL for an empty operator class. If an operator class has no operators or functions, and doesn't need a STORAGE clause, we emitted "CREATE OPERATOR CLASS ... AS ;" which is syntactically invalid. Fix by forcing a STORAGE clause to be emitted anyway in this case. (

[COMMITTERS] pgsql: Remove docs mention of PGREALM variable

2017-05-26 Thread Magnus Hagander
Remove docs mention of PGREALM variable This variable was only used with Kerberos v4. That support was removed in 2005, but we forgot to remove the documentation. Noted by Shinichi Matsuda Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/828db4d2af0e4e4ad028e

[COMMITTERS] pgsql: Remove docs mention of PGREALM variable

2017-05-26 Thread Magnus Hagander
Remove docs mention of PGREALM variable This variable was only used with Kerberos v4. That support was removed in 2005, but we forgot to remove the documentation. Noted by Shinichi Matsuda Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/50d9476920b5c0dac1592

[COMMITTERS] pgsql: Remove docs mention of PGREALM variable

2017-05-26 Thread Magnus Hagander
Remove docs mention of PGREALM variable This variable was only used with Kerberos v4. That support was removed in 2005, but we forgot to remove the documentation. Noted by Shinichi Matsuda Branch -- REL9_2_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8f6396470a9d0308e4f28

[COMMITTERS] pgsql: Remove docs mention of PGREALM variable

2017-05-26 Thread Magnus Hagander
Remove docs mention of PGREALM variable This variable was only used with Kerberos v4. That support was removed in 2005, but we forgot to remove the documentation. Noted by Shinichi Matsuda Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/1218abc47e859c3f98030

[COMMITTERS] pgsql: Remove docs mention of PGREALM variable

2017-05-26 Thread Magnus Hagander
Remove docs mention of PGREALM variable This variable was only used with Kerberos v4. That support was removed in 2005, but we forgot to remove the documentation. Noted by Shinichi Matsuda Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9c34a05b7d2304eac3fdc5e9db9f

[COMMITTERS] pgsql: Remove docs mention of PGREALM variable

2017-05-26 Thread Magnus Hagander
Remove docs mention of PGREALM variable This variable was only used with Kerberos v4. That support was removed in 2005, but we forgot to remove the documentation. Noted by Shinichi Matsuda Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d192a19799a97de20ca94