[COMMITTERS] Re: pgsql: Code review focused on new node types added by partitioning supp

2017-05-29 Thread Noah Misch
On Mon, May 29, 2017 at 03:20:41AM +, Tom Lane wrote: > Annotate the fact that somebody added location fields to PartitionBoundSpec > and PartitionRangeDatum but forgot to handle them in > outfuncs.c/readfuncs.c. This is fairly harmless for production purposes > (since readfuncs.c would just s

[COMMITTERS] pgsql: Fix improper quoting of format_type_be() output.

2017-05-29 Thread Tom Lane
Fix improper quoting of format_type_be() output. Per our message style guidelines, error messages incorporating the results of format_type_be() and its siblings should not add quotes around those results, because those functions already add quotes at need. Fix a few places that hadn't gotten that

[COMMITTERS] pgsql: Try to ensure that stats collector's receive buffer size is at l

2017-05-29 Thread Tom Lane
Try to ensure that stats collector's receive buffer size is at least 100KB. Back-patch of commit 8b0b6303e991079726e83d17401405e94da11564. Discussion: https://postgr.es/m/22173.1494788...@sss.pgh.pa.us Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/34782a34

[COMMITTERS] pgsql: Try to ensure that stats collector's receive buffer size is at l

2017-05-29 Thread Tom Lane
Try to ensure that stats collector's receive buffer size is at least 100KB. Back-patch of commit 8b0b6303e991079726e83d17401405e94da11564. Discussion: https://postgr.es/m/22173.1494788...@sss.pgh.pa.us Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/54676c72

[COMMITTERS] pgsql: Try to ensure that stats collector's receive buffer size is at l

2017-05-29 Thread Tom Lane
Try to ensure that stats collector's receive buffer size is at least 100KB. Back-patch of commit 8b0b6303e991079726e83d17401405e94da11564. Discussion: https://postgr.es/m/22173.1494788...@sss.pgh.pa.us Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4a3bb96c

[COMMITTERS] pgsql: Try to ensure that stats collector's receive buffer size is at l

2017-05-29 Thread Tom Lane
Try to ensure that stats collector's receive buffer size is at least 100KB. Back-patch of commit 8b0b6303e991079726e83d17401405e94da11564. Discussion: https://postgr.es/m/22173.1494788...@sss.pgh.pa.us Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/82f8c21e

[COMMITTERS] pgsql: Try to ensure that stats collector's receive buffer size is at l

2017-05-29 Thread Tom Lane
Try to ensure that stats collector's receive buffer size is at least 100KB. Back-patch of commit 8b0b6303e991079726e83d17401405e94da11564. Discussion: https://postgr.es/m/22173.1494788...@sss.pgh.pa.us Branch -- REL9_2_STABLE Details --- https://git.postgresql.org/pg/commitdiff/364100e0

[COMMITTERS] pgsql: Make edge-case behavior of jsonb_populate_record match json_popu

2017-05-29 Thread Tom Lane
Make edge-case behavior of jsonb_populate_record match json_populate_record json_populate_record throws an error if asked to convert a JSON scalar or array into a composite type. jsonb_populate_record was returning a record full of NULL fields instead. It seems better to make it throw an error f

[COMMITTERS] pgsql: Fix thinko in JsObjectSize() macro.

2017-05-29 Thread Tom Lane
Fix thinko in JsObjectSize() macro. The macro gave the wrong answers for a JsObject with is_json == 0: it would return 1 if jsonb_cont == NULL, or if that wasn't NULL, it would return 1 for any non-zero size. We could fix that, but the only use of this macro at present is in the JsObjectIsEmpty()

[COMMITTERS] pgsql: Prevent running pg_resetwal/pg_resetxlog against wrong-version d

2017-05-29 Thread Tom Lane
Prevent running pg_resetwal/pg_resetxlog against wrong-version data dirs. pg_resetwal (formerly pg_resetxlog) doesn't insist on finding a matching version number in pg_control, and that seems like an important thing to preserve since recovering from corrupt pg_control is a prime reason to need to

[COMMITTERS] pgsql: Prevent running pg_resetwal/pg_resetxlog against wrong-version d

2017-05-29 Thread Tom Lane
Prevent running pg_resetwal/pg_resetxlog against wrong-version data dirs. pg_resetwal (formerly pg_resetxlog) doesn't insist on finding a matching version number in pg_control, and that seems like an important thing to preserve since recovering from corrupt pg_control is a prime reason to need to

[COMMITTERS] pgsql: Prevent running pg_resetwal/pg_resetxlog against wrong-version d

2017-05-29 Thread Tom Lane
Prevent running pg_resetwal/pg_resetxlog against wrong-version data dirs. pg_resetwal (formerly pg_resetxlog) doesn't insist on finding a matching version number in pg_control, and that seems like an important thing to preserve since recovering from corrupt pg_control is a prime reason to need to

[COMMITTERS] pgsql: Prevent running pg_resetwal/pg_resetxlog against wrong-version d

2017-05-29 Thread Tom Lane
Prevent running pg_resetwal/pg_resetxlog against wrong-version data dirs. pg_resetwal (formerly pg_resetxlog) doesn't insist on finding a matching version number in pg_control, and that seems like an important thing to preserve since recovering from corrupt pg_control is a prime reason to need to

[COMMITTERS] pgsql: Prevent running pg_resetwal/pg_resetxlog against wrong-version d

2017-05-29 Thread Tom Lane
Prevent running pg_resetwal/pg_resetxlog against wrong-version data dirs. pg_resetwal (formerly pg_resetxlog) doesn't insist on finding a matching version number in pg_control, and that seems like an important thing to preserve since recovering from corrupt pg_control is a prime reason to need to

[COMMITTERS] pgsql: Prevent running pg_resetwal/pg_resetxlog against wrong-version d

2017-05-29 Thread Tom Lane
Prevent running pg_resetwal/pg_resetxlog against wrong-version data dirs. pg_resetwal (formerly pg_resetxlog) doesn't insist on finding a matching version number in pg_control, and that seems like an important thing to preserve since recovering from corrupt pg_control is a prime reason to need to

[COMMITTERS] pgsql: Allow NumericOnly to be "+ FCONST".

2017-05-29 Thread Tom Lane
Allow NumericOnly to be "+ FCONST". The NumericOnly grammar production accepted ICONST, + ICONST, - ICONST, FCONST, and - FCONST, but for some reason not + FCONST. This led to strange inconsistencies like regression=# set random_page_cost = +4; SET regression=# set random_page_cost = 40;

[COMMITTERS] pgsql: Allow NumericOnly to be "+ FCONST".

2017-05-29 Thread Tom Lane
Allow NumericOnly to be "+ FCONST". The NumericOnly grammar production accepted ICONST, + ICONST, - ICONST, FCONST, and - FCONST, but for some reason not + FCONST. This led to strange inconsistencies like regression=# set random_page_cost = +4; SET regression=# set random_page_cost = 40;

[COMMITTERS] pgsql: Allow NumericOnly to be "+ FCONST".

2017-05-29 Thread Tom Lane
Allow NumericOnly to be "+ FCONST". The NumericOnly grammar production accepted ICONST, + ICONST, - ICONST, FCONST, and - FCONST, but for some reason not + FCONST. This led to strange inconsistencies like regression=# set random_page_cost = +4; SET regression=# set random_page_cost = 40;

[COMMITTERS] pgsql: Allow NumericOnly to be "+ FCONST".

2017-05-29 Thread Tom Lane
Allow NumericOnly to be "+ FCONST". The NumericOnly grammar production accepted ICONST, + ICONST, - ICONST, FCONST, and - FCONST, but for some reason not + FCONST. This led to strange inconsistencies like regression=# set random_page_cost = +4; SET regression=# set random_page_cost = 40;

[COMMITTERS] pgsql: Allow NumericOnly to be "+ FCONST".

2017-05-29 Thread Tom Lane
Allow NumericOnly to be "+ FCONST". The NumericOnly grammar production accepted ICONST, + ICONST, - ICONST, FCONST, and - FCONST, but for some reason not + FCONST. This led to strange inconsistencies like regression=# set random_page_cost = +4; SET regression=# set random_page_cost = 40;

[COMMITTERS] pgsql: Allow NumericOnly to be "+ FCONST".

2017-05-29 Thread Tom Lane
Allow NumericOnly to be "+ FCONST". The NumericOnly grammar production accepted ICONST, + ICONST, - ICONST, FCONST, and - FCONST, but for some reason not + FCONST. This led to strange inconsistencies like regression=# set random_page_cost = +4; SET regression=# set random_page_cost = 40;

[COMMITTERS] pgsql: More code review for get_qual_for_list().

2017-05-29 Thread Tom Lane
More code review for get_qual_for_list(). Avoid trashing the input PartitionBoundSpec; while that might be safe for current callers, it's certainly trouble waiting to happen. In the same vein, make sure that all of the result data structure is freshly palloc'd, rather than some of it being pointe

[COMMITTERS] pgsql: Fix typo in comment

2017-05-29 Thread Magnus Hagander
Fix typo in comment Masahiko Sawada Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/917d91285f187e599039a962d9b869a782390304 Modified Files -- src/backend/executor/execExpr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-comm