[COMMITTERS] pgsql: Disallow set-returning functions inside CASE or COALESCE.

Disallow set-returning functions inside CASE or COALESCE. When we reimplemented SRFs in commit 69f4b9c85, our initial choice was to allow the behavior to vary from historical practice in cases where a SRF call appeared within a conditional-execution construct (currently, only CASE or COALESCE).

[COMMITTERS] pgsql: doc: Update example version numbers in pg_upgrade documentation

doc: Update example version numbers in pg_upgrade documentation The exact numbers don't matter, since they are examples, but it was looking quite dated. For the target version, we now automatically substitute the current major version. The updated example source version should be good for a

Re: [COMMITTERS] pgsql: Assert that we don't invent relfilenodes or type OIDs in binary

On Tue, Jun 13, 2017 at 03:10:16PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Tue, Jun 13, 2017 at 11:52:04AM -0700, Andres Freund wrote: > >> I'm not sure what you're actually concerned about here? > > > I am concerned a non-assert build will not error out, but if

Re: [COMMITTERS] pgsql: Assert that we don't invent relfilenodes or type OIDs in binary

Bruce Momjian writes: > On Tue, Jun 13, 2017 at 11:52:04AM -0700, Andres Freund wrote: >> I'm not sure what you're actually concerned about here? > I am concerned a non-assert build will not error out, but if no one else > is concerned about that, I am fine. I think in a

Re: [COMMITTERS] pgsql: Assert that we don't invent relfilenodes or type OIDs in binary

On Tue, Jun 13, 2017 at 11:52:04AM -0700, Andres Freund wrote: > On 2017-06-13 13:45:12 -0400, Bruce Momjian wrote: > > On Tue, Jun 13, 2017 at 01:39:34PM -0400, Tom Lane wrote: > > > Bruce Momjian writes: > > > > Uh, is there a reason this is only an Assert(), meaning it only

Re: [COMMITTERS] pgsql: Assert that we don't invent relfilenodes or type OIDs in binary

On 2017-06-13 13:45:12 -0400, Bruce Momjian wrote: > On Tue, Jun 13, 2017 at 01:39:34PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > Uh, is there a reason this is only an Assert(), meaning it only checks > > > in assert builds. pg_upgrade already has a lot of checks

[COMMITTERS] pgsql: psql: Use more consistent capitalization of some output headings

psql: Use more consistent capitalization of some output headings Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/272171279f8676c57b3a8edf7daf792ad55b2c2c Modified Files -- .../hstore_plperl/expected/create_transform.out| 6 +-

Re: [COMMITTERS] pgsql: Assert that we don't invent relfilenodes or type OIDs in binary

On Tue, Jun 13, 2017 at 01:39:34PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Uh, is there a reason this is only an Assert(), meaning it only checks > > in assert builds. pg_upgrade already has a lot of checks and they are > > all fatal. > > Yeah, I didn't think it was

Re: [COMMITTERS] pgsql: Assert that we don't invent relfilenodes or type OIDs in binary

Bruce Momjian writes: > Uh, is there a reason this is only an Assert(), meaning it only checks > in assert builds. pg_upgrade already has a lot of checks and they are > all fatal. Yeah, I didn't think it was worth adding overhead to production builds for it.

Re: [COMMITTERS] pgsql: Assert that we don't invent relfilenodes or type OIDs in binary

Uh, is there a reason this is only an Assert(), meaning it only checks in assert builds. pg_upgrade already has a lot of checks and they are all fatal. --- On Tue, Jun 13, 2017 at 12:04:48AM +, Tom Lane wrote: > Assert

[COMMITTERS] pgsql: Re-run pgindent.

Re-run pgindent. This is just to have a clean base state for testing of Piotr Stefaniak's latest version of FreeBSD indent. I fixed up a couple of places where pgindent would have changed format not-nicely. perltidy not included. Discussion:

[COMMITTERS] pgsql: Always initialize PartitionBoundInfoData's null_index.

Always initialize PartitionBoundInfoData's null_index. This doesn't actually matter at present, because the current code never consults null_index for range partitions. However, leaving it uninitialized is still a bad idea, so let's not do that. Amul Sul, reviewed by Ashutosh Bapat Discussion:

[COMMITTERS] pgsql: Teach relation_is_updatable() about partitioned tables.

Teach relation_is_updatable() about partitioned tables. Table partitioning, introduced in commit f0e44751d7, added a new relkind - RELKIND_PARTITIONED_TABLE. Update relation_is_updatable() to handle it. Specifically, partitioned tables and simple views built on top of them are updatable. This

[COMMITTERS] pgsql: libpq: Message style improvements

libpq: Message style improvements Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2e3fc7a7d322289c70f89199be0a5e899ec7d9b9 Modified Files -- src/interfaces/libpq/fe-auth.c| 3 ++- src/interfaces/libpq/fe-connect.c | 2 +- 2 files changed, 3

[COMMITTERS] pgsql: Fix failure to remove dependencies when a partition is detached.

Fix failure to remove dependencies when a partition is detached. Otherwise, dropping the partitioned table will automatically drop any previously-detached children, which would be unfortunate. Ashutosh Bapat and Rahila Syed, reviewed by Amit Langote and by me. Discussion:

[COMMITTERS] pgsql: doc: Fix typo

doc: Fix typo Author: Julien Rouhaud Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/506b565831e6c88666c18a467377c2f98066ccac Modified Files -- doc/src/sgml/brin.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --

Re: [COMMITTERS] pgsql: Fix collprovider of predefined collations

On 6/13/17 10:57, Tom Lane wrote: > I wrote: >> Peter Eisentraut writes: >>> Fix collprovider of predefined collations >>> An earlier version of the patch had collprovider as an integer and thus >>> set these to 0, but the correct setting is now null. > >> Surely this is not

Re: [COMMITTERS] pgsql: Fix collprovider of predefined collations

I wrote: > Peter Eisentraut writes: >> Fix collprovider of predefined collations >> An earlier version of the patch had collprovider as an integer and thus >> set these to 0, but the correct setting is now null. > Surely this is not right. Neither collprovider nor the other

[COMMITTERS] pgsql: In initdb, defend against assignment of NULL values to not-null

In initdb, defend against assignment of NULL values to not-null columns. Previously, you could write _null_ in a BKI DATA line for a column that's supposed to be NOT NULL and initdb would let it pass, probably breaking subsequent accesses to the row. No doubt the original coding overlooked this

[COMMITTERS] pgsql: Fix typo

Fix typo Author: Masahiko Sawada Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f2a886104a6683227bfcb0932dde97d30b123961 Modified Files -- src/backend/storage/ipc/shm_mq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[COMMITTERS] pgsql: Improve code comments

Improve code comments Author: Erik Rijkers Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/88c6cff8e71eccac00fe68f4c15530161b99e6c5 Modified Files -- src/backend/replication/logical/tablesync.c | 46 ++--- 1 file

Re: [COMMITTERS] pgsql: Fix collprovider of predefined collations

Peter Eisentraut writes: > Fix collprovider of predefined collations > An earlier version of the patch had collprovider as an integer and thus > set these to 0, but the correct setting is now null. Surely this is not right. Neither collprovider nor the other fixed-length fields

[COMMITTERS] pgsql: Use correct ICU path for Windows 32 vs. 64 bit

Use correct ICU path for Windows 32 vs. 64 bit Author: Ashutosh Sharma Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ae1aa28eb6a0adb1ae0b36eb25a7d0ee2ee3db0b Modified Files -- src/tools/msvc/Solution.pm | 15 --- 1

[COMMITTERS] pgsql: Fix collprovider of predefined collations

Fix collprovider of predefined collations An earlier version of the patch had collprovider as an integer and thus set these to 0, but the correct setting is now null. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ec7129b7812ce276520f749d0946875663c34093 Modified

[COMMITTERS] pgsql: pg_dump: Allow dumping default collation

pg_dump: Allow dumping default collation This will not work on restore, but it will allow dumping out pg_catalog for research and documentation. Reported-by: Neil Anderson Bug: #14701 Branch -- master Details ---

[COMMITTERS] pgsql: Prevent copying default collation

Prevent copying default collation This will not have the desired effect and might lead to crashes when the copied collation is used. Reported-by: Tom Lane Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/17082a88eadfca79b50c04c5a78a2c38ee4f5d9c