[COMMITTERS] pgsql: Make opr_sanity test complain about built-in functions marked pr

2017-06-20 Thread Tom Lane
Make opr_sanity test complain about built-in functions marked prosecdef. Currently, there are no built-in functions that are SECURITY DEFINER. But we just found an instance where one was mistakenly marked that way, so it seems prudent to add a test about it. If we ever grow some functions that ar

[COMMITTERS] pgsql: Fix typo in code comment

2017-06-20 Thread Peter Eisentraut
Fix typo in code comment Author: Masahiko Sawada Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/15c91568cfa4777892207a85000fdfd72b59b677 Modified Files -- src/backend/catalog/partition.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent

[COMMITTERS] pgsql: Upgrade documentation connected with shared_preload_libraries et

2017-06-20 Thread Tom Lane
Upgrade documentation connected with shared_preload_libraries et al. Noplace in the documentation actually defined what these variables contain. Define them as lists of arguments for LOAD, and improve that command's documentation a bit. Discussion: https://postgr.es/m/cab-ojtxhvdc3h+km3cjb9my1v

[COMMITTERS] pgsql: pg_upgrade: start/stop new server after pg_resetwal

2017-06-20 Thread Bruce Momjian
pg_upgrade: start/stop new server after pg_resetwal When commit 0f33a719fdbb5d8c43839ea0d2c90cd03e2af2d2 removed the instructions to start/stop the new cluster before running rsync, it was now possible for pg_resetwal/pg_resetxlog to leave the final WAL record at wal_level=minimum, preventing upg

[COMMITTERS] pgsql: pg_upgrade: start/stop new server after pg_resetwal

2017-06-20 Thread Bruce Momjian
pg_upgrade: start/stop new server after pg_resetwal When commit 0f33a719fdbb5d8c43839ea0d2c90cd03e2af2d2 removed the instructions to start/stop the new cluster before running rsync, it was now possible for pg_resetwal/pg_resetxlog to leave the final WAL record at wal_level=minimum, preventing upg

[COMMITTERS] pgsql: pg_upgrade: start/stop new server after pg_resetwal

2017-06-20 Thread Bruce Momjian
pg_upgrade: start/stop new server after pg_resetwal When commit 0f33a719fdbb5d8c43839ea0d2c90cd03e2af2d2 removed the instructions to start/stop the new cluster before running rsync, it was now possible for pg_resetwal/pg_resetxlog to leave the final WAL record at wal_level=minimum, preventing upg

[COMMITTERS] pgsql: pg_upgrade: start/stop new server after pg_resetwal

2017-06-20 Thread Bruce Momjian
pg_upgrade: start/stop new server after pg_resetwal When commit 0f33a719fdbb5d8c43839ea0d2c90cd03e2af2d2 removed the instructions to start/stop the new cluster before running rsync, it was now possible for pg_resetwal/pg_resetxlog to leave the final WAL record at wal_level=minimum, preventing upg

[COMMITTERS] pgsql: pg_upgrade: start/stop new server after pg_resetwal

2017-06-20 Thread Bruce Momjian
pg_upgrade: start/stop new server after pg_resetwal When commit 0f33a719fdbb5d8c43839ea0d2c90cd03e2af2d2 removed the instructions to start/stop the new cluster before running rsync, it was now possible for pg_resetwal/pg_resetxlog to leave the final WAL record at wal_level=minimum, preventing upg

[COMMITTERS] pgsql: pg_upgrade: start/stop new server after pg_resetwal

2017-06-20 Thread Bruce Momjian
pg_upgrade: start/stop new server after pg_resetwal When commit 0f33a719fdbb5d8c43839ea0d2c90cd03e2af2d2 removed the instructions to start/stop the new cluster before running rsync, it was now possible for pg_resetwal/pg_resetxlog to leave the final WAL record at wal_level=minimum, preventing upg

[COMMITTERS] pgsql: Don't downcase entries within shared_preload_libraries et al.

2017-06-20 Thread Tom Lane
Don't downcase entries within shared_preload_libraries et al. load_libraries(), which processes the various xxx_preload_libraries GUCs, was parsing them using SplitIdentifierString() which isn't really appropriate for values that could be path names: it downcases unquoted text, and it doesn't allo

[COMMITTERS] pgsql: Tweak publication fetching in psql

2017-06-20 Thread Peter Eisentraut
Tweak publication fetching in psql Viewing a table with \d in psql also shows the publications at table is in. If a publication is concurrently dropped, this shows an error, because the view pg_publication_tables internally uses pg_get_publication_tables(), which uses a catalog snapshot. This ca

[COMMITTERS] pgsql: doc: adjust wal_level pg_upgrade patch

2017-06-20 Thread Bruce Momjian
doc: adjust wal_level pg_upgrade patch Since 9.5 has two WAL levels that apply to standby upgrades, archive and hot_standby, adjust the docs for that version to say, basically, "restore old cluster wal_level value in the new cluster". This is a follow-on patch to fd376afc9863dd8ea3eba95edfa79961

[COMMITTERS] pgsql: Change pg_get_publication_tables to prosecdef false

2017-06-20 Thread Peter Eisentraut
Change pg_get_publication_tables to prosecdef false This was apparently a mistake in the original commit. Reported-by: Tom Lane Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/20d7d68b098dde6106e6c382e787c8b10c4403df Modified Files -- src/include/cata