[COMMITTERS] pgsql: Reduce wal_retrieve_retry_interval in applicable TAP tests.

2017-06-26 Thread Tom Lane
Reduce wal_retrieve_retry_interval in applicable TAP tests. By default, wal_retrieve_retry_interval is five seconds, which is far more than is needed in any of our TAP tests, leaving the test cases just twiddling their thumbs for significant stretches. Moreover, because it's so large, we get basi

[COMMITTERS] pgsql: Reduce wal_retrieve_retry_interval in applicable TAP tests.

2017-06-26 Thread Tom Lane
Reduce wal_retrieve_retry_interval in applicable TAP tests. By default, wal_retrieve_retry_interval is five seconds, which is far more than is needed in any of our TAP tests, leaving the test cases just twiddling their thumbs for significant stretches. Moreover, because it's so large, we get basi

[COMMITTERS] pgsql: Don't lose walreceiver start requests due to race condition in p

2017-06-26 Thread Tom Lane
Don't lose walreceiver start requests due to race condition in postmaster. When a walreceiver dies, the startup process will notice that and send a PMSIGNAL_START_WALRECEIVER signal to the postmaster, asking for a new walreceiver to be launched. There's a race condition, which at least in HEAD is

[COMMITTERS] pgsql: Don't lose walreceiver start requests due to race condition in p

2017-06-26 Thread Tom Lane
Don't lose walreceiver start requests due to race condition in postmaster. When a walreceiver dies, the startup process will notice that and send a PMSIGNAL_START_WALRECEIVER signal to the postmaster, asking for a new walreceiver to be launched. There's a race condition, which at least in HEAD is

[COMMITTERS] pgsql: Don't lose walreceiver start requests due to race condition in p

2017-06-26 Thread Tom Lane
Don't lose walreceiver start requests due to race condition in postmaster. When a walreceiver dies, the startup process will notice that and send a PMSIGNAL_START_WALRECEIVER signal to the postmaster, asking for a new walreceiver to be launched. There's a race condition, which at least in HEAD is

[COMMITTERS] pgsql: Don't lose walreceiver start requests due to race condition in p

2017-06-26 Thread Tom Lane
Don't lose walreceiver start requests due to race condition in postmaster. When a walreceiver dies, the startup process will notice that and send a PMSIGNAL_START_WALRECEIVER signal to the postmaster, asking for a new walreceiver to be launched. There's a race condition, which at least in HEAD is

[COMMITTERS] pgsql: Don't lose walreceiver start requests due to race condition in p

2017-06-26 Thread Tom Lane
Don't lose walreceiver start requests due to race condition in postmaster. When a walreceiver dies, the startup process will notice that and send a PMSIGNAL_START_WALRECEIVER signal to the postmaster, asking for a new walreceiver to be launched. There's a race condition, which at least in HEAD is

[COMMITTERS] pgsql: Don't lose walreceiver start requests due to race condition in p

2017-06-26 Thread Tom Lane
Don't lose walreceiver start requests due to race condition in postmaster. When a walreceiver dies, the startup process will notice that and send a PMSIGNAL_START_WALRECEIVER signal to the postmaster, asking for a new walreceiver to be launched. There's a race condition, which at least in HEAD is

[COMMITTERS] pgsql: Ignore old stats file timestamps when starting the stats collect

2017-06-26 Thread Tom Lane
Ignore old stats file timestamps when starting the stats collector. The stats collector disregards inquiry messages that bear a cutoff_time before when it last wrote the relevant stats file. That's fine, but at startup when it reads the "permanent" stats files, it absorbed their timestamps as if

[COMMITTERS] pgsql: Ignore old stats file timestamps when starting the stats collect

2017-06-26 Thread Tom Lane
Ignore old stats file timestamps when starting the stats collector. The stats collector disregards inquiry messages that bear a cutoff_time before when it last wrote the relevant stats file. That's fine, but at startup when it reads the "permanent" stats files, it absorbed their timestamps as if

[COMMITTERS] pgsql: Ignore old stats file timestamps when starting the stats collect

2017-06-26 Thread Tom Lane
Ignore old stats file timestamps when starting the stats collector. The stats collector disregards inquiry messages that bear a cutoff_time before when it last wrote the relevant stats file. That's fine, but at startup when it reads the "permanent" stats files, it absorbed their timestamps as if

[COMMITTERS] pgsql: Ignore old stats file timestamps when starting the stats collect

2017-06-26 Thread Tom Lane
Ignore old stats file timestamps when starting the stats collector. The stats collector disregards inquiry messages that bear a cutoff_time before when it last wrote the relevant stats file. That's fine, but at startup when it reads the "permanent" stats files, it absorbed their timestamps as if

[COMMITTERS] pgsql: Ignore old stats file timestamps when starting the stats collect

2017-06-26 Thread Tom Lane
Ignore old stats file timestamps when starting the stats collector. The stats collector disregards inquiry messages that bear a cutoff_time before when it last wrote the relevant stats file. That's fine, but at startup when it reads the "permanent" stats files, it absorbed their timestamps as if

[COMMITTERS] pgsql: Ignore old stats file timestamps when starting the stats collect

2017-06-26 Thread Tom Lane
Ignore old stats file timestamps when starting the stats collector. The stats collector disregards inquiry messages that bear a cutoff_time before when it last wrote the relevant stats file. That's fine, but at startup when it reads the "permanent" stats files, it absorbed their timestamps as if

[COMMITTERS] pgsql: Reduce pg_ctl's reaction time when waiting for postmaster start/

2017-06-26 Thread Tom Lane
Reduce pg_ctl's reaction time when waiting for postmaster start/stop. pg_ctl has traditionally waited one second between probes for whether the start or stop request has completed. That behavior was embodied in the original shell script written in 1999 (commit 5b912b089) and I doubt anyone's ques

[COMMITTERS] pgsql: Improve wait logic in TAP tests for streaming replication.

2017-06-26 Thread Tom Lane
Improve wait logic in TAP tests for streaming replication. Remove hard-wired sleep(2) delays in 001_stream_rep.pl in favor of using poll_query_until to check for the desired state to appear. In addition, add such a wait before the last test in the script, as it's possible to demonstrate failures

[COMMITTERS] pgsql: Avoid useless "x = ANY(ARRAY[])" test for empty partition list.

2017-06-26 Thread Tom Lane
Avoid useless "x = ANY(ARRAY[])" test for empty partition list. This arises in practice if the partition only admits NULL values. Jeevan Ladhe Discussion: https://postgr.es/m/caogct0ochrn--uuqh6wg6z8+nxncwj+2q-uhnk4koandrrx...@mail.gmail.com Branch -- master Details --- https://git.po

[COMMITTERS] pgsql: Minor code review for parse_phrase_operator().

2017-06-26 Thread Tom Lane
Minor code review for parse_phrase_operator(). Fix its header comment, which described the old behavior of the phrase distance operator; we missed updating that in commit 028350f61. Also, reset errno before strtol() call, to defend against the possibility that it was already ERANGE at entry. (Th

[COMMITTERS] pgsql: Minor code review for parse_phrase_operator().

2017-06-26 Thread Tom Lane
Minor code review for parse_phrase_operator(). Fix its header comment, which described the old behavior of the phrase distance operator; we missed updating that in commit 028350f61. Also, reset errno before strtol() call, to defend against the possibility that it was already ERANGE at entry. (Th

[COMMITTERS] pgsql: Consistently use () for function calls in release notes

2017-06-26 Thread Magnus Hagander
Consistently use () for function calls in release notes Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/59cd3987afd61191483a4cfe8f6a0abfb8c878d6 Modified Files -- doc/src/sgml/release-10.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --