[COMMITTERS] pgsql: Fix UPDATE of GENERATED ALWAYS identity columns

2017-06-30 Thread Peter Eisentraut
Fix UPDATE of GENERATED ALWAYS identity columns The bug would previously prevent the update of any column in a table with identity columns, rather than just the actual identity column. Reported-by: zam...@gmail.com Bug: #14718 Branch -- master Details --- https://git.postgresql.org/pg/c

[COMMITTERS] pgsql: Fix locking in WAL receiver/sender shmem state structs

2017-06-30 Thread Alvaro Herrera
Fix locking in WAL receiver/sender shmem state structs In WAL receiver and WAL server, some accesses to their corresponding shared memory control structs were done without holding any kind of lock, which could lead to inconsistent and possibly insecure results. In walsender, fix by clarifying the

[COMMITTERS] pgsql: PL/Python: Fix hint about returning composite type from Python

2017-06-30 Thread Peter Eisentraut
PL/Python: Fix hint about returning composite type from Python ('foo') is not a Python tuple: it is a string wrapped in parentheses. A valid 1-element Python tuple is ('foo',). Author: Daniele Varrazzo Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/898d24ae2ad71

[COMMITTERS] pgsql: Fix typo in comment

2017-06-30 Thread Peter Eisentraut
Fix typo in comment Author: Masahiko Sawada Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b295cc3b9ab48c3c34724fa577d6c1cfb753058c Modified Files -- src/backend/catalog/aclchk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsq

[COMMITTERS] pgsql: Fix race conditions and missed wakeups in syncrep worker signali

2017-06-30 Thread Tom Lane
Fix race conditions and missed wakeups in syncrep worker signaling. When a sync worker is waiting for the associated apply worker to notice that it's in SYNCWAIT state, wait_for_worker_state_change() would just patiently wait for that to happen. This generally required waiting for the 1-second ti

[COMMITTERS] pgsql: Fix typo in comment

2017-06-30 Thread Peter Eisentraut
Fix typo in comment Author: Albe Laurenz Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1db49c3b6d2399f8f83a97f1fa34e749b9fada7c Modified Files -- contrib/postgres_fdw/postgres_fdw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via

[COMMITTERS] pgsql: Fix typo in comment

2017-06-30 Thread Peter Eisentraut
Fix typo in comment Author: Amit Langote Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/da8f26ec4eb6e3dced9e348efefac17d733008c0 Modified Files -- src/backend/access/transam/xlog.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- Sen

[COMMITTERS] pgsql: Remove outdated comment

2017-06-30 Thread Peter Eisentraut
Remove outdated comment Author: Thomas Munro Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1acc04e4045d4e863c14d144f8c2bf18b80da504 Modified Files -- src/include/access/slru.h | 4 1 file changed, 4 deletions(-) -- Sent via pgsql-committers ma

[COMMITTERS] pgsql: Update code comments for pg_xlog -> pg_wal

2017-06-30 Thread Peter Eisentraut
Update code comments for pg_xlog -> pg_wal Author: Michael Paquier Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4260c05c6d5ffed8f61d97ec26ebadd991a97c14 Modified Files -- src/bin/pg_basebackup/walmethods.c | 4 ++-- src/bin/pg_basebackup/walmethods.h

[COMMITTERS] pgsql: Check for error during PQendcopy.

2017-06-30 Thread Tom Lane
Check for error during PQendcopy. Oversight in commit 78c8c8143; noted while nosing around the walreceiver startup/shutdown code. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/609fa63db6d1e1f2c27a6dd31e9ac8d3b7bcae03 Modified Files -- src/backend/repl

[COMMITTERS] pgsql: Fix walsender to exit promptly if client requests shutdown.

2017-06-30 Thread Tom Lane
Fix walsender to exit promptly if client requests shutdown. It's possible for WalSndWaitForWal to be asked to wait for WAL that doesn't exist yet. That's fine, in fact it's the normal situation if we're caught up; but when the client requests shutdown we should not keep waiting. The previous codi

[COMMITTERS] pgsql: Fix walsender to exit promptly if client requests shutdown.

2017-06-30 Thread Tom Lane
Fix walsender to exit promptly if client requests shutdown. It's possible for WalSndWaitForWal to be asked to wait for WAL that doesn't exist yet. That's fine, in fact it's the normal situation if we're caught up; but when the client requests shutdown we should not keep waiting. The previous codi

[COMMITTERS] pgsql: Fix walsender to exit promptly if client requests shutdown.

2017-06-30 Thread Tom Lane
Fix walsender to exit promptly if client requests shutdown. It's possible for WalSndWaitForWal to be asked to wait for WAL that doesn't exist yet. That's fine, in fact it's the normal situation if we're caught up; but when the client requests shutdown we should not keep waiting. The previous codi

[COMMITTERS] pgsql: Fix walsender to exit promptly if client requests shutdown.

2017-06-30 Thread Tom Lane
Fix walsender to exit promptly if client requests shutdown. It's possible for WalSndWaitForWal to be asked to wait for WAL that doesn't exist yet. That's fine, in fact it's the normal situation if we're caught up; but when the client requests shutdown we should not keep waiting. The previous codi

[COMMITTERS] pgsql: Prohibit creating ICU collation with different ctype

2017-06-30 Thread Peter Eisentraut
Prohibit creating ICU collation with different ctype ICU does not support "collate" and "ctype" being different, so the collctype catalog column is ignored. But for catalog neatness, ensure that they are the same. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/13a

[COMMITTERS] pgsql: Add missing period to comment.

2017-06-30 Thread Robert Haas
Add missing period to comment. Masahiko Sawada Discussion: http://postgr.es/m/cad21aoa0jjxxhqk6ym3jznoudvhxfytkwtttsvsr1vpukcj...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7d4a1838efc5a93ba96b8e0e77f39731603a1f48 Modified Files --

[COMMITTERS] pgsql: Copy collencoding in CREATE COLLATION / FROM

2017-06-30 Thread Peter Eisentraut
Copy collencoding in CREATE COLLATION / FROM This command used to compute the collencoding entry like when a completely new collation is created. But for example when copying the "C" collation, this would then result in a collation that has a collencoding entry for the current database encoding r