[COMMITTERS] pgsql: Fix another race-condition-ish issue in recovery/t/001_stream_re

2017-07-05 Thread Tom Lane
Fix another race-condition-ish issue in recovery/t/001_stream_rep.pl. Buildfarm members hornet and sungazer have shown multiple instances of "Failed test 'xmin of non-cascaded slot with hs feedback has changed'". The reason seems to be that the test is checking the current xmin of the master serve

[COMMITTERS] pgsql: Restore linking libpq into pg_ctl on Mingw builds.

2017-07-05 Thread Tom Lane
Restore linking libpq into pg_ctl on Mingw builds. Commit 1ae853654 missed this. Per Andrew Dunstan. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ff68e909acd924b532e58c7699e93a1aff71654a Modified Files -- src/bin/pg_ctl/Makefile | 12 ++-- 1

Re: [COMMITTERS] pgsql: Ooops, WIN32 code in pg_ctl.c still needs PQExpBuffer.

2017-07-05 Thread Tom Lane
Andrew Dunstan writes: > On 06/28/2017 06:00 PM, Tom Lane wrote: >> Ooops, WIN32 code in pg_ctl.c still needs PQExpBuffer. > Looks to me like we need to put back the Makefile line for WIN32 for > pg_ctl, too. Oh, yuck. Forgot about mingw builds. Will fix. regards, tom

Re: [COMMITTERS] pgsql: Ooops, WIN32 code in pg_ctl.c still needs PQExpBuffer.

2017-07-05 Thread Andrew Dunstan
On 06/28/2017 06:00 PM, Tom Lane wrote: > Ooops, WIN32 code in pg_ctl.c still needs PQExpBuffer. > > Per buildfarm. > Looks to me like we need to put back the Makefile line for WIN32 for pg_ctl, too. cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com PostgreSQL Devel

[COMMITTERS] pgsql: Remove unnecessary pg_is_in_recovery calls in tests

2017-07-05 Thread Peter Eisentraut
Remove unnecessary pg_is_in_recovery calls in tests Since pg_ctl promote already waits for recovery to end, these calls are obsolete. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6deb52b202e0f673b583b03ad141ccad6f8e7fba Modified Files -- src/test/mod

[COMMITTERS] pgsql: pg_ctl: Make failure to complete operation a nonzero exit

2017-07-05 Thread Peter Eisentraut
pg_ctl: Make failure to complete operation a nonzero exit If an operation being waited for does not complete within the timeout, then exit with a nonzero exit status. This was previously handled inconsistently. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1bac5f

[COMMITTERS] pgsql: Fix output of char node fields

2017-07-05 Thread Peter Eisentraut
Fix output of char node fields WRITE_CHAR_FIELD() didn't do any escaping, so that for example a zero byte would cause the whole output string to be truncated. To fix, pass the char through outToken(), so it is escaped like a string. Adjust the reading side to handle this. Branch -- master