Re: [COMMITTERS] pgsql: Improve legibility of numeric literal

2017-07-17 Thread Andrew Dunstan
On 07/17/2017 10:22 PM, Robert Haas wrote: > On Mon, Jul 17, 2017 at 3:36 PM, Andrew Dunstan wrote: >> Improve legibility of numeric literal > Ugh. Are we going to start doing this all the time? Some of the > time? At the whim of whoever was committing? I didn't even know this > was legal sy

Re: [COMMITTERS] pgsql: Improve legibility of numeric literal

2017-07-17 Thread Robert Haas
On Mon, Jul 17, 2017 at 3:36 PM, Andrew Dunstan wrote: > Improve legibility of numeric literal Ugh. Are we going to start doing this all the time? Some of the time? At the whim of whoever was committing? I didn't even know this was legal syntax. -- Robert Haas EnterpriseDB: http://www.enter

[COMMITTERS] pgsql: Reverse-convert row types in ExecWithCheckOptions.

2017-07-17 Thread Robert Haas
Reverse-convert row types in ExecWithCheckOptions. Just as we already do in ExecConstraints, and for the same reason: to improve the quality of error messages. Etsuro Fujita, reviewed by Amit Langote Discussion: http://postgr.es/m/56e0baa8-e458-2bbb-7936-367f7d832...@lab.ntt.co.jp Branch -

[COMMITTERS] pgsql: Use a real RT index when setting up partition tuple routing.

2017-07-17 Thread Robert Haas
Use a real RT index when setting up partition tuple routing. Before, we always used a dummy value of 1, but that's not right when the partitioned table being modified is inside of a WITH clause rather than part of the main query. Amit Langote, reported and reviewd by Etsuro Fujita, with a comment

[COMMITTERS] pgsql: Doc: explain dollar quoting in the intro part of the pl/pgsql ch

2017-07-17 Thread Tom Lane
Doc: explain dollar quoting in the intro part of the pl/pgsql chapter. We're throwing people into the guts of the syntax with not much context; let's back up one step and point out that this goes inside a literal in a CREATE FUNCTION command. Per suggestion from Kurt Kartaltepe. Discussion: htt

[COMMITTERS] pgsql: Doc: explain dollar quoting in the intro part of the pl/pgsql ch

2017-07-17 Thread Tom Lane
Doc: explain dollar quoting in the intro part of the pl/pgsql chapter. We're throwing people into the guts of the syntax with not much context; let's back up one step and point out that this goes inside a literal in a CREATE FUNCTION command. Per suggestion from Kurt Kartaltepe. Discussion: htt

[COMMITTERS] pgsql: Doc: explain dollar quoting in the intro part of the pl/pgsql ch

2017-07-17 Thread Tom Lane
Doc: explain dollar quoting in the intro part of the pl/pgsql chapter. We're throwing people into the guts of the syntax with not much context; let's back up one step and point out that this goes inside a literal in a CREATE FUNCTION command. Per suggestion from Kurt Kartaltepe. Discussion: htt

[COMMITTERS] pgsql: Doc: explain dollar quoting in the intro part of the pl/pgsql ch

2017-07-17 Thread Tom Lane
Doc: explain dollar quoting in the intro part of the pl/pgsql chapter. We're throwing people into the guts of the syntax with not much context; let's back up one step and point out that this goes inside a literal in a CREATE FUNCTION command. Per suggestion from Kurt Kartaltepe. Discussion: htt

[COMMITTERS] pgsql: Doc: explain dollar quoting in the intro part of the pl/pgsql ch

2017-07-17 Thread Tom Lane
Doc: explain dollar quoting in the intro part of the pl/pgsql chapter. We're throwing people into the guts of the syntax with not much context; let's back up one step and point out that this goes inside a literal in a CREATE FUNCTION command. Per suggestion from Kurt Kartaltepe. Discussion: htt

[COMMITTERS] pgsql: Doc: explain dollar quoting in the intro part of the pl/pgsql ch

2017-07-17 Thread Tom Lane
Doc: explain dollar quoting in the intro part of the pl/pgsql chapter. We're throwing people into the guts of the syntax with not much context; let's back up one step and point out that this goes inside a literal in a CREATE FUNCTION command. Per suggestion from Kurt Kartaltepe. Discussion: htt

[COMMITTERS] pgsql: Improve legibility of numeric literal

2017-07-17 Thread Andrew Dunstan
Improve legibility of numeric literal Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cde11fa3c003407fc6c4ddc427d57e588ea17d1c Modified Files -- src/test/perl/PostgresNode.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-commi

[COMMITTERS] pgsql: Merge large_object.sql test into largeobject.source.

2017-07-17 Thread Tom Lane
Merge large_object.sql test into largeobject.source. It seems pretty confusing to have tests named both largeobject and large_object. The latter is of very recent vintage (commit ff992c074), so get rid of it in favor of merging into the former. Also, enable the LO comment test that was added by

[COMMITTERS] pgsql: Merge large_object.sql test into largeobject.source.

2017-07-17 Thread Tom Lane
Merge large_object.sql test into largeobject.source. It seems pretty confusing to have tests named both largeobject and large_object. The latter is of very recent vintage (commit ff992c074), so get rid of it in favor of merging into the former. Also, enable the LO comment test that was added by

[COMMITTERS] pgsql: Merge large_object.sql test into largeobject.source.

2017-07-17 Thread Tom Lane
Merge large_object.sql test into largeobject.source. It seems pretty confusing to have tests named both largeobject and large_object. The latter is of very recent vintage (commit ff992c074), so get rid of it in favor of merging into the former. Also, enable the LO comment test that was added by

[COMMITTERS] pgsql: Merge large_object.sql test into largeobject.source.

2017-07-17 Thread Tom Lane
Merge large_object.sql test into largeobject.source. It seems pretty confusing to have tests named both largeobject and large_object. The latter is of very recent vintage (commit ff992c074), so get rid of it in favor of merging into the former. Also, enable the LO comment test that was added by

[COMMITTERS] pgsql: Merge large_object.sql test into largeobject.source.

2017-07-17 Thread Tom Lane
Merge large_object.sql test into largeobject.source. It seems pretty confusing to have tests named both largeobject and large_object. The latter is of very recent vintage (commit ff992c074), so get rid of it in favor of merging into the former. Also, enable the LO comment test that was added by

[COMMITTERS] pgsql: Merge large_object.sql test into largeobject.source.

2017-07-17 Thread Tom Lane
Merge large_object.sql test into largeobject.source. It seems pretty confusing to have tests named both largeobject and large_object. The latter is of very recent vintage (commit ff992c074), so get rid of it in favor of merging into the former. Also, enable the LO comment test that was added by

[COMMITTERS] pgsql: Use usleep instead of select for timeouts in PostgresNode.pm

2017-07-17 Thread Andrew Dunstan
Use usleep instead of select for timeouts in PostgresNode.pm select() for pure timeouts is not portable, and in particular doesn't work on Windows. Discussion: https://postgr.es/m/186943e0-3405-978d-b19d-9d3335427...@2ndquadrant.com Branch -- master Details --- https://git.postgresql.o

[COMMITTERS] pgsql: hash: Fix write-ahead logging bugs related to init forks.

2017-07-17 Thread Robert Haas
hash: Fix write-ahead logging bugs related to init forks. One, logging for CREATE INDEX was oblivious to the fact that when an unlogged table is created, *only* operations on the init fork should be logged. Two, init fork buffers need to be flushed after they are written; otherwise, a filesystem-