[COMMITTERS] pgsql: Use MINVALUE/MAXVALUE instead of UNBOUNDED for range partition b

2017-07-21 Thread Dean Rasheed
Use MINVALUE/MAXVALUE instead of UNBOUNDED for range partition bounds. Previously, UNBOUNDED meant no lower bound when used in the FROM list, and no upper bound when used in the TO list, which was OK for single-column range partitioning, but problematic with multiple columns. For example, an upper

Re: [COMMITTERS] pgsql: Use MINVALUE/MAXVALUE instead of UNBOUNDED for range partition b

2017-07-21 Thread Dean Rasheed
On 21 July 2017 at 09:24, Dean Rasheed wrote: > Use MINVALUE/MAXVALUE instead of UNBOUNDED for range partition bounds. > Hmm, looks like the buildfarm doesn't like this. It looks like the order of partitions listed by \d+ isn't entirely predictable ... looking into it now. Regards, Dean -- S

[COMMITTERS] pgsql: Make the new partition regression tests locale-independent.

2017-07-21 Thread Dean Rasheed
Make the new partition regression tests locale-independent. The order of partitions listed by \d+ is in general locale-dependent. Rename the partitions in the test added by d363d42bb9 to force them to be listed in a consistent order. Branch -- master Details --- https://git.postgresql.or

[COMMITTERS] pgsql: Fix double shared memory allocation.

2017-07-21 Thread Teodor Sigaev
Fix double shared memory allocation. SLRU buffer lwlocks are allocated twice by oversight in commit fe702a7b3f9f2bc5bf6d173166d7d55226af82c8 where that locks were moved to separate tranche. The bug doesn't have user-visible effects except small overspending of shared memory. Backpatch to 9.6 wher

[COMMITTERS] pgsql: Fix double shared memory allocation.

2017-07-21 Thread Teodor Sigaev
Fix double shared memory allocation. SLRU buffer lwlocks are allocated twice by oversight in commit fe702a7b3f9f2bc5bf6d173166d7d55226af82c8 where that locks were moved to separate tranche. The bug doesn't have user-visible effects except small overspending of shared memory. Backpatch to 9.6 wher

Re: [COMMITTERS] pgsql: Add a Gather executor node.

2017-07-21 Thread Andres Freund
Hi, On 2015-09-30 23:29:30 +, Robert Haas wrote: > Add a Gather executor node. > ... > src/backend/executor/execProcnode.c | 46 I just noticed that this added a new execProcnode dispatch routine, but didn't add that to the file's header * INTERFACE ROUTINES *

[COMMITTERS] pgsql: Re-establish postgres_fdw connections after server or user mappi

2017-07-21 Thread Tom Lane
Re-establish postgres_fdw connections after server or user mapping changes. Previously, postgres_fdw would keep on using an existing connection even if the user did ALTER SERVER or ALTER USER MAPPING commands that should affect connection parameters. Teach it to watch for catcache invals on these

[COMMITTERS] pgsql: Re-establish postgres_fdw connections after server or user mappi

2017-07-21 Thread Tom Lane
Re-establish postgres_fdw connections after server or user mapping changes. Previously, postgres_fdw would keep on using an existing connection even if the user did ALTER SERVER or ALTER USER MAPPING commands that should affect connection parameters. Teach it to watch for catcache invals on these

[COMMITTERS] pgsql: Re-establish postgres_fdw connections after server or user mappi

2017-07-21 Thread Tom Lane
Re-establish postgres_fdw connections after server or user mapping changes. Previously, postgres_fdw would keep on using an existing connection even if the user did ALTER SERVER or ALTER USER MAPPING commands that should affect connection parameters. Teach it to watch for catcache invals on these

[COMMITTERS] pgsql: Re-establish postgres_fdw connections after server or user mappi

2017-07-21 Thread Tom Lane
Re-establish postgres_fdw connections after server or user mapping changes. Previously, postgres_fdw would keep on using an existing connection even if the user did ALTER SERVER or ALTER USER MAPPING commands that should affect connection parameters. Teach it to watch for catcache invals on these

[COMMITTERS] pgsql: Re-establish postgres_fdw connections after server or user mappi

2017-07-21 Thread Tom Lane
Re-establish postgres_fdw connections after server or user mapping changes. Previously, postgres_fdw would keep on using an existing connection even if the user did ALTER SERVER or ALTER USER MAPPING commands that should affect connection parameters. Teach it to watch for catcache invals on these

[COMMITTERS] pgsql: pg_rewind: Fix busted sanity check.

2017-07-21 Thread Robert Haas
pg_rewind: Fix busted sanity check. As written, the code would only fail the sanity check if none of the columns returned by the server were of the expected type, but we want it to fail if even one column is not of the expected type. Discussion: http://postgr.es/m/CA+TgmoYuY5zW7JEs+1hSS1D=V5K8h1

[COMMITTERS] pgsql: pg_rewind: Fix busted sanity check.

2017-07-21 Thread Robert Haas
pg_rewind: Fix busted sanity check. As written, the code would only fail the sanity check if none of the columns returned by the server were of the expected type, but we want it to fail if even one column is not of the expected type. Discussion: http://postgr.es/m/CA+TgmoYuY5zW7JEs+1hSS1D=V5K8h1

[COMMITTERS] pgsql: pg_rewind: Fix busted sanity check.

2017-07-21 Thread Robert Haas
pg_rewind: Fix busted sanity check. As written, the code would only fail the sanity check if none of the columns returned by the server were of the expected type, but we want it to fail if even one column is not of the expected type. Discussion: http://postgr.es/m/CA+TgmoYuY5zW7JEs+1hSS1D=V5K8h1

[COMMITTERS] pgsql: Stabilize postgres_fdw regression tests.

2017-07-21 Thread Tom Lane
Stabilize postgres_fdw regression tests. The new test cases added in commit 8bf58c0d9 turn out to have output that can vary depending on the lc_messages setting prevailing on the test server. Hide the remote end's error messages to ensure stable output. This isn't a terribly desirable solution;

[COMMITTERS] pgsql: Stabilize postgres_fdw regression tests.

2017-07-21 Thread Tom Lane
Stabilize postgres_fdw regression tests. The new test cases added in commit 8bf58c0d9 turn out to have output that can vary depending on the lc_messages setting prevailing on the test server. Hide the remote end's error messages to ensure stable output. This isn't a terribly desirable solution;

[COMMITTERS] pgsql: Stabilize postgres_fdw regression tests.

2017-07-21 Thread Tom Lane
Stabilize postgres_fdw regression tests. The new test cases added in commit 8bf58c0d9 turn out to have output that can vary depending on the lc_messages setting prevailing on the test server. Hide the remote end's error messages to ensure stable output. This isn't a terribly desirable solution;

[COMMITTERS] pgsql: Stabilize postgres_fdw regression tests.

2017-07-21 Thread Tom Lane
Stabilize postgres_fdw regression tests. The new test cases added in commit 8bf58c0d9 turn out to have output that can vary depending on the lc_messages setting prevailing on the test server. Hide the remote end's error messages to ensure stable output. This isn't a terribly desirable solution;

[COMMITTERS] pgsql: Stabilize postgres_fdw regression tests.

2017-07-21 Thread Tom Lane
Stabilize postgres_fdw regression tests. The new test cases added in commit 8bf58c0d9 turn out to have output that can vary depending on the lc_messages setting prevailing on the test server. Hide the remote end's error messages to ensure stable output. This isn't a terribly desirable solution;

[COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.

2017-07-21 Thread Robert Haas
pg_rewind: Fix some problems when copying files >2GB. When incrementally updating a file larger than 2GB, the old code could either fail outright (if the client asked the server for bytes beyond the 2GB boundary) or fail to copy all the blocks that had actually been modified (if the server reporte

[COMMITTERS] pgsql: Doc: update versioning information in libpq.sgml.

2017-07-21 Thread Tom Lane
Doc: update versioning information in libpq.sgml. The descriptions of PQserverVersion and PQlibVersion hadn't been updated for the new two-part version-numbering approach. Fix that. In passing, remove some trailing whitespace elsewhere in the file. Branch -- master Details --- https://

[COMMITTERS] pgsql: Fix typo in comment

2017-07-21 Thread Alvaro Herrera
Fix typo in comment Commit fd31cd265138 renamed the variable to skipping_blocks, but forgot to update this comment. Noticed while inspecting code. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/de38489b926e3e5af84f22cf4788fe4498e13c72 Modified Files -

[COMMITTERS] pgsql: Fix typo in comment

2017-07-21 Thread Alvaro Herrera
Fix typo in comment Commit fd31cd265138 renamed the variable to skipping_blocks, but forgot to update this comment. Noticed while inspecting code. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/afd56b8521c562f7ed20d04159aa597516d74bf5 Modified Files --

[COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.

2017-07-21 Thread Robert Haas
pg_rewind: Fix some problems when copying files >2GB. When incrementally updating a file larger than 2GB, the old code could either fail outright (if the client asked the server for bytes beyond the 2GB boundary) or fail to copy all the blocks that had actually been modified (if the server reporte

[COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.

2017-07-21 Thread Robert Haas
pg_rewind: Fix some problems when copying files >2GB. When incrementally updating a file larger than 2GB, the old code could either fail outright (if the client asked the server for bytes beyond the 2GB boundary) or fail to copy all the blocks that had actually been modified (if the server reporte