[COMMITTERS] pgsql: Make PostgresNode easily subclassable

2017-07-25 Thread Alvaro Herrera
Make PostgresNode easily subclassable This module becomes much more useful if we allow it to be used as base class for external projects. To achieve this, change the exported get_new_node function into a class method instead, and use the standard Perl idiom of accepting the class as first argumen

[COMMITTERS] pgsql: Make PostgresNode easily subclassable

2017-07-25 Thread Alvaro Herrera
Make PostgresNode easily subclassable This module becomes much more useful if we allow it to be used as base class for external projects. To achieve this, change the exported get_new_node function into a class method instead, and use the standard Perl idiom of accepting the class as first argumen

[COMMITTERS] pgsql: Fix race conditions in replication slot operations

2017-07-25 Thread Alvaro Herrera
Fix race conditions in replication slot operations It is relatively easy to get a replication slot to look as still active while one process is in the process of getting rid of it; when some other process tries to "acquire" the slot, it would fail with an error message of "replication slot XYZ is