[COMMITTERS] pgsql: Remove uses of "slave" in replication contexts

2017-08-10 Thread Peter Eisentraut
Remove uses of "slave" in replication contexts This affects mostly code comments, some documentation, and tests. Official APIs already used "standby". Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a1ef920e27ba6ab3602aaf6d6751d8628fac1af8 Modified Files --

[COMMITTERS] pgsql: Reject use of ucol_strcollUTF8() before ICU 53

2017-08-10 Thread Peter Eisentraut
Reject use of ucol_strcollUTF8() before ICU 53 Various bugs can cause crashes, so don't use that function before ICU 53. It will fall back to the code path used for other encodings. Since we now tie the function availability to an ICU version, we don't need the configure test anymore. That also

[COMMITTERS] pgsql: Fix order of ICU_CFLAGS

2017-08-10 Thread Peter Eisentraut
Fix order of ICU_CFLAGS It must be before CPPFLAGS so that an ICU installation in a nonstandard path can take precedence over one in the system path. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b83e54564ad0733f5382b20c04695ee9fb4cf451 Modified Files ---

[COMMITTERS] pgsql: Improve the error message when creating an empty range partition

2017-08-10 Thread Robert Haas
Improve the error message when creating an empty range partition. The previous message didn't mention the name of the table or the bounds. Put the table name in the primary error message and the bounds in the detail message. Amit Langote, changed slightly by me. Suggestions on the exac phrasing

[COMMITTERS] pgsql: Make some more improvements to parallel query documentation.

2017-08-10 Thread Robert Haas
Make some more improvements to parallel query documentation. Many places that mentioned only Gather should also mention Gather Merge, or should be phrased in a more neutral way. Be more clear about the fact that max_parallel_workers_per_gather affects the number of workers the planner may want to

[COMMITTERS] pgsql: Fix typo in comment.

2017-08-10 Thread Robert Haas
Fix typo in comment. Etsuro Fujita Discussion: http://postgr.es/m/5f794b91-67df-1ac6-8a4f-069f8e8e1...@lab.ntt.co.jp Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e694010758772da1ac0f3355027fad0e47da4465 Modified Files -- src/include/nodes/plannodes

[COMMITTERS] pgsql: pgstatindex: Insert some casts to prevent overflow.

2017-08-10 Thread Robert Haas
pgstatindex: Insert some casts to prevent overflow. This could cause hash indexes to report greater than 100% free space. Ashutosh Sharma, reviewed by Amit Kapila Discussion: http://postgr.es/m/CAE9k0PnCKfg-ZK1CwGZJPF1yKcG2A=gugc3bmdnmzlaxvoo...@mail.gmail.com Branch -- master Details ---

[COMMITTERS] pgsql: Remove incorrect assertion in clog.c

2017-08-10 Thread Robert Haas
Remove incorrect assertion in clog.c We must advance the oldest XID that can be safely looked up in clog *before* truncating CLOG, and the oldest XID that can't be reused *after* truncating CLOG. This assertion, and the accompanying comment, are confused; remove them. Reported by Neha Sharma. D

[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options. Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make pg_user_mappings enforce the qualifications user_mapping_options had been enforcing, but its removal of a longstanding restriction left them distinct when the cu

[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options. Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make pg_user_mappings enforce the qualifications user_mapping_options had been enforcing, but its removal of a longstanding restriction left them distinct when the cu

[COMMITTERS] pgsql: Don't allow logging in with empty password.

2017-08-10 Thread Heikki Linnakangas
Don't allow logging in with empty password. Some authentication methods allowed it, others did not. In the client-side, libpq does not even try to authenticate with an empty password, which makes using empty passwords hazardous: an administrator might think that an account with an empty password c

[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options. Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make pg_user_mappings enforce the qualifications user_mapping_options had been enforcing, but its removal of a longstanding restriction left them distinct when the cu

[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options. Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make pg_user_mappings enforce the qualifications user_mapping_options had been enforcing, but its removal of a longstanding restriction left them distinct when the cu

[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options. Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make pg_user_mappings enforce the qualifications user_mapping_options had been enforcing, but its removal of a longstanding restriction left them distinct when the cu

[COMMITTERS] pgsql: Require update permission for the large object written by lo_put

2017-08-10 Thread Tom Lane
Require update permission for the large object written by lo_put(). lo_put() surely should require UPDATE permission, the same as lowrite(), but it failed to check for that, as reported by Chapman Flack. Oversight in commit c50b7c09d; backpatch to 9.4 where that was introduced. Tom Lane and Mich

[COMMITTERS] pgsql: Last-minute updates for release notes.

2017-08-10 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2017-7546, CVE-2017-7547, CVE-2017-7548 Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5bb8162e45e3604a0f29825f792594f6ab2a7973 Modified Files -- doc/src/sgml/release-9.2.sgml | 199 ++

[COMMITTERS] pgsql: Last-minute updates for release notes.

2017-08-10 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2017-7546, CVE-2017-7547, CVE-2017-7548 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/16f4297d1dc892eb55b384eb0a11543287138de3 Modified Files -- doc/src/sgml/release-9.2.sgml | 199 ++

[COMMITTERS] pgsql: Require update permission for the large object written by lo_put

2017-08-10 Thread Tom Lane
Require update permission for the large object written by lo_put(). lo_put() surely should require UPDATE permission, the same as lowrite(), but it failed to check for that, as reported by Chapman Flack. Oversight in commit c50b7c09d; backpatch to 9.4 where that was introduced. Tom Lane and Mich

[COMMITTERS] pgsql: Require update permission for the large object written by lo_put

2017-08-10 Thread Tom Lane
Require update permission for the large object written by lo_put(). lo_put() surely should require UPDATE permission, the same as lowrite(), but it failed to check for that, as reported by Chapman Flack. Oversight in commit c50b7c09d; backpatch to 9.4 where that was introduced. Tom Lane and Mich

[COMMITTERS] pgsql: Don't allow logging in with empty password.

2017-08-10 Thread Heikki Linnakangas
Don't allow logging in with empty password. Some authentication methods allowed it, others did not. In the client-side, libpq does not even try to authenticate with an empty password, which makes using empty passwords hazardous: an administrator might think that an account with an empty password c

[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options. Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make pg_user_mappings enforce the qualifications user_mapping_options had been enforcing, but its removal of a longstanding restriction left them distinct when the cu

[COMMITTERS] pgsql: Last-minute updates for release notes.

2017-08-10 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2017-7546, CVE-2017-7547, CVE-2017-7548 Branch -- REL9_2_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e28b2b094319e007b53ba384bb114c3f0b775a05 Modified Files -- doc/src/sgml/release-9.2.sgml | 199 ++

[COMMITTERS] pgsql: Last-minute updates for release notes.

2017-08-10 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2017-7546, CVE-2017-7547, CVE-2017-7548 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a8b37ebe407f1916c5df22452cdbb1d00e2a409d Modified Files -- doc/src/sgml/release-9.2.sgml | 199 +

[COMMITTERS] pgsql: Last-minute updates for release notes.

2017-08-10 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2017-7546, CVE-2017-7547, CVE-2017-7548 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/57b995a9a4650cd294e1017946af54aabbbfe146 Modified Files -- doc/src/sgml/release-9.2.sgml | 199 ++

[COMMITTERS] pgsql: Last-minute updates for release notes.

2017-08-10 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2017-7546, CVE-2017-7547, CVE-2017-7548 Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d64440f5fb7483faeb5fc1c9822e1ad2e0b555e2 Modified Files -- doc/src/sgml/release-9.2.sgml | 199 ++

[COMMITTERS] pgsql: Don't allow logging in with empty password.

2017-08-10 Thread Heikki Linnakangas
Don't allow logging in with empty password. Some authentication methods allowed it, others did not. In the client-side, libpq does not even try to authenticate with an empty password, which makes using empty passwords hazardous: an administrator might think that an account with an empty password c

[COMMITTERS] pgsql: Don't allow logging in with empty password.

2017-08-10 Thread Heikki Linnakangas
Don't allow logging in with empty password. Some authentication methods allowed it, others did not. In the client-side, libpq does not even try to authenticate with an empty password, which makes using empty passwords hazardous: an administrator might think that an account with an empty password c

[COMMITTERS] pgsql: Don't allow logging in with empty password.

2017-08-10 Thread Heikki Linnakangas
Don't allow logging in with empty password. Some authentication methods allowed it, others did not. In the client-side, libpq does not even try to authenticate with an empty password, which makes using empty passwords hazardous: an administrator might think that an account with an empty password c

[COMMITTERS] pgsql: Require update permission for the large object written by lo_put

2017-08-10 Thread Tom Lane
Require update permission for the large object written by lo_put(). lo_put() surely should require UPDATE permission, the same as lowrite(), but it failed to check for that, as reported by Chapman Flack. Oversight in commit c50b7c09d; backpatch to 9.4 where that was introduced. Tom Lane and Mich

[COMMITTERS] pgsql: Don't allow logging in with empty password.

2017-08-10 Thread Heikki Linnakangas
Don't allow logging in with empty password. Some authentication methods allowed it, others did not. In the client-side, libpq does not even try to authenticate with an empty password, which makes using empty passwords hazardous: an administrator might think that an account with an empty password c