Re: [COMMITTERS] pgsql: Remove endof macro

2017-09-06 Thread Peter Eisentraut
On 9/5/17 15:10, Andres Freund wrote: > On 2017-09-05 19:08:06 +, Peter Eisentraut wrote: >> Remove endof macro >> >> It has not been used in a long time, and it doesn't seem safe anyway, so >> drop it. > > I've no problem removing this, but why isn't it safe? It's explicitly > allowed to comp

[COMMITTERS] pgsql: Sync function prototype with its actual definition.

2017-09-06 Thread Tom Lane
Sync function prototype with its actual definition. Use the same parameter names as in the definition. Cosmetic fix only. Tatsuro Yamada Discussion: https://postgr.es/m/58e711af.7070...@lab.ntt.co.jp Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/793a89c1966733c

[COMMITTERS] pgsql: Merge duplicative code for \sf/\sv, \ef/\ev in psql/command.c.

2017-09-06 Thread Tom Lane
Merge duplicative code for \sf/\sv, \ef/\ev in psql/command.c. Saves ~150 lines, costs little. Fabien Coelho, reviewed by Victor Drobny Discussion: https://postgr.es/m/alpine.DEB.2.20.1703311958001.14355@lancre Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ca4e2

[COMMITTERS] pgsql: Allow SET STATISTICS on expression indexes

2017-09-06 Thread Simon Riggs
Allow SET STATISTICS on expression indexes Index columns are referenced by ordinal number rather than name, e.g. CREATE INDEX coord_idx ON measured (x, y, (z + t)); ALTER INDEX coord_idx ALTER COLUMN 3 SET STATISTICS 1000; Incompatibility note for release notes: \d+ for indexes now also displays

[COMMITTERS] pgsql: Use more of gcc's __sync_fetch_and_xxx builtin functions for ato

2017-09-06 Thread Tom Lane
Use more of gcc's __sync_fetch_and_xxx builtin functions for atomic ops. In addition to __sync_fetch_and_add, gcc offers __sync_fetch_and_sub, __sync_fetch_and_and, and __sync_fetch_and_or, which correspond directly to primitive atomic ops that we want. Testing shows that in some cases they gener

[COMMITTERS] pgsql: Remove duplicate reads from the inner loops in generic atomic op

2017-09-06 Thread Tom Lane
Remove duplicate reads from the inner loops in generic atomic ops. The pg_atomic_compare_exchange_xxx functions are defined to update *expected to whatever they read from the target variable. Therefore, there's no need to do additional explicit reads after we've initialized the "old" variable. T

[COMMITTERS] pgsql: doc: Make function synopsis formatting more uniform

2017-09-06 Thread Peter Eisentraut
doc: Make function synopsis formatting more uniform Whitespace use was inconsistent in the same chapter. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/34ae182833a4f69ad5d93f06588665a918ee5b03 Modified Files -- doc/src/sgml/fdwhandler.sgml | 177 ++

[COMMITTERS] pgsql: Add psql variables showing server version and psql version.

2017-09-06 Thread Tom Lane
Add psql variables showing server version and psql version. We already had a psql variable VERSION that shows the verbose form of psql's own version. Add VERSION_NAME to show the short form (e.g., "11devel") and VERSION_NUM to show the numeric form (e.g., 11). Also add SERVER_VERSION_NAME and

[COMMITTERS] pgsql: Escape < and & in SGML

2017-09-06 Thread Peter Eisentraut
Escape < and & in SGML This is not required in SGML, but will be in XML, so this is a step to prepare for the conversion to XML. (It is still not required to escape >, but we did it here in some cases for symmetry.) Add a command-line option to osx/onsgmls calls to warn about unescaped occurrenc

[COMMITTERS] pgsql: Clean up handling of dropped columns in NAMEDTUPLESTORE RTEs.

2017-09-06 Thread Tom Lane
Clean up handling of dropped columns in NAMEDTUPLESTORE RTEs. The NAMEDTUPLESTORE patch piggybacked on the infrastructure for TABLEFUNC/VALUES/CTE RTEs, none of which can ever have dropped columns, so the possibility was ignored most places. Fix that, including adding a specification to parsenode

[COMMITTERS] pgsql: Clean up handling of dropped columns in NAMEDTUPLESTORE RTEs.

2017-09-06 Thread Tom Lane
Clean up handling of dropped columns in NAMEDTUPLESTORE RTEs. The NAMEDTUPLESTORE patch piggybacked on the infrastructure for TABLEFUNC/VALUES/CTE RTEs, none of which can ever have dropped columns, so the possibility was ignored most places. Fix that, including adding a specification to parsenode