On Fri, Sep 15, 2017 at 4:59 PM, Tom Lane wrote:
> Looks like force_parallel_mode might be the key to causing that.
Yeah. The regress tests in d36f7efb39e1b9613193b2e12717dbe2418ddae5
tested this stuff in parallel mode, but only a happy case to
demonstrate blessed RECORD types travelling through
Thomas Munro writes:
> Rebased on your fix.
Ah, yet a different issue :-(. Pushed that too.
> Investigating the runtime failure...
Looks like force_parallel_mode might be the key to causing that.
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-com
Don't use anonymous unions.
Commit cc5f81366c36b3dd8f02bd9be1cf75b2cc8482bd introduced a language
feature that is not acceptable to strict C89 compilers.
Thomas Munro
Per buildfarm.
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/eaa4070543c2e36f0521f831d051265139
Thomas Munro writes:
> Sorry about that -- clearly I need to test my patches on more compilers
> in future.
Don't sweat about it too much, this is exactly what the buildfarm is for.
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresq
On Fri, Sep 15, 2017 at 4:34 PM, Thomas Munro
wrote:
> Here's a version that just forward declares SharedRecordTypmodRegistry
> in session.h (but keeps the typedef in typcache.h where it is useful
> for shorter function prototypes). Neither GCC 6 -Wall -std=c89 not
> Clang -Wall -std=c89 complain
On Fri, Sep 15, 2017 at 3:45 PM, Tom Lane wrote:
> Thomas Munro writes:
>> My compiler, C++ and more recent C standards are OK with identical
>> redefinition of a typedef like that, but not the older standards or
>> those particular compilers. D'oh. (I should figure out how to make
>> my automa
Andres Freund writes:
> Sorry for missing that during review - unfortunately I don't have a computer
> with me now - so I won't get around to this till tomorrow...
It turns out that this breaks my local build, too, so I went ahead and
pushed a fix.
At least two buildfarm members think there's s
Avoid duplicate typedef for SharedRecordTypmodRegistry.
This isn't our usual solution for such problems, and older compilers
(not terribly old, either) don't like it.
Per buildfarm and local testing.
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/fba366555659fc1dc
On September 14, 2017 8:38:09 PM PDT, Thomas Munro
wrote:
>On Fri, Sep 15, 2017 at 3:18 PM, Tom Lane wrote:
>> Andres Freund writes:
>>> Add support for coordinating record typmods among parallel workers.
>>
>> Buildfarm not happy ...
>
>My compiler, C++ and more recent C standards are OK wit
Thomas Munro writes:
> My compiler, C++ and more recent C standards are OK with identical
> redefinition of a typedef like that, but not the older standards or
> those particular compilers. D'oh. (I should figure out how to make
> my automatic patch tester this fussy). I think we should probabl
On Fri, Sep 15, 2017 at 3:18 PM, Tom Lane wrote:
> Andres Freund writes:
>> Add support for coordinating record typmods among parallel workers.
>
> Buildfarm not happy ...
My compiler, C++ and more recent C standards are OK with identical
redefinition of a typedef like that, but not the older st
Andres Freund writes:
> Add support for coordinating record typmods among parallel workers.
Buildfarm not happy ...
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql
Add support for coordinating record typmods among parallel workers.
Tuples can have type RECORDOID and a typmod number that identifies a blessed
TupleDesc in a backend-private cache. To support the sharing of such tuples
through shared memory and temporary files, provide a typmod registry in
shar
Remove TupleDesc remapping logic from tqueue.c.
With the introduction of a shared memory record typmod registry, it is no
longer necessary to remap record typmods when sending tuples between backends
so most of tqueue.c can be removed.
Author: Thomas Munro
Reviewed-By: Andres Freund
Discussion:
chkpass: Add test suite
Reviewed-by: David Steele
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/8423bf4f25ecd7afdd1d89adfbf29ea28992678f
Modified Files
--
contrib/chkpass/.gitignore | 4
contrib/chkpass/Makefile | 2 ++
con
adminpack: Add test suite
Reviewed-by: David Steele
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/b28dfa6d6f4e9a7a518d3c22b28375cad8a22272
Modified Files
--
contrib/adminpack/.gitignore | 4 +
contrib/adminpack/Makefile |
fuzzystrmatch: Add test suite
Reviewed-by: David Steele
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/6141123a827a47d02b8b6c8eb97643c33aa4461d
Modified Files
--
contrib/fuzzystrmatch/.gitignore | 4 ++
contrib/fuzzystrmatch/Makefile
passwordcheck: Add test suite
Also improve one error message.
Reviewed-by: David Steele
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/af7211e92dc2bba66f90de9e5bea6ae5fa914c61
Modified Files
--
contrib/passwordcheck/.gitignore | 4 ++
pg_archivecleanup: Add test suite
Reviewed-by: David Steele
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/98470fdfa72b78ec49dea9a25e658876e6e51989
Modified Files
--
src/bin/pg_archivecleanup/.gitignore | 2 +
src/bin/pg_archivecleanup/M
isn: Fix debug code
The ISN_DEBUG code did not compile. Fix that code, don't hide it behind
an #ifdef, make it run when building with asserts, and make it error out
instead of just logging if it fails.
Reviewed-by: David Steele
Branch
--
master
Details
---
https://git.postgresql.org/p
lo: Add test suite
Reviewed-by: David Steele
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/4cb89d830626d009ed6a4482bed3a141c5039a7c
Modified Files
--
contrib/lo/.gitignore | 4
contrib/lo/Makefile| 2 ++
contrib/lo/expected/lo.out |
Add missing tags to GetCommandLogLevel.
Otherwise, log_statement = 'ddl' causes errors if those statement
types are used.
Michael Paquier, reviewed by Ashutosh Sharma
Discussion:
http://postgr.es/m/cab7npqstc3hke76q1mnhsvd1vf1td9zxapzyadzdmylmrkk...@mail.gmail.com
Branch
--
master
Details
Add missing tags to GetCommandLogLevel.
Otherwise, log_statement = 'ddl' causes errors if those statement
types are used.
Michael Paquier, reviewed by Ashutosh Sharma
Discussion:
http://postgr.es/m/cab7npqstc3hke76q1mnhsvd1vf1td9zxapzyadzdmylmrkk...@mail.gmail.com
Branch
--
REL_10_STABLE
Add missing tags to GetCommandLogLevel.
Otherwise, log_statement = 'ddl' causes errors if those statement
types are used.
Michael Paquier, reviewed by Ashutosh Sharma
Discussion:
http://postgr.es/m/cab7npqstc3hke76q1mnhsvd1vf1td9zxapzyadzdmylmrkk...@mail.gmail.com
Branch
--
REL9_6_STABLE
Perform only one ReadControlFile() during startup.
Previously we read the control file in multiple places. But soon the
segment size will be configurable and stored in the control file, and
that needs to be available earlier than it currently is needed.
Instead of adding yet another place where i
Expand partitioned table RTEs level by level, without flattening.
Flattening the partitioning hierarchy at this stage makes various
desirable optimizations difficult. The original use case for this
patch was partition-wise join, which wants to match up the partitions
in one partitioning hierarchy
Avoid use of bool in thread_test.c
It's not necessary for such a small program, and it causes unnecessary
extra work to get the correct definition of bool, more so if we are
going to introduce stdbool.h later.
Reviewed-by: Thomas Munro
Branch
--
master
Details
---
https://git.postgresq
Make RelationGetPartitionDispatchInfo expand depth-first.
With this change, the order of leaf partitions as returned by
RelationGetPartitionDispatchInfo should now be the same as the
order used by expand_inherited_rtentry. This will make it simpler
for future patches to match up the partition dis
Fix bool/int type confusion
Using ++ on a bool variable doesn't work well when stdbool.h is in use.
The original BSD code appears to use int here, so use that instead.
Reviewed-by: Thomas Munro
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/0ec2e908babfbfde83a392
Remove BoolPtr type
Not used and doesn't seem useful.
Reviewed-by: Thomas Munro
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/8951c65df2701a4620ea43f12b9fbabdb653c164
Modified Files
--
src/include/c.h | 2 --
1 file changed, 2 deletions(-)
--
Sent
Fix inconsistent capitalization.
Amit Langote
Discussion:
http://postgr.es/m/a83a0899-19f5-594c-9aac-3ba0f1698...@lab.ntt.co.jp
Branch
--
REL_10_STABLE
Details
---
https://git.postgresql.org/pg/commitdiff/29f021160ea7bfbc02600e651cf3588bb4ce8e78
Modified Files
--
src/backe
Fix inconsistent capitalization.
Amit Langote
Discussion:
http://postgr.es/m/a83a0899-19f5-594c-9aac-3ba0f1698...@lab.ntt.co.jp
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/42651bdd68a123544d5bfd0773a170aa3b443f1b
Modified Files
--
src/backend/comm
Set partitioned_rels appropriately when UNION ALL is used.
In most cases, this omission won't matter, because the appropriate
locks will have been acquired during parse/plan or by AcquireExecutorLocks.
But it's a bug all the same.
Report by Ashutosh Bapat. Patch by me, reviewed by Amit Langote.
Set partitioned_rels appropriately when UNION ALL is used.
In most cases, this omission won't matter, because the appropriate
locks will have been acquired during parse/plan or by AcquireExecutorLocks.
But it's a bug all the same.
Report by Ashutosh Bapat. Patch by me, reviewed by Amit Langote.
Properly check interrupts in execScan.c.
During the development of d47cfef711 the CFI()s in ExecScan() were
moved back and forth, ending up in the wrong place. Thus queries that
largely spend their time in ExecScan(), and have neither projection
nor a qual, can't be cancelled in a timely manner.
Properly check interrupts in execScan.c.
During the development of d47cfef711 the CFI()s in ExecScan() were
moved back and forth, ending up in the wrong place. Thus queries that
largely spend their time in ExecScan(), and have neither projection
nor a qual, can't be cancelled in a timely manner.
36 matches
Mail list logo
