Re: [COMMITTERS] pgsql: Add test for postmaster crash restarts.

2017-09-18 Thread Andres Freund
On September 18, 2017 8:55:35 PM PDT, Tom Lane wrote: >Andres Freund writes: >> Add test for postmaster crash restarts. > >Hm, calliphoridae doesn't like this. Yea. Not clear to me why yet. The machine ran a number of instances with nearly the same config successfully. Can't imagine that copy

Re: [COMMITTERS] pgsql: Add test for postmaster crash restarts.

2017-09-18 Thread Tom Lane
Andres Freund writes: > Add test for postmaster crash restarts. Hm, calliphoridae doesn't like this. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/p

[COMMITTERS] pgsql: Rearm statement_timeout after each executed query.

2017-09-18 Thread Andres Freund
Rearm statement_timeout after each executed query. Previously statement_timeout, in the extended protocol, affected all messages till a Sync message. For clients that pipeline/batch query execution that's problematic. Instead disable timeout after each Execute message, and enable, if necessary,

[COMMITTERS] pgsql: Fix uninitialized variable in dshash.c.

2017-09-18 Thread Andres Freund
Fix uninitialized variable in dshash.c. A bugfix for commit 8c0d7bafad36434cb08ac2c78e69ae72c194ca20. The code would have crashed if hashtable->size_log2 ever had the same value as hashtable->control->size_log2 by coincidence. Per Valgrind. Author: Thomas Munro Reported-By: Tomas Vondra Discuss

[COMMITTERS] pgsql: Add test for postmaster crash restarts.

2017-09-18 Thread Andres Freund
Add test for postmaster crash restarts. Given that I managed to break this... We probably should extend the tests to also cover other sub-processes dying, but that's something for later. Author: Andres Freund Discussion: https://postgr.es/m/20170917080752.rcmihzfmgbeuq...@alap3.anarazel.de Bra

[COMMITTERS] pgsql: Fix crash restart bug introduced in 8356753c212.

2017-09-18 Thread Andres Freund
Fix crash restart bug introduced in 8356753c212. The bug was caused by not re-reading the control file during crash recovery restarts, which lead to an attempt to pfree() shared memory contents. The fix is to re-read the control file, which seems good anyway. It's unclear as of this moment, wheth

[COMMITTERS] pgsql: Stamp 10rc1.

2017-09-18 Thread Tom Lane
Stamp 10rc1. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/dc28213c3e0b8f2b71d75bb8c779b9dd0fce5670 Modified Files -- configure | 18 +- configure.in | 2 +- doc/bug.template | 2

[COMMITTERS] pgsql: Fixed ECPG to correctly handle out-of-scope cursor declarations

2017-09-18 Thread Michael Meskes
Fixed ECPG to correctly handle out-of-scope cursor declarations with pointers or array variables. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3a5aa7de311788d9f5ae2fb235801738ae888b50 Modified Files -- src/interfaces/ecpg/preproc/ecpg.header |

[COMMITTERS] pgsql: Fixed ECPG to correctly handle out-of-scope cursor declarations

2017-09-18 Thread Michael Meskes
Fixed ECPG to correctly handle out-of-scope cursor declarations with pointers or array variables. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/59b5a3e5c72e4b91876df226eab09dc97c6e190e Modified Files -- src/interfaces/ecpg/preproc/ecpg.header |

[COMMITTERS] pgsql: Fixed ECPG to correctly handle out-of-scope cursor declarations

2017-09-18 Thread Michael Meskes
Fixed ECPG to correctly handle out-of-scope cursor declarations with pointers or array variables. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/75fbf8ad1209e3711704dd6194926a2d60a8d849 Modified Files -- src/interfaces/ecpg/preproc/ecpg.header |

[COMMITTERS] pgsql: Fixed ECPG to correctly handle out-of-scope cursor declarations

2017-09-18 Thread Michael Meskes
Fixed ECPG to correctly handle out-of-scope cursor declarations with pointers or array variables. Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/149cfdb3a2e9969cbadc1d6b5bfee88f974086f4 Modified Files -- src/interfaces/ecpg/preproc/ecpg.header |

[COMMITTERS] pgsql: Fixed ECPG to correctly handle out-of-scope cursor declarations

2017-09-18 Thread Michael Meskes
Fixed ECPG to correctly handle out-of-scope cursor declarations with pointers or array variables. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e5b8b771e7a98e3620679cd9873ad2507ab87fb5 Modified Files -- src/interfaces/ecpg/preproc/ecpg.header |

[COMMITTERS] pgsql: Minor code-cleanliness improvements for btree.

2017-09-18 Thread Tom Lane
Minor code-cleanliness improvements for btree. Make the btree page-flags test macros (P_ISLEAF and friends) return clean boolean values, rather than values that might not fit in a bool. Use them in a few places that were randomly referencing the flag bits directly. In passing, change access/nbtr

[COMMITTERS] pgsql: Make ExplainOpenGroup and ExplainCloseGroup public.

2017-09-18 Thread Tom Lane
Make ExplainOpenGroup and ExplainCloseGroup public. Extensions with custom plan nodes might like to use these in their EXPLAIN output. Hadi Moshayedi Discussion: https://postgr.es/m/CA+_kT_dU-rHCN0u6pjA6bN5CZniMfD=-wvqpy4qlrkuy_uj...@mail.gmail.com Branch -- master Details --- https:/

[COMMITTERS] pgsql: Make DatumGetFoo/PG_GETARG_FOO/PG_RETURN_FOO macro names more co

2017-09-18 Thread Tom Lane
Make DatumGetFoo/PG_GETARG_FOO/PG_RETURN_FOO macro names more consistent. By project convention, these names should include "P" when dealing with a pointer type; that is, if the result of a GETARG macro is of type FOO *, it should be called PG_GETARG_FOO_P not just PG_GETARG_FOO. Some newer types

[COMMITTERS] pgsql: Fix, or at least ameliorate, bugs in logicalrep_worker_launch().

2017-09-18 Thread Tom Lane
Fix, or at least ameliorate, bugs in logicalrep_worker_launch(). If we failed to get a background worker slot, the code just walked away from the logicalrep-worker slot it already had, leaving that looking like the worker is still starting up. This led to an indefinite hang in subscription startu

[COMMITTERS] pgsql: Fix, or at least ameliorate, bugs in logicalrep_worker_launch().

2017-09-18 Thread Tom Lane
Fix, or at least ameliorate, bugs in logicalrep_worker_launch(). If we failed to get a background worker slot, the code just walked away from the logicalrep-worker slot it already had, leaving that looking like the worker is still starting up. This led to an indefinite hang in subscription startu

[COMMITTERS] pgsql: Update some dead external links in the documentation

2017-09-18 Thread Peter Eisentraut
Update some dead external links in the documentation Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/90906b855e8867f001339259ae5abd2048b92ac6 Modified Files -- doc/src/sgml/sepgsql.sgml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[COMMITTERS] pgsql: Update some dead external links in the documentation

2017-09-18 Thread Peter Eisentraut
Update some dead external links in the documentation Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4b17c894293d0c3ed944da76aeb9bc2bb02a6db6 Modified Files -- doc/src/sgml/sepgsql.sgml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- Sen

[COMMITTERS] pgsql: Remove dead external links from documentation

2017-09-18 Thread Peter Eisentraut
Remove dead external links from documentation Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4f75e3bbd96fcb73e4995428c595b2698471871a Modified Files -- doc/src/sgml/installation.sgml | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-

[COMMITTERS] pgsql: Remove dead external links from documentation

2017-09-18 Thread Peter Eisentraut
Remove dead external links from documentation Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d31892e2105cf48d8430807d74d5fdf1434af541 Modified Files -- doc/src/sgml/installation.sgml | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) --

[COMMITTERS] pgsql: Translation updates

2017-09-18 Thread Peter Eisentraut
Translation updates Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: ba86fd34c722d76964b1b1fcf14ea18435172529 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b2800df278b3914044285980826b5c9db308971f Modified Files