[COMMITTERS] pgsql: Associate partitioning information with each RelOptInfo.

2017-09-20 Thread Robert Haas
Associate partitioning information with each RelOptInfo. This is not used for anything yet, but it is necessary infrastructure for partition-wise join and for partition pruning without constraint exclusion. Ashutosh Bapat, reviewed by Amit Langote and with quite a few changes, mostly cosmetic, by

[COMMITTERS] pgsql: Improve dubious memory management in pg_newlocale_from_collation

2017-09-20 Thread Tom Lane
Improve dubious memory management in pg_newlocale_from_collation(). pg_newlocale_from_collation() used malloc() and strdup() directly, which is generally not per backend coding style, and it didn't bother to check for failure results, but would just SIGSEGV instead. Also, if one of the numerous e

[COMMITTERS] pgsql: Improve dubious memory management in pg_newlocale_from_collation

2017-09-20 Thread Tom Lane
Improve dubious memory management in pg_newlocale_from_collation(). pg_newlocale_from_collation() used malloc() and strdup() directly, which is generally not per backend coding style, and it didn't bother to check for failure results, but would just SIGSEGV instead. Also, if one of the numerous e

Re: [COMMITTERS] pgsql: Add basic TAP test setup for pg_upgrade

2017-09-20 Thread Tom Lane
Peter Eisentraut writes: > Add basic TAP test setup for pg_upgrade > The plan is to convert the current pg_upgrade test to the TAP > framework. This commit just puts a basic TAP test in place so that we > can see how the build farm behaves, since the build farm client has some > special knowledge

Re: [COMMITTERS] pgsql: Fix erroneous documentation about noise word GROUP.

2017-09-20 Thread Alvaro Herrera
Tom Lane wrote: > Fix erroneous documentation about noise word GROUP. > > GRANT, REVOKE, and some allied commands allow the noise word GROUP > before a role name (cf. grantee production in gram.y). This option > does not exist elsewhere, but it had nonetheless snuck into the > documentation for A

[COMMITTERS] pgsql: Fix instability in subscription regression test.

2017-09-20 Thread Tom Lane
Fix instability in subscription regression test. 005_encoding.pl neglected to wait for the subscriber's initial synchronization to happen. While we have not seen this fail in the buildfarm, it's pretty easy to demonstrate there's an issue by hacking logicalrep_worker_launch() to fail most of the

[COMMITTERS] pgsql: Fix instability in subscription regression test.

2017-09-20 Thread Tom Lane
Fix instability in subscription regression test. 005_encoding.pl neglected to wait for the subscriber's initial synchronization to happen. While we have not seen this fail in the buildfarm, it's pretty easy to demonstrate there's an issue by hacking logicalrep_worker_launch() to fail most of the

[COMMITTERS] pgsql: Fix erroneous documentation about noise word GROUP.

2017-09-20 Thread Tom Lane
Fix erroneous documentation about noise word GROUP. GRANT, REVOKE, and some allied commands allow the noise word GROUP before a role name (cf. grantee production in gram.y). This option does not exist elsewhere, but it had nonetheless snuck into the documentation for ALTER ROLE, ALTER USER, and C

[COMMITTERS] pgsql: Fix erroneous documentation about noise word GROUP.

2017-09-20 Thread Tom Lane
Fix erroneous documentation about noise word GROUP. GRANT, REVOKE, and some allied commands allow the noise word GROUP before a role name (cf. grantee production in gram.y). This option does not exist elsewhere, but it had nonetheless snuck into the documentation for ALTER ROLE, ALTER USER, and C

[COMMITTERS] pgsql: Fix erroneous documentation about noise word GROUP.

2017-09-20 Thread Tom Lane
Fix erroneous documentation about noise word GROUP. GRANT, REVOKE, and some allied commands allow the noise word GROUP before a role name (cf. grantee production in gram.y). This option does not exist elsewhere, but it had nonetheless snuck into the documentation for ALTER ROLE, ALTER USER, and C

[COMMITTERS] pgsql: Fix erroneous documentation about noise word GROUP.

2017-09-20 Thread Tom Lane
Fix erroneous documentation about noise word GROUP. GRANT, REVOKE, and some allied commands allow the noise word GROUP before a role name (cf. grantee production in gram.y). This option does not exist elsewhere, but it had nonetheless snuck into the documentation for ALTER ROLE, ALTER USER, and C

[COMMITTERS] pgsql: Fix create_lateral_join_info to handle dead relations properly.

2017-09-20 Thread Robert Haas
Fix create_lateral_join_info to handle dead relations properly. Commit 0a480502b092195a9b25a2f0f199a21d592a9c57 broke it. Report by Andreas Seltenreich. Fix by Ashutosh Bapat. Discussion: http://postgr.es/m/874ls2vrnx@ansel.ydns.eu Branch -- master Details --- https://git.postgres

Re: [COMMITTERS] pgsql: Set partitioned_rels appropriately when UNION ALL is used.

2017-09-20 Thread Robert Haas
On Tue, Sep 19, 2017 at 7:59 PM, Thomas Munro wrote: > I spotted a typo: s/unexpcted/unexpected/. Thnks! Commmitted yur paatch. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Compny -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.or

[COMMITTERS] pgsql: Fix typo.

2017-09-20 Thread Robert Haas
Fix typo. Thomas Munro Discussion: http://postgr.es/m/CAEepm=2j-hagnburaazws0ry7z_ihk+d7g+ye3u99+6wbig...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7f3a3312abf34ea7e899046e326775612802764b Modified Files -- src/backend/optimizer/p

[COMMITTERS] pgsql: docs: re-add instructions on setting wal_level for rsync use

2017-09-20 Thread Bruce Momjian
docs: re-add instructions on setting wal_level for rsync use This step was erroneously removed four days ago by me. Reported-by: Magnus via IM Backpatch-through: 9.5 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/00210e3fb974ff2b9affc4d8f3b29f9cb3645a60 Modifi

[COMMITTERS] pgsql: docs: re-add instructions on setting wal_level for rsync use

2017-09-20 Thread Bruce Momjian
docs: re-add instructions on setting wal_level for rsync use This step was erroneously removed four days ago by me. Reported-by: Magnus via IM Backpatch-through: 9.5 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/95a231aef9bb872913f67f30a8cffcfefaf8ca51

[COMMITTERS] pgsql: docs: re-add instructions on setting wal_level for rsync use

2017-09-20 Thread Bruce Momjian
docs: re-add instructions on setting wal_level for rsync use This step was erroneously removed four days ago by me. Reported-by: Magnus via IM Backpatch-through: 9.5 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8aa520045e1427f6f2ee0881e6d551546787da55

[COMMITTERS] pgsql: docs: re-add instructions on setting wal_level for rsync use

2017-09-20 Thread Bruce Momjian
docs: re-add instructions on setting wal_level for rsync use This step was erroneously removed four days ago by me. Reported-by: Magnus via IM Backpatch-through: 9.5 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4131cc6b90ce274a44462627a1c878bf1950838b

[COMMITTERS] pgsql: Fix compiler warning

2017-09-20 Thread Peter Eisentraut
Fix compiler warning from gcc-7 -Wformat-truncation (via -Wall) Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d42294fc00da4b97d04ddb4401b76295e8d86816 Modified Files -- src/bin/initdb/initdb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[COMMITTERS] pgsql: Sync process names between ps and pg_stat_activity

2017-09-20 Thread Peter Eisentraut
Sync process names between ps and pg_stat_activity Remove gratuitous differences in the process names shown in pg_stat_activity.backend_type and the ps output. Reviewed-by: Takayuki Tsunakawa Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/be87b70b6117609b7db0cd5e

[COMMITTERS] pgsql: Mention need for --no-inc-recursive in rsync command

2017-09-20 Thread Magnus Hagander
Mention need for --no-inc-recursive in rsync command Since rsync 3.0.0 (released in 2008), the default way to enumerate changes was changed in a way that makes it less likely that the hardlink sync mode works. Since the whole point of the documented procedure is for the hardlinks to work, change o

[COMMITTERS] pgsql: Mention need for --no-inc-recursive in rsync command

2017-09-20 Thread Magnus Hagander
Mention need for --no-inc-recursive in rsync command Since rsync 3.0.0 (released in 2008), the default way to enumerate changes was changed in a way that makes it less likely that the hardlink sync mode works. Since the whole point of the documented procedure is for the hardlinks to work, change o

[COMMITTERS] pgsql: Mention need for --no-inc-recursive in rsync command

2017-09-20 Thread Magnus Hagander
Mention need for --no-inc-recursive in rsync command Since rsync 3.0.0 (released in 2008), the default way to enumerate changes was changed in a way that makes it less likely that the hardlink sync mode works. Since the whole point of the documented procedure is for the hardlinks to work, change o

[COMMITTERS] pgsql: Mention need for --no-inc-recursive in rsync command

2017-09-20 Thread Magnus Hagander
Mention need for --no-inc-recursive in rsync command Since rsync 3.0.0 (released in 2008), the default way to enumerate changes was changed in a way that makes it less likely that the hardlink sync mode works. Since the whole point of the documented procedure is for the hardlinks to work, change o