Re: [COMMITTERS] pgsql: Provide a test for variable existence in psql

2017-09-21 Thread Fabien COELHO
Provide a test for variable existence in psql Thanks for the editing & commit. Pavel's feedback helped to devise a nicer syntax, although it was not strictly speaking a review. -- Fabien. -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your

[COMMITTERS] pgsql: Sync our copy of the timezone library with IANA tzcode master.

2017-09-21 Thread Tom Lane
Sync our copy of the timezone library with IANA tzcode master. This patch absorbs a few unreleased fixes in the IANA code. It corresponds to commit 2d8b944c1cec0808ac4f7a9ee1a463c28f9cd00a in https://github.com/eggert/tz. Non-cosmetic changes include: TZDEFRULESTRING is updated to match current

[COMMITTERS] pgsql: Revert "Fix bool/int type confusion"

2017-09-21 Thread Tom Lane
Revert "Fix bool/int type confusion" This reverts commit 0ec2e908babfbfde83a3925680f06b16408739ff. We'll use the upstream (IANA) fix instead. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a890432a872afc9ca2327573f3313fd994d17384 Modified Files -- src/

[COMMITTERS] pgsql: Sync our copy of the timezone library with IANA tzcode master.

2017-09-21 Thread Tom Lane
Sync our copy of the timezone library with IANA tzcode master. This patch absorbs a few unreleased fixes in the IANA code. It corresponds to commit 2d8b944c1cec0808ac4f7a9ee1a463c28f9cd00a in https://github.com/eggert/tz. Non-cosmetic changes include: TZDEFRULESTRING is updated to match current

[COMMITTERS] pgsql: Sync our copy of the timezone library with IANA tzcode master.

2017-09-21 Thread Tom Lane
Sync our copy of the timezone library with IANA tzcode master. This patch absorbs a few unreleased fixes in the IANA code. It corresponds to commit 2d8b944c1cec0808ac4f7a9ee1a463c28f9cd00a in https://github.com/eggert/tz. Non-cosmetic changes include: TZDEFRULESTRING is updated to match current

[COMMITTERS] pgsql: Sync our copy of the timezone library with IANA tzcode master.

2017-09-21 Thread Tom Lane
Sync our copy of the timezone library with IANA tzcode master. This patch absorbs a few unreleased fixes in the IANA code. It corresponds to commit 2d8b944c1cec0808ac4f7a9ee1a463c28f9cd00a in https://github.com/eggert/tz. Non-cosmetic changes include: TZDEFRULESTRING is updated to match current

[COMMITTERS] pgsql: Sync our copy of the timezone library with IANA tzcode master.

2017-09-21 Thread Tom Lane
Sync our copy of the timezone library with IANA tzcode master. This patch absorbs a few unreleased fixes in the IANA code. It corresponds to commit 2d8b944c1cec0808ac4f7a9ee1a463c28f9cd00a in https://github.com/eggert/tz. Non-cosmetic changes include: TZDEFRULESTRING is updated to match current

[COMMITTERS] pgsql: Sync our copy of the timezone library with IANA tzcode master.

2017-09-21 Thread Tom Lane
Sync our copy of the timezone library with IANA tzcode master. This patch absorbs a few unreleased fixes in the IANA code. It corresponds to commit 2d8b944c1cec0808ac4f7a9ee1a463c28f9cd00a in https://github.com/eggert/tz. Non-cosmetic changes include: TZDEFRULESTRING is updated to match current

[COMMITTERS] pgsql: Sync our copy of the timezone library with IANA tzcode master.

2017-09-21 Thread Tom Lane
Sync our copy of the timezone library with IANA tzcode master. This patch absorbs a few unreleased fixes in the IANA code. It corresponds to commit 2d8b944c1cec0808ac4f7a9ee1a463c28f9cd00a in https://github.com/eggert/tz. Non-cosmetic changes include: TZDEFRULESTRING is updated to match current

Re: [HACKERS] Re: [COMMITTERS] pgsql: Make new crash restart test a bit more robust.

2017-09-21 Thread Thomas Munro
On Wed, Sep 20, 2017 at 4:42 PM, Andres Freund wrote: > On 2017-09-19 19:00:38 -0700, Andres Freund wrote: >> Given this fact pattern, I'll allow the case without a received error >> message in the recovery test. Objections? > > Hearing none. Pushed. > > While debugging this, I've also introduced

[COMMITTERS] pgsql: Provide a test for variable existence in psql

2017-09-21 Thread Andrew Dunstan
Provide a test for variable existence in psql "\if :{?variable_name}" will be translated to "\if TRUE" if the variable exists and "\if FALSE" otherwise. Thus it will be possible to execute code conditionally on the existence of the variable, regardless of its value. Fabien Coelho, with some revie

[COMMITTERS] pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu

2017-09-21 Thread Tom Lane
Give a better error for duplicate entries in VACUUM/ANALYZE column list. Previously, the code didn't think about this case and would just try to analyze such a column twice. That would fail at the point of inserting the second version of the pg_statistic row, with obscure error messsages like "du

[COMMITTERS] pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu

2017-09-21 Thread Tom Lane
Give a better error for duplicate entries in VACUUM/ANALYZE column list. Previously, the code didn't think about this case and would just try to analyze such a column twice. That would fail at the point of inserting the second version of the pg_statistic row, with obscure error messsages like "du

[COMMITTERS] pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu

2017-09-21 Thread Tom Lane
Give a better error for duplicate entries in VACUUM/ANALYZE column list. Previously, the code didn't think about this case and would just try to analyze such a column twice. That would fail at the point of inserting the second version of the pg_statistic row, with obscure error messsages like "du

[COMMITTERS] pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu

2017-09-21 Thread Tom Lane
Give a better error for duplicate entries in VACUUM/ANALYZE column list. Previously, the code didn't think about this case and would just try to analyze such a column twice. That would fail at the point of inserting the second version of the pg_statistic row, with obscure error messsages like "du

[COMMITTERS] pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu

2017-09-21 Thread Tom Lane
Give a better error for duplicate entries in VACUUM/ANALYZE column list. Previously, the code didn't think about this case and would just try to analyze such a column twice. That would fail at the point of inserting the second version of the pg_statistic row, with obscure error messsages like "du

[COMMITTERS] pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu

2017-09-21 Thread Tom Lane
Give a better error for duplicate entries in VACUUM/ANALYZE column list. Previously, the code didn't think about this case and would just try to analyze such a column twice. That would fail at the point of inserting the second version of the pg_statistic row, with obscure error messsages like "du

[COMMITTERS] pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu

2017-09-21 Thread Tom Lane
Give a better error for duplicate entries in VACUUM/ANALYZE column list. Previously, the code didn't think about this case and would just try to analyze such a column twice. That would fail at the point of inserting the second version of the pg_statistic row, with obscure error messsages like "du

[COMMITTERS] pgsql: Quieten warnings about unused variables

2017-09-21 Thread Andrew Dunstan
Quieten warnings about unused variables These variables are only ever written to in assertion-enabled builds, and the latest Microsoft compilers complain about such variables in non-assertion-enabled builds. Apparently they don't worry so much about variables that are written to but not read from