Re: [COMMITTERS] pgsql: Fix saving and restoring umask

2017-09-22 Thread Tom Lane
Peter Eisentraut writes: > Fix saving and restoring umask > In two cases, we set a different umask for some piece of code and > restore it afterwards. But if the contained code errors out, the umask > is not restored. So add TRY/CATCH blocks to fix that. Doesn't that need to be back-patched?

[COMMITTERS] pgsql: Fix saving and restoring umask

2017-09-22 Thread Peter Eisentraut
Fix saving and restoring umask In two cases, we set a different umask for some piece of code and restore it afterwards. But if the contained code errors out, the umask is not restored. So add TRY/CATCH blocks to fix that. Branch -- master Details --- https://git.postgresql.org/pg/commi

[COMMITTERS] pgsql: Revert "Add basic TAP test setup for pg_upgrade"

2017-09-22 Thread Peter Eisentraut
Revert "Add basic TAP test setup for pg_upgrade" This reverts commit f41e56c76e39f02bef7ba002c9de03d62b76de4d. The build farm client would run the pg_upgrade tests twice, once as part of the existing pg_upgrade check run and once as part of picking up all TAP tests by looking for "t" directories.

[COMMITTERS] pgsql: Add inline murmurhash32(uint32) function.

2017-09-22 Thread Andres Freund
Add inline murmurhash32(uint32) function. The function already existed in tidbitmap.c but more users requiring fast hashing of 32bit ints are coming up. Author: Andres Freund Discussion: https://postgr.es/m/20170914061207.zxotvyopetm7l...@alap3.anarazel.de Branch -- master Details ---

[COMMITTERS] pgsql: doc: Document commands that cannot be run in a transaction block

2017-09-22 Thread Peter Eisentraut
doc: Document commands that cannot be run in a transaction block Mainly covering the new CREATE SUBSCRIPTION and DROP SUBSCRIPTION, but ALTER DATABASE SET TABLESPACE was also missing. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/91ad8b416cee753eaa6f520ee2d21c2d41

[COMMITTERS] pgsql: doc: Document commands that cannot be run in a transaction block

2017-09-22 Thread Peter Eisentraut
doc: Document commands that cannot be run in a transaction block Mainly covering the new CREATE SUBSCRIPTION and DROP SUBSCRIPTION, but ALTER DATABASE SET TABLESPACE was also missing. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e114289e1e4774dfc3371372e36

[COMMITTERS] pgsql: Fix s/intidb/initdb/ typo.

2017-09-22 Thread Andres Freund
Fix s/intidb/initdb/ typo. Reported-By: Michael Paquier Discussion: https://postgr.es/m/CAB7nPqTfaKAYZ4wuUM-W8kc4VnXrxX1=5-a9i==vouptmfp...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f9583e86b4bfa8c4e4d83ab33e5dcdaeab5c45a1 Modified Files -

[COMMITTERS] pgsql: Expand expected output for recovery test even further.

2017-09-22 Thread Andres Freund
Expand expected output for recovery test even further. I'd assumed that the backend being killed should be able to get out an error message - but it turns out it's not guaranteed that it's not still sending a ready-for-query. Really need to do something about getting these error message to the cl

[COMMITTERS] pgsql: For wal_consistency_checking, mask page checksum as well as page

2017-09-22 Thread Robert Haas
For wal_consistency_checking, mask page checksum as well as page LSN. If the LSN is different, the checksum will be different, too. Ashwin Agrawal, reviewed by Michael Paquier and Kuntal Ghosh Discussion: http://postgr.es/m/CALfoeis5iqrAU-+JAN+ZzXkpPr7+-0OAGv7QUHwFn=-wdy4...@mail.gmail.com Bra

[COMMITTERS] pgsql: For wal_consistency_checking, mask page checksum as well as page

2017-09-22 Thread Robert Haas
For wal_consistency_checking, mask page checksum as well as page LSN. If the LSN is different, the checksum will be different, too. Ashwin Agrawal, reviewed by Michael Paquier and Kuntal Ghosh Discussion: http://postgr.es/m/CALfoeis5iqrAU-+JAN+ZzXkpPr7+-0OAGv7QUHwFn=-wdy4...@mail.gmail.com Bra

[COMMITTERS] pgsql: hash: Implement page-at-a-time scan.

2017-09-22 Thread Robert Haas
hash: Implement page-at-a-time scan. Commit 09cb5c0e7d6fbc9dee26dc429e4fc0f2a88e5272 added a similar optimization to btree back in 2006, but nobody bothered to implement the same thing for hash indexes, probably because they weren't WAL-logged and had lots of other performance problems as well. A

Re: [COMMITTERS] pgsql: Accept that server might not be able to send error in crash reco

2017-09-22 Thread Andres Freund
On 2017-09-22 13:30:14 -0400, Tom Lane wrote: > Andres Freund writes: > > Accept that server might not be able to send error in crash recovery test. > > piculet says you didn't cover all the bases: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=piculet&dt=2017-09-22%2017%3A10%3A01 >

Re: [COMMITTERS] pgsql: Accept that server might not be able to send error in crash reco

2017-09-22 Thread Tom Lane
Andres Freund writes: > Accept that server might not be able to send error in crash recovery test. piculet says you didn't cover all the bases: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=piculet&dt=2017-09-22%2017%3A10%3A01 Looks like you missed adding the "server closed the connec

[COMMITTERS] pgsql: Allow up to 3 "-P 1" reports per thread in pgbench run of 2 seco

2017-09-22 Thread Tom Lane
Allow up to 3 "-P 1" reports per thread in pgbench run of 2 seconds. There seems to be some considerable imprecision in the timing of -P progress reports. Nominally each thread ought to produce 2 reports in this test, but about 10% of the time we only get one, and 1% of the time we get three, as

[COMMITTERS] pgsql: Remove contrib/chkpass

2017-09-22 Thread Peter Eisentraut
Remove contrib/chkpass The recent addition of a test suite for this module revealed a few problems. It uses a crypt() method that is no longer considered secure and doesn't work anymore on some platforms. Using a volatile input function violates internal sanity check assumptions and leads to fai

[COMMITTERS] pgsql: Mop-up for commit 85feb77aa09cda9ff3e12cf95c757c499dc25343.

2017-09-22 Thread Tom Lane
Mop-up for commit 85feb77aa09cda9ff3e12cf95c757c499dc25343. Adjust commentary in regc_pg_locale.c to remove mention of the possibility of not having functions, since we no longer consider that. Eliminate duplicate code in wparser_def.c by generalizing the p_iswhat macro to take a parameter sayin

[COMMITTERS] pgsql: Assume wcstombs(), towlower(), and sibling functions are always

2017-09-22 Thread Tom Lane
Assume wcstombs(), towlower(), and sibling functions are always present. These functions are required by SUS v2, which is our minimum baseline for Unix platforms, and are present on all interesting Windows versions as well. Even our oldest buildfarm members have them. Thus, we were not testing t

[COMMITTERS] pgsql: Fix build with !USE_WIDE_UPPER_LOWER

2017-09-22 Thread Peter Eisentraut
Fix build with !USE_WIDE_UPPER_LOWER The placement of the ifdef blocks in formatting.c was pretty bogus, so the code failed to compile if USE_WIDE_UPPER_LOWER was not defined. Reported-by: Peter Geoghegan Reported-by: Noah Misch Branch -- REL_10_STABLE Details --- https://git.postgres

[COMMITTERS] pgsql: Fix build with !USE_WIDE_UPPER_LOWER

2017-09-22 Thread Peter Eisentraut
Fix build with !USE_WIDE_UPPER_LOWER The placement of the ifdef blocks in formatting.c was pretty bogus, so the code failed to compile if USE_WIDE_UPPER_LOWER was not defined. Reported-by: Peter Geoghegan Reported-by: Noah Misch Branch -- master Details --- https://git.postgresql.org/

[COMMITTERS] pgsql: Document further existing locks as wait events

2017-09-22 Thread Alvaro Herrera
Document further existing locks as wait events Reported-by: Jeremy Schneider Author: Michael Paquier Discussion: https://postgr.es/m/ca+fndazapcwfy8lp-pflnugfaxru1vflyrgdup-l-kwcbj8...@mail.gmail.com Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e9c9ba7845

[COMMITTERS] pgsql: Document further existing locks as wait events

2017-09-22 Thread Alvaro Herrera
Document further existing locks as wait events Reported-by: Jeremy Schneider Author: Michael Paquier Discussion: https://postgr.es/m/ca+fndazapcwfy8lp-pflnugfaxru1vflyrgdup-l-kwcbj8...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/885cab58115a5af94