is doing:
>
> Ah-hah. Still, the log message should have been there before.
>
No, it didn't exist before because dirname passed to scan_directory_ci
didn't contain the filename appended to it.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
--
Sent
On Sun, May 7, 2017 at 2:33 PM, David Rowley
wrote:
> , On 7 May 2017 at 17:19, Tom Lane wrote:
>> Amit Kapila writes:
>>> On Wed, May 3, 2017 at 7:21 AM, Tom Lane wrote:
>>>> Improve performance of timezone loading, especially pg_timezone_names view.
>>
t open directory "/installation/share/timezone/posixrules": No
such file or directory
This occurs both during initdb and server start.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make
On Sat, Apr 15, 2017 at 2:34 AM, Tom Lane wrote:
> Clean up manipulations of hash indexes' hasho_flag field.
>
Attached patch to fix one remaining cleanup for the hasho_flag field.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
change_usage_hashho
gt; pending list cleaning, perhaps visibility map bit setting, both of which
> are currently invoked during vacuum, but do not really depend on vacuum
> taking place.
>
I think this can also be used for split cleanup work for hash indexes.
--
With Regards,
Amit Kapila.
EnterpriseDB: http:
On Wed, Mar 15, 2017 at 9:44 AM, Amit Kapila wrote:
> On Wed, Mar 15, 2017 at 9:18 AM, Tom Lane wrote:
>> Amit Kapila writes:
>>> On Wed, Mar 15, 2017 at 8:56 AM, Tom Lane wrote:
>>>> However, we probably do need to fix the src/test/mb/expected/ files.
>>&
On Wed, Mar 15, 2017 at 9:18 AM, Tom Lane wrote:
> Amit Kapila writes:
>> On Wed, Mar 15, 2017 at 8:56 AM, Tom Lane wrote:
>>> However, we probably do need to fix the src/test/mb/expected/ files.
>>> Has anyone tried running that test suite?
>
>> I haven&#x
> However, we probably do need to fix the src/test/mb/expected/ files.
> Has anyone tried running that test suite?
>
I haven't tried. Does this run as part of any regression tests or is
the only way is run it manually (sh mbregress.sh)?
--
With Regards,
Amit Kapila.
EnterpriseDB: ht
greed and posted a patch on hackers [1]
[1] -
https://www.postgresql.org/message-id/CAA4eK1LeVu8rSvA%3DhfbezqjNv5x3nU-rPbHCHHbbsCrLX-0zAg%40mail.gmail.com
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
--
Sent via pgsql-committers mailing list (pgsql-committers@postg
opment Group
+ * Portions Copyright (c) 1994, Regents of the University of California
+ *
+ * src/include/common/relpath.h
file name in directory path is not matching actual file name.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
--
Sent via pgsql-committers mailing list
ame in
ForgetBackgroundWorker(). Attached patch fixes the problem for me.
Ashutosh Sharma has independently reported (offlist) this problem to me.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
select_parallel_hang_v1.patch
Description: Binary data
--
Sent via pgsql-comm
On Fri, Feb 3, 2017 at 8:13 PM, Tom Lane wrote:
> Amit Kapila writes:
>> I have gone through all the of the SQL declarations and it seems
>> hash_metapage_info(...,OUT procid int4,..) is not consistent. procid
>> is unsigned int, so isn't it better to use the corresp
gt; of selecting *?
>
> Yeah, that's one possible answer. We could also maintain two
> expected-files for 32 bit v 64 bit, but I'm not sure it's worth
> the trouble.
>
I think for now selecting named fields is sufficient.
--
With Regards,
Amit Kapila.
Enterp
this magnitude deserves a big round of applause.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
adf32b36d5538e4602a90c3e0fb), everything works
fine. I have noticed that if I use initdb command as below, then it
passes
./initdb -D ../../data -U amitkapila
echo $USER prints
Amitkapila
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
--
Sent via pgsql-committers mail
t;path.parallel_workers > 0)
+ path->path.rows /= get_parallel_divisor(&path->path);
Isn't it better to call clamp_row_est in join costing functions as we
are doing in cost_seqscan()? Is there a reason to keep those
different?
--
With Regards,
Amit Kapila.
EnterpriseD
On Wed, Oct 5, 2016 at 5:53 PM, Amit Kapila wrote:
> On Tue, Oct 4, 2016 at 8:32 PM, Robert Haas wrote:
>> Extend framework from commit 53be0b1ad to report latch waits.
>>
>
> I am facing windows below compilation error:
>
> 1>pgstat.h(726): warning C4005: 'WAI
\Windows\v7.0A\include\winerror.h(1797) : see previous definition
of 'WAIT_TIMEOUT'
It seems windows already have a define for WAIT_TIMEOUT. Do we want
to rename it to WAIT_TIMEEXPIRED or WAIT_EXPIRETIME?
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
--
Sent v
On Sat, Jun 18, 2016 at 10:06 AM, Tom Lane wrote:
>
> Amit Kapila writes:
> > On Sat, Jun 18, 2016 at 8:56 AM, Tom Lane wrote:
> >> I think the two lines in question are just a poorly-thought-through
case
> >> of premature optimization. If removing them makes th
On Sat, Jun 18, 2016 at 8:56 AM, Tom Lane wrote:
>
> Amit Kapila writes:
> > Patch fixing the failures along with a new test case is attached with
this
> > mail
>
> That can't possibly be right, because the PathTarget.sortgrouprefs field
> is not a pointer to a
On Sat, Jun 18, 2016 at 7:44 AM, Amit Kapila
wrote:
>
> On Sat, Jun 18, 2016 at 7:06 AM, Tom Lane wrote:
> >
> > Amit Kapila writes:
> > > On Sat, Jun 18, 2016 at 6:11 AM, Tom Lane wrote:
> > >> Was this supposed to fix the "ORDER/GROUP BY expres
On Sat, Jun 18, 2016 at 7:06 AM, Tom Lane wrote:
>
> Amit Kapila writes:
> > On Sat, Jun 18, 2016 at 6:11 AM, Tom Lane wrote:
> >> Was this supposed to fix the "ORDER/GROUP BY expression not found in
> >> targetlist" problem?
> >> If so, it hasn&
gt; If so, it hasn't ...
>
Can you please share why you think so?
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
27;parallel restricted function run in worker';
+ end if;
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
On Tue, Apr 19, 2016 at 8:41 PM, Kevin Grittner wrote:
>
> On Tue, Apr 19, 2016 at 9:57 AM, Amit Kapila
wrote:
> > On Sun, Apr 17, 2016 at 2:26 AM, Andres Freund
wrote:
> >>
> >> On 2016-04-16 16:44:52 -0400, Noah Misch wrote:
> >> > That is more contr
On Thu, Apr 21, 2016 at 6:38 AM, Ants Aasma wrote:
>
> On Tue, Apr 19, 2016 at 6:11 PM, Kevin Grittner wrote:
> > On Tue, Apr 19, 2016 at 9:57 AM, Amit Kapila
wrote:
> >> On Sun, Apr 17, 2016 at 2:26 AM, Andres Freund
wrote:
> >>>
> >>> FWIW, I coul
On Wed, Apr 20, 2016 at 7:39 PM, Andres Freund wrote:
>
> On 2016-04-19 20:27:31 +0530, Amit Kapila wrote:
> > On Sun, Apr 17, 2016 at 2:26 AM, Andres Freund
wrote:
> > >
> > > On 2016-04-16 16:44:52 -0400, Noah Misch wrote:
> > > > That is more contr
On Tue, Apr 19, 2016 at 8:44 PM, Robert Haas wrote:
>
> On Tue, Apr 19, 2016 at 11:11 AM, Kevin Grittner
wrote:
> > On Tue, Apr 19, 2016 at 9:57 AM, Amit Kapila
wrote:
>
> >> It seems that for read-only workloads, MaintainOldSnapshotTimeMapping()
> >> takes EXC
>latest_xmin?
If we don't need it for above cases, I think it can address the performance
regression to a good degree for read-only workloads when the feature is
enabled.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
On Wed, Nov 11, 2015 at 11:06 PM, Peter Geoghegan wrote:
>
> On Wed, Nov 11, 2015 at 9:08 AM, Peter Geoghegan wrote:
> > Congratulations, Robert.
>
> I should certainly extend my congratulations to Amit too.
>
Thanks!
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
as well and the same is
needed for the cases when after the readers are done we still need
to access dsm, like for rescan and for scanning the data from local
node.
Here, we should just shutdown the workers and that is what we were
doing previous to this commit. Attached patch fixes this problem.
h fixes the problem.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
fix_win_compiler_warning_v1.patch
Description: Binary data
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
lspcdir.
> Wouldn't it make more sense to open the directory inside
>> do_pg_start_backup?
>>
>
>
>
Good point. It does look cleaner to do that.
>
>
If you prefer that way, I can look into rearranging the
code.
>
>
>> In the BASE_BACKUP command, is there any reason to not always include the
>> tablespace map?
>
>
The main reason is that it is not required to restore symlinks
for plain format. Also I think it can cause a problem if user
has used --tablespace-mapping option in plain format as the
tablespace_map file doesn't contain information for same and recovery
will try to restore symlinks for wrong path based on tablespace_map
file.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
33 matches
Mail list logo
