[COMMITTERS] pgsql: Improve gendef.pl diagnostic on failure to open sym file

2017-10-26 Thread Andrew Dunstan
Improve gendef.pl diagnostic on failure to open sym file There have been numerous buildfarm failures but the diagnostic is currently silent about the reason for failure to open the file. Let's see if we can get to the bottom of it. Backpatch to all live branches. Branch -- REL9_6_STABLE Det

[COMMITTERS] pgsql: Improve gendef.pl diagnostic on failure to open sym file

2017-10-26 Thread Andrew Dunstan
Improve gendef.pl diagnostic on failure to open sym file There have been numerous buildfarm failures but the diagnostic is currently silent about the reason for failure to open the file. Let's see if we can get to the bottom of it. Backpatch to all live branches. Branch -- REL9_5_STABLE Det

[COMMITTERS] pgsql: Improve gendef.pl diagnostic on failure to open sym file

2017-10-26 Thread Andrew Dunstan
Improve gendef.pl diagnostic on failure to open sym file There have been numerous buildfarm failures but the diagnostic is currently silent about the reason for failure to open the file. Let's see if we can get to the bottom of it. Backpatch to all live branches. Branch -- REL9_4_STABLE Det

[COMMITTERS] pgsql: Improve gendef.pl diagnostic on failure to open sym file

2017-10-26 Thread Andrew Dunstan
Improve gendef.pl diagnostic on failure to open sym file There have been numerous buildfarm failures but the diagnostic is currently silent about the reason for failure to open the file. Let's see if we can get to the bottom of it. Backpatch to all live branches. Branch -- REL_10_STABLE Det

[COMMITTERS] pgsql: Improve gendef.pl diagnostic on failure to open sym file

2017-10-26 Thread Andrew Dunstan
Improve gendef.pl diagnostic on failure to open sym file There have been numerous buildfarm failures but the diagnostic is currently silent about the reason for failure to open the file. Let's see if we can get to the bottom of it. Backpatch to all live branches. Branch -- REL9_2_STABLE Det

[COMMITTERS] pgsql: Improve gendef.pl diagnostic on failure to open sym file

2017-10-26 Thread Andrew Dunstan
Improve gendef.pl diagnostic on failure to open sym file There have been numerous buildfarm failures but the diagnostic is currently silent about the reason for failure to open the file. Let's see if we can get to the bottom of it. Backpatch to all live branches. Branch -- REL9_3_STABLE Det

[COMMITTERS] pgsql: Improve gendef.pl diagnostic on failure to open sym file

2017-10-26 Thread Andrew Dunstan
Improve gendef.pl diagnostic on failure to open sym file There have been numerous buildfarm failures but the diagnostic is currently silent about the reason for failure to open the file. Let's see if we can get to the bottom of it. Backpatch to all live branches. Branch -- master Details --

[COMMITTERS] pgsql: Undo inadvertent change in capitalization in commit 18fc4ec.

2017-10-26 Thread Andrew Dunstan
Undo inadvertent change in capitalization in commit 18fc4ec. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/adee9e4e317169463816d005e8bf901333271917 Modified Files -- src/backend/utils/adt/jsonb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -

[COMMITTERS] pgsql: Undo inadvertent change in capitalization in commit 18fc4ec.

2017-10-26 Thread Andrew Dunstan
Undo inadvertent change in capitalization in commit 18fc4ec. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/aa828819aa59a84b486837b4cc3d7afc739332f5 Modified Files -- src/backend/utils/adt/jsonb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[COMMITTERS] pgsql: Process variadic arguments consistently in json functions

2017-10-25 Thread Andrew Dunstan
Process variadic arguments consistently in json functions json_build_object and json_build_array and the jsonb equivalents did not correctly process explicit VARIADIC arguments. They are modified to use the new extract_variadic_args() utility function which abstracts away the details of the call m

[COMMITTERS] pgsql: Add a utility function to extract variadic function arguments

2017-10-25 Thread Andrew Dunstan
Add a utility function to extract variadic function arguments This is epecially useful in the case or "VARIADIC ANY" functions. The caller can get the artguments and types regardless of whether or not and explicit VARIADIC array argument has been used. The function also provides an option to conve

[COMMITTERS] pgsql: Add a utility function to extract variadic function arguments

2017-10-25 Thread Andrew Dunstan
Add a utility function to extract variadic function arguments This is epecially useful in the case or "VARIADIC ANY" functions. The caller can get the artguments and types regardless of whether or not and explicit VARIADIC array argument has been used. The function also provides an option to conve

[COMMITTERS] pgsql: Add a utility function to extract variadic function arguments

2017-10-25 Thread Andrew Dunstan
Add a utility function to extract variadic function arguments This is epecially useful in the case or "VARIADIC ANY" functions. The caller can get the artguments and types regardless of whether or not and explicit VARIADIC array argument has been used. The function also provides an option to conve

[COMMITTERS] pgsql: Process variadic arguments consistently in json functions

2017-10-25 Thread Andrew Dunstan
Process variadic arguments consistently in json functions json_build_object and json_build_array and the jsonb equivalents did not correctly process explicit VARIADIC arguments. They are modified to use the new extract_variadic_args() utility function which abstracts away the details of the call m

[COMMITTERS] pgsql: Process variadic arguments consistently in json functions

2017-10-25 Thread Andrew Dunstan
Process variadic arguments consistently in json functions json_build_object and json_build_array and the jsonb equivalents did not correctly process explicit VARIADIC arguments. They are modified to use the new extract_variadic_args() utility function which abstracts away the details of the call m

[COMMITTERS] pgsql: Process variadic arguments consistently in json functions

2017-10-25 Thread Andrew Dunstan
Process variadic arguments consistently in json functions json_build_object and json_build_array and the jsonb equivalents did not correctly process explicit VARIADIC arguments. They are modified to use the new extract_variadic_args() utility function which abstracts away the details of the call m

[COMMITTERS] pgsql: Add a utility function to extract variadic function arguments

2017-10-25 Thread Andrew Dunstan
Add a utility function to extract variadic function arguments This is epecially useful in the case or "VARIADIC ANY" functions. The caller can get the artguments and types regardless of whether or not and explicit VARIADIC array argument has been used. The function also provides an option to conve

[COMMITTERS] pgsql: Process variadic arguments consistently in json functions

2017-10-25 Thread Andrew Dunstan
Process variadic arguments consistently in json functions json_build_object and json_build_array and the jsonb equivalents did not correctly process explicit VARIADIC arguments. They are modified to use the new extract_variadic_args() utility function which abstracts away the details of the call m

[COMMITTERS] pgsql: Add a utility function to extract variadic function arguments

2017-10-25 Thread Andrew Dunstan
Add a utility function to extract variadic function arguments This is epecially useful in the case or "VARIADIC ANY" functions. The caller can get the artguments and types regardless of whether or not and explicit VARIADIC array argument has been used. The function also provides an option to conve

Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen.

2017-10-10 Thread Andrew Dunstan
On 10/10/2017 03:48 PM, Andres Freund wrote: > On 2017-10-09 23:33:36 -0400, Andrew Dunstan wrote: >> >> On 10/09/2017 07:15 PM, Andres Freund wrote: >>> Hi Andrew, >>> >>> On 2017-10-09 22:22:04 +, Andres Freund wrote: >>>> Add pg_strnl

Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen.

2017-10-09 Thread Andrew Dunstan
On 10/09/2017 07:15 PM, Andres Freund wrote: > Hi Andrew, > > On 2017-10-09 22:22:04 +, Andres Freund wrote: >> Add pg_strnlen() a portable implementation of strlen. >> >> As the OS version is likely going to be more optimized, fall back to >> it if available, as detected by configure. > I'm

Re: [COMMITTERS] pgsql: Add test for postmaster crash restarts.

2017-10-01 Thread Andrew Dunstan
all platforms. cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.pos

Re: [COMMITTERS] pgsql: Add test for postmaster crash restarts.

2017-09-30 Thread Andrew Dunstan
On 09/30/2017 06:44 PM, Andres Freund wrote: > On 2017-09-30 15:27:12 -0700, Andres Freund wrote: >> On 2017-09-30 18:21:33 -0400, Andrew Dunstan wrote: >>> [re-adding commiters which I inadvertently left off] >>> >>> >>> On 09/30/2017 06:10 PM, Andre

Re: [COMMITTERS] pgsql: Add test for postmaster crash restarts.

2017-09-30 Thread Andrew Dunstan
hat's why you give it a pid argument" "pg_ctl kill signal_name process_id" cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-committers mailing list

Re: [COMMITTERS] pgsql: Support arrays over domains.

2017-09-30 Thread Andrew Dunstan
On 09/30/2017 03:32 PM, Tom Lane wrote: > Andrew Dunstan writes: >> We seem to have caused a problem with pg_upgrade :-( >> pg_restore: [archiver (db)] could not execute query: ERROR:  pg_type >> array OID value not set when in binary upgrade mode >> Here

Re: [COMMITTERS] pgsql: Support arrays over domains.

2017-09-30 Thread Andrew Dunstan
restore: [archiver (db)] could not execute query: ERROR:  pg_type array OID value not set when in binary upgrade mode     Command was: -- For binary upgrade, must preserve pg_type oid SELECT pg_catalog.binary_upgrade_set_next_pg_type_oid('51354'::pg_catalog.oid); CREATE

[COMMITTERS] pgsql: Support building with Visual Studio 2017

2017-09-25 Thread Andrew Dunstan
Support building with Visual Studio 2017 Haribabu Kommi, reviewed by Takeshi Ideriha and Christian Ullrich Backpatch to 9.6 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/99e90bac4f9f3bd8d7b285a6f4095c2089e09efe Modified Files -- doc/src/sgml/i

[COMMITTERS] pgsql: Support building with Visual Studio 2017

2017-09-25 Thread Andrew Dunstan
Support building with Visual Studio 2017 Haribabu Kommi, reviewed by Takeshi Ideriha and Christian Ullrich Backpatch to 9.6 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/10aafbdbe4224846095198644a1169807ab9b391 Modified Files -- doc/src/sgml/i

[COMMITTERS] pgsql: Support building with Visual Studio 2017

2017-09-25 Thread Andrew Dunstan
Support building with Visual Studio 2017 Haribabu Kommi, reviewed by Takeshi Ideriha and Christian Ullrich Backpatch to 9.6 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f2ab3898f3a25ef431db4ea90a8d128b974dbffe Modified Files -- doc/src/sgml/install-

[COMMITTERS] pgsql: Provide a test for variable existence in psql

2017-09-21 Thread Andrew Dunstan
Provide a test for variable existence in psql "\if :{?variable_name}" will be translated to "\if TRUE" if the variable exists and "\if FALSE" otherwise. Thus it will be possible to execute code conditionally on the existence of the variable, regardless of its value. Fabien Coelho, with some revie

[COMMITTERS] pgsql: Quieten warnings about unused variables

2017-09-21 Thread Andrew Dunstan
Quieten warnings about unused variables These variables are only ever written to in assertion-enabled builds, and the latest Microsoft compilers complain about such variables in non-assertion-enabled builds. Apparently they don't worry so much about variables that are written to but not read from

[COMMITTERS] pgsql: Disable multi-byte citext tests

2017-09-19 Thread Andrew Dunstan
Disable multi-byte citext tests This reverts commit 890faaf1 which attempted unsuccessfully to deal with the problem, and instead just comments out these tests like other similar tests elsewhere in the script. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d1687c69

[COMMITTERS] pgsql: Set client encoding to UTF8 for the citext regression script

2017-09-19 Thread Andrew Dunstan
Set client encoding to UTF8 for the citext regression script Problem introduced with non-ascii characters in commit f2464997644c and discovered on various buildfarm animals. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/890faaf1957759c6e17fbcbfd16f7cabc4a59d07 Mo

[COMMITTERS] pgsql: Add citext_pattern_ops for citext contrib module

2017-09-19 Thread Andrew Dunstan
Add citext_pattern_ops for citext contrib module This is similar to text_pattern_ops. Alexey Chernyshov, reviewed by Jacob Champion. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f2464997644c64b5dec93ab3c08305f48bfe14f1 Modified Files -- contrib/cite

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

2017-08-07 Thread Andrew Dunstan
On 08/07/2017 04:20 PM, Tom Lane wrote: > Andrew Dunstan writes: >> On 08/07/2017 04:07 PM, Tom Lane wrote: >>> Sorry, I was imprecise. What I'm suggesting is that you drop the >>> runtime PATH-foolery and instead put this in configure's environm

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

2017-08-07 Thread Andrew Dunstan
On 08/07/2017 04:07 PM, Tom Lane wrote: > Andrew Dunstan writes: >> On 08/07/2017 03:36 PM, Tom Lane wrote: >>> My goodness, that's ugly. Is it really better than injecting >>> "PROVE=prove"? (I'd suggest saying that to configure, not make, >&

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

2017-08-07 Thread Andrew Dunstan
On 08/07/2017 03:36 PM, Tom Lane wrote: > Andrew Dunstan writes: >> On 08/07/2017 03:21 PM, Tom Lane wrote: >>> I'm confused. AFAIK, that commit did not change which "prove" would >>> be used --- at least not unless you change PATH between co

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

2017-08-07 Thread Andrew Dunstan
On 08/07/2017 03:21 PM, Tom Lane wrote: > Andrew Dunstan writes: >> On 07/31/2017 01:02 PM, Tom Lane wrote: >>> Record full paths of programs sought by "configure". >> The problem with this commit, as jacana is demonstrating, is that on >> Msys it finds

Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

2017-08-07 Thread Andrew Dunstan
ve needs to run with the perl from the MSys DTK that understands MSys virtualized paths. I have a hack that will allow the buildfarm to overcome the difficulty, (essentially it passes 'PROVE=prove' to make) but that's fairly ugly and certainly non-intuitive for someone

[COMMITTERS] pgsql: Work around Msys weakness in Testlib.pm's command_like()

2017-07-26 Thread Andrew Dunstan
Work around Msys weakness in Testlib.pm's command_like() When output of IPC::Run::run () is redirected to scalar references, in certain circumstances the Msys perl does not correctly detect that the end of file has been seen, making the test hang indefinitely. One such circumstance is when the com

Re: [COMMITTERS] pgsql: Improve legibility of numeric literal

2017-07-17 Thread Andrew Dunstan
On 07/17/2017 10:22 PM, Robert Haas wrote: > On Mon, Jul 17, 2017 at 3:36 PM, Andrew Dunstan wrote: >> Improve legibility of numeric literal > Ugh. Are we going to start doing this all the time? Some of the > time? At the whim of whoever was committing? I didn't even k

[COMMITTERS] pgsql: Improve legibility of numeric literal

2017-07-17 Thread Andrew Dunstan
Improve legibility of numeric literal Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cde11fa3c003407fc6c4ddc427d57e588ea17d1c Modified Files -- src/test/perl/PostgresNode.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-commi

[COMMITTERS] pgsql: Use usleep instead of select for timeouts in PostgresNode.pm

2017-07-17 Thread Andrew Dunstan
Use usleep instead of select for timeouts in PostgresNode.pm select() for pure timeouts is not portable, and in particular doesn't work on Windows. Discussion: https://postgr.es/m/186943e0-3405-978d-b19d-9d3335427...@2ndquadrant.com Branch -- master Details --- https://git.postgresql.o

[COMMITTERS] pgsql: fix typo

2017-07-16 Thread Andrew Dunstan
fix typo Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f5b2f270849395b39bdd87a6459bd0a05f78249d Modified Files -- src/tools/msvc/vcregress.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsq

[COMMITTERS] pgsql: fix typo

2017-07-16 Thread Andrew Dunstan
fix typo Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f13e48bd54b2a1e9357da775d4ac263a98cab97d Modified Files -- src/tools/msvc/vcregress.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsq

[COMMITTERS] pgsql: fix typo

2017-07-16 Thread Andrew Dunstan
fix typo Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/220a9b5e55070c9c37017914f456a9a4c6f46145 Modified Files -- src/tools/msvc/vcregress.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsq

[COMMITTERS] pgsql: fix typo

2017-07-16 Thread Andrew Dunstan
fix typo Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/deb0129a222ec6b189d5d198cf77012591f300d8 Modified Files -- src/tools/msvc/vcregress.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-commi

[COMMITTERS] pgsql: Fix vcregress.pl PROVE_FLAGS bug in commit 93b7d9731f

2017-07-16 Thread Andrew Dunstan
Fix vcregress.pl PROVE_FLAGS bug in commit 93b7d9731f This change didn't adjust the publicly visible taptest function, causing buildfarm failures on bowerbird. Backpatch to 9.4 like previous change. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9c3f502b45a

[COMMITTERS] pgsql: Fix vcregress.pl PROVE_FLAGS bug in commit 93b7d9731f

2017-07-16 Thread Andrew Dunstan
Fix vcregress.pl PROVE_FLAGS bug in commit 93b7d9731f This change didn't adjust the publicly visible taptest function, causing buildfarm failures on bowerbird. Backpatch to 9.4 like previous change. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b4a1d69ed4d

[COMMITTERS] pgsql: Fix vcregress.pl PROVE_FLAGS bug in commit 93b7d9731f

2017-07-16 Thread Andrew Dunstan
Fix vcregress.pl PROVE_FLAGS bug in commit 93b7d9731f This change didn't adjust the publicly visible taptest function, causing buildfarm failures on bowerbird. Backpatch to 9.4 like previous change. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fd2487e49f406471c1

[COMMITTERS] pgsql: Fix vcregress.pl PROVE_FLAGS bug in commit 93b7d9731f

2017-07-16 Thread Andrew Dunstan
Fix vcregress.pl PROVE_FLAGS bug in commit 93b7d9731f This change didn't adjust the publicly visible taptest function, causing buildfarm failures on bowerbird. Backpatch to 9.4 like previous change. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7eb4124da5b

Re: [COMMITTERS] pgsql: Ooops, WIN32 code in pg_ctl.c still needs PQExpBuffer.

2017-07-05 Thread Andrew Dunstan
On 06/28/2017 06:00 PM, Tom Lane wrote: > Ooops, WIN32 code in pg_ctl.c still needs PQExpBuffer. > > Per buildfarm. > Looks to me like we need to put back the Makefile line for WIN32 for pg_ctl, too. cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.co

[COMMITTERS] pgsql: Take PROVE_FLAGS from the command line but not the environment

2017-06-10 Thread Andrew Dunstan
Take PROVE_FLAGS from the command line but not the environment This reverts commit 56b6ef893fee9e9bf47d927a02f4d1ea911f4d9c and instead makes vcregress.pl parse out PROVE_FLAGS from a command line argument when doing a TAP test, thus making it consistent with the makefile treatment. Discussion:

[COMMITTERS] pgsql: Take PROVE_FLAGS from the command line but not the environment

2017-06-10 Thread Andrew Dunstan
Take PROVE_FLAGS from the command line but not the environment This reverts commit 56b6ef893fee9e9bf47d927a02f4d1ea911f4d9c and instead makes vcregress.pl parse out PROVE_FLAGS from a command line argument when doing a TAP test, thus making it consistent with the makefile treatment. Discussion:

[COMMITTERS] pgsql: Take PROVE_FLAGS from the command line but not the environment

2017-06-10 Thread Andrew Dunstan
Take PROVE_FLAGS from the command line but not the environment This reverts commit 56b6ef893fee9e9bf47d927a02f4d1ea911f4d9c and instead makes vcregress.pl parse out PROVE_FLAGS from a command line argument when doing a TAP test, thus making it consistent with the makefile treatment. Discussion:

[COMMITTERS] pgsql: Take PROVE_FLAGS from the command line but not the environment

2017-06-10 Thread Andrew Dunstan
Take PROVE_FLAGS from the command line but not the environment This reverts commit 56b6ef893fee9e9bf47d927a02f4d1ea911f4d9c and instead makes vcregress.pl parse out PROVE_FLAGS from a command line argument when doing a TAP test, thus making it consistent with the makefile treatment. Discussion:

[COMMITTERS] pgsql: Mark to_tsvector(regconfig,json[b]) functions immutable

2017-06-08 Thread Andrew Dunstan
Mark to_tsvector(regconfig,json[b]) functions immutable This make them consistent with the text function and means they can be used in functional indexes. Catalog version bumped. Per gripe from Josh Berkus. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f7e6853e1

[COMMITTERS] pgsql: Fix thinko in previous openssl change

2017-06-05 Thread Andrew Dunstan
Fix thinko in previous openssl change Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b2482ab83242d895e0e0eaa362b5a918d15ce408 Modified Files -- src/tools/msvc/Solution.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-c

[COMMITTERS] pgsql: Fix thinko in previous openssl change

2017-06-05 Thread Andrew Dunstan
Fix thinko in previous openssl change Branch -- REL9_2_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f964a7c5ab9f8af5cf496f650ce162f7e3d34714 Modified Files -- src/tools/msvc/Solution.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-c

[COMMITTERS] pgsql: Fix thinko in previous openssl change

2017-06-05 Thread Andrew Dunstan
Fix thinko in previous openssl change Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6da9996358989b86744febd0eab24f0b5dc2f7d0 Modified Files -- src/tools/msvc/Solution.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-c

[COMMITTERS] pgsql: Fix thinko in previous openssl change

2017-06-05 Thread Andrew Dunstan
Fix thinko in previous openssl change Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2e02136fe688046cd3b3c0bbcdd6ba970932ec8e Modified Files -- src/tools/msvc/Solution.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committe

[COMMITTERS] pgsql: Fix thinko in previous openssl change

2017-06-05 Thread Andrew Dunstan
Fix thinko in previous openssl change Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/da30fa603aeb3b406931543b1ff4427bdf051ec5 Modified Files -- src/tools/msvc/Solution.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-c

[COMMITTERS] pgsql: Fix thinko in previous openssl change

2017-06-05 Thread Andrew Dunstan
Fix thinko in previous openssl change Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ec504aff740993560d8d1ca16f70cbf8147cc622 Modified Files -- src/tools/msvc/Solution.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-c

[COMMITTERS] pgsql: Find openssl lib files in right directory for MSVC

2017-06-05 Thread Andrew Dunstan
Find openssl lib files in right directory for MSVC Some openssl builds put their lib files in a VC subdirectory, others do not. Cater for both cases. Backpatch to all live branches. From an offline discussion with Leonardo Cecchi. Branch -- REL9_3_STABLE Details --- https://git.postgre

[COMMITTERS] pgsql: Find openssl lib files in right directory for MSVC

2017-06-05 Thread Andrew Dunstan
Find openssl lib files in right directory for MSVC Some openssl builds put their lib files in a VC subdirectory, others do not. Cater for both cases. Backpatch to all live branches. From an offline discussion with Leonardo Cecchi. Branch -- REL9_5_STABLE Details --- https://git.postgre

[COMMITTERS] pgsql: Find openssl lib files in right directory for MSVC

2017-06-05 Thread Andrew Dunstan
Find openssl lib files in right directory for MSVC Some openssl builds put their lib files in a VC subdirectory, others do not. Cater for both cases. Backpatch to all live branches. From an offline discussion with Leonardo Cecchi. Branch -- REL9_2_STABLE Details --- https://git.postgre

[COMMITTERS] pgsql: Find openssl lib files in right directory for MSVC

2017-06-05 Thread Andrew Dunstan
Find openssl lib files in right directory for MSVC Some openssl builds put their lib files in a VC subdirectory, others do not. Cater for both cases. Backpatch to all live branches. From an offline discussion with Leonardo Cecchi. Branch -- master Details --- https://git.postgresql.org

[COMMITTERS] pgsql: Find openssl lib files in right directory for MSVC

2017-06-05 Thread Andrew Dunstan
Find openssl lib files in right directory for MSVC Some openssl builds put their lib files in a VC subdirectory, others do not. Cater for both cases. Backpatch to all live branches. From an offline discussion with Leonardo Cecchi. Branch -- REL9_4_STABLE Details --- https://git.postgre

[COMMITTERS] pgsql: Find openssl lib files in right directory for MSVC

2017-06-05 Thread Andrew Dunstan
Find openssl lib files in right directory for MSVC Some openssl builds put their lib files in a VC subdirectory, others do not. Cater for both cases. Backpatch to all live branches. From an offline discussion with Leonardo Cecchi. Branch -- REL9_6_STABLE Details --- https://git.postgre

Re: [COMMITTERS] pgsql: Fix signal handling in logical replication workers

2017-06-05 Thread Andrew Dunstan
rm.postgresql.org/cgi-bin/show_history.pl?nm=nightjar&br=HEAD>. It's only been running the tests for about 53 days. I'm prepared to give any help needed, including access to nightjar if required. cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com

Re: [COMMITTERS] pgsql: Tag refs/tags/REL_10_BETA1 was created

2017-05-17 Thread Andrew Dunstan
On 05/16/2017 10:37 PM, Tom Lane wrote: > Peter Eisentraut writes: >> On 5/16/17 18:14, pg...@postgresql.org wrote: >>> Tag refs/tags/REL_10_BETA1 was created. >> Was this change in naming pattern intentional? > Yes, it was. Andrew Dunstan suggested[1] during th

[COMMITTERS] pgsql: Suppress indentation from Data::Dumper in regression tests

2017-05-13 Thread Andrew Dunstan
Suppress indentation from Data::Dumper in regression tests Ultra-modern versions of the perl Data::Dumper module have apparently changed how they indent output. Instead of trying to keep up we choose to tell it to supporess all indentation in the hstore_plperl regression tests. Backpatch to 9.5 w

[COMMITTERS] pgsql: Suppress indentation from Data::Dumper in regression tests

2017-05-13 Thread Andrew Dunstan
Suppress indentation from Data::Dumper in regression tests Ultra-modern versions of the perl Data::Dumper module have apparently changed how they indent output. Instead of trying to keep up we choose to tell it to supporess all indentation in the hstore_plperl regression tests. Backpatch to 9.5 w

[COMMITTERS] pgsql: Suppress indentation from Data::Dumper in regression tests

2017-05-13 Thread Andrew Dunstan
Suppress indentation from Data::Dumper in regression tests Ultra-modern versions of the perl Data::Dumper module have apparently changed how they indent output. Instead of trying to keep up we choose to tell it to supporess all indentation in the hstore_plperl regression tests. Backpatch to 9.5 w

Re: [COMMITTERS] pgsql: Use a better way of skipping all subscription tests on Windows

2017-05-13 Thread Andrew Dunstan
On 05/13/2017 02:50 AM, Andrew Dunstan wrote: > Use a better way of skipping all subscription tests on Windows Of course, this should read "authentication", not "subscription". cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com PostgreSQL De

[COMMITTERS] pgsql: Use a better way of skipping all subscription tests on Windows

2017-05-12 Thread Andrew Dunstan
Use a better way of skipping all subscription tests on Windows This way we only need to specify the number of tests in one place, and the output is also less verbose. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8d9f06097714ce1f4243329172f73c2d20b896a6 Modified

[COMMITTERS] pgsql: Honor PROVE_FLAGS environment setting

2017-05-12 Thread Andrew Dunstan
Honor PROVE_FLAGS environment setting On MSVC builds and on back branches that means removing the hardcoded --verbose setting. On master for Unix that means removing the empty setting in the global Makefile so that the value can be acquired from the environment as well as from the make arguments.

[COMMITTERS] pgsql: Honor PROVE_FLAGS environment setting

2017-05-12 Thread Andrew Dunstan
Honor PROVE_FLAGS environment setting On MSVC builds and on back branches that means removing the hardcoded --verbose setting. On master for Unix that means removing the empty setting in the global Makefile so that the value can be acquired from the environment as well as from the make arguments.

[COMMITTERS] pgsql: Honor PROVE_FLAGS environment setting

2017-05-12 Thread Andrew Dunstan
Honor PROVE_FLAGS environment setting On MSVC builds and on back branches that means removing the hardcoded --verbose setting. On master for Unix that means removing the empty setting in the global Makefile so that the value can be acquired from the environment as well as from the make arguments.

[COMMITTERS] pgsql: Honor PROVE_FLAGS environment setting

2017-05-12 Thread Andrew Dunstan
Honor PROVE_FLAGS environment setting On MSVC builds and on back branches that means removing the hardcoded --verbose setting. On master for Unix that means removing the empty setting in the global Makefile so that the value can be acquired from the environment as well as from the make arguments.

[COMMITTERS] pgsql: Add libxml2 include path for MSVC builds

2017-05-12 Thread Andrew Dunstan
Add libxml2 include path for MSVC builds On Unix this path is detected via the use of xml2-config, but that's not available on Windows. This means that users building with libxml2 will no longer need to move things around from the standard libxml2 installation for MSVC builds. Backpatch to all li

[COMMITTERS] pgsql: Add libxml2 include path for MSVC builds

2017-05-12 Thread Andrew Dunstan
Add libxml2 include path for MSVC builds On Unix this path is detected via the use of xml2-config, but that's not available on Windows. This means that users building with libxml2 will no longer need to move things around from the standard libxml2 installation for MSVC builds. Backpatch to all li

[COMMITTERS] pgsql: Add libxml2 include path for MSVC builds

2017-05-12 Thread Andrew Dunstan
Add libxml2 include path for MSVC builds On Unix this path is detected via the use of xml2-config, but that's not available on Windows. This means that users building with libxml2 will no longer need to move things around from the standard libxml2 installation for MSVC builds. Backpatch to all li

[COMMITTERS] pgsql: Add libxml2 include path for MSVC builds

2017-05-12 Thread Andrew Dunstan
Add libxml2 include path for MSVC builds On Unix this path is detected via the use of xml2-config, but that's not available on Windows. This means that users building with libxml2 will no longer need to move things around from the standard libxml2 installation for MSVC builds. Backpatch to all li

[COMMITTERS] pgsql: Add libxml2 include path for MSVC builds

2017-05-12 Thread Andrew Dunstan
Add libxml2 include path for MSVC builds On Unix this path is detected via the use of xml2-config, but that's not available on Windows. This means that users building with libxml2 will no longer need to move things around from the standard libxml2 installation for MSVC builds. Backpatch to all li

[COMMITTERS] pgsql: Add libxml2 include path for MSVC builds

2017-05-12 Thread Andrew Dunstan
Add libxml2 include path for MSVC builds On Unix this path is detected via the use of xml2-config, but that's not available on Windows. This means that users building with libxml2 will no longer need to move things around from the standard libxml2 installation for MSVC builds. Backpatch to all li

[COMMITTERS] pgsql: Avoid tests which crash the calling process on Windows

2017-05-12 Thread Andrew Dunstan
Avoid tests which crash the calling process on Windows Certain recovery tests use the Perl IPC::Run module's start/kill_kill method of processing. On at least some versions of perl this causes the whole process and its caller to crash. If we ever find a better way of doing these tests they can be

[COMMITTERS] pgsql: Fix perl thinko in commit fed6df486dca

2017-05-02 Thread Andrew Dunstan
Fix perl thinko in commit fed6df486dca Report and fix from Vaishnavi Prabakaran Backpatch to 9.4 like original. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/df53413ba524a01cced9c12131606d84d52a0fc9 Modified Files -- src/tools/msvc/vcregress.p

[COMMITTERS] pgsql: Fix perl thinko in commit fed6df486dca

2017-05-02 Thread Andrew Dunstan
Fix perl thinko in commit fed6df486dca Report and fix from Vaishnavi Prabakaran Backpatch to 9.4 like original. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b2ed1c8a467c2f8f91323a13696a900f31a3239d Modified Files -- src/tools/msvc/vcregress.p

[COMMITTERS] pgsql: Fix perl thinko in commit fed6df486dca

2017-05-02 Thread Andrew Dunstan
Fix perl thinko in commit fed6df486dca Report and fix from Vaishnavi Prabakaran Backpatch to 9.4 like original. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f06caa09d9c539a2336434e6b521b6541c3da624 Modified Files -- src/tools/msvc/vcregress.p

[COMMITTERS] pgsql: Fix perl thinko in commit fed6df486dca

2017-05-02 Thread Andrew Dunstan
Fix perl thinko in commit fed6df486dca Report and fix from Vaishnavi Prabakaran Backpatch to 9.4 like original. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9a0d2008c3fe82c9d62a81e87cd0c4de1be09e0f Modified Files -- src/tools/msvc/vcregress.pl | 2 +

[COMMITTERS] pgsql: Allow vcregress.pl to run an arbitrary TAP test set

2017-05-01 Thread Andrew Dunstan
Allow vcregress.pl to run an arbitrary TAP test set Currently only provision for running the bin checks in a single step is provided for. Now these tests can be run individually, as well as tests in other locations (e.g. src.test/recover). Also provide for suppressing unnecessary temp installs by

[COMMITTERS] pgsql: Allow vcregress.pl to run an arbitrary TAP test set

2017-05-01 Thread Andrew Dunstan
Allow vcregress.pl to run an arbitrary TAP test set Currently only provision for running the bin checks in a single step is provided for. Now these tests can be run individually, as well as tests in other locations (e.g. src.test/recover). Also provide for suppressing unnecessary temp installs by

[COMMITTERS] pgsql: Allow vcregress.pl to run an arbitrary TAP test set

2017-05-01 Thread Andrew Dunstan
Allow vcregress.pl to run an arbitrary TAP test set Currently only provision for running the bin checks in a single step is provided for. Now these tests can be run individually, as well as tests in other locations (e.g. src.test/recover). Also provide for suppressing unnecessary temp installs by

[COMMITTERS] pgsql: Allow vcregress.pl to run an arbitrary TAP test set

2017-05-01 Thread Andrew Dunstan
Allow vcregress.pl to run an arbitrary TAP test set Currently only provision for running the bin checks in a single step is provided for. Now these tests can be run individually, as well as tests in other locations (e.g. src.test/recover). Also provide for suppressing unnecessary temp installs by

[COMMITTERS] pgsql: Fix TAP infrastructure to support Mingw better

2017-04-23 Thread Andrew Dunstan
Fix TAP infrastructure to support Mingw better archive_command and restore_command need to refer to Windows paths, not Msys virtual file system paths, as postgres is completely unaware of the latter, so prefix them with the Windows path to the virtual file system root. Clean psql output of carriag

[COMMITTERS] pgsql: Fix TAP infrastructure to support Mingw better

2017-04-23 Thread Andrew Dunstan
Fix TAP infrastructure to support Mingw better archive_command and restore_command need to refer to Windows paths, not Msys virtual file system paths, as postgres is completely unaware of the latter, so prefix them with the Windows path to the virtual file system root. Clean psql and pg_recvlogica

[COMMITTERS] pgsql: Require sufficiently modern version of Test::More for TAP tests

2017-04-22 Thread Andrew Dunstan
Require sufficiently modern version of Test::More for TAP tests Ancient versions of Test::More don't support the note() function used in some TAP tests, so we require the minimum version of the module that does. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f92562

[COMMITTERS] pgsql: Simplify docs on creating a self-signed SSL certificate

2017-04-18 Thread Andrew Dunstan
Simplify docs on creating a self-signed SSL certificate Discussion: Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2b67c9d207d428c2476af0dd39043d83469d70c2 Modified Files -- do

[COMMITTERS] pgsql: Make sure to run one initdb TAP test with no TZ set

2017-04-15 Thread Andrew Dunstan
Make sure to run one initdb TAP test with no TZ set That way we make sure that initdb's time zone setting code is exercised. This doesn't add an extra test, it just alters an existing test. Discussion: Branch -- master Details --- http

  1   2   3   4   5   6   7   8   9   10   >