[COMMITTERS] pgsql: Get rid of extern declarations of non-existent functions.

2017-04-24 Thread Fujii Masao
Get rid of extern declarations of non-existent functions. Those extern declartions were mistakenly added by commit 7c4f52409. Author: Petr Jelinek Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cbc2270e3fcfae0831e4aa22f797f1dcac483d46 Modified Files

Re: [COMMITTERS] pgsql: Allow vacuums to report oldestxmin

2017-03-30 Thread Fujii Masao
On Wed, Mar 29, 2017 at 3:31 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Wed, Mar 29, 2017 at 1:32 AM, Fujii Masao <masao.fu...@gmail.com> wrote: >> On Tue, Mar 28, 2017 at 1:06 AM, Masahiko Sawada <sawada.m...@gmail.com> >> wrote: >>> On Sun

[COMMITTERS] pgsql: Simplify the example of VACUUM in documentation.

2017-03-30 Thread Fujii Masao
Simplify the example of VACUUM in documentation. Previously a detailed activity report by VACUUM VERBOSE ANALYZE was described as an example of VACUUM in docs. But it had been obsolete for a long time. For example, commit feb4f44d296b88b7f0723f4a4f3945a371276e0b updated the content of that

[COMMITTERS] pgsql: Simplify the example of VACUUM in documentation.

2017-03-30 Thread Fujii Masao
Simplify the example of VACUUM in documentation. Previously a detailed activity report by VACUUM VERBOSE ANALYZE was described as an example of VACUUM in docs. But it had been obsolete for a long time. For example, commit feb4f44d296b88b7f0723f4a4f3945a371276e0b updated the content of that

[COMMITTERS] pgsql: Simplify the example of VACUUM in documentation.

2017-03-30 Thread Fujii Masao
Simplify the example of VACUUM in documentation. Previously a detailed activity report by VACUUM VERBOSE ANALYZE was described as an example of VACUUM in docs. But it had been obsolete for a long time. For example, commit feb4f44d296b88b7f0723f4a4f3945a371276e0b updated the content of that

[COMMITTERS] pgsql: Simplify the example of VACUUM in documentation.

2017-03-30 Thread Fujii Masao
Simplify the example of VACUUM in documentation. Previously a detailed activity report by VACUUM VERBOSE ANALYZE was described as an example of VACUUM in docs. But it had been obsolete for a long time. For example, commit feb4f44d296b88b7f0723f4a4f3945a371276e0b updated the content of that

[COMMITTERS] pgsql: Simplify the example of VACUUM in documentation.

2017-03-30 Thread Fujii Masao
Simplify the example of VACUUM in documentation. Previously a detailed activity report by VACUUM VERBOSE ANALYZE was described as an example of VACUUM in docs. But it had been obsolete for a long time. For example, commit feb4f44d296b88b7f0723f4a4f3945a371276e0b updated the content of that

[COMMITTERS] pgsql: Simplify the example of VACUUM in documentation.

2017-03-30 Thread Fujii Masao
Simplify the example of VACUUM in documentation. Previously a detailed activity report by VACUUM VERBOSE ANALYZE was described as an example of VACUUM in docs. But it had been obsolete for a long time. For example, commit feb4f44d296b88b7f0723f4a4f3945a371276e0b updated the content of that

Re: [COMMITTERS] pgsql: Allow vacuums to report oldestxmin

2017-03-28 Thread Fujii Masao
On Tue, Mar 28, 2017 at 1:06 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Sun, Mar 26, 2017 at 2:26 AM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> On Sun, Mar 26, 2017 at 1:37 AM, Fujii Masao <masao.fu...@gmail.com> wrote: >>> On Mon,

Re: [COMMITTERS] pgsql: Allow vacuums to report oldestxmin

2017-03-25 Thread Fujii Masao
quot;tuples" in the above should be "row versions"? We should review not only this line but also all the lines in the example of VERBOSE output, I think. Regards, -- Fujii Masao -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Make VACUUM VERBOSE report the number of skipped frozen pages.

2017-03-24 Thread Fujii Masao
Make VACUUM VERBOSE report the number of skipped frozen pages. Previously manual VACUUM did not report the number of skipped frozen pages even when VERBOSE option is specified. But this information is helpful to monitor the VACUUM activity, and also autovacuum reports that number in the log file

[COMMITTERS] pgsql: Prevent logical rep workers with removed subscriptions from star

2017-03-08 Thread Fujii Masao
Prevent logical rep workers with removed subscriptions from starting. Any logical rep workers must have their subscription entries in pg_subscription. To ensure this, we need to prevent the launcher from starting new worker corresponding to the subscription that DROP SUBSCRIPTION command is

[COMMITTERS] pgsql: Fix connection leak in DROP SUBSCRIPTION command, take 2.

2017-03-08 Thread Fujii Masao
Fix connection leak in DROP SUBSCRIPTION command, take 2. Commit 898a792eb8283e31efc0b6fcbc03bbcd5f7df667 fixed the connection leak issue, but it was an unreliable way of bugfix. This bugfix was assuming that walrcv_command() subroutine cannot throw an error, but it's untenable assumption. For

Re: [COMMITTERS] pgsql: Fix connection leak in DROP SUBSCRIPTION command.

2017-03-08 Thread Fujii Masao
On Wed, Feb 22, 2017 at 1:27 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Wed, Feb 22, 2017 at 8:39 AM, Fujii Masao <masao.fu...@gmail.com> wrote: >> On Wed, Feb 22, 2017 at 6:57 AM, Michael Paquier >> <michael.paqu...@gmail.com> wrote: >>>

Re: [COMMITTERS] pgsql: Fix connection leak in DROP SUBSCRIPTION command.

2017-02-21 Thread Fujii Masao
On Wed, Feb 22, 2017 at 6:57 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Wed, Feb 22, 2017 at 4:12 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> Fujii Masao <fu...@postgresql.org> writes: >>> Fix connection leak in DROP SUBSCRIPTION command. >&g

Re: [COMMITTERS] pgsql: Make walsender always initialize the buffers.

2017-02-21 Thread Fujii Masao
On Wed, Feb 22, 2017 at 4:04 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Fujii Masao <fu...@postgresql.org> writes: >> Make walsender always initialize the buffers. >> ... >> Back-patch to 9.4 where replication slot was introduced. > > Doesn't look like you

[COMMITTERS] pgsql: Make walsender always initialize the buffers.

2017-02-21 Thread Fujii Masao
Make walsender always initialize the buffers. Walsender uses the local buffers for each outgoing and incoming message. Previously when creating replication slot, walsender forgot to initialize one of them and which can cause the segmentation fault error. To fix this issue, this commit changes

[COMMITTERS] pgsql: Make walsender always initialize the buffers.

2017-02-21 Thread Fujii Masao
Make walsender always initialize the buffers. Walsender uses the local buffers for each outgoing and incoming message. Previously when creating replication slot, walsender forgot to initialize one of them and which can cause the segmentation fault error. To fix this issue, this commit changes

[COMMITTERS] pgsql: Make walsender always initialize the buffers.

2017-02-21 Thread Fujii Masao
Make walsender always initialize the buffers. Walsender uses the local buffers for each outgoing and incoming message. Previously when creating replication slot, walsender forgot to initialize one of them and which can cause the segmentation fault error. To fix this issue, this commit changes

[COMMITTERS] pgsql: Fix typo in comment.

2017-02-21 Thread Fujii Masao
Fix typo in comment. neha khatri Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e14ec7d346f8686c9471c16a01579d6b1c3b4975 Modified Files -- src/backend/utils/adt/varlena.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via

[COMMITTERS] pgsql: Fix connection leak in DROP SUBSCRIPTION command.

2017-02-21 Thread Fujii Masao
Fix connection leak in DROP SUBSCRIPTION command. Previously the command forgot to close the connection to the publisher when it failed to drop the replication slot. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/898a792eb8283e31efc0b6fcbc03bbcd5f7df667 Modified

[COMMITTERS] pgsql: Make walsender always initialize the buffers.

2017-02-21 Thread Fujii Masao
Make walsender always initialize the buffers. Walsender uses the local buffers for each outgoing and incoming message. Previously when creating replication slot, walsender forgot to initialize one of them and which can cause the segmentation fault error. To fix this issue, this commit changes

[COMMITTERS] pgsql: Remove confusing comment about unsupported feature.

2017-02-21 Thread Fujii Masao
Remove confusing comment about unsupported feature. The initial table synchronization feature has not been supported yet, but there was the confusing header comment about it in logical/worker.c. Branch -- master Details ---

[COMMITTERS] pgsql: Replace reference to "xlog-method" with "wal-method" in error me

2017-02-14 Thread Fujii Masao
Replace reference to "xlog-method" with "wal-method" in error message. Commit 62e8b38 renamed "--xlog-method" option for pg_basebackup to "--wal-method", but forgot to update the error message mentioning that option. Branch -- master Details ---

[COMMITTERS] pgsql: Replace references to "xlog" with "wal" in docs.

2017-02-13 Thread Fujii Masao
Replace references to "xlog" with "wal" in docs. Commit f82ec32ac30ae7e3ec7c84067192535b2ff8ec0e renamed the pg_xlog directory to pg_wal. To make things consistent, we decided to eliminate "xlog" from user-visible docs. Branch -- master Details ---

[COMMITTERS] pgsql: Be sure to release LogicalRepLauncherLock in DROP SUBSCRIPTION c

2017-02-03 Thread Fujii Masao
Be sure to release LogicalRepLauncherLock in DROP SUBSCRIPTION command. Previously DROP SUBSCRIPTION command forgot to release the lock at all. Original patches by Kyotaro Horiguchi and Michael Paquier, but I didn't use them. Discussion:

[COMMITTERS] pgsql: Fix typo in description for pg_replication_origin_advance functi

2017-01-26 Thread Fujii Masao
Fix typo in description for pg_replication_origin_advance function. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bdadf36eb40e88f93a9daf20ecd005595ebec1cd Modified Files -- src/include/catalog/pg_proc.h | 2 +- 1 file changed, 1 insertion(+), 1

[COMMITTERS] pgsql: Fix bug in verifying TLI (timeline ID) in WAL page header during

2017-01-24 Thread Fujii Masao
Fix bug in verifying TLI (timeline ID) in WAL page header during recovery.. Previously ValidXLOGHeader() could not handle properly the case where we re-read the WAL segment after reading its subsequent segment having larger TLI. This case can happen, for example, when the WAL record is split

[COMMITTERS] pgsql: Mention logical replication tests in src/test/README.

2017-01-23 Thread Fujii Masao
Mention logical replication tests in src/test/README. Craig Ringer Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3eaf03b5d331b7a06d79e5ad2be7e36c4a9c3d72 Modified Files -- src/test/README | 3 +++ 1 file changed, 3 insertions(+) -- Sent via

[COMMITTERS] pgsql: Be sure to release the lock on failure to launch logical replica

2017-01-23 Thread Fujii Masao
Be sure to release the lock on failure to launch logical replication worker. Petr Jelinek Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/dc82f5a6406dfef21ae1668b1c69a32c8a68c670 Modified Files -- src/backend/replication/logical/launcher.c | 1 + 1 file

[COMMITTERS] pgsql: Add description of temporary column into pg_replication_slots do

2017-01-20 Thread Fujii Masao
Add description of temporary column into pg_replication_slots doc. Ayumi Ishii Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/954737095061e5b5f1d87fb8cc43f7f8afff64c6 Modified Files -- doc/src/sgml/catalogs.sgml | 9 + 1 file changed, 9

[COMMITTERS] pgsql: Fix an assertion failure related to an exclusive backup.

2017-01-17 Thread Fujii Masao
Fix an assertion failure related to an exclusive backup. Previously multiple sessions could execute pg_start_backup() and pg_stop_backup() to start and stop an exclusive backup at the same time. This could trigger the assertion failure of "FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)".

[COMMITTERS] pgsql: Fix an assertion failure related to an exclusive backup.

2017-01-17 Thread Fujii Masao
Fix an assertion failure related to an exclusive backup. Previously multiple sessions could execute pg_start_backup() and pg_stop_backup() to start and stop an exclusive backup at the same time. This could trigger the assertion failure of "FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)".

[COMMITTERS] pgsql: Fix an assertion failure related to an exclusive backup.

2017-01-17 Thread Fujii Masao
Fix an assertion failure related to an exclusive backup. Previously multiple sessions could execute pg_start_backup() and pg_stop_backup() to start and stop an exclusive backup at the same time. This could trigger the assertion failure of "FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)".

[COMMITTERS] pgsql: Fix an assertion failure related to an exclusive backup.

2017-01-17 Thread Fujii Masao
Fix an assertion failure related to an exclusive backup. Previously multiple sessions could execute pg_start_backup() and pg_stop_backup() to start and stop an exclusive backup at the same time. This could trigger the assertion failure of "FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)".

[COMMITTERS] pgsql: Fix an assertion failure related to an exclusive backup.

2017-01-17 Thread Fujii Masao
Fix an assertion failure related to an exclusive backup. Previously multiple sessions could execute pg_start_backup() and pg_stop_backup() to start and stop an exclusive backup at the same time. This could trigger the assertion failure of "FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)".

[COMMITTERS] pgsql: Fix an assertion failure related to an exclusive backup.

2017-01-17 Thread Fujii Masao
Fix an assertion failure related to an exclusive backup. Previously multiple sessions could execute pg_start_backup() and pg_stop_backup() to start and stop an exclusive backup at the same time. This could trigger the assertion failure of "FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)".

[COMMITTERS] pgsql: Fix typos in comments.

2017-01-16 Thread Fujii Masao
Fix typos in comments. Masahiko Sawada Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8fa6019b405f9d39539a77c6f5f11fe640ddf955 Modified Files -- src/backend/storage/lmgr/condition_variable.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --

[COMMITTERS] pgsql: Forbid invalid combination of options in pg_basebackup.

2016-12-21 Thread Fujii Masao
Forbid invalid combination of options in pg_basebackup. Commit 56c7d8d4552180fd66fe48423bb2a9bb767c2d87 allowed pg_basebackup to stream WAL in tar mode. But there is the restriction that WAL streaming in tar mode works only when the value - (dash) is not specified as output directory. This means

[COMMITTERS] pgsql: Support quorum-based synchronous replication.

2016-12-19 Thread Fujii Masao
Support quorum-based synchronous replication. This feature is also known as "quorum commit" especially in discussion on pgsql-hackers. This commit adds the following new syntaxes into synchronous_standby_names GUC. By using FIRST and ANY keywords, users can specify the method to choose

[COMMITTERS] pgsql: Ensure that num_sync is greater than zero in synchronous_standby

2016-12-16 Thread Fujii Masao
Ensure that num_sync is greater than zero in synchronous_standby_names. Previously num_sync could be set to zero and this setting caused an assertion failure. This means that multiple synchronous standbys code should assume that num_sync is greater than zero. Also setting num_sync to zero is

[COMMITTERS] pgsql: Ensure that num_sync is greater than zero in synchronous_standby

2016-12-16 Thread Fujii Masao
Ensure that num_sync is greater than zero in synchronous_standby_names. Previously num_sync could be set to zero and this setting caused an assertion failure. This means that multiple synchronous standbys code should assume that num_sync is greater than zero. Also setting num_sync to zero is

[COMMITTERS] pgsql: Add missing documentation for effective_io_concurrency tablespac

2016-12-16 Thread Fujii Masao
Add missing documentation for effective_io_concurrency tablespace option. The description of effective_io_concurrency option was missing in ALTER TABLESPACE docs though it's included in CREATE TABLESPACE one. Back-patch to 9.6 where effective_io_concurrency tablespace option was added. Michael

[COMMITTERS] pgsql: Add missing documentation for effective_io_concurrency tablespac

2016-12-16 Thread Fujii Masao
Add missing documentation for effective_io_concurrency tablespace option. The description of effective_io_concurrency option was missing in ALTER TABLESPACE docs though it's included in CREATE TABLESPACE one. Back-patch to 9.6 where effective_io_concurrency tablespace option was added. Michael

[COMMITTERS] pgsql: Improve documentation about pg_stat_replication view.

2016-12-06 Thread Fujii Masao
Improve documentation about pg_stat_replication view. Add the descriptions of possible values in "state" and "sync_state" columns of pg_stat_replication view. Author: Michael Paquier, slightly modified by me Discussion:

[COMMITTERS] pgsql: Fix typo in docs.

2016-12-05 Thread Fujii Masao
Fix typo in docs. Reported-by: Darko Prelec Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/daac8e30eb7874722f277ae3461abe46a39e56ed Modified Files -- doc/src/sgml/parallel.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via

[COMMITTERS] pgsql: Fix typo in docs.

2016-12-05 Thread Fujii Masao
Fix typo in docs. Reported-by: Darko Prelec Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/efeb3135061dd45d3882eadd878ac09943d0362a Modified Files -- doc/src/sgml/parallel.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via

[COMMITTERS] pgsql: Fix incorrect output from gin_desc().

2016-12-05 Thread Fujii Masao
Fix incorrect output from gin_desc(). Previously gin_desc() displayed incorrect output "unknown action 0" for XLOG_GIN_INSERT and XLOG_GIN_VACUUM_DATA_LEAF_PAGE records with valid actions. The cause of this problem was that gin_desc() wrongly used XLogRecGetData() to extract data from those

[COMMITTERS] pgsql: Fix incorrect output from gin_desc().

2016-12-05 Thread Fujii Masao
Fix incorrect output from gin_desc(). Previously gin_desc() displayed incorrect output "unknown action 0" for XLOG_GIN_INSERT and XLOG_GIN_VACUUM_DATA_LEAF_PAGE records with valid actions. The cause of this problem was that gin_desc() wrongly used XLogRecGetData() to extract data from those

[COMMITTERS] pgsql: Fix incorrect output from gin_desc().

2016-12-05 Thread Fujii Masao
Fix incorrect output from gin_desc(). Previously gin_desc() displayed incorrect output "unknown action 0" for XLOG_GIN_INSERT and XLOG_GIN_VACUUM_DATA_LEAF_PAGE records with valid actions. The cause of this problem was that gin_desc() wrongly used XLogRecGetData() to extract data from those

[COMMITTERS] pgsql: Fix typos in comments.

2016-08-29 Thread Fujii Masao
Fix typos in comments. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bd082231edbaf25626a023913394b611fe7928e8 Modified Files -- src/backend/access/brin/brin_inclusion.c | 2 +- src/timezone/localtime.c | 2 +- 2 files changed, 2

[COMMITTERS] pgsql: Fix pg_xlogdump so that it handles cross-page XLP_FIRST_IS_CONTR

2016-08-29 Thread Fujii Masao
Fix pg_xlogdump so that it handles cross-page XLP_FIRST_IS_CONTRECORD record. Previously pg_xlogdump failed to dump the contents of the WAL file if the file starts with the continuation WAL record which spans more than one pages. Since pg_xlogdump assumed that the continuation record always fits

[COMMITTERS] pgsql: Fix pg_xlogdump so that it handles cross-page XLP_FIRST_IS_CONTR

2016-08-29 Thread Fujii Masao
Fix pg_xlogdump so that it handles cross-page XLP_FIRST_IS_CONTRECORD record. Previously pg_xlogdump failed to dump the contents of the WAL file if the file starts with the continuation WAL record which spans more than one pages. Since pg_xlogdump assumed that the continuation record always fits

[COMMITTERS] pgsql: Fix pg_xlogdump so that it handles cross-page XLP_FIRST_IS_CONTR

2016-08-29 Thread Fujii Masao
Fix pg_xlogdump so that it handles cross-page XLP_FIRST_IS_CONTRECORD record. Previously pg_xlogdump failed to dump the contents of the WAL file if the file starts with the continuation WAL record which spans more than one pages. Since pg_xlogdump assumed that the continuation record always fits

[COMMITTERS] pgsql: Fix pg_xlogdump so that it handles cross-page XLP_FIRST_IS_CONTR

2016-08-29 Thread Fujii Masao
Fix pg_xlogdump so that it handles cross-page XLP_FIRST_IS_CONTRECORD record. Previously pg_xlogdump failed to dump the contents of the WAL file if the file starts with the continuation WAL record which spans more than one pages. Since pg_xlogdump assumed that the continuation record always fits

[COMMITTERS] pgsql: Fix pg_xlogdump so that it handles cross-page XLP_FIRST_IS_CONTR

2016-08-29 Thread Fujii Masao
Fix pg_xlogdump so that it handles cross-page XLP_FIRST_IS_CONTRECORD record. Previously pg_xlogdump failed to dump the contents of the WAL file if the file starts with the continuation WAL record which spans more than one pages. Since pg_xlogdump assumed that the continuation record always fits

[COMMITTERS] pgsql: Add note about unused arguments for pg_replication_origin_xact_r

2016-08-05 Thread Fujii Masao
Add note about unused arguments for pg_replication_origin_xact_reset() in docs. In 9.5, two arguments were introduced into pg_replication_origin_xact_reset() by mistake while they are actually not used at all. We cannot fix this issue for 9.5 anymore because it needs a catalog version bump.

[COMMITTERS] pgsql: Remove unused arguments from pg_replication_origin_xact_reset fu

2016-08-01 Thread Fujii Masao
Remove unused arguments from pg_replication_origin_xact_reset function. The document specifies that pg_replication_origin_xact_reset function doesn't have any argument variables. But previously it was actually defined so as to have two argument variables, though they were not used at all. That

[COMMITTERS] pgsql: Fix pg_basebackup so that it accepts 0 as a valid compression le

2016-08-01 Thread Fujii Masao
Fix pg_basebackup so that it accepts 0 as a valid compression level. The help message for pg_basebackup specifies that the numbers 0 through 9 are accepted as valid values of -Z option. But, previously -Z 0 was rejected as an invalid compression level. Per discussion, it's better to make

[COMMITTERS] pgsql: Fix pg_basebackup so that it accepts 0 as a valid compression le

2016-08-01 Thread Fujii Masao
Fix pg_basebackup so that it accepts 0 as a valid compression level. The help message for pg_basebackup specifies that the numbers 0 through 9 are accepted as valid values of -Z option. But, previously -Z 0 was rejected as an invalid compression level. Per discussion, it's better to make

[COMMITTERS] pgsql: Fix pg_basebackup so that it accepts 0 as a valid compression le

2016-08-01 Thread Fujii Masao
Fix pg_basebackup so that it accepts 0 as a valid compression level. The help message for pg_basebackup specifies that the numbers 0 through 9 are accepted as valid values of -Z option. But, previously -Z 0 was rejected as an invalid compression level. Per discussion, it's better to make

[COMMITTERS] pgsql: Fix pg_basebackup so that it accepts 0 as a valid compression le

2016-08-01 Thread Fujii Masao
Fix pg_basebackup so that it accepts 0 as a valid compression level. The help message for pg_basebackup specifies that the numbers 0 through 9 are accepted as valid values of -Z option. But, previously -Z 0 was rejected as an invalid compression level. Per discussion, it's better to make

[COMMITTERS] pgsql: Fix pg_basebackup so that it accepts 0 as a valid compression le

2016-08-01 Thread Fujii Masao
Fix pg_basebackup so that it accepts 0 as a valid compression level. The help message for pg_basebackup specifies that the numbers 0 through 9 are accepted as valid values of -Z option. But, previously -Z 0 was rejected as an invalid compression level. Per discussion, it's better to make

[COMMITTERS] pgsql: Fix pg_basebackup so that it accepts 0 as a valid compression le

2016-08-01 Thread Fujii Masao
Fix pg_basebackup so that it accepts 0 as a valid compression level. The help message for pg_basebackup specifies that the numbers 0 through 9 are accepted as valid values of -Z option. But, previously -Z 0 was rejected as an invalid compression level. Per discussion, it's better to make

[COMMITTERS] pgsql: Fix incorrect description of udt_privileges view in documentatio

2016-07-28 Thread Fujii Masao
Fix incorrect description of udt_privileges view in documentation. The description of udt_privileges view contained an incorrect copy-pasted word. Back-patch to 9.2 where udt_privileges view was added. Author: Alexander Law Branch -- REL9_4_STABLE Details ---

[COMMITTERS] pgsql: Fix incorrect description of udt_privileges view in documentatio

2016-07-28 Thread Fujii Masao
Fix incorrect description of udt_privileges view in documentation. The description of udt_privileges view contained an incorrect copy-pasted word. Back-patch to 9.2 where udt_privileges view was added. Author: Alexander Law Branch -- master Details ---

[COMMITTERS] pgsql: Fix incorrect description of udt_privileges view in documentatio

2016-07-28 Thread Fujii Masao
Fix incorrect description of udt_privileges view in documentation. The description of udt_privileges view contained an incorrect copy-pasted word. Back-patch to 9.2 where udt_privileges view was added. Author: Alexander Law Branch -- REL9_2_STABLE Details ---

[COMMITTERS] pgsql: Fix incorrect description of udt_privileges view in documentatio

2016-07-28 Thread Fujii Masao
Fix incorrect description of udt_privileges view in documentation. The description of udt_privileges view contained an incorrect copy-pasted word. Back-patch to 9.2 where udt_privileges view was added. Author: Alexander Law Branch -- REL9_3_STABLE Details ---

[COMMITTERS] pgsql: Fix incorrect description of udt_privileges view in documentatio

2016-07-28 Thread Fujii Masao
Fix incorrect description of udt_privileges view in documentation. The description of udt_privileges view contained an incorrect copy-pasted word. Back-patch to 9.2 where udt_privileges view was added. Author: Alexander Law Branch -- REL9_5_STABLE Details ---

[COMMITTERS] pgsql: Fix improper example of using psql() function in TAP tests docum

2016-07-26 Thread Fujii Masao
Fix improper example of using psql() function in TAP tests documentation. In an example of TAP test scripts, there is the test checking whether the result of the query is expected or not. But, in previous example, the exit code of psql instead of the query result was checked unexpectedly.

[COMMITTERS] pgsql: Fix typo in comment.

2016-07-25 Thread Fujii Masao
Fix typo in comment. Author: Masahiko Sawada Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1804d1555f56fcad4ce62e160bab17bdff6c94aa Modified Files -- contrib/postgres_fdw/deparse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via

[COMMITTERS] pgsql: Rename pg_stat_wal_receiver.conn_info to conninfo.

2016-07-06 Thread Fujii Masao
Rename pg_stat_wal_receiver.conn_info to conninfo. Per discussion on pgsql-hackers, conninfo is better as the column name because it's more commonly used in PostgreSQL. Catalog version bumped due to the change of pg_proc. Author: Michael Paquier Branch -- master Details ---

[COMMITTERS] pgsql: Fix typo in comment.

2016-07-06 Thread Fujii Masao
Fix typo in comment. Author: Masahiko Sawada Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1109164913caf7fa64e75e0b9fa64f7ba5fe5753 Modified Files -- src/backend/utils/adt/jsonb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via

[COMMITTERS] pgsql: Fix typo in docs.

2016-04-17 Thread Fujii Masao
Fix typo in docs. Artur Zakirov Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8ce8307bd4d6028371c6e8b51bdc6ad260baa03a Modified Files -- doc/src/sgml/indexam.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers

[COMMITTERS] pgsql: Make regression test for multiple synchronous standbys more stab

2016-04-14 Thread Fujii Masao
Make regression test for multiple synchronous standbys more stable. The regression test checks whether the output of pg_stat_replication is expected or not after changing synchronous_standby_names and reloading the configuration file. Regarding this test logic, previously there was a timing issue

[COMMITTERS] pgsql: Fix duplicated index entry in doc.

2016-04-13 Thread Fujii Masao
Fix duplicated index entry in doc. Commit cfe96ae corrected the name of pg_logical_emit_message() in its index entry. But this typo fix caused duplicated index entry because there was another index entry for the function. Spotted by Tom Lane. Branch -- master Details ---

[COMMITTERS] pgsql: Remove unused function GetOldestWALSendPointer from walsender co

2016-04-12 Thread Fujii Masao
Remove unused function GetOldestWALSendPointer from walsender code. That unused function was introduced as a sample because synchronous replication or replication monitoring tools might need it in the future. Recently commit 989be08 added the function SyncRepGetOldestSyncRecPtr which provides

[COMMITTERS] pgsql: Fix documented return type of pg_logical_emit_message() in func.

2016-04-11 Thread Fujii Masao
Fix documented return type of pg_logical_emit_message() in func.sgml. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cfe96ae24c97ff376157c48ccd5ca6d3938632be Modified Files -- doc/src/sgml/func.sgml | 8 1 file changed, 4 insertions(+), 4

[COMMITTERS] pgsql: Use ereport(ERROR) instead of Assert() to emit syncrep_parser er

2016-04-11 Thread Fujii Masao
Use ereport(ERROR) instead of Assert() to emit syncrep_parser error. The existing code would either Assert or generate an invalid SyncRepConfig variable, neither of which is desirable. A regular error should be thrown instead. This commit silences compiler warning in non assertion-enabled

[COMMITTERS] pgsql: Add regression tests for multiple synchronous standbys.

2016-04-08 Thread Fujii Masao
Add regression tests for multiple synchronous standbys. Authors: Suraj Kharage, Michael Paquier, Masahiko Sawada, refactored by me Reviewed-By: Kyotaro Horiguchi Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/196b72fb9a5556c66f2b012cc4e869175a3049fa Modified Files

[COMMITTERS] pgsql: Fix a couple of places in doc that implied there was only one sy

2016-04-07 Thread Fujii Masao
Fix a couple of places in doc that implied there was only one sync standby. Thomas Munro Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8643b91ecf8f47a1307df4a00d66b2fceada0d6f Modified Files -- doc/src/sgml/high-availability.sgml | 13 +++-- 1

Re: [COMMITTERS] pgsql: Generic Messages for Logical Decoding

2016-04-07 Thread Fujii Masao
On Thu, Apr 7, 2016 at 1:47 PM, Andres Freund <and...@anarazel.de> wrote: > On 2016-04-07 12:26:28 +0900, Fujii Masao wrote: >> In my example, the WAL record of INSERT that I executed last should be in >> 00010005. But pg_xlogdump could not displa

Re: [COMMITTERS] pgsql: Generic Messages for Logical Decoding

2016-04-06 Thread Fujii Masao
On Thu, Apr 7, 2016 at 12:06 AM, Andres Freund <and...@anarazel.de> wrote: > > > On April 6, 2016 5:00:54 PM GMT+02:00, Fujii Masao <masao.fu...@gmail.com> > wrote: >>On Wed, Apr 6, 2016 at 6:08 PM, Simon Riggs <si...@2ndquadrant.com> >>wrote: >>>

Re: [COMMITTERS] pgsql: Use GRANT system to manage access to sensitive functions

2016-04-06 Thread Fujii Masao
from a replication role. Doesn't this affect many systems that a replication role is used to take a backup? This commit forces administrators of those systems to manually grant the privilege to a replication role when upgrading the system to 9.6. Regards, -- Fujii Masao -- Sent via pgsql-committe

Re: [COMMITTERS] pgsql: Generic Messages for Logical Decoding

2016-04-06 Thread Fujii Masao
xlogdump data/pg_xlog/00010005 pg_xlogdump: FATAL: could not find a valid record after 0/500 Regards, -- Fujii Masao -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Use proper format specifier %X/%X for LSN, again.

2016-04-06 Thread Fujii Masao
Use proper format specifier %X/%X for LSN, again. Commit cee31f5 fixed this problem, but commit 989be08 accidentally reverted the fix. Thomas Munro Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ead9963c471ccde50ff220e8294ea11a57eee91c Modified Files

[COMMITTERS] pgsql: Support multiple synchronous standby servers.

2016-04-06 Thread Fujii Masao
regression test for multiple synchronous standbys is not included in this commit. It should come later. Authors: Sawada Masahiko, Beena Emerson, Michael Paquier, Fujii Masao Reviewed-By: Kyotaro Horiguchi, Amit Kapila, Robert Haas, Simon Riggs, Amit Langote, Thomas Munro, Sameer Thakur, Suraj Kharag

[COMMITTERS] pgsql: Use proper format specifier %X/%X for LSN.

2016-03-30 Thread Fujii Masao
Use proper format specifier %X/%X for LSN. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cee31f5fee950fed4159a4e093dab60b70ef215a Modified Files -- src/backend/replication/syncrep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via

[COMMITTERS] pgsql: Fix typo in docs.

2016-03-22 Thread Fujii Masao
Fix typo in docs. Jeff Janes Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/112a2d0615bab27630829e486c8b0cd2fdd6980b Modified Files -- doc/src/sgml/monitoring.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers

[COMMITTERS] pgsql: Ignore recovery_min_apply_delay until recovery has reached consi

2016-03-05 Thread Fujii Masao
Ignore recovery_min_apply_delay until recovery has reached consistent state Previously recovery_min_apply_delay was applied even before recovery had reached consistency. This could cause us to wait a long time unexpectedly for read-only connections to be allowed. It's problematic because the

[COMMITTERS] pgsql: Ignore recovery_min_apply_delay until recovery has reached consi

2016-03-05 Thread Fujii Masao
Ignore recovery_min_apply_delay until recovery has reached consistent state Previously recovery_min_apply_delay was applied even before recovery had reached consistency. This could cause us to wait a long time unexpectedly for read-only connections to be allowed. It's problematic because the

[COMMITTERS] pgsql: Ignore recovery_min_apply_delay until recovery has reached consi

2016-03-05 Thread Fujii Masao
Ignore recovery_min_apply_delay until recovery has reached consistent state Previously recovery_min_apply_delay was applied even before recovery had reached consistency. This could cause us to wait a long time unexpectedly for read-only connections to be allowed. It's problematic because the

[COMMITTERS] pgsql: Correct the formulas for System V IPC parameters SEMMNI and SEMM

2016-02-15 Thread Fujii Masao
-patch to 9.2 where the checkpointer process was added and the number of needed semaphores was increased. Author: Kyotaro Horiguchi Reviewed-by: Fujii Masao Backpatch: 9.2 Discussion: http://www.postgresql.org/message-id/20160203.125119.66820697.horiguchi.kyot...@lab.ntt.co.jp Branch

[COMMITTERS] pgsql: Correct the formulas for System V IPC parameters SEMMNI and SEMM

2016-02-15 Thread Fujii Masao
-patch to 9.2 where the checkpointer process was added and the number of needed semaphores was increased. Author: Kyotaro Horiguchi Reviewed-by: Fujii Masao Backpatch: 9.2 Discussion: http://www.postgresql.org/message-id/20160203.125119.66820697.horiguchi.kyot...@lab.ntt.co.jp Branch

[COMMITTERS] pgsql: Correct the formulas for System V IPC parameters SEMMNI and SEMM

2016-02-15 Thread Fujii Masao
-patch to 9.2 where the checkpointer process was added and the number of needed semaphores was increased. Author: Kyotaro Horiguchi Reviewed-by: Fujii Masao Backpatch: 9.2 Discussion: http://www.postgresql.org/message-id/20160203.125119.66820697.horiguchi.kyot...@lab.ntt.co.jp Branch

[COMMITTERS] pgsql: Correct the formulas for System V IPC parameters SEMMNI and SEMM

2016-02-15 Thread Fujii Masao
-patch to 9.2 where the checkpointer process was added and the number of needed semaphores was increased. Author: Kyotaro Horiguchi Reviewed-by: Fujii Masao Backpatch: 9.2 Discussion: http://www.postgresql.org/message-id/20160203.125119.66820697.horiguchi.kyot...@lab.ntt.co.jp Branch -- master

[COMMITTERS] pgsql: Correct the formulas for System V IPC parameters SEMMNI and SEMM

2016-02-15 Thread Fujii Masao
-patch to 9.2 where the checkpointer process was added and the number of needed semaphores was increased. Author: Kyotaro Horiguchi Reviewed-by: Fujii Masao Backpatch: 9.2 Discussion: http://www.postgresql.org/message-id/20160203.125119.66820697.horiguchi.kyot...@lab.ntt.co.jp Branch

Re: [COMMITTERS] pgsql: Add gin_clean_pending_list function to clean up GIN pending list

2016-02-08 Thread Fujii Masao
On Mon, Feb 8, 2016 at 2:19 AM, Fujii Masao <masao.fu...@gmail.com> wrote: > On Sat, Feb 6, 2016 at 1:09 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> Fujii Masao <fu...@postgresql.org> writes: >>> Add gin_clean_pending_list function to clean up GIN pending list

[COMMITTERS] pgsql: Make GIN regression test stable.

2016-02-08 Thread Fujii Masao
Make GIN regression test stable. Commit 7f46eaf added the regression test which checks that gin_clean_pending_list() cleans up the GIN pending list and returns >0. This usually works fine. But if autovacuum comes along and cleans the list before gin_clean_pending_list() starts, the function may

Re: [COMMITTERS] pgsql: Add gin_clean_pending_list function to clean up GIN pending list

2016-02-07 Thread Fujii Masao
On Sat, Feb 6, 2016 at 1:09 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Fujii Masao <fu...@postgresql.org> writes: >> Add gin_clean_pending_list function to clean up GIN pending list > > The regression test case added by this commit is unstable, as per > http://bu

  1   2   3   4   5   >