Re: [COMMITTERS] pgsql: Keep pg_stat_statements' query texts in a file, not in shared me

2014-01-27 Thread KONDO Mitsumasa
And it was from Peter. On Mon, Jan 27, 2014 at 8:20 PM, KONDO Mitsumasa wrote: At least, only postgres superuser can see pg_stat_statemnet view in old version. And you should change document at this sentences. No, it was precisely the same situation in every way that matters; the texts and

Re: [COMMITTERS] pgsql: Keep pg_stat_statements' query texts in a file, not in shared me

2014-01-27 Thread KONDO Mitsumasa
Sorry, I forgot to add pgsql-commiters email adress. So I re-post our e-mail discussion. (2014/01/28 11:50), Peter Geoghegan wrote: On Mon, Jan 27, 2014 at 6:31 PM, KONDO Mitsumasa wrote: No. I don't say root user is superuser. Executing initdb user will be postgres superuser. But i

Re: [COMMITTERS] pgsql: Keep pg_stat_statements' query texts in a file, not in shared me

2014-01-27 Thread KONDO Mitsumasa
(2014/01/28 11:07), Peter Geoghegan wrote: On Mon, Jan 27, 2014 at 6:04 PM, KONDO Mitsumasa wrote: It is written in documents; "For security reasons, non-superusers are not allowed to see the text of queries executed by other users." Is root user superuser? And initdb user might cha

Re: [COMMITTERS] pgsql: Keep pg_stat_statements' query texts in a file, not in shared me

2014-01-27 Thread KONDO Mitsumasa
(2014/01/28 10:23), Tom Lane wrote: > Peter Geoghegan writes: >> On Mon, Jan 27, 2014 at 5:12 PM, KONDO Mitsumasa >> wrote: >>> This patch has security problem that root can easily see the statement file >>> in database cluster. > >> By default, we al

Re: [COMMITTERS] pgsql: Keep pg_stat_statements' query texts in a file, not in shared me

2014-01-27 Thread KONDO Mitsumasa
(2014/01/28 10:15), Peter Geoghegan wrote: On Mon, Jan 27, 2014 at 5:12 PM, KONDO Mitsumasa wrote: This patch has security problem that root can easily see the statement file in database cluster. By default, we always serialize statements along with their query texts to disk on shutdown

Re: [COMMITTERS] pgsql: Keep pg_stat_statements' query texts in a file, not in shared me

2014-01-27 Thread KONDO Mitsumasa
Hi, (2014/01/28 5:38), Tom Lane wrote: Keep pg_stat_statements' query texts in a file, not in shared memory. This patch has security problem that root can easily see the statement file in database cluster. Is it OK or disscussed? If root user and operation user don't have access privilege in t

Re: [COMMITTERS] pgsql: docs: update release notes for 8.4.18, 9.0.14, 9.1.10, 9.2.5, 9

2013-10-07 Thread KONDO Mitsumasa
(2013/10/08 10:35), Bruce Momjian wrote: docs: update release notes for 8.4.18, 9.0.14, 9.1.10, 9.2.5, 9.3.1 Thank you for createing good release note. I have one comment. In 9.1 and 9.2 release note, Is "Improve WAL segment timeline handling during recovery" means commit which is "Install re

Re: [COMMITTERS] pgsql: Install recycled WAL segments with current timeline ID during re

2013-05-01 Thread KONDO Mitsumasa
I test this patch, it seems to fix this problem. I think recovery and WAL write control are very difficult... So I make debug log which is more helpful for like this trouble. Sorry, attached my patch had very easy problem... Please used this patch. Best regards, -- NTT Open Sorce Software Center

Re: [COMMITTERS] pgsql: Install recycled WAL segments with current timeline ID during re

2013-05-01 Thread KONDO Mitsumasa
Thanks for creating patch !! I test this patch, it seems to fix this problem. I think recovery and WAL write control are very difficult... So I make debug log which is more helpful for like this trouble. Though I think you have already known, this problem has occurred in also master database