[COMMITTERS] pgsql: Account for the effect of lossy pages when costing bitmap scans.

2017-11-10 Thread Robert Haas
Account for the effect of lossy pages when costing bitmap scans. Dilip Kumar, reviewed by Alexander Kumenkov, Amul Sul, and me. Some final adjustments by me. Discussion: http://postgr.es/m/cafitn-sytquoxq4spuhtv0z9gd0si3yxzgv_pqaamx8qboo...@mail.gmail.com Branch -- master Details --- h

[COMMITTERS] pgsql: Fix incorrect comment.

2017-11-10 Thread Robert Haas
Fix incorrect comment. Etsuro Fujita Discussion: http://postgr.es/m/5a05728e.4050...@lab.ntt.co.jp Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b9941d3468505aea8bfdd74840b753ed27b9d29f Modified Files -- src/backend/optimizer/util/relnode.c | 3 +-- 1

[COMMITTERS] pgsql: Add hash partitioning.

2017-11-09 Thread Robert Haas
Add hash partitioning. Hash partitioning is useful when you want to partition a growing data set evenly. This can be useful to keep table sizes reasonable, which makes maintenance operations such as VACUUM faster, or to enable partition-wise join. At present, we still depend on constraint exclus

[COMMITTERS] pgsql: Fix typo in comment.

2017-11-07 Thread Robert Haas
Fix typo in comment. Masahiko Sawada Discussion: http://postgr.es/m/CAD21AoDrf5AOpZ-mX-j6O=zfnffkatdhkv3o1x2ess2nbxa...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/698e5254377baffb95774d47872100997f135cba Modified Files -- src/backe

Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

2017-11-02 Thread Robert Haas
bugs that we don't know about yet, but they can reasonably expect us to issue fixes promptly for ones that we do know about. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-committers mailing list (pgsql-committers@postgresq

Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

2017-11-02 Thread Robert Haas
On Thu, Nov 2, 2017 at 10:26 PM, Peter Geoghegan wrote: > On Thu, Nov 2, 2017 at 9:44 AM, Robert Haas wrote: >> The second commit (22576734b805fb0952f9be841ca8f643694ee868) is where >> I think things get a lot more dangerous. The problem (as Andres >> pointed out to me th

Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

2017-11-02 Thread Robert Haas
easily, but haste makes bugs, and (I know you're all tired of hearing me say this) patches that implicate the on-disk format are scary. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

2017-11-02 Thread Robert Haas
create new problems that didn't exist before those commits. And if we release without reverting those commits then we can't change our mind later. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-committers mailing list (pgsql

[COMMITTERS] pgsql: Don't exaggerate the number of temporary blocks read.

2017-10-31 Thread Robert Haas
Don't exaggerate the number of temporary blocks read. A read that returns zero bytes (or an error) should not increment the number of temporary blocks read. Thomas Munro Discussion: http://postgr.es/m/CAEepm=21xgihg=wag+o5mfotezfn6kfetpfw+rksneqnqqg...@mail.gmail.com Branch -- master Deta

[COMMITTERS] pgsql: Fix code related to partitioning schemes for dropped columns.

2017-10-31 Thread Robert Haas
Fix code related to partitioning schemes for dropped columns. The entry in appinfo->translated_vars can be NULL; if so, we must avoid dereferencing it. Ashutosh Bapat Discussion: http://postgr.es/m/CAFjFpReL7+1ien=-21rhjpo3bv7aam1rq8xglvk2csfagsz...@mail.gmail.com Branch -- master Details

[COMMITTERS] pgsql: Add sanity check for pg_proc.provariadic

2017-10-30 Thread Robert Haas
Add sanity check for pg_proc.provariadic Check that the values from pg_proc.h match what ProcedureCreate would have done. Robert Haas and Amul Sul Discussion: http://postgr.es/m/ca+tgmoz_ugxfq5ygeddmdusj4j_vx7nfnjc6mfy6bgoj3qz...@mail.gmail.com Branch -- master Details --- https

[COMMITTERS] pgsql: Allow parallel query for prepared statements with generic plans.

2017-10-29 Thread Robert Haas
Allow parallel query for prepared statements with generic plans. This was always intended to work, but due to an oversight in max_parallel_hazard_walker, it didn't. In testing, we missed the fact that it was only working for custom plans, where the parameter value has been substituted for the par

[COMMITTERS] pgsql: Fix problems with the "role" GUC and parallel query.

2017-10-29 Thread Robert Haas
Fix problems with the "role" GUC and parallel query. Without this fix, dropping a role can sometimes result in parallel query failures in sessions that have used "SET ROLE" to assume the dropped role, even if that setting isn't active any more. Report by Pavan Deolasee. Patch by Amit Kapila, rev

[COMMITTERS] pgsql: Fix problems with the "role" GUC and parallel query.

2017-10-29 Thread Robert Haas
Fix problems with the "role" GUC and parallel query. Without this fix, dropping a role can sometimes result in parallel query failures in sessions that have used "SET ROLE" to assume the dropped role, even if that setting isn't active any more. Report by Pavan Deolasee. Patch by Amit Kapila, rev

[COMMITTERS] pgsql: Fix problems with the "role" GUC and parallel query.

2017-10-29 Thread Robert Haas
Fix problems with the "role" GUC and parallel query. Without this fix, dropping a role can sometimes result in parallel query failures in sessions that have used "SET ROLE" to assume the dropped role, even if that setting isn't active any more. Report by Pavan Deolasee. Patch by Amit Kapila, rev

[COMMITTERS] pgsql: pg_receivewal: Add --no-sync option.

2017-10-29 Thread Robert Haas
pg_receivewal: Add --no-sync option. Michael Paquier, reviewed by Kuntal Ghosh and by me. I did a little wordsmithing on the documentation, too. Discussion: http://postgr.es/m/CAB7nPqTuXuyEoVKcWcExh_b0uAjgWd_14KfGLrCTccBZ=va...@mail.gmail.com Branch -- master Details --- https://git.p

[COMMITTERS] pgsql: Add hash_combine64.

2017-10-29 Thread Robert Haas
Add hash_combine64. Extracted from a larger patch by Amul Sul, with some comment additions by me. Discussion: http://postgr.es/m/20171024113004.hn5qajypin4dy...@alap3.anarazel.de Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b7f3eb31405f1dbbf086e5a8f88569a6dc8515

[COMMITTERS] pgsql: Fix typo.

2017-10-28 Thread Robert Haas
Fix typo. Eiji Seki Discussion: http://postgr.es/m/A11BD0E1A40FAC479D740CEFA373E203397E5276@g01jpexmbkw05 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c6fd5cd7062283575a436ec4ea3ed7899ace79a0 Modified Files -- contrib/bloom/blvacuum.c | 2 +- 1 file

[COMMITTERS] pgsql: Improve comments for parallel executor estimation functions.

2017-10-28 Thread Robert Haas
Improve comments for parallel executor estimation functions. The previous comment (which was copied as boilerplate from one file to the next) implied that it was the executor node itself which was being serialized, but that's not right. We're not serializing the executor nodes; we're just allowin

[COMMITTERS] pgsql: Add table_constraint synopsis to ALTER TABLE documentation.

2017-10-28 Thread Robert Haas
Add table_constraint synopsis to ALTER TABLE documentation. This is already present in the CREATE TABLE documentation, but it's nicer not to have to refer to CREATE TABLE to find out the syntax for ALTER TABLE. Lætitia Avrot Branch -- master Details --- https://git.postgresql.org/pg/com

[COMMITTERS] pgsql: Fix grammar.

2017-10-28 Thread Robert Haas
Fix grammar. Etsuro Fujita Discussion: http://postgr.es/m/cc7767b6-6a1b-74a2-8b3c-48b8e64c1...@lab.ntt.co.jp Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/24fd674a1affe1ca9776bd6b21b2b35feb0fe6ed Modified Files -- src/backend/optimizer/README | 4 ++

[COMMITTERS] pgsql: Fix misplaced ReleaseSysCache call in get_default_partition_oid.

2017-10-28 Thread Robert Haas
Fix misplaced ReleaseSysCache call in get_default_partition_oid. Julien Rouhaud Discussion: http://postgr.es/m/caobau_y4omla+vbsvda-jwblojwipxfdkckmjrzm7nmzxa1...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1310ac258c773ab9d41650b509098dd01cb4ec

[COMMITTERS] pgsql: Allow parallel query for prepared statements with generic plans.

2017-10-27 Thread Robert Haas
Allow parallel query for prepared statements with generic plans. This was always intended to work, but due to an oversight in max_parallel_hazard_walker, it didn't. In testing, we missed the fact that it was only working for custom plans, where the parameter value has been substituted for the par

[COMMITTERS] pgsql: Move new structure member to the end.

2017-10-27 Thread Robert Haas
Move new structure member to the end. Reduces ABI breakage. Per Tom Lane. Discussion: http://postgr.es/m/4035.1509113...@sss.pgh.pa.us Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/69fc2ca4ccdc70c6f9bd7909a771b0983017cb5c Modified Files -- sr

[COMMITTERS] pgsql: Revert "Move new structure member to the end."

2017-10-27 Thread Robert Haas
Revert "Move new structure member to the end." This reverts commit 94d622f27be6d48e61a68496da4f2efb06fe8746. That commit was supposed to get pushed to REL_10_STABLE, but I messed up. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f0392e677ed098e9e514ad5e4d5dc148c0

Re: [COMMITTERS] pgsql: Move new structure member to the end.

2017-10-27 Thread Robert Haas
On Fri, Oct 27, 2017 at 4:48 PM, Tom Lane wrote: > Robert Haas writes: >> Move new structure member to the end. >> Reduces ABI breakage. Per Tom Lane. > >> Branch >> -- >> master > > Uh, no. I wasn't complaining that you made this change in

[COMMITTERS] pgsql: Move new structure member to the end.

2017-10-27 Thread Robert Haas
Move new structure member to the end. Reduces ABI breakage. Per Tom Lane. Discussion: http://postgr.es/m/4035.1509113...@sss.pgh.pa.us Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/94d622f27be6d48e61a68496da4f2efb06fe8746 Modified Files -- src/inclu

[COMMITTERS] pgsql: Fix mistaken failure to allow parallelism in corner case.

2017-10-27 Thread Robert Haas
Fix mistaken failure to allow parallelism in corner case. If we try to run a parallel plan in serial mode because, for example, it's going to be scanned via a cursor, but for some reason we're already in parallel mode (for example because an outer query is running in parallel), we'd incorrectly tr

[COMMITTERS] pgsql: Fix mistaken failure to allow parallelism in corner case.

2017-10-27 Thread Robert Haas
Fix mistaken failure to allow parallelism in corner case. If we try to run a parallel plan in serial mode because, for example, it's going to be scanned via a cursor, but for some reason we're already in parallel mode (for example because an outer query is running in parallel), we'd incorrectly tr

[COMMITTERS] pgsql: Fix mistaken failure to allow parallelism in corner case.

2017-10-27 Thread Robert Haas
Fix mistaken failure to allow parallelism in corner case. If we try to run a parallel plan in serial mode because, for example, it's going to be scanned via a cursor, but for some reason we're already in parallel mode (for example because an outer query is running in parallel), we'd incorrectly tr

[COMMITTERS] pgsql: In relevant log messages, indicate whether vacuums are aggressiv

2017-10-26 Thread Robert Haas
In relevant log messages, indicate whether vacuums are aggressive. Kyotaro Horiguchi, reviewed Masahiko Sawada, David G. Johnston, Álvaro Herrera, and me. Grammar correction to the final posted patch by me. Discussion: http://postgr.es/m/20170329.124649.193656100.horiguchi.kyot...@lab.ntt.co.jp

[COMMITTERS] pgsql: pg_stat_statements: Add a comment about the dangers of padding b

2017-10-20 Thread Robert Haas
pg_stat_statements: Add a comment about the dangers of padding bytes. Inspired by a patch from Julien Rouhaud, but I reworded it. Discussion: http://postgr.es/m/CAOBaU_a8AH8=ypfqgHnDYu06ts+jWTUgh=vgcxa3ynv-k10...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg

[COMMITTERS] pgsql: Fix possible crash with Parallel Bitmap Heap Scan.

2017-10-13 Thread Robert Haas
Fix possible crash with Parallel Bitmap Heap Scan. If a Parallel Bitmap Heap scan's chain of leftmost descendents includes a BitmapOr whose first child is a BitmapAnd, the prior coding would mistakenly create a non-shared TIDBitmap and then try to perform shared iteration. Report by Tomas Vondra.

[COMMITTERS] pgsql: Fix possible crash with Parallel Bitmap Heap Scan.

2017-10-13 Thread Robert Haas
Fix possible crash with Parallel Bitmap Heap Scan. If a Parallel Bitmap Heap scan's chain of leftmost descendents includes a BitmapOr whose first child is a BitmapAnd, the prior coding would mistakenly create a non-shared TIDBitmap and then try to perform shared iteration. Report by Tomas Vondra.

[COMMITTERS] pgsql: Avoid coercing a whole-row variable that is already coerced.

2017-10-12 Thread Robert Haas
Avoid coercing a whole-row variable that is already coerced. Marginal efficiency and beautification hack. I'm not sure whether this case ever arises currently, but the pending patch for update tuple routing will cause it to arise. Amit Khandekar Discussion: http://postgr.es/m/caj3gd9cazfppe7-w

[COMMITTERS] pgsql: Use ResultRelInfo ** rather than ResultRelInfo * for tuple routi

2017-10-12 Thread Robert Haas
Use ResultRelInfo ** rather than ResultRelInfo * for tuple routing. The previous convention doesn't lend itself to creating ResultRelInfos lazily, as we already do in ExecGetTriggerResultRel. This patch doesn't make anything lazier than before, but the pending patch for UPDATE tuple routing propo

[COMMITTERS] pgsql: Synchronize error messages.

2017-10-12 Thread Robert Haas
Synchronize error messages. Commits 6476b26115f3ef25a9cd87880e0ac5ec5f7a05f6 and 14f67a8ee282ebc0de78e773fbd597f460ab4a54 didn't use quite the same error message for what is basically the same situation. Amit Langote, pared back a bit by me. Discussion: http://postgr.es/m/54dc76d0-3b5b-ba5a-27d

[COMMITTERS] pgsql: Fix logical replication to fire BEFORE ROW DELETE triggers.

2017-10-12 Thread Robert Haas
Fix logical replication to fire BEFORE ROW DELETE triggers. Before, that would fail to happen unless a BEFORE ROW UPDATE trigger was also present. Noted by me while reviewing a patch from Masahiko Sawada, who also wrote this patch. Reviewed by Petr Jelinek. Discussion: http://postgr.es/m/ca+tg

[COMMITTERS] pgsql: Fix logical replication to fire BEFORE ROW DELETE triggers.

2017-10-12 Thread Robert Haas
Fix logical replication to fire BEFORE ROW DELETE triggers. Before, that would fail to happen unless a BEFORE ROW UPDATE trigger was also present. Noted by me while reviewing a patch from Masahiko Sawada, who also wrote this patch. Reviewed by Petr Jelinek. Discussion: http://postgr.es/m/ca+tg

[COMMITTERS] pgsql: pg_stat_statements: Widen query IDs from 32 bits to 64 bits.

2017-10-11 Thread Robert Haas
pg_stat_statements: Widen query IDs from 32 bits to 64 bits. This takes advantage of the infrastructure introduced by commit 81c5e46c490e2426db243eada186995da5bb0ba7 to greatly reduce the likelihood that two different queries will end up with the same query ID. It's still possible, of course, but

[COMMITTERS] pgsql: Fix mistakes in comments.

2017-10-11 Thread Robert Haas
Fix mistakes in comments. Masahiko Sawada Discussion: http://postgr.es/m/cad21aobsfysmhd6_sl9in3n_foaa+opbl5jg55dxu1chauj...@mail.gmail.com Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/516e29ab6f1f66767a78361dea0392f1530766b6 Modified Files

[COMMITTERS] pgsql: Fix mistakes in comments.

2017-10-11 Thread Robert Haas
Fix mistakes in comments. Masahiko Sawada Discussion: http://postgr.es/m/cad21aobsfysmhd6_sl9in3n_foaa+opbl5jg55dxu1chauj...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/20d210bf5bb0d5ae37c727d364cfd810c367704a Modified Files -- src/

[COMMITTERS] pgsql: Copy information from the relcache instead of pointing to it.

2017-10-06 Thread Robert Haas
Copy information from the relcache instead of pointing to it. We have the relations continuously locked, but not open, so relcache pointers are not guaranteed to be stable. Per buildfarm member prion. Ashutosh Bapat. I fixed a typo. Discussion: http://postgr.es/m/CAFjFpRcRBqoKLZSNmRsjKr81uEP=

Re: [COMMITTERS] pgsql: Basic partition-wise join functionality.

2017-10-06 Thread Robert Haas
On Fri, Oct 6, 2017 at 12:47 PM, Tom Lane wrote: > Robert Haas writes: >> Basic partition-wise join functionality. > > Buildfarm member prion seems quite unhappy with this. > > I'm not sure if that's a case of the plan choices being less > platform-indepe

[COMMITTERS] pgsql: Basic partition-wise join functionality.

2017-10-06 Thread Robert Haas
Basic partition-wise join functionality. Instead of joining two partitioned tables in their entirety we can, if it is an equi-join on the partition keys, join the matching partitions individually. This involves teaching the planner about "other join" rels, which are related to regular join rels i

[COMMITTERS] pgsql: On CREATE TABLE, consider skipping validation of subpartitions.

2017-10-05 Thread Robert Haas
On CREATE TABLE, consider skipping validation of subpartitions. This is just like commit 14f67a8ee282ebc0de78e773fbd597f460ab4a54, but for CREATE PARTITION rather than ATTACH PARTITION. Jeevan Ladhe, with test case changes by me. Discussion: http://postgr.es/m/CAOgcT0MWwG8WBw8frFMtRYHAgDD=tpt6u

[COMMITTERS] pgsql: Improve error message when skipping scan of default partition.

2017-10-05 Thread Robert Haas
Improve error message when skipping scan of default partition. It seems like a good idea to clearly distinguish between skipping the scan of the new partition itself and skipping the scan of the default partition. Amit Langote Discussion: http://postgr.es/m/1f08b844-0078-aa8d-452e-7af3bf77d...@

[COMMITTERS] pgsql: On attach, consider skipping validation of subpartitions individ

2017-10-05 Thread Robert Haas
On attach, consider skipping validation of subpartitions individually. If the table attached as a partition is itself partitioned, individual partitions might have constraints strong enough to skip scanning the table even if the table actually attached does not. This is pretty cheap to check, and

[COMMITTERS] pgsql: Allow DML commands that create tables to use parallel query.

2017-10-05 Thread Robert Haas
Allow DML commands that create tables to use parallel query. Haribabu Kommi, reviewed by Dilip Kumar and Rafia Sabih. Various cosmetic changes by me to explain why this appears to be safe but allowing inserts in parallel mode in general wouldn't be. Also, I removed the REFRESH MATERIALIZED VIEW

[COMMITTERS] pgsql: Fix typo.

2017-10-05 Thread Robert Haas
Fix typo. Etsuro Fujita Discussion: http://postgr.es/m/1b2e9ac7-b99a-2769-5e42-afdf62bfa...@lab.ntt.co.jp Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4b2ba1fe0222b7820a2f4cd52b133baeb91c5a93 Modified Files -- src/backend/catalog/partition.c | 2 +-

[COMMITTERS] pgsql: Fix more user-visible elog() calls.

2017-10-05 Thread Robert Haas
Fix more user-visible elog() calls. Michael Paquier discovered that this could be triggered via SQL; give a nicer message instead. Patch by Michael Paquier, reviewed by Masahiko Sawada. Discussion: http://postgr.es/m/cab7npqqtpg+lkktzdkn26judhcvpz0s1gnigzot4j8cyuuu...@mail.gmail.com Branch ---

[COMMITTERS] pgsql: Fix more user-visible elog() calls.

2017-10-05 Thread Robert Haas
Fix more user-visible elog() calls. Michael Paquier discovered that this could be triggered via SQL; give a nicer message instead. Patch by Michael Paquier, reviewed by Masahiko Sawada. Discussion: http://postgr.es/m/cab7npqqtpg+lkktzdkn26judhcvpz0s1gnigzot4j8cyuuu...@mail.gmail.com Branch ---

[COMMITTERS] pgsql: Fix more user-visible elog() calls.

2017-10-05 Thread Robert Haas
Fix more user-visible elog() calls. Michael Paquier discovered that this could be triggered via SQL; give a nicer message instead. Patch by Michael Paquier, reviewed by Masahiko Sawada. Discussion: http://postgr.es/m/cab7npqqtpg+lkktzdkn26judhcvpz0s1gnigzot4j8cyuuu...@mail.gmail.com Branch ---

[COMMITTERS] pgsql: Fix more user-visible elog() calls.

2017-10-05 Thread Robert Haas
Fix more user-visible elog() calls. Michael Paquier discovered that this could be triggered via SQL; give a nicer message instead. Patch by Michael Paquier, reviewed by Masahiko Sawada. Discussion: http://postgr.es/m/cab7npqqtpg+lkktzdkn26judhcvpz0s1gnigzot4j8cyuuu...@mail.gmail.com Branch ---

[COMMITTERS] pgsql: psql: Don't try to print a partition constraint we didn't fetch.

2017-09-29 Thread Robert Haas
psql: Don't try to print a partition constraint we didn't fetch. If \d rather than \d+ is used, then verbose is false and we don't ask the server for the partition constraint; so we shouldn't print it in that case either. Maksim Milyutin, per a report from Jesper Pedersen. Reviewed by Jesper Ped

[COMMITTERS] pgsql: pgbench: If we fail to send a command to the server, fail.

2017-09-29 Thread Robert Haas
pgbench: If we fail to send a command to the server, fail. This beats the old behavior of busy-waiting hands down. Oversight in commit 12788ae49e1933f463bc59a6efe46c4a01701b76. Report by Pavan Deolasee. Patch by Fabien Coelho. Reviewed by Pavan Deolasee. Discussion: http://postgr.es/m/CABOikd

[COMMITTERS] pgsql: pgbench: If we fail to send a command to the server, fail.

2017-09-29 Thread Robert Haas
pgbench: If we fail to send a command to the server, fail. This beats the old behavior of busy-waiting hands down. Oversight in commit 12788ae49e1933f463bc59a6efe46c4a01701b76. Report by Pavan Deolasee. Patch by Fabien Coelho. Reviewed by Pavan Deolasee. Discussion: http://postgr.es/m/CABOikd

[COMMITTERS] pgsql: Remove replacement selection sort.

2017-09-29 Thread Robert Haas
Remove replacement selection sort. At the time replacement_sort_tuples was introduced, there were still cases where replacement selection sort noticeably outperformed using quicksort even for the first run. However, those cases seem to have evaporated as a result of further improvements made sinc

[COMMITTERS] pgsql: Remove lsn from HashScanPosData.

2017-09-26 Thread Robert Haas
Remove lsn from HashScanPosData. This was intended as infrastructure for weakening VACUUM's locking requirements, similar to what was done for btree indexes in commit 2ed5b87f96d473962ec5230fd820abfeaccb2069. However, for hash indexes, it seems that the improvements which are possible are actuall

[COMMITTERS] pgsql: Fix trivial mistake in README.

2017-09-26 Thread Robert Haas
Fix trivial mistake in README. You might think I (Robert) could manage to count to five without messing it up, but if you did, you would be wrong. Amit Kapila Discussion: http://postgr.es/m/CAA4eK1JxqqcuC5Un7YLQVhOYSZBS+t=3xqzuekt5ryquyux...@mail.gmail.com Branch -- master Details ---

[COMMITTERS] pgsql: For wal_consistency_checking, mask page checksum as well as page

2017-09-22 Thread Robert Haas
For wal_consistency_checking, mask page checksum as well as page LSN. If the LSN is different, the checksum will be different, too. Ashwin Agrawal, reviewed by Michael Paquier and Kuntal Ghosh Discussion: http://postgr.es/m/CALfoeis5iqrAU-+JAN+ZzXkpPr7+-0OAGv7QUHwFn=-wdy4...@mail.gmail.com Bra

[COMMITTERS] pgsql: For wal_consistency_checking, mask page checksum as well as page

2017-09-22 Thread Robert Haas
For wal_consistency_checking, mask page checksum as well as page LSN. If the LSN is different, the checksum will be different, too. Ashwin Agrawal, reviewed by Michael Paquier and Kuntal Ghosh Discussion: http://postgr.es/m/CALfoeis5iqrAU-+JAN+ZzXkpPr7+-0OAGv7QUHwFn=-wdy4...@mail.gmail.com Bra

[COMMITTERS] pgsql: hash: Implement page-at-a-time scan.

2017-09-22 Thread Robert Haas
hash: Implement page-at-a-time scan. Commit 09cb5c0e7d6fbc9dee26dc429e4fc0f2a88e5272 added a similar optimization to btree back in 2006, but nobody bothered to implement the same thing for hash indexes, probably because they weren't WAL-logged and had lots of other performance problems as well. A

[COMMITTERS] pgsql: Associate partitioning information with each RelOptInfo.

2017-09-20 Thread Robert Haas
Associate partitioning information with each RelOptInfo. This is not used for anything yet, but it is necessary infrastructure for partition-wise join and for partition pruning without constraint exclusion. Ashutosh Bapat, reviewed by Amit Langote and with quite a few changes, mostly cosmetic, by

[COMMITTERS] pgsql: Fix create_lateral_join_info to handle dead relations properly.

2017-09-20 Thread Robert Haas
Fix create_lateral_join_info to handle dead relations properly. Commit 0a480502b092195a9b25a2f0f199a21d592a9c57 broke it. Report by Andreas Seltenreich. Fix by Ashutosh Bapat. Discussion: http://postgr.es/m/874ls2vrnx@ansel.ydns.eu Branch -- master Details --- https://git.postgres

Re: [COMMITTERS] pgsql: Set partitioned_rels appropriately when UNION ALL is used.

2017-09-20 Thread Robert Haas
On Tue, Sep 19, 2017 at 7:59 PM, Thomas Munro wrote: > I spotted a typo: s/unexpcted/unexpected/. Thnks! Commmitted yur paatch. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Compny -- Sent via pgsql-committers mailing list (pgsql-committ

[COMMITTERS] pgsql: Fix typo.

2017-09-20 Thread Robert Haas
Fix typo. Thomas Munro Discussion: http://postgr.es/m/CAEepm=2j-hagnburaazws0ry7z_ihk+d7g+ye3u99+6wbig...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7f3a3312abf34ea7e899046e326775612802764b Modified Files -- src/backend/optimizer/p

Re: [COMMITTERS] pgsql: Avoid use of non-portable strnlen() in pgstat_clip_activity().

2017-09-19 Thread Robert Haas
explaining why we're careful. > > Author: Andres Freund > Discussion: https://postgr.es/m/e1duokj-0001mc...@gemulon.postgresql.org I think it should say a NUL byte or a \0 byte, not a NULL byte. NULL is a pointer value. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The

[COMMITTERS] pgsql: After a MINVALUE/MAXVALUE bound, allow only more of the same.

2017-09-15 Thread Robert Haas
After a MINVALUE/MAXVALUE bound, allow only more of the same. In the old syntax, which used UNBOUNDED, we had a similar restriction, but commit d363d42bb9a4399a0207bd3b371c966e22e06bd3, which changed the syntax, eliminated it. Put it back. Patch by me, reviewed by Dean Rasheed. Discussion: htt

[COMMITTERS] pgsql: After a MINVALUE/MAXVALUE bound, allow only more of the same.

2017-09-15 Thread Robert Haas
After a MINVALUE/MAXVALUE bound, allow only more of the same. In the old syntax, which used UNBOUNDED, we had a similar restriction, but commit d363d42bb9a4399a0207bd3b371c966e22e06bd3, which changed the syntax, eliminated it. Put it back. Patch by me, reviewed by Dean Rasheed. Discussion: htt

[COMMITTERS] pgsql: Test coverage for CREATE/ALTER FOREIGN DATA WRAPPER .. HANDLER.

2017-09-15 Thread Robert Haas
Test coverage for CREATE/ALTER FOREIGN DATA WRAPPER .. HANDLER. Amit Langote, per a suggestion from Mark Dilger. Reviewed by Marc Dilger and Ashutosh Bapat. Discussion: http://postgr.es/m/cafjfprel0oen7scpnsepbqjhb2bp1wnh1uvbof_w6keuv6z...@mail.gmail.com Branch -- master Details --- h

[COMMITTERS] pgsql: Add missing tags to GetCommandLogLevel.

2017-09-14 Thread Robert Haas
Add missing tags to GetCommandLogLevel. Otherwise, log_statement = 'ddl' causes errors if those statement types are used. Michael Paquier, reviewed by Ashutosh Sharma Discussion: http://postgr.es/m/cab7npqstc3hke76q1mnhsvd1vf1td9zxapzyadzdmylmrkk...@mail.gmail.com Branch -- master Details

[COMMITTERS] pgsql: Add missing tags to GetCommandLogLevel.

2017-09-14 Thread Robert Haas
Add missing tags to GetCommandLogLevel. Otherwise, log_statement = 'ddl' causes errors if those statement types are used. Michael Paquier, reviewed by Ashutosh Sharma Discussion: http://postgr.es/m/cab7npqstc3hke76q1mnhsvd1vf1td9zxapzyadzdmylmrkk...@mail.gmail.com Branch -- REL_10_STABLE

[COMMITTERS] pgsql: Add missing tags to GetCommandLogLevel.

2017-09-14 Thread Robert Haas
Add missing tags to GetCommandLogLevel. Otherwise, log_statement = 'ddl' causes errors if those statement types are used. Michael Paquier, reviewed by Ashutosh Sharma Discussion: http://postgr.es/m/cab7npqstc3hke76q1mnhsvd1vf1td9zxapzyadzdmylmrkk...@mail.gmail.com Branch -- REL9_6_STABLE

[COMMITTERS] pgsql: Expand partitioned table RTEs level by level, without flattening

2017-09-14 Thread Robert Haas
Expand partitioned table RTEs level by level, without flattening. Flattening the partitioning hierarchy at this stage makes various desirable optimizations difficult. The original use case for this patch was partition-wise join, which wants to match up the partitions in one partitioning hierarchy

[COMMITTERS] pgsql: Make RelationGetPartitionDispatchInfo expand depth-first.

2017-09-14 Thread Robert Haas
Make RelationGetPartitionDispatchInfo expand depth-first. With this change, the order of leaf partitions as returned by RelationGetPartitionDispatchInfo should now be the same as the order used by expand_inherited_rtentry. This will make it simpler for future patches to match up the partition dis

[COMMITTERS] pgsql: Fix inconsistent capitalization.

2017-09-14 Thread Robert Haas
Fix inconsistent capitalization. Amit Langote Discussion: http://postgr.es/m/a83a0899-19f5-594c-9aac-3ba0f1698...@lab.ntt.co.jp Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/29f021160ea7bfbc02600e651cf3588bb4ce8e78 Modified Files -- src/backe

[COMMITTERS] pgsql: Fix inconsistent capitalization.

2017-09-14 Thread Robert Haas
Fix inconsistent capitalization. Amit Langote Discussion: http://postgr.es/m/a83a0899-19f5-594c-9aac-3ba0f1698...@lab.ntt.co.jp Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/42651bdd68a123544d5bfd0773a170aa3b443f1b Modified Files -- src/backend/comm

[COMMITTERS] pgsql: Set partitioned_rels appropriately when UNION ALL is used.

2017-09-14 Thread Robert Haas
Set partitioned_rels appropriately when UNION ALL is used. In most cases, this omission won't matter, because the appropriate locks will have been acquired during parse/plan or by AcquireExecutorLocks. But it's a bug all the same. Report by Ashutosh Bapat. Patch by me, reviewed by Amit Langote.

[COMMITTERS] pgsql: Set partitioned_rels appropriately when UNION ALL is used.

2017-09-14 Thread Robert Haas
Set partitioned_rels appropriately when UNION ALL is used. In most cases, this omission won't matter, because the appropriate locks will have been acquired during parse/plan or by AcquireExecutorLocks. But it's a bug all the same. Report by Ashutosh Bapat. Patch by me, reviewed by Amit Langote.

Re: [COMMITTERS] pgsql: Allow a partitioned table to have a default partition.

2017-09-08 Thread Robert Haas
On Fri, Sep 8, 2017 at 6:50 PM, Tom Lane wrote: > But it ain't. It's failing on empty partition expressions, and there's > a short-circuit exit from map_partition_varattnos. > > Will fix. Thanks. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The En

[COMMITTERS] pgsql: Allow a partitioned table to have a default partition.

2017-09-08 Thread Robert Haas
Allow a partitioned table to have a default partition. Any tuples that don't route to any other partition will route to the default partition. Jeevan Ladhe, Beena Emerson, Ashutosh Bapat, Rahila Syed, and Robert Haas, with review and testing at various stages by (at least) Rushabh Lathia,

[COMMITTERS] pgsql: Refactor get_partition_for_tuple a bit.

2017-09-07 Thread Robert Haas
Refactor get_partition_for_tuple a bit. Pending patches for both default partitioning and hash partitioning find the current coding pattern to be inconvenient. Change it so that we switch on the partitioning method first and then do whatever is needed. Amul Sul, reviewed by Jeevan Ladhe, with a

[COMMITTERS] pgsql: Even if some partitions are foreign, allow tuple routing.

2017-09-07 Thread Robert Haas
Even if some partitions are foreign, allow tuple routing. This doesn't allow routing tuple to the foreign partitions themselves, but it permits tuples to be routed to regular partitions despite the presence of foreign partitions in the same inheritance hierarchy. Etsuro Fujita, reviewed by Amit L

[COMMITTERS] pgsql: Even if some partitions are foreign, allow tuple routing.

2017-09-07 Thread Robert Haas
Even if some partitions are foreign, allow tuple routing. This doesn't allow routing tuple to the foreign partitions themselves, but it permits tuples to be routed to regular partitions despite the presence of foreign partitions in the same inheritance hierarchy. Etsuro Fujita, reviewed by Amit L

[COMMITTERS] pgsql: Tighten up some code in RelationBuildPartitionDesc.

2017-09-01 Thread Robert Haas
Tighten up some code in RelationBuildPartitionDesc. This probably doesn't save anything meaningful in terms of performance, but making the code simpler is a good idea anyway. Code by Beena Emerson, extracted from a larger patch by Jeevan Ladhe, slightly adjusted by me. Discussion: http://postgr

[COMMITTERS] pgsql: pg_dumpall: Add a -E flag to set the encoding, like pg_dump has.

2017-09-01 Thread Robert Haas
pg_dumpall: Add a -E flag to set the encoding, like pg_dump has. Michael Paquier, reviewed by Fabien Coelho Discussion: http://postgr.es/m/CAB7nPqQcYWmrm2n-dVaMUhYPKFU_DxQwPuUGuC4ZF+8B=ds...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/84be67181a

[COMMITTERS] pgsql: Use group updates when setting transaction status in clog.

2017-09-01 Thread Robert Haas
Use group updates when setting transaction status in clog. Commit 0e141c0fbb211bdd23783afa731e3eef95c9ad7a introduced a mechanism to reduce contention on ProcArrayLock by having a single process clear XIDs in the procArray on behalf of multiple processes, reducing the need to hand the lock around.

[COMMITTERS] pgsql: Fix assorted carelessness about Datum vs. int64 vs. uint64

2017-08-31 Thread Robert Haas
Fix assorted carelessness about Datum vs. int64 vs. uint64 Bugs introduced by commit 81c5e46c490e2426db243eada186995da5bb0ba7 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7b69b6ceb8047979ddf82af12ec1de143da62263 Modified Files -- src/backend/utils/ad

[COMMITTERS] pgsql: Try to repair poorly-considered code in previous commit.

2017-08-31 Thread Robert Haas
Try to repair poorly-considered code in previous commit. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0d9506d125beef18247a5e38a219d3b23e2d312e Modified Files -- src/backend/utils/adt/jsonb_op.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[COMMITTERS] pgsql: Introduce 64-bit hash functions with a 64-bit seed.

2017-08-31 Thread Robert Haas
l for anything that wants a 64-bit hash value rather than a 32-bit hash value. Just in case somebody wants a 64-bit hash value that is compatible with the existing 32-bit hash values, make the low 32-bits of the 64-bit hash value match the 32-bit hash value when the seed is 0. Robert Haas and Amu

[COMMITTERS] pgsql: Improve low-level backup documentation.

2017-08-31 Thread Robert Haas
Improve low-level backup documentation. Our documentation hasn't really caught up with the fact that non-exclusive backups can now be taken using pg_start_backup and pg_stop_backup even on standbys. Update. David Steele, reviewed by Robert Haas and Michael Paquier Discussion: http://post

[COMMITTERS] pgsql: Expand partitioned tables in PartDesc order.

2017-08-31 Thread Robert Haas
Expand partitioned tables in PartDesc order. Previously, we expanded the inheritance hierarchy in the order in which find_all_inheritors had locked the tables, but that turns out to block quite a bit of useful optimization. For example, a partition-wise join can't count on two tables with matchin

[COMMITTERS] pgsql: Propagate sort instrumentation from workers back to leader.

2017-08-29 Thread Robert Haas
1177ab1dabf72bafee8f19d904cee3a299f25892 forced the test case added by commit 1f6d515a67ec98194c23a5db25660856c9aab944 to run without parallelism; now that we have this infrastructure, allow that again, with a little tweaking to make it pass with and without force_parallel_mode. Robert Haas and Tom Lane Discussion: http://postgr.es

[COMMITTERS] pgsql: Push tuple limits through Gather and Gather Merge.

2017-08-29 Thread Robert Haas
Sort immediately below the Gather Merge can be done as a bounded sort if there is an applicable limit. Robert Haas and Tom Lane Discussion: http://postgr.es/m/ca+tgmoya3qkkrlj5rx7uvgqhh73g1li4b-ekxrmasaca2tf...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commi

[COMMITTERS] pgsql: Improve low-level backup documentation.

2017-08-25 Thread Robert Haas
ac1d6. Updates to the 9.6 documentation are needed as well, but that will need a separate patch as some things are different on that version. David Steele, reviewed by Robert Haas and Michael Paquier Discussion: http://postgr.es/m/d4d951b9-89c0-6bc1-b6ff-d0b2dd5a8...@pgmasters.net Branch -- m

[COMMITTERS] pgsql: Improve low-level backup documentation.

2017-08-25 Thread Robert Haas
ac1d6. Updates to the 9.6 documentation are needed as well, but that will need a separate patch as some things are different on that version. David Steele, reviewed by Robert Haas and Michael Paquier Discussion: http://postgr.es/m/d4d951b9-89c0-6bc1-b6ff-d0b2dd5a8...@pgmasters.net B

Re: [COMMITTERS] pgsql: Push limit through subqueries to underlying sort, where possible

2017-08-23 Thread Robert Haas
On Wed, Aug 23, 2017 at 5:55 PM, Andres Freund wrote: > On 2017-08-21 18:42:56 +0000, Robert Haas wrote: >> Push limit through subqueries to underlying sort, where possible. >> >> Douglas Doole, reviewed by Ashutosh Bapat and by me. Minor formatting >> change by me.

[COMMITTERS] pgsql: pg_prewarm: Add automatic prewarm feature.

2017-08-21 Thread Robert Haas
still-unused shared buffers. Mithun Cy and Robert Haas, reviewed and tested by Beena Emerson, Amit Kapila, Jim Nasby, and Rafia Sabih. Discussion: http://postgr.es/m/cad__ougubos1vy7kgf6xtjmeqtr4crgav8w+zbay_+mzeit...@mail.gmail.com Branch -- master Details --- https://git.postgresql.o

[COMMITTERS] pgsql: Push limit through subqueries to underlying sort, where possible

2017-08-21 Thread Robert Haas
Push limit through subqueries to underlying sort, where possible. Douglas Doole, reviewed by Ashutosh Bapat and by me. Minor formatting change by me. Discussion: http://postgr.es/m/cade5jyluugneeusyw6q_4mzfytxhxavcqmgasf0yiy8zdgg...@mail.gmail.com Branch -- master Details --- https://

  1   2   3   4   5   6   7   8   9   10   >