On 04/13/2014 12:42 AM, Stephen Frost wrote:
Add ANALYZE into regression tests
Looks like we can end up with different plans happening on the
buildfarm, which breaks the regression tests when we include
EXPLAIN output (which is done in the regression tests for
updatable security views, to
* Andrew Dunstan (and...@dunslane.net) wrote:
Are you really sure we can do this consistently? The regression
tests have to run against all sorts of settings, including those we
have no control over via installcheck.
Sure? No. However, there are quite a few existing regression tests
that do
On 04/13/2014 08:48 AM, Stephen Frost wrote:
* Andrew Dunstan (and...@dunslane.net) wrote:
Are you really sure we can do this consistently? The regression
tests have to run against all sorts of settings, including those we
have no control over via installcheck.
Sure? No. However, there are
Yeah I think this is OK.
But the original goal seems like it would be easier and better done with an
immutable function which lies and calls elog to leak information. That's
the actual attack this is supposed to protect against anyways.
That would make the tests more robust against other changes
Greg,
* Greg Stark (st...@mit.edu) wrote:
But the original goal seems like it would be easier and better done with an
immutable function which lies and calls elog to leak information. That's
the actual attack this is supposed to protect against anyways.
Uh, yes, that's what the explain is
Stephen Frost sfr...@snowman.net writes:
* Greg Stark (st...@mit.edu) wrote:
But the original goal seems like it would be easier and better done with an
immutable function which lies and calls elog to leak information. That's
the actual attack this is supposed to protect against anyways.
* Tom Lane (t...@sss.pgh.pa.us) wrote:
Sure, but I think Greg's point is that this could be tested by a
black-box functional test (does it print something it shouldn't)
rather than a white-box test that necessarily depends on a whole lot
of *other* planner choices that don't have much to do
Add ANALYZE into regression tests
Looks like we can end up with different plans happening on the
buildfarm, which breaks the regression tests when we include
EXPLAIN output (which is done in the regression tests for
updatable security views, to ensure that the user-defined
function isn't pushed
