Re: [COMMITTERS] pgsql: Add PL/pgSQL SQLSTATE and SQLERRM support which sets these values

2005-05-26 Thread Peter Eisentraut
Tom Lane wrote: > Peter Eisentraut <[EMAIL PROTECTED]> writes: > > Does Oracle support GET DIAGNOSTICS? If so, couldn't we just use > > that? I can't see what good will become of making any slightly > > useful information become available as magic variables of some > > kind. > > Oracle actually de

Re: [COMMITTERS] pgsql: Add PL/pgSQL SQLSTATE and SQLERRM support which sets these values

2005-05-26 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Does Oracle support GET DIAGNOSTICS? If so, couldn't we just use that? > I can't see what good will become of making any slightly useful > information become available as magic variables of some kind. Oracle actually defines these things as parame

Re: [COMMITTERS] pgsql: Add PL/pgSQL SQLSTATE and SQLERRM support which sets these values

2005-05-25 Thread Peter Eisentraut
Tom Lane wrote: > I suggest that what we should do is define SQLSTATE and SQLERRM > similarly to FOUND: they are procedure-local variables that are > assigned to by an occurrence of an error. I'd be inclined to make > them start out NULL, too, not 0/"Successful completion". Does Oracle suppor

Re: [COMMITTERS] pgsql: Add PL/pgSQL SQLSTATE and SQLERRM support which sets these values

2005-05-25 Thread Tom Lane
[EMAIL PROTECTED] (Bruce Momjian) writes: > Add PL/pgSQL SQLSTATE and SQLERRM support which sets these values on > error. I had not taken the time to review this patch before, but now that I have looked at it I'm pretty unhappy with it. It creates new local variables SQLSTATE and SQLERRM in *ever

[COMMITTERS] pgsql: Add PL/pgSQL SQLSTATE and SQLERRM support which sets these values

2005-05-25 Thread Bruce Momjian
Log Message: --- Add PL/pgSQL SQLSTATE and SQLERRM support which sets these values on error. Pavel Stehule Modified Files: -- pgsql/doc/src/sgml: plpgsql.sgml (r1.67 -> r1.68) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/plpgsql.sgml.diff