Peter Eisentraut writes:
> Again, I applaud this, but this is clearly a new major chunk of mostly
> not-peer-reviewed code with potential for portability problems and the
> possibility to break downstream packaging routines. There is no harm in
> leaving this for 9.7.
FWIW, I was and remain p
On 5/6/16 3:11 PM, Stephen Frost wrote:
These are just new tests..?
This is a matter of degree, but I think there is a difference between
new test cases and a whole new test suite.
I assumed that would be welcome during post
feature-freeze, and certainly no one raised any concerns about add
On 5/6/16 4:07 PM, Stephen Frost wrote:
Are you suggesting commiting to still-9.6-HEAD post-beta1? I took
Peter's comment as suggesting that adding the tests would have to wait
til after we branched 9.6, as we do for features.
I'd really like to have these tests included as that will make them
Tom Lane wrote:
> Alvaro Herrera writes:
> > Stephen Frost wrote:
> >> I'm guessing the right answer here is to just add test_pg_dump to that
> >> list.
>
> > I don't like this solution, because it means pg_dump will get little
> > testing on Windows.
>
> No, that's incorrect: @contrib_excludes
Alvaro Herrera writes:
> Stephen Frost wrote:
>> I'm guessing the right answer here is to just add test_pg_dump to that
>> list.
> I don't like this solution, because it means pg_dump will get little
> testing on Windows.
No, that's incorrect: @contrib_excludes stops the MSVC stuff from trying
t
* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote:
> Stephen Frost wrote:
> > * Stephen Frost (sfr...@snowman.net) wrote:
>
> > > The intagg contrib modules doesn't have a .c file either, nor a
> > > MODULES_big line, and I don't see any errors with it. I'm not terribly
> > > familiar with how th
Stephen Frost wrote:
> * Stephen Frost (sfr...@snowman.net) wrote:
> > The intagg contrib modules doesn't have a .c file either, nor a
> > MODULES_big line, and I don't see any errors with it. I'm not terribly
> > familiar with how the Windows builds are run though.
>
> It looks like there's an
* Tom Lane (t...@sss.pgh.pa.us) wrote:
> Stephen Frost writes:
> > * Stephen Frost (sfr...@snowman.net) wrote:
> >> Looks like the test_pg_dump extension made the Windows builds upset.
> >> I'm guessing that's because I set 'MODULES_big' even though there isn't
> >> a .c component.
> >>
> >> Doin
Stephen Frost writes:
> * Stephen Frost (sfr...@snowman.net) wrote:
>> Looks like the test_pg_dump extension made the Windows builds upset.
>> I'm guessing that's because I set 'MODULES_big' even though there isn't
>> a .c component.
>>
>> Doing a local build with that commented out, assuming tha
* Stephen Frost (sfr...@snowman.net) wrote:
> Alright, apparently that made other Windows buildfarm members unhappy...
>
> I guess the next approach will be to add back MODULES_big and add in a
> .c file for the Windows systems to be happy about. I'm certainly open
> to other suggestions.
>
> Th
* Stephen Frost (sfr...@snowman.net) wrote:
> * Stephen Frost (sfr...@snowman.net) wrote:
> > src/test/modules/test_pg_dump/Makefile | 25 +
> > src/test/modules/test_pg_dump/README |2 +
> > .../modules/test_pg_dump/expected/test_pg_dump.out |6 +
> > src/test/modu
On 2016-05-06 15:11:53 -0400, Stephen Frost wrote:
> * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote:
> > On 5/6/16 2:06 PM, Stephen Frost wrote:
> > >Add TAP tests for pg_dump
> >
> > I'd be the first to welcome this, but what happened to feature freeze?
>
> These are just new tests.
* Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote:
> On 5/6/16 2:06 PM, Stephen Frost wrote:
> >Add TAP tests for pg_dump
>
> I'd be the first to welcome this, but what happened to feature freeze?
These are just new tests..? I assumed that would be welcome during post
feature-freeze, a
On 5/6/16 2:06 PM, Stephen Frost wrote:
Add TAP tests for pg_dump
I'd be the first to welcome this, but what happened to feature freeze?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-commit
* Stephen Frost (sfr...@snowman.net) wrote:
> src/test/modules/test_pg_dump/Makefile | 25 +
> src/test/modules/test_pg_dump/README |2 +
> .../modules/test_pg_dump/expected/test_pg_dump.out |6 +
> src/test/modules/test_pg_dump/sql/test_pg_dump.sql |1 +
> src/t
Add TAP tests for pg_dump
This TAP test suite will create a new cluster, populate it based on
the 'create_sql' values in the '%tests' hash, run all of the runs
defined in the '%pgdump_runs' hash, and then for each test in the
'%tests' hash, compare each run's output the the regular expression
defi
16 matches
Mail list logo
