On Sat, 2010-04-24 at 12:59 -0400, Tom Lane wrote:
> Well, you did it without much thought at all.
To the consequences, definitely.
> I think this episode is a
> perfect demonstration of why we ask for concrete use-cases for proposed
> hooks. If you'd actually tried to write something that used
Simon Riggs writes:
> We can override table stats but not functions stats. I noticed that hole
> in the previous implementation, and rectified it with the intention of
> helping users with what I saw as a small, low risk patch that exactly
> followed existing code. It would seem I did that too qui
On Sat, 2010-04-24 at 11:17 -0400, Tom Lane wrote:
> Robert Haas writes:
> > On Sat, Apr 24, 2010 at 3:31 AM, Simon Riggs wrote:
> >> Existing hooks were not fully complete in their coverage. That has
> >> happened before, and we have discussed that before on hackers, so I took
> >> care not to d
Robert Haas writes:
> On Sat, Apr 24, 2010 at 3:31 AM, Simon Riggs wrote:
>> Existing hooks were not fully complete in their coverage. That has
>> happened before, and we have discussed that before on hackers, so I took
>> care not to deviate from that implementation. This is a very low impact
>>
On Sat, Apr 24, 2010 at 3:31 AM, Simon Riggs wrote:
> On Fri, 2010-04-23 at 18:55 -0400, Tom Lane wrote:
>> sri...@postgresql.org (Simon Riggs) writes:
>> > Log Message:
>> > ---
>> > Add missing optimizer hooks for function cost and number of rows.
>> > Closely follow design of other opti
On Fri, 2010-04-23 at 18:55 -0400, Tom Lane wrote:
> sri...@postgresql.org (Simon Riggs) writes:
> > Log Message:
> > ---
> > Add missing optimizer hooks for function cost and number of rows.
> > Closely follow design of other optimizer hooks: if hook exists
> > retrieve value from plugin;
On Fri, Apr 23, 2010 at 6:55 PM, Tom Lane wrote:
> sri...@postgresql.org (Simon Riggs) writes:
>> Log Message:
>> ---
>> Add missing optimizer hooks for function cost and number of rows.
>> Closely follow design of other optimizer hooks: if hook exists
>> retrieve value from plugin; if sti
sri...@postgresql.org (Simon Riggs) writes:
> Log Message:
> ---
> Add missing optimizer hooks for function cost and number of rows.
> Closely follow design of other optimizer hooks: if hook exists
> retrieve value from plugin; if still not set then get from cache.
What exactly are we doin
Log Message:
---
Add missing optimizer hooks for function cost and number of rows.
Closely follow design of other optimizer hooks: if hook exists
retrieve value from plugin; if still not set then get from cache.
Modified Files:
--
pgsql/src/backend/utils/cache:
lsys
