On 09/30/2017 10:32 PM, Andres Freund wrote:
>> Haven't tested on MSVC but with this patch it passes on jacana (mingw).
> Yay! Thanks for testing.
>
I have now tested on bowerbird (MSVC) and it passes. This suggests that
we can run tests there in cases where we can use IPC::Run's finish()
inst
Hi,
On 2017-09-30 22:28:39 -0400, Andrew Dunstan wrote:
> >> But even after fixing that, there unfortunately is:
> >>
> >> static void
> >> set_sig(char *signame)
> >> {
> >> …
> >> #if 0
> >>/* probably should NOT provide SIGKILL */
> >>else if (strcmp(signame, "KILL") == 0)
> >>
On 09/30/2017 06:44 PM, Andres Freund wrote:
> On 2017-09-30 15:27:12 -0700, Andres Freund wrote:
>> On 2017-09-30 18:21:33 -0400, Andrew Dunstan wrote:
>>> [re-adding commiters which I inadvertently left off]
>>>
>>>
>>> On 09/30/2017 06:10 PM, Andres Freund wrote:
> I was just looking
On 2017-09-30 15:27:12 -0700, Andres Freund wrote:
> On 2017-09-30 18:21:33 -0400, Andrew Dunstan wrote:
> >
> > [re-adding commiters which I inadvertently left off]
> >
> >
> > On 09/30/2017 06:10 PM, Andres Freund wrote:
> > >
> > >
> > >> I was just looking at this. Why aren't we using "pg_ct
On 2017-09-30 18:21:33 -0400, Andrew Dunstan wrote:
>
> [re-adding commiters which I inadvertently left off]
>
>
> On 09/30/2017 06:10 PM, Andres Freund wrote:
> >
> >
> >> I was just looking at this. Why aren't we using "pg_ctl kill" to
> >> terminate the backend? That's supposed to be portable
[re-adding commiters which I inadvertently left off]
On 09/30/2017 06:10 PM, Andres Freund wrote:
>
>
>> I was just looking at this. Why aren't we using "pg_ctl kill" to
>> terminate the backend? That's supposed to be portable.
> Because pg_ctl can't do that for any process but postmaster, no? T
Andres Freund writes:
> If the buildfarm doesn't complain about the use of IPC::Run's timeout
> functionality, we should probably patch that into the other use of
> IPC::Run as well, but especially into the other user of the pump() until
> ... scheme.
jacana hasn't passed this regression test yet
On 2017-09-19 09:58:26 -0700, Andres Freund wrote:
>
>
> On September 19, 2017 9:53:28 AM PDT, Tom Lane wrote:
> >Well, please fix it ASAP, if you don't want to take it out pending
> >the fixes.
>
> Will as soon as I finished my morning coffee. Uncaffeinated, which my phone
> fittingly autocor
On September 19, 2017 9:53:28 AM PDT, Tom Lane wrote:
>Well, please fix it ASAP, if you don't want to take it out pending
>the fixes.
Will as soon as I finished my morning coffee. Uncaffeinated, which my phone
fittingly autocorrects to unvaccinated, commits aren't a good idea.
Andres
--
Sent
Andres Freund writes:
> On 2017-09-19 12:13:54 -0400, Tom Lane wrote:
>> IOW, the "$monitor" instance of psql did not complete making its
>> connection until after the crash/restart cycle had occurred.
> That'd be easy enough to fix...
> Just something like
> $monitor_stdin .= q[
> SELECT $$am-
Hi,
On 2017-09-19 12:13:54 -0400, Tom Lane wrote:
> IOW, the "$monitor" instance of psql did not complete making its
> connection until after the crash/restart cycle had occurred.
That'd be easy enough to fix...
Just something like
$monitor_stdin .= q[
SELECT $$am-i-up$$;
];
$monitor->pump unti
I discovered that prairiedog has been hung up for many hours in the
013_crash_restart.pl. It looks to me like the explanation is that
the test has a race condition, because what I find in the postmaster
log is
2017-09-19 00:31:48.194 EDT [27839] [unknown] LOG: connection received:
host=[local]
On September 18, 2017 8:55:35 PM PDT, Tom Lane wrote:
>Andres Freund writes:
>> Add test for postmaster crash restarts.
>
>Hm, calliphoridae doesn't like this.
Yea. Not clear to me why yet. The machine ran a number of instances with nearly
the same config successfully. Can't imagine that copy
Andres Freund writes:
> Add test for postmaster crash restarts.
Hm, calliphoridae doesn't like this.
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/p
Add test for postmaster crash restarts.
Given that I managed to break this... We probably should extend the
tests to also cover other sub-processes dying, but that's something
for later.
Author: Andres Freund
Discussion:
https://postgr.es/m/20170917080752.rcmihzfmgbeuq...@alap3.anarazel.de
Bra
15 matches
Mail list logo
